AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[V8] Add back owners check

Browse Source 
This adds parts of Chromium's PanProjectChecks. We don't add all yet
as there is to much chance for the checks to fire on files later. We
first need to find a way to run the checks on all files (not only
changed ones).

NOTRY=true

Bug: v8:7689
Change-Id: I747b49a9a362cf76f329e7f743545c6e6cb56f85
Reviewed-on: https://chromium-review.googlesource.com/1029854
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52828}
This commit is contained in:
Michael Achenbach 2018-04-26 10:34:07 +02:00 committed by Commit Bot
parent 15db6d5512
commit 8961287aec
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
PRESUBMIT.py
View File

@ -289,6 +289,13 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
# TODO(machenbach): Replace some of those checks, e.g. owners and copyright,
# with the canned PanProjectChecks. Need to make sure that the checks all
# pass on all existing files.
results.extend(input_api.canned_checks.CheckOwnersFormat(
input_api, output_api))
results.extend(input_api.canned_checks.CheckOwners(
input_api, output_api))
results.extend(_CheckCommitMessageBugEntry(input_api, output_api))
results.extend(input_api.canned_checks.CheckPatchFormatted(
input_api, output_api))