AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[torque] Temporarily disable torque format check to pass presubmit"

Browse Source 
This reverts commit 0052f12a96.

Reason for revert: Fix available

Original change's description:
> [torque] Temporarily disable torque format check to pass presubmit
> 
> Revert this once the bug is fixed.
> 
> Change-Id: I28490ecc9290b5c1f09e1ee8bcd8b600f79f017d
> Bug: v8:8873
> Notry: true
> Notreechecks: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1477747
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59720}

TBR=machenbach@chromium.org,sigurds@chromium.org,tebbi@chromium.org

Change-Id: I1a51ee93d7adbd1f14103da68e64548141163706
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8873
Reviewed-on: https://chromium-review.googlesource.com/c/1478198
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59735}
This commit is contained in:
Sigurd Schneider 2019-02-20 14:06:46 +00:00 committed by Commit Bot
parent 3119feabfc
commit 8e7f155e04
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PRESUBMIT.py
View File

@ -99,7 +99,7 @@ def _V8PresubmitChecks(input_api, output_api):
if not TorqueLintProcessor().RunOnFiles(
input_api.AffectedFiles(file_filter=FilterTorqueFile,
include_deletes=False)):
results.append(output_api.PresubmitPromptOrNotify("Torque format check failed"))
results.append(output_api.PresubmitError("Torque format check failed"))
if not SourceProcessor().RunOnFiles(
input_api.AffectedFiles(include_deletes=False)):
results.append(output_api.PresubmitError(