AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[testrunner] Add mode detection for v8_enable_pointer_compression

Browse Source 
Tbr: machenbach@chromium.org
Bug: v8:8562
Change-Id: If2242c6271d400e7c4c031e10871b06438c2636d
Reviewed-on: https://chromium-review.googlesource.com/c/1384088
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58373}
This commit is contained in:
Igor Sheludko 2018-12-19 17:21:38 +01:00 committed by Commit Bot
parent 0400fc2049
commit a4993b73c5
5 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
BUILD.gn
View File

@ -1237,6 +1237,7 @@ action("v8_dump_build_config") {
"v8_enable_jitless_mode=$v8_enable_jitless_mode",
"v8_enable_verify_csa=$v8_enable_verify_csa",
"v8_enable_lite_mode=$v8_enable_lite_mode",
"v8_enable_pointer_compression=$v8_enable_pointer_compression",
]
if (v8_current_cpu == "mips" || v8_current_cpu == "mipsel" ||

4
tools/testrunner/base_runner.py
View File

@ -188,6 +188,7 @@ class BuildConfig(object):
self.embedded_builtins = build_config['v8_enable_embedded_builtins']
self.verify_csa = build_config['v8_enable_verify_csa']
self.lite_mode = build_config['v8_enable_lite_mode']
self.pointer_compression = build_config['v8_enable_pointer_compression']
# Export only for MIPS target
if self.arch in ['mips', 'mipsel', 'mips64', 'mips64el']:
self.mips_arch_variant = build_config['mips_arch_variant']
@ -222,6 +223,8 @@ class BuildConfig(object):
detected_options.append('verify_csa')
if self.lite_mode:
detected_options.append('lite_mode')
if self.pointer_compression:
detected_options.append('pointer_compression')
return '\n'.join(detected_options)
@ -669,6 +672,7 @@ class BaseTestRunner(object):
"embedded_builtins": self.build_config.embedded_builtins,
"verify_csa": self.build_config.verify_csa,
"lite_mode": self.build_config.lite_mode,
"pointer_compression": self.build_config.pointer_compression,
}
def _create_test_config(self, options):

3
tools/unittests/run_tests_test.py
View File

@ -359,7 +359,8 @@ class SystemTest(unittest.TestCase):
is_msan=True, is_tsan=True, is_ubsan_vptr=True, target_cpu='x86',
v8_enable_i18n_support=False, v8_target_cpu='x86',
v8_use_snapshot=False, v8_enable_embedded_builtins=False,
v8_enable_verify_csa=False, v8_enable_lite_mode=False)
v8_enable_verify_csa=False, v8_enable_lite_mode=False,
v8_enable_pointer_compression=False)
result = run_tests(
basedir,
'--mode=Release',

3
tools/unittests/testdata/testroot1/v8_build_config.json vendored
View File

@ -18,5 +18,6 @@
"v8_use_snapshot": true,
"v8_enable_embedded_builtins": false,
"v8_enable_verify_csa": false,
"v8_enable_lite_mode": false
"v8_enable_lite_mode": false,
"v8_enable_pointer_compression": true
}

3
tools/unittests/testdata/testroot2/v8_build_config.json vendored
View File

@ -18,5 +18,6 @@
"v8_use_snapshot": true,
"v8_enable_embedded_builtins": false,
"v8_enable_verify_csa": false,
"v8_enable_lite_mode": false
"v8_enable_lite_mode": false,
"v8_enable_pointer_compression": false
}