AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[torque] Temporarily remove torque format check to pass presubmit"

Browse Source 
This reverts commit 5a161ce35c.

Reason for revert: Fix is available

Original change's description:
> [torque] Temporarily remove torque format check to pass presubmit
> 
> .. also from v8_presubmit.py
> 
> Revert this once the bug is fixed.
> 
> TBR=machenbach@chromium.org
> 
> Change-Id: I82f443e1d6bea4c4c43d50631f559b3aa25f8410
> Bug: v8:8873
> Notry: true
> Notreechecks: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1478690
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59722}

TBR=machenbach@chromium.org,sigurds@chromium.org

Change-Id: I9b8f01e9563cc53d34c0835872fb6fe8b5ddb240
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8873
Reviewed-on: https://chromium-review.googlesource.com/c/1478195
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59732}
This commit is contained in:
Sigurd Schneider 2019-02-20 14:00:50 +00:00 committed by Commit Bot
parent 64bad451f4
commit c977b08db1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/v8_presubmit.py
View File

@ -688,8 +688,9 @@ def Main():
print("Running C++ lint check...")
success &= CppLintProcessor(use_cache=use_linter_cache).RunOnPath(workspace)
print("Running Torque formatting check... (ignoring results)")
TorqueLintProcessor(use_cache=use_linter_cache).RunOnPath(workspace)
print("Running Torque formatting check...")
success &= TorqueLintProcessor(use_cache=use_linter_cache).RunOnPath(
workspace)
print("Running copyright header, trailing whitespaces and " \
"two empty lines between declarations check...")
success &= SourceProcessor().RunOnPath(workspace)