AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev] Disable Maglev for the default ctor omitting test

Browse Source 
Maglev support is not implemented yet.

Also make Maglev conflict with --no-maglev.

Bug: v8:13091,v8:13253
Change-Id: Iac5f06a5697405348f681b29ec43044abf50d90a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3907725
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Marja Hölttä <marja@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83327}
This commit is contained in:
Marja Hölttä 2022-09-20 13:18:55 +02:00 committed by V8 LUCI CQ
parent 332604d14b
commit ce572f953c
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/mjsunit/omit-default-ctors-array-iterator.js
View File

@ -2,9 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --omit-default-ctors --no-turbofan --no-always-turbofan // Flags: --omit-default-ctors --no-turbofan --no-always-turbofan --no-maglev
// TODO(v8:13091): Enable TurboFan. // TODO(v8:13091): Enable TurboFan.
// TODO(v8:13091): Enable Maglev.
// This behavior is not spec compliant, see crbug.com/v8/13249. // This behavior is not spec compliant, see crbug.com/v8/13249.
(function ArrayIteratorMonkeyPatched() { (function ArrayIteratorMonkeyPatched() {

3
test/mjsunit/omit-default-ctors.js
View File

@ -2,9 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --omit-default-ctors --no-turbofan --no-always-turbofan // Flags: --omit-default-ctors --no-turbofan --no-always-turbofan --no-maglev
// TODO(v8:13091): Enable TurboFan. // TODO(v8:13091): Enable TurboFan.
// TODO(v8:13091): Enable Maglev.
(function OmitDefaultBaseCtor() { (function OmitDefaultBaseCtor() {
class A {} // default base ctor -> will be omitted class A {} // default base ctor -> will be omitted

2
tools/testrunner/local/variants.py
View File

@ -80,7 +80,7 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = {
], ],
"sparkplug": ["--jitless", "--no-sparkplug"], "sparkplug": ["--jitless", "--no-sparkplug"],
"concurrent_sparkplug": ["--jitless"], "concurrent_sparkplug": ["--jitless"],
"maglev": ["--jitless"], "maglev": ["--jitless", "--no-maglev"],
"stress_maglev": ["--jitless"], "stress_maglev": ["--jitless"],
"always_sparkplug": ["--jitless", "--no-sparkplug"], "always_sparkplug": ["--jitless", "--no-sparkplug"],
"code_serializer": [ "code_serializer": [