Reassign some old TODOs to folks currently working on the respective code
Change-Id: I8fd11742c4ea13cfd5cd3864e167785b97f1383a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404274 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/main@{#78695}
This commit is contained in:
parent
ff2005b72f
commit
d4dd9cd68b
12
BUILD.gn
12
BUILD.gn
@ -1004,7 +1004,7 @@ config("toolchain") {
|
|||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|
||||||
# TODO(jochen): Add support for arm_test_noprobe.
|
# TODO(infra): Add support for arm_test_noprobe.
|
||||||
|
|
||||||
if (current_cpu != "arm") {
|
if (current_cpu != "arm") {
|
||||||
# These defines ares used for the ARM simulator.
|
# These defines ares used for the ARM simulator.
|
||||||
@ -1072,7 +1072,7 @@ config("toolchain") {
|
|||||||
defines += [ "FPU_MODE_FP32" ]
|
defines += [ "FPU_MODE_FP32" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
# TODO(jochen): Add support for mips_arch_variant rx and loongson.
|
# TODO(infra): Add support for mips_arch_variant rx and loongson.
|
||||||
}
|
}
|
||||||
|
|
||||||
if (v8_current_cpu == "mips64el" || v8_current_cpu == "mips64") {
|
if (v8_current_cpu == "mips64el" || v8_current_cpu == "mips64") {
|
||||||
@ -1200,8 +1200,8 @@ config("toolchain") {
|
|||||||
defines += [ "V8_TARGET_OS_WIN" ]
|
defines += [ "V8_TARGET_OS_WIN" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
# TODO(jochen): Support v8_enable_prof on Windows.
|
# TODO(infra): Support v8_enable_prof on Windows.
|
||||||
# TODO(jochen): Add support for compiling with simulators.
|
# TODO(infra): Add support for compiling with simulators.
|
||||||
|
|
||||||
if (v8_enable_debugging_features) {
|
if (v8_enable_debugging_features) {
|
||||||
if ((is_linux || is_chromeos) && v8_enable_backtrace) {
|
if ((is_linux || is_chromeos) && v8_enable_backtrace) {
|
||||||
@ -5175,7 +5175,7 @@ v8_component("v8_libbase") {
|
|||||||
"src/base/platform/platform-macos.cc",
|
"src/base/platform/platform-macos.cc",
|
||||||
]
|
]
|
||||||
} else if (is_win) {
|
} else if (is_win) {
|
||||||
# TODO(jochen): Add support for cygwin.
|
# TODO(infra): Add support for cygwin.
|
||||||
sources += [
|
sources += [
|
||||||
"src/base/debug/stack_trace_win.cc",
|
"src/base/debug/stack_trace_win.cc",
|
||||||
"src/base/platform/platform-win32.cc",
|
"src/base/platform/platform-win32.cc",
|
||||||
@ -5224,7 +5224,7 @@ v8_component("v8_libbase") {
|
|||||||
[ "//build/config/clang:llvm-symbolizer_data($host_toolchain)" ]
|
[ "//build/config/clang:llvm-symbolizer_data($host_toolchain)" ]
|
||||||
}
|
}
|
||||||
|
|
||||||
# TODO(jochen): Add support for qnx, freebsd, openbsd, netbsd, and solaris.
|
# TODO(infra): Add support for qnx, freebsd, openbsd, netbsd, and solaris.
|
||||||
}
|
}
|
||||||
|
|
||||||
v8_component("v8_libplatform") {
|
v8_component("v8_libplatform") {
|
||||||
|
@ -8705,7 +8705,7 @@ void Isolate::Initialize(Isolate* isolate,
|
|||||||
params.experimental_attach_to_shared_isolate));
|
params.experimental_attach_to_shared_isolate));
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO(jochen): Once we got rid of Isolate::Current(), we can remove this.
|
// TODO(v8:2487): Once we got rid of Isolate::Current(), we can remove this.
|
||||||
Isolate::Scope isolate_scope(isolate);
|
Isolate::Scope isolate_scope(isolate);
|
||||||
if (i_isolate->snapshot_blob() == nullptr) {
|
if (i_isolate->snapshot_blob() == nullptr) {
|
||||||
FATAL(
|
FATAL(
|
||||||
|
@ -476,7 +476,7 @@ bool Builtins::AllowDynamicFunction(Isolate* isolate, Handle<JSFunction> target,
|
|||||||
if (FLAG_allow_unsafe_function_constructor) return true;
|
if (FLAG_allow_unsafe_function_constructor) return true;
|
||||||
HandleScopeImplementer* impl = isolate->handle_scope_implementer();
|
HandleScopeImplementer* impl = isolate->handle_scope_implementer();
|
||||||
Handle<Context> responsible_context = impl->LastEnteredOrMicrotaskContext();
|
Handle<Context> responsible_context = impl->LastEnteredOrMicrotaskContext();
|
||||||
// TODO(jochen): Remove this.
|
// TODO(verwaest): Remove this.
|
||||||
if (responsible_context.is_null()) {
|
if (responsible_context.is_null()) {
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
@ -4318,7 +4318,8 @@ bool Shell::SetOptions(int argc, char* argv[]) {
|
|||||||
argv[i] = nullptr;
|
argv[i] = nullptr;
|
||||||
} else if (strcmp(argv[i], "--invoke-weak-callbacks") == 0) {
|
} else if (strcmp(argv[i], "--invoke-weak-callbacks") == 0) {
|
||||||
options.invoke_weak_callbacks = true;
|
options.invoke_weak_callbacks = true;
|
||||||
// TODO(jochen) See issue 3351
|
// TODO(v8:3351): Invoking weak callbacks does not always collect all
|
||||||
|
// available garbage.
|
||||||
options.send_idle_notification = true;
|
options.send_idle_notification = true;
|
||||||
argv[i] = nullptr;
|
argv[i] = nullptr;
|
||||||
} else if (strcmp(argv[i], "--omit-quit") == 0) {
|
} else if (strcmp(argv[i], "--omit-quit") == 0) {
|
||||||
|
@ -6301,7 +6301,7 @@ Handle<Derived> ObjectHashTableBase<Derived, Shape>::Put(Isolate* isolate,
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Rehash if more than 33% of the entries are deleted entries.
|
// Rehash if more than 33% of the entries are deleted entries.
|
||||||
// TODO(jochen): Consider to shrink the fixed array in place.
|
// TODO(verwaest): Consider to shrink the fixed array in place.
|
||||||
if ((table->NumberOfDeletedElements() << 1) > table->NumberOfElements()) {
|
if ((table->NumberOfDeletedElements() << 1) > table->NumberOfElements()) {
|
||||||
table->Rehash(isolate);
|
table->Rehash(isolate);
|
||||||
}
|
}
|
||||||
|
@ -28,7 +28,7 @@
|
|||||||
[
|
[
|
||||||
################################################################################
|
################################################################################
|
||||||
[ALWAYS, {
|
[ALWAYS, {
|
||||||
# TODO(jochen): The following test is flaky.
|
# TODO(ftang,jshin): The following test is flaky.
|
||||||
'overrides/caching': [PASS, FAIL],
|
'overrides/caching': [PASS, FAIL],
|
||||||
}], # ALWAYS
|
}], # ALWAYS
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user