AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tools] tools/node/fetch_deps.py returns False.

Browse Source 
This will act as a switch so that we can enable Node.js GN builds
via V8 change.

R=machenbach@chromium.org

Bug: v8:6105
Change-Id: Ie786a4dad7f53e4bbf7d8830bb72b1f8031cee12
Reviewed-on: https://chromium-review.googlesource.com/866839
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50612}
This commit is contained in:
Yang Guo 2018-01-16 11:02:14 +01:00 committed by Commit Bot
parent 6b909391fc
commit d8a965a07c
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/node/fetch_deps.py
View File

@ -89,5 +89,11 @@ def FetchDeps(v8_path):
if os.path.isfile(gclient_entries):
os.remove(gclient_entries)
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
if __name__ == "__main__":
FetchDeps(sys.argv[1])