AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove negative flag implication for --experimental

Browse Source 
The conflict with --future causes tests that enable experimental
features to fail if the test configuration enables --future, and the
conflict with --fuzzing makes it impossible to reproduce issues in
Clusterfuzz as it always adds --fuzzing to the commandline.

Change-Id: I7d952fc5c09967386e06d992b4dbd6129ea404c0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224454
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85684}
This commit is contained in:
Samuel Groß 2023-02-06 15:39:35 +01:00 committed by V8 LUCI CQ
parent 58076e4263
commit e0d7681e31
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flags/flag-definitions.h
View File

@ -199,10 +199,6 @@ DEFINE_BOOL(experimental, false,
"Indicates that V8 is running with experimental features enabled. " "Indicates that V8 is running with experimental features enabled. "
"This flag is typically not set explicitly but instead enabled as " "This flag is typically not set explicitly but instead enabled as "
"an implication of other flags which enable experimental features.") "an implication of other flags which enable experimental features.")
// Features considered experimental should not be staged behind --future.
DEFINE_NEG_IMPLICATION(future, experimental)
// Features considered experimental are not ready for fuzzing.
DEFINE_NEG_IMPLICATION(fuzzing, experimental)
#define DEFINE_EXPERIMENTAL_FEATURE(nam, cmt) \ #define DEFINE_EXPERIMENTAL_FEATURE(nam, cmt) \
FLAG(BOOL, bool, nam, false, cmt " (experimental)") \ FLAG(BOOL, bool, nam, false, cmt " (experimental)") \
DEFINE_IMPLICATION(nam, experimental) DEFINE_IMPLICATION(nam, experimental)