AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[gc][static-roots] Fix one remaining access to r/o markbits"

Browse Source 
This reverts commit 229f91a339.

Reason for revert: Initial CL(https://chromium-review.googlesource.com/c/v8/v8/+/4212397) with InReadOnlySpace() was reverted.

Original change's description:
> [gc][static-roots] Fix one remaining access to r/o markbits
>
> Yet another access to the markbits on the r/o pages that was overlooked
> in https://chromium-review.googlesource.com/c/v8/v8/+/4212397.
>
> No-Tree-Checks: true
> No-Try: true
> Bug: v8:13717
> Change-Id: I682a2604512dfda00b3f69d0e1f60edd66391687
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4221702
> Commit-Queue: Olivier Flückiger <olivf@chromium.org>
> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
> Auto-Submit: Olivier Flückiger <olivf@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#85672}

Bug: v8:13717
Change-Id: I72a629d335c1ec90d080dbc4a3e79ab54da7a8b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4226003
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ilya Rezvov <irezvov@chromium.org>
Owners-Override: Ilya Rezvov <irezvov@chromium.org>
Commit-Queue: Ilya Rezvov <irezvov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85697}
This commit is contained in:
Ilya Rezvov 2023-02-06 21:23:28 +00:00 committed by V8 LUCI CQ
parent e6353fe071
commit fa73edeb1e
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/heap/mark-compact.cc
View File

@ -2082,7 +2082,6 @@ bool MarkCompactCollector::IsUnmarkedHeapObject(Heap* heap, FullObjectSlot p) {
Object o = *p;
if (!o.IsHeapObject()) return false;
HeapObject heap_object = HeapObject::cast(o);
if (heap_object.InReadOnlySpace()) return false;
MarkCompactCollector* collector = heap->mark_compact_collector();
if (V8_UNLIKELY(collector->uses_shared_heap_) &&
!collector->is_shared_heap_isolate_) {