AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fixes bug in Array.prototype.lastIndexOf when called with null or undefined as fromIndex argument. (fixes issue 754).

Browse Source 
Review URL: http://codereview.chromium.org/2840021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4950 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
ricow@chromium.org 2010-06-25 09:28:38 +00:00
parent 8036035777
commit faaf524445
2 changed files with 41 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/array.js
View File

@ -954,7 +954,7 @@ function ArrayMap(f, receiver) {
function ArrayIndexOf(element, index) {
var length = this.length;
if (index == null) {
if (IS_UNDEFINED(index)) {
index = 0;
} else {
index = TO_INTEGER(index);
@ -981,7 +981,7 @@ function ArrayIndexOf(element, index) {
function ArrayLastIndexOf(element, index) {
var length = this.length;
if (index == null) {
if (%_ArgumentsLength() < 2) {
index = length - 1;
} else {
index = TO_INTEGER(index);

39
test/mjsunit/regress/regress-754.js Normal file
View File

@ -0,0 +1,39 @@
// Copyright 2010 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Test that Array.prototype.lastIndexOf correctly handles null and undefined
// as fromIndex argument.
// See: http://code.google.com/p/v8/issues/detail?id=754
var a = new Array(1,2,1);
assertEquals(1, a.lastIndexOf(2));
assertEquals(2, a.lastIndexOf(1));
assertEquals(0, a.lastIndexOf(1, undefined));
assertEquals(0, a.lastIndexOf(1, null));
assertEquals(-1, a.lastIndexOf(2, undefined));
assertEquals(-1, a.lastIndexOf(2, null));