AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbolizer] Fix a latent bug when dragging a node under another node.

Browse Source 
BUG=
R=danno

Review-Url: https://codereview.chromium.org/2169023002
Cr-Commit-Position: refs/heads/master@{#38004}
This commit is contained in:
bgeron 2016-07-25 02:49:52 -07:00 committed by Commit bot
parent 7ef24ad99c
commit fe728e52b4
1 changed files with 9 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
tools/turbolizer/graph-view.js
View File

@ -469,33 +469,17 @@ class GraphView extends View {
if (!mouseDownNode) return;
if (mouseDownNode !== d){
// we're in a different node: create new edge for mousedown edge and add to graph
var newEdge = {source: mouseDownNode, target: d};
var filtRes = graph.visibleEdges.filter(function(d){
if (d.source === newEdge.target && d.target === newEdge.source){
graph.edges.splice(graph.edges.indexOf(d), 1);
}
return d.source === newEdge.source && d.target === newEdge.target;
});
if (!filtRes[0].length){
graph.edges.push(newEdge);
graph.updateGraphVisibility();
}
if (state.justDragged) {
// dragged, not clicked
state.justDragged = false;
} else{
// we're in the same node
if (state.justDragged) {
// dragged, not clicked
state.justDragged = false;
} else{
// clicked, not dragged
var extend = d3.event.shiftKey;
var selection = graph.state.selection;
if (!extend) {
selection.clear();
}
selection.select(d3node[0][0], true);
// clicked, not dragged
var extend = d3.event.shiftKey;
var selection = graph.state.selection;
if (!extend) {
selection.clear();
}
selection.select(d3node[0][0], true);
}
}