wingo
9efb230d36
Fix -Wsign-compare errors in TF tests under GCC 4.9.2
...
R=jkummerow@chromium.org
LOG=N
BUG=
Review URL: https://codereview.chromium.org/1191433003
Cr-Commit-Position: refs/heads/master@{#29023}
2015-06-15 12:03:45 +00:00
machenbach
06ac599d1e
Revert of Fix clobbered register when setting this_function variable. (patchset #2 id:20001 of https://codereview.chromium.org/1185703002/ )
...
Reason for revert:
[Sheriff] Makes mjsunit/es6/block-const-assign flaky, e.g.:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/4082
Original issue's description:
> Fix clobbered register when setting this_function variable.
>
> R=arv@chromium.org
> TEST=mjsunit/regress/regress-crbug-498022
> BUG=chromium:498022
> LOG=N
>
> Committed: https://crrev.com/bf2bbc8ba508ccd21edf3c08d2e4192c4764ae91
> Cr-Commit-Position: refs/heads/master@{#29020}
TBR=arv@chromium.org ,rossberg@chromium.org,mstarzinger@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:498022
Review URL: https://codereview.chromium.org/1184093003
Cr-Commit-Position: refs/heads/master@{#29022}
2015-06-15 11:56:25 +00:00
bmeurer
2cde7dc82e
[mjsunit] regress/regress-crbug-491062 takes too long with --always-opt.
...
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/1183133002
Cr-Commit-Position: refs/heads/master@{#29021}
2015-06-15 10:27:32 +00:00
mstarzinger
bf2bbc8ba5
Fix clobbered register when setting this_function variable.
...
R=arv@chromium.org
TEST=mjsunit/regress/regress-crbug-498022
BUG=chromium:498022
LOG=N
Review URL: https://codereview.chromium.org/1185703002
Cr-Commit-Position: refs/heads/master@{#29020}
2015-06-15 10:18:57 +00:00
jarin
ed977c972e
Fix debug printing of inputs in the deoptimizer, pull out printing into separate methods.
...
Also fixed the duplicated output of context deopt.
BUG=
Review URL: https://codereview.chromium.org/1187533002
Cr-Commit-Position: refs/heads/master@{#29019}
2015-06-15 10:14:40 +00:00
bmeurer
d19410f8e7
[mjsunit] Remove unsupported flag --turbo-deoptimization from tests.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1183123002
Cr-Commit-Position: refs/heads/master@{#29018}
2015-06-15 09:43:11 +00:00
bmeurer
e30b351d7b
[mjsunit] Remove obsolete nosse2 tests.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1186713003
Cr-Commit-Position: refs/heads/master@{#29017}
2015-06-15 09:32:01 +00:00
yangguo
a0342678e8
Serializer: clear string hash for code serializer.
...
R=jochen@chromium.org
BUG=v8:4179
LOG=N
Review URL: https://codereview.chromium.org/1183483006
Cr-Commit-Position: refs/heads/master@{#29016}
2015-06-15 08:41:27 +00:00
ulan
143a9e0431
Compute the heap growing factor based on mutator utilization and allocation throughput.
...
Doc: https://goo.gl/LLGvBs
BUG=
Review URL: https://codereview.chromium.org/1163143009
Cr-Commit-Position: refs/heads/master@{#29015}
2015-06-15 08:32:59 +00:00
jochen
29715d7c07
Reland "Keep track of array buffers in new space separately"
...
Original review https://codereview.chromium.org/1133773002/
BUG=v8:3996
TBR=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1177293003
Cr-Commit-Position: refs/heads/master@{#29014}
2015-06-15 07:57:43 +00:00
machenbach
9345dfb2de
Update V8 DEPS.
...
Rolling v8/third_party/android_tools to ed3dde6470c39b196c70f0c20374894d169754ec
Resubmission of https://codereview.chromium.org/1183753006/
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/1181413003
Cr-Commit-Position: refs/heads/master@{#29013}
2015-06-15 07:54:08 +00:00
yangguo
50be442515
Add test for code caching API.
...
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1180113002
Cr-Commit-Position: refs/heads/master@{#29012}
2015-06-15 06:37:02 +00:00
bmeurer
f588b1c550
[turbofan] Mark MachineType as uint16_t.
...
This fixes a few funky implicit conversions for the enum (that are
inconsistent across compilers) and also helps to save space, i.e. for
the representations_ vector in the InstructionSequence.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1182303003
Cr-Commit-Position: refs/heads/master@{#29011}
2015-06-15 06:27:24 +00:00
bmeurer
dc3712c873
[turbofan] Remove unused typedef VirtualRegisterSet.
...
TBR=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1179913003
Cr-Commit-Position: refs/heads/master@{#29010}
2015-06-15 06:08:00 +00:00
jochen
a99fe1fd76
Revert of Reland "Keep track of array buffers in new space separately" (patchset #2 id:20001 of https://codereview.chromium.org/1177083003/ )
...
Reason for revert:
Still broken
Original issue's description:
> Reland "Keep track of array buffers in new space separately"
>
> Original review https://codereview.chromium.org/1133773002/
>
> BUG=v8:3996
> TBR=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3
> Cr-Commit-Position: refs/heads/master@{#28987}
TBR=hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996
Review URL: https://codereview.chromium.org/1186613007
Cr-Commit-Position: refs/heads/master@{#29009}
2015-06-14 18:23:33 +00:00
verwaest
028025f07e
Also handle elements in *RealNamed* api methods
...
Apparently the *RealNamed* API methods only have named variants, but were always used by the embedder to find elements as well. We'd never find them though, since we wouldn't even look
there.
This CL ensures we check whether the name is actually an array index.
I guess for all named API functions we should assume they are used similar to o["name"] where name could also be a number... At least we should make it uniform between embedder and V8. This matches us up with their expectations for now...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1177383004
Cr-Commit-Position: refs/heads/master@{#29008}
2015-06-13 11:16:12 +00:00
v8-autoroll
a6bc7cd4e2
Update V8 DEPS.
...
Rolling v8/tools/clang to bb23ac0328fd3d051fc2f5ff027c8e0f87cc6fb5
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1186753003
Cr-Commit-Position: refs/heads/master@{#29007}
2015-06-13 03:25:17 +00:00
binji
9bda43a2ea
Remove some unused definitions from d8.h
...
BUG=none
LOG=n
Review URL: https://codereview.chromium.org/1184853003
Cr-Commit-Position: refs/heads/master@{#29006}
2015-06-12 19:41:09 +00:00
chunyang.dai
3fdfebd26b
Currently on X87 platform we use only Double register (stack register) for Turbofan. So we directly
...
use 1 as allocatable Double register number when setting up the default register configuration..
It does not change the double register configuration of other platforms.
BUG=v8:4135
LOG=N
Review URL: https://codereview.chromium.org/1164813007
Cr-Commit-Position: refs/heads/master@{#29005}
2015-06-12 17:22:56 +00:00
verwaest
2ea4f01f70
Introduce LookupIterator::PropertyOrElement which converts name to index if possible.
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1178893002
Cr-Commit-Position: refs/heads/master@{#29004}
2015-06-12 16:30:18 +00:00
chunyang.dai
8c57b2e16d
X87: Disable the test case for X87 since ea2cb139d
.
...
The strong-object-set-proto test cases will throw one expected exception
and the exception message should include the source position in the JS
file. But crankshaft compiler does not generate the source position for
it when creating the flow graph by default. The source position information
is always zero. So it failed when comparing with the reference file.
If we use crankshaft compiler on IA32 platform to run this test case, it
has the same failure.
we will open these test case for x87 once turbofan for X87 is enabled.
BUG=
Review URL: https://codereview.chromium.org/1179763003
Cr-Commit-Position: refs/heads/master@{#29003}
2015-06-12 15:22:44 +00:00
verwaest
fa3e6c0850
Introduce DefineOwnPropertyIgnoreAttributes and make it call SetPropertyWithInterceptor.
...
Otherwise using Object.defineProperty with window.localStorage will not actually store the value into the database but on the object itself.
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1180073002
Cr-Commit-Position: refs/heads/master@{#29002}
2015-06-12 14:14:12 +00:00
machenbach
6a10931820
[test] More debugging output in test runner.
...
Also use again the taskkill method, recently removed in
https://codereview.chromium.org/1156133006/
BUG=chromium:485932
LOG=n
TBR=jkummerow@chromium.org
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1177903005
Cr-Commit-Position: refs/heads/master@{#29001}
2015-06-12 13:43:57 +00:00
verwaest
a066202b17
Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/ )
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1180943002
Cr-Commit-Position: refs/heads/master@{#29000}
2015-06-12 12:39:44 +00:00
ishell
4cc4bc591c
Map::TryUpdate() must be in sync with Map::Update().
...
This CL fixes elements kind transitions handling in Map::TryUpdate().
BUG=v8:4121
LOG=Y
Review URL: https://codereview.chromium.org/1181163002
Cr-Commit-Position: refs/heads/master@{#28999}
2015-06-12 12:36:40 +00:00
wingo
103fcfaa40
Add script context with context-allocated "const this"
...
This is a reapplication of https://codereview.chromium.org/1173333004 .
R=rossberg@chromium.org
LOG=N
BUG=498811
Review URL: https://codereview.chromium.org/1178903003
Cr-Commit-Position: refs/heads/master@{#28998}
2015-06-12 12:34:24 +00:00
bmeurer
c487aba74c
[turbofan] Use appropriate type for NodeId.
...
Up until now we used int32_t for NodeId, but that was not ideal because
negative values are invalid for NodeId and we use it as an array index
for example in the NodeMarker class, where C++ compilers on x64 have to
generate code that does proper sign extension for the indices, which is
completely unnecessary.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1178403004
Cr-Commit-Position: refs/heads/master@{#28997}
2015-06-12 12:03:19 +00:00
wingo
7063ed2de6
Revert of Add script context with context-allocated "const this" (patchset #2 id:20001 of https://codereview.chromium.org/1173333004/ )
...
Reason for revert:
nosnap failure
Original issue's description:
> Add script context with context-allocated "const this"
>
> This is a reapplication of https://codereview.chromium.org/1179893002/ .
>
> R=rossberg@chromium.org ,mstarzinger@chromium.org
> LOG=N
> BUG=498811
>
> Committed: https://crrev.com/cfc764f4050edc74aef92daa4c39ccc113893968
> Cr-Commit-Position: refs/heads/master@{#28994}
TBR=mstarzinger@chromium.org ,rossberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498811
Review URL: https://codereview.chromium.org/1177903004
Cr-Commit-Position: refs/heads/master@{#28996}
2015-06-12 11:53:11 +00:00
dusan.milosavljevic
a5b0a3e298
MIPS64: Fix memory allocation when code range is used for LO space only.
...
Allocation must respect requested reserve size, not requested commit area size.
Additionally fix check failures in debug mode for mips64.
After CL: https://codereview.chromium.org/1147503002/
memory for large code objects is allocated from code range,
memory for regular code objects is allocated normally.
TEST=cctest/test-spaces/MemoryChunk
BUG=
Review URL: https://codereview.chromium.org/1172333002
Cr-Commit-Position: refs/heads/master@{#28995}
2015-06-12 11:42:15 +00:00
wingo
cfc764f405
Add script context with context-allocated "const this"
...
This is a reapplication of https://codereview.chromium.org/1179893002/ .
R=rossberg@chromium.org ,mstarzinger@chromium.org
LOG=N
BUG=498811
Review URL: https://codereview.chromium.org/1173333004
Cr-Commit-Position: refs/heads/master@{#28994}
2015-06-12 11:11:28 +00:00
bmeurer
b5b00cc031
[turbofan] Move RawMachineAssembler to unittests.
...
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/1177353003
Cr-Commit-Position: refs/heads/master@{#28993}
2015-06-12 10:33:19 +00:00
machenbach
32e6455c1a
Revert of Add script context with context-allocated "const this" (patchset #7 id:120001 of https://codereview.chromium.org/1179893002/ )
...
Reason for revert:
[Sheriff] Breaks gc mole:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/2435
Original issue's description:
> Add script context with context-allocated "const this"
>
> R=rossberg@chromium.org
> LOG=N
> BUG=498811
>
> Committed: https://crrev.com/fa32d461c16a053cc6d48d3fb326016bc2765765
> Cr-Commit-Position: refs/heads/master@{#28988}
TBR=rossberg@chromium.org ,mstarzinger@chromium.org,wingo@igalia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498811
Review URL: https://codereview.chromium.org/1180043004
Cr-Commit-Position: refs/heads/master@{#28992}
2015-06-12 10:07:34 +00:00
yangguo
74534bb8be
Revert of MIPS64: Enable shorten-64-to-32 warning. (patchset #12 id:240001 of https://codereview.chromium.org/1133163005/ )
...
Reason for revert:
Compile failure: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/builds/3070/steps/compile/logs/stdio
Original issue's description:
> MIPS64: Enable shorten-64-to-32 warning.
>
> Port cdc43bc5fd
>
> Original commit message:
> Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
> that arise.
>
> BUG=
>
> Committed: https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb
> Cr-Commit-Position: refs/heads/master@{#28990}
TBR=danno@chromium.org ,martyn.capewell@arm.com,paul.lind@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,jkummerow@chromium.org,machenbach@chromium.org,svenpanne@chromium.org,balazs.kilvady@imgtec.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1182493007
Cr-Commit-Position: refs/heads/master@{#28991}
2015-06-12 09:58:34 +00:00
balazs.kilvady
9af578a7c8
MIPS64: Enable shorten-64-to-32 warning.
...
Port cdc43bc5fd
Original commit message:
Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
that arise.
BUG=
Review URL: https://codereview.chromium.org/1133163005
Cr-Commit-Position: refs/heads/master@{#28990}
2015-06-12 09:40:06 +00:00
yangguo
dd96c47a81
External snapshot: allow empty snapshot for external snapshot.
...
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1180043003
Cr-Commit-Position: refs/heads/master@{#28989}
2015-06-12 09:37:11 +00:00
wingo
fa32d461c1
Add script context with context-allocated "const this"
...
R=rossberg@chromium.org
LOG=N
BUG=498811
Review URL: https://codereview.chromium.org/1179893002
Cr-Commit-Position: refs/heads/master@{#28988}
2015-06-12 09:35:57 +00:00
jochen
89b9a2cfb3
Reland "Keep track of array buffers in new space separately"
...
Original review https://codereview.chromium.org/1133773002/
BUG=v8:3996
TBR=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1177083003
Cr-Commit-Position: refs/heads/master@{#28987}
2015-06-12 09:34:54 +00:00
Michael Achenbach
c9368b2e77
Whitespace change to test infra clean-ups.
...
Cr-Commit-Position: refs/heads/master@{#28986}
2015-06-12 09:25:47 +00:00
jochen
21bca71c6d
Update PrintStack signature in gdbinit
...
BUG=none
R=yangguo@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1179053004
Cr-Commit-Position: refs/heads/master@{#28985}
2015-06-12 08:35:50 +00:00
jochen
b935e44c79
Add support for walking stack frames from hydrogen stubs
...
R=yangguo@chromium.org
BUG=none
LOG=n
Review URL: https://codereview.chromium.org/1184493003
Cr-Commit-Position: refs/heads/master@{#28984}
2015-06-12 08:28:00 +00:00
Benedikt Meurer
bd3edf37e1
[turbofan] Inline hot functions for NodeMarkerBase.
...
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1184693002 .
Cr-Commit-Position: refs/heads/master@{#28983}
2015-06-12 08:05:16 +00:00
Michael Achenbach
068008e985
Whitespace change to test infra clean-ups.
...
Cr-Commit-Position: refs/heads/master@{#28982}
2015-06-12 07:20:19 +00:00
machenbach
f2747ed9b4
Revert of [es6] Bound function names (patchset #1 id:1 of https://codereview.chromium.org/1182513002/ )
...
Reason for revert:
[Sheriff] Speculative revert for changing layout tests:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/379/layout-test-results/results.html
Exact blame assignment is not possible as our blink bots were in a bad state for a few builds.
Original issue's description:
> [es6] Bound function names
>
> https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind
>
> Bound functions should have a name based on the function that was
> bound.
>
> BUG=N
> LOG=N
> R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3
> Cr-Commit-Position: refs/heads/master@{#28968}
TBR=adamk@chromium.org ,arv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=N
Review URL: https://codereview.chromium.org/1186463002
Cr-Commit-Position: refs/heads/master@{#28981}
2015-06-12 06:49:45 +00:00
bmeurer
888b4ecab4
[turbofan] Use RootIndexMap to speed up IsMaterializableFromRoot predicate.
...
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1181123002
Cr-Commit-Position: refs/heads/master@{#28980}
2015-06-12 06:31:08 +00:00
bmeurer
64ba57ce61
Revert of Keep track of array buffers in new space separately (patchset #4 id:60001 of https://codereview.chromium.org/1133773002/ )
...
Reason for revert:
GC stress unhappy
Original issue's description:
> Keep track of array buffers in new space separately
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc
> Cr-Commit-Position: refs/heads/master@{#28978}
TBR=hpayer@chromium.org ,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996
Review URL: https://codereview.chromium.org/1178403003
Cr-Commit-Position: refs/heads/master@{#28979}
2015-06-12 06:29:20 +00:00
jochen
506397d0a4
Keep track of array buffers in new space separately
...
BUG=v8:3996
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1133773002
Cr-Commit-Position: refs/heads/master@{#28978}
2015-06-12 05:35:35 +00:00
jacob.bramley
065b2374aa
Reland [arm64][turbofan]: Handle any immediate shift.
...
With this patch, we can generate simple immediate-shift instructions for
immediates outside the range "0 <= imm < width". Several related
instruction selectors have also been updated accordingly.
Example of generated code:
---- Before --- ---- After ----
movz w0, #33 lsr w0, w1, #1
lsr w0, w1, w0
BUG=
Review URL: https://codereview.chromium.org/1179893003
Cr-Commit-Position: refs/heads/master@{#28977}
2015-06-12 05:03:18 +00:00
martyn.capewell
b702cd97d4
[turbofan] Prefer add/shift over madd on ARM64
...
Before selecting multiply-accumulate for a multiplication with add operation,
check that the multiply can't be reduced to add-with-shift. This prevents
simple multiplications by 3, 5, etc turning into register moves and madd
instructions.
Review URL: https://codereview.chromium.org/1180863002
Cr-Commit-Position: refs/heads/master@{#28976}
2015-06-12 05:01:07 +00:00
mstarzinger
063079976c
[turbofan] Fix throwing conversion inserted by JSTypedLowering.
...
This fixes the graph wiring of implicit JSToNumber nodes inserted by
JSTypedLowering, to be correctly hooked into a surrounding exceptional
continuation.
R=bmeurer@chromium.org
TEST=mjsunit/compiler/try-binop,test262
Review URL: https://codereview.chromium.org/1178153004
Cr-Commit-Position: refs/heads/master@{#28975}
2015-06-12 04:42:14 +00:00
v8-autoroll
6d8c7958e1
Update V8 DEPS.
...
Rolling v8/tools/clang to 8b3ed2cb2e2512fa1074043cea3ada1143b80f26
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1179113002
Cr-Commit-Position: refs/heads/master@{#28974}
2015-06-12 03:27:22 +00:00