machenbach
1f44e7267e
Revert of [turbofan] simplify gap ordering (patchset #2 id:20001 of https://codereview.chromium.org/810013002/ )
...
Reason for revert:
Revert for breaking emscripten bullet with turbofan on android arm64.
Original issue's description:
> [turbofan] simplify gap ordering
>
> BUG=
>
> Committed: https://crrev.com/70b5eb47b39acbf31746f4a116a9b3ce2730218a
> Cr-Commit-Position: refs/heads/master@{#25865}
TBR=bmeurer@chromium.org ,dcarney@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/815743002
Cr-Commit-Position: refs/heads/master@{#25888}
2014-12-18 15:49:58 +00:00
ulan
2bc756e4b3
Retain maps for several garbage collections
...
This keeps dying maps alive for FLAG_retain_maps_for_n_gc garbage collections to increase chances of them being reused for new objects in future.
BUG=v8:3664
LOG=N
TEST=cctest/test-heap/MapRetaining
Review URL: https://codereview.chromium.org/794583003
Cr-Commit-Position: refs/heads/master@{#25887}
2014-12-18 15:44:37 +00:00
machenbach
40f45ab255
Revert of [turbofan] Skip printing of empty gap moves. (patchset #1 id:1 of https://codereview.chromium.org/812983002/ )
...
Reason for revert:
Needed to revert 70b5eb47b3
Original issue's description:
> [turbofan] Skip printing of empty gap moves.
>
> R=bmeurer@chromium.org
> BUG=
TBR=bmeurer@chromium.org ,titzer@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/816703002
Cr-Commit-Position: refs/heads/master@{#25886}
2014-12-18 15:01:17 +00:00
jkummerow
76aab824fe
Reduce impact of HParameter inputs on HPhi representation selection
...
This is a follow-up to r25153.
BUG=v8:3766
LOG=n
Review URL: https://codereview.chromium.org/807273003
Cr-Commit-Position: refs/heads/master@{#25885}
2014-12-18 14:50:07 +00:00
machenbach
70eb456e73
Revert of [turbofan] remove control field from instruction (patchset #1 id:1 of https://codereview.chromium.org/810023002/ )
...
Reason for revert:
Needed to revert 70b5eb47b3
Original issue's description:
> [turbofan] remove control field from instruction
>
> R=titzer@chromium.org
> BUG=
>
> Committed: https://crrev.com/7b9cb2eb3764d0c807c669e397fc3b84fbefb175
> Cr-Commit-Position: refs/heads/master@{#25866}
TBR=titzer@chromium.org ,dcarney@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/814043002
Cr-Commit-Position: refs/heads/master@{#25884}
2014-12-18 14:42:16 +00:00
ulan
83e6c7fe26
Temporarily disable mjsunit/debug-stepframe for GC stress until
...
crash is fixed.
BUG=v8:3776
LOG=N
TBR=hpayer@chromium.org
Review URL: https://codereview.chromium.org/812283004
Cr-Commit-Position: refs/heads/master@{#25883}
2014-12-18 14:05:04 +00:00
ulan
9ffdae66e2
Monomorphic and polymorphic ICs with cleared maps should not go megamorphic.
...
BUG=v8:3663
TEST=cctest/test-heap/MonomorphicStaysMonomorphicAfterGC
LOG=N
Review URL: https://codereview.chromium.org/816653002
Cr-Commit-Position: refs/heads/master@{#25882}
2014-12-18 13:09:43 +00:00
hpayer
377de64246
Make sure backing store pointer in handles get cleared after use in factory.
...
BUG=442710
LOG=n
Review URL: https://codereview.chromium.org/813023002
Cr-Commit-Position: refs/heads/master@{#25881}
2014-12-18 12:50:14 +00:00
svenpanne
bb65d40dbf
Fixed -fsanitize=float-cast-overflow problems.
...
BUG=v8:3773
LOG=y
Review URL: https://codereview.chromium.org/809293003
Cr-Commit-Position: refs/heads/master@{#25880}
2014-12-18 11:13:04 +00:00
jochen
a09168be68
Don't use AddSubstring for external natives
...
The input string is not necessarily zero terminated
BUG=chromium:443230
R=adamk@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/795383003
Cr-Commit-Position: refs/heads/master@{#25879}
2014-12-18 11:01:54 +00:00
titzer
7edd6efd4e
[turbofan] Skip printing of empty gap moves.
...
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/812983002
Cr-Commit-Position: refs/heads/master@{#25878}
2014-12-18 09:41:53 +00:00
jochen
b34a7d23d2
Crash with an error message when ICU data files are missing
...
Before, we'd just crash.
BUG=v8:3348
R=svenpanne@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/807313003
Cr-Commit-Position: refs/heads/master@{#25877}
2014-12-18 08:56:50 +00:00
machenbach
73b4c2b7c0
Add script to check for clusterfuzz issues.
...
BUG=443153
LOG=n
NOTRY=true
Review URL: https://codereview.chromium.org/811073002
Cr-Commit-Position: refs/heads/master@{#25876}
2014-12-18 08:44:14 +00:00
Benedikt Meurer
0925be14a2
[turbofan] Further reduction of Word32And with Int32Add.
...
- (y * (K << L) + x) & (-1 << L) => (x & (-1 << L)) + y * (K << L)
- (x + y * (K << L)) & (-1 << L) => (x & (-1 << L)) + y * (K << L)
TEST=unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/811293002
Cr-Commit-Position: refs/heads/master@{#25875}
2014-12-18 08:42:57 +00:00
Benedikt Meurer
bc2f2774a4
[turbofan] Also run MachineOperatorReducer in SimplifiedLoweringPhase.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/809313002
Cr-Commit-Position: refs/heads/master@{#25874}
2014-12-18 07:47:43 +00:00
erikcorry
389c275b4f
Mozilla test status: Assign bug number to quadratic assembler arm64 issue & misc regexp cleanup
...
R=marja@chromium.org
BUG=
Review URL: https://codereview.chromium.org/810053002
Cr-Commit-Position: refs/heads/master@{#25873}
2014-12-17 23:13:19 +00:00
machenbach
7d48fd9dc2
Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/792233008/ )
...
Reason for revert:
[sheriff] Still crashes on win32 (XP):
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1380
Original issue's description:
> ES6 computed property names
>
> This adds support for computed property names, under the flag
> --harmony-computed-property-names, for both object literals and
> classes.
>
> This is a revert of the revert, a76419f0f4
.
>
> This changes to do an early bailout in
> HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later
> loop.
>
> BUG=v8:3754
> LOG=Y
> TBR=dslomov@chromium.org
TBR=dslomov@chromium.org ,arv@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3754
Review URL: https://codereview.chromium.org/811593004
Cr-Commit-Position: refs/heads/master@{#25872}
2014-12-17 19:47:12 +00:00
Michael Achenbach
486e375963
Whitespace change to trigger bots.
...
Cr-Commit-Position: refs/heads/master@{#25871}
2014-12-17 19:43:36 +00:00
Michael Achenbach
966e52f635
Whitespace change to trigger bots.
...
Cr-Commit-Position: refs/heads/master@{#25870}
2014-12-17 19:10:33 +00:00
Michael Achenbach
4a37d99229
Whitespace change to trigger bots.
...
Cr-Commit-Position: refs/heads/master@{#25869}
2014-12-17 19:07:50 +00:00
arv
cc568d1b7a
ES6 computed property names
...
This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.
This is a revert of the revert, a76419f0f4
.
This changes to do an early bailout in
HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later
loop.
BUG=v8:3754
LOG=Y
TBR=dslomov@chromium.org
Review URL: https://codereview.chromium.org/792233008
Cr-Commit-Position: refs/heads/master@{#25868}
2014-12-17 18:38:55 +00:00
dcarney
44e2dd535e
[turbofan] move assembly order to InstructionBlock
...
R=titzer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/805263003
Cr-Commit-Position: refs/heads/master@{#25867}
2014-12-17 15:10:03 +00:00
dcarney
7b9cb2eb37
[turbofan] remove control field from instruction
...
R=titzer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/810023002
Cr-Commit-Position: refs/heads/master@{#25866}
2014-12-17 14:10:46 +00:00
dcarney
70b5eb47b3
[turbofan] simplify gap ordering
...
BUG=
Review URL: https://codereview.chromium.org/810013002
Cr-Commit-Position: refs/heads/master@{#25865}
2014-12-17 13:37:56 +00:00
dcarney
84345afbfb
[turbofan] use START and END gap positions for constraints
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/798363007
Cr-Commit-Position: refs/heads/master@{#25864}
2014-12-17 12:13:58 +00:00
Benedikt Meurer
a7d8724188
[turbofan] Improve reduction of Word32And and Int32Add.
...
TEST=unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/816433002
Cr-Commit-Position: refs/heads/master@{#25863}
2014-12-17 11:34:39 +00:00
hpayer
83849a347c
Revert of Shrink initial old generation size based on new space survival rate. (patchset #7 id:140001 of https://codereview.chromium.org/785593002/ )
...
Reason for revert:
Performance regressions.
Original issue's description:
> Shrink initial old generation size based on new space survival rate.
>
> BUG=
>
> Committed: https://crrev.com/37f9bb72b9c7ea4eccef6cb6533b3c42792fb5e6
> Cr-Commit-Position: refs/heads/master@{#25850}
TBR=jochen@chromium.org ,ulan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/813733002
Cr-Commit-Position: refs/heads/master@{#25862}
2014-12-17 11:17:40 +00:00
Benedikt Meurer
d0a7ef938a
[turbofan] Recursively reduce new inputs of changed nodes.
...
The GraphReducer should recurse into new inputs after a node was
changed. Most of the reducers already assume this behavior, and it
mostly worked by accident in many cases.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/800073004
Cr-Commit-Position: refs/heads/master@{#25861}
2014-12-17 10:31:52 +00:00
jochen
7303db84f5
Allocate memory for external snapshot paths in d8
...
R=marja@chromium.org
BUG=chromium:442804
LOG=n
Review URL: https://codereview.chromium.org/791713003
Cr-Commit-Position: refs/heads/master@{#25860}
2014-12-17 10:30:52 +00:00
bmeurer
5a8be47d21
Revert of [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer. (patchset #1 id:1 of https://codereview.chromium.org/801263002/ )
...
Reason for revert:
Can cause reduce cycles, needs more investigation
Original issue's description:
> [turbofan] Correctify TruncateFloat64ToInt32 reduction in MachineOperatorReducer.
>
> TEST=unittests
> R=svenpanne@chromium.org
>
> Committed: 6e7ceee4d0
TBR=svenpanne@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/794473003
Cr-Commit-Position: refs/heads/master@{#25859}
2014-12-17 09:51:17 +00:00
erik.corry
a75fc3a95b
Allow timeout on regexp test
...
R=marja@chromium.org
BUG=
Review URL: https://codereview.chromium.org/798713004
Cr-Commit-Position: refs/heads/master@{#25858}
2014-12-17 08:23:29 +00:00
Benedikt Meurer
788411c334
[turbofan] Handle collisions properly in value numbering.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/795433003
Cr-Commit-Position: refs/heads/master@{#25857}
2014-12-17 08:05:34 +00:00
v8-autoroll
f9be562d61
Update V8 DEPS.
...
Rolling v8/tools/clang to 90fb65e7a9a5c9d6d9613dfb0e78921c52ca9cfc
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/795843004
Cr-Commit-Position: refs/heads/master@{#25856}
2014-12-17 04:29:39 +00:00
caitpotter88
525385ab50
Fix ArrayConcat for JSValues/JSFunctions/JSRegExps with @@isConcatSpreadable
...
LOG=N
BUG=v8:3764, v8:3765
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/799803003
Cr-Commit-Position: refs/heads/master@{#25855}
2014-12-16 21:08:27 +00:00
arv
2639bfe993
ES6: Update unscopables to match spec
...
The spec ended up using Get(unscopables, propertyName) and
comparing the result to undefined instead of using Has.
BUG=v8:3632
LOG=Y
R=adamk, dslomov@chromium.org
Review URL: https://codereview.chromium.org/807893002
Cr-Commit-Position: refs/heads/master@{#25854}
2014-12-16 20:07:41 +00:00
arv
5f22fdd5ae
Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/807173002/ )
...
Reason for revert:
Crashes Win32. It was not flake.
Original issue's description:
> ES6 computed property names
>
> This adds support for computed property names, under the flag
> --harmony-computed-property-names, for both object literals and
> classes.
>
> This is a revert of the revert, a76419f0f4
with
> no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots
> try again.
>
> BUG=v8:3754
> LOG=Y
> TBR=dslomov@chromium.org
TBR=dslomov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3754
Review URL: https://codereview.chromium.org/807033003
Cr-Commit-Position: refs/heads/master@{#25853}
2014-12-16 19:38:59 +00:00
erikcorry
7de5933759
Speed up ARM64 debug assembler more
...
R=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/810473004
Cr-Commit-Position: refs/heads/master@{#25852}
2014-12-16 17:46:41 +00:00
arv
a235b1076a
ES6 computed property names
...
This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.
This is a revert of the revert, a76419f0f4
with
no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots
try again.
BUG=v8:3754
LOG=Y
TBR=dslomov@chromium.org
Review URL: https://codereview.chromium.org/807173002
Cr-Commit-Position: refs/heads/master@{#25851}
2014-12-16 17:30:05 +00:00
hpayer
37f9bb72b9
Shrink initial old generation size based on new space survival rate.
...
BUG=
Review URL: https://codereview.chromium.org/785593002
Cr-Commit-Position: refs/heads/master@{#25850}
2014-12-16 16:26:34 +00:00
ulan
13449b6623
ARM: check immediate overflow in branch and mov_label_offset in release mode to catch crashes earlier.
...
BUG=chromium:440913
LOG=N
Review URL: https://codereview.chromium.org/810763002
Cr-Commit-Position: refs/heads/master@{#25849}
2014-12-16 15:35:38 +00:00
erik.corry
0e1b46ba31
Fix quadratic test in debug-mode ARM64 assembler
...
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/812593002
Cr-Commit-Position: refs/heads/master@{#25848}
2014-12-16 15:17:22 +00:00
dslomov
52e487d7a2
Make sure FunctionToMethod is lazily compiled.
...
R=arv@chromium.org
BUG=v8:3330
LOG=N
Review URL: https://codereview.chromium.org/808723002
Cr-Commit-Position: refs/heads/master@{#25847}
2014-12-16 15:09:56 +00:00
Jakob Kummerow
d5e6462d86
Bump the limit for test-heap/TestSizeOfRegExpCode
...
R=erik.corry@gmail.com
Review URL: https://codereview.chromium.org/808773003
Cr-Commit-Position: refs/heads/master@{#25846}
2014-12-16 14:29:06 +00:00
jkummerow
01a0931728
Add tools/find-commit-for-patch.py
...
It searches for a commit that a given patch can cleanly be applied to.
Review URL: https://codereview.chromium.org/799273003
Cr-Commit-Position: refs/heads/master@{#25845}
2014-12-16 14:25:00 +00:00
jkummerow
028425916f
Follow-up to r25822: only internalize short strings optimistically
...
BUG=chromium:442703
LOG=n
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/809723002
Cr-Commit-Position: refs/heads/master@{#25844}
2014-12-16 14:21:32 +00:00
svenpanne
cbf3b0bcc7
More -fsanitize=vptr fixes.
...
This actually fixes 3 different issues when accessing Operand1:
* Object vs. HeapObject
* Wrong defaults for equals/hash
* silently dropping const
TEST=test/mjsunit/regress/regress-441099.js
BUG=chromium:441099
LOG=y
Review URL: https://codereview.chromium.org/812563002
Cr-Commit-Position: refs/heads/master@{#25843}
2014-12-16 14:20:28 +00:00
ishell
08146dc023
Introduced PropertyType ACCESSOR_FIELD.
...
Review URL: https://codereview.chromium.org/805453002
Cr-Commit-Position: refs/heads/master@{#25842}
2014-12-16 13:22:31 +00:00
dcarney
0349f7b71f
[turbofan] enable stack slot reuse
...
BUG=
Review URL: https://codereview.chromium.org/793683002
Cr-Commit-Position: refs/heads/master@{#25841}
2014-12-16 13:09:23 +00:00
Benedikt Meurer
2b4eb88cdd
[turbofan] Cache conversions inserted during typed lowering.
...
This greatly reduces the number of nodes in the graph (by more than 20x in
some extreme cases) for the Emscripten python interpreter main function.
BUG=v8:3763
LOG=y
TEST=cctest,mjsunit,unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/802353003
Cr-Commit-Position: refs/heads/master@{#25840}
2014-12-16 12:59:16 +00:00
erik.corry
d287f225a3
Limit code size generated for very large regexps
...
R=jkummerow@chromium.org , yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/799403003
Cr-Commit-Position: refs/heads/master@{#25839}
2014-12-16 12:33:32 +00:00