Commit Graph

60 Commits

Author SHA1 Message Date
machenbach@chromium.org
bebe520950 Add try server configuration for 'git cl try'.
BUG=
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/177533029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-04 01:29:27 +00:00
machenbach@chromium.org
fe69172e4b Revert "Add debug output to presubmit script for investigating tree check behavior." and "Add more temporary debugging output to PRESUBMIT.py".
This reverts commits r18538 and r18528, since the investigated problem was found.

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/133993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-10 15:17:49 +00:00
jkummerow@chromium.org
9fdee384c3 Add more temporary debugging output to PRESUBMIT.py
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/133863002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-10 13:48:43 +00:00
machenbach@chromium.org
6d2ff2f8d5 Add debug output to presubmit script for investigating tree check behavior.
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/133603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-10 10:50:59 +00:00
machenbach@chromium.org
901e4f60c5 Add ChangeLog presubmit check.
LOG=
BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/61733023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-11-14 14:49:07 +00:00
yangguo@chromium.org
b8534d6a82 Scripts should not care about closed tree when committing.
I just got bitten by this when merging to branch.

R=jkummerow@chromium.org, machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24254005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-24 13:35:45 +00:00
machenbach@chromium.org
f6b81d10fc Add gate keeper logic to presubmit commit check.
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/21338002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15978 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-07-31 09:16:31 +00:00
yangguo@chromium.org
02674ee414 Keep two empty lines between declarations for cpp files
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/18509003

Patch from Haitao Feng <haitao.feng@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15510 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-07-05 09:52:11 +00:00
jkummerow@chromium.org
06c26f5722 Run style checks also when uploading.
The right moment for fixing style errors is when working on the CL, not when
committing it. And this makes non-committers bump into this check too when
uploading changes.

BUG=none

Review URL: https://codereview.chromium.org/14070005
Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-04-11 12:41:31 +00:00
danno@chromium.org
037558c1c0 Add PRESUBMIT script to V8
Currently, it executes the OWNERS check and tools/presubmit.py, as well as a
check for a non-empty commit message

BUG=none
TEST=run git cl presubmit

Review URL: https://codereview.chromium.org/11092002
Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-10-08 13:49:57 +00:00