Commit Graph

4215 Commits

Author SHA1 Message Date
ricow@chromium.org
2f8af4f0a4 Fix bug in 64 bit codegen causing us to always go slowcase in apply.
After introducing the direct instruction pointer in functions the
CallApplyLazy method was changed on all platforms. The change made to
the 64 bit version was wrong, not using the right operand for the code
comparisons always forcing us into slow case.


Review URL: http://codereview.chromium.org/3104027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5317 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-23 11:21:09 +00:00
erik.corry@gmail.com
8682804746 Fix an issue in the ARM port where a left shift was predicted to have a Smi result when it had an int32 result. This is a commit of http://codereview.chromium.org/3195004 for Rodolph Perfetta. Part 2
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5316 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-23 09:04:31 +00:00
erik.corry@gmail.com
0c60beb3f2 Fix an issue in the ARM port where a left shift was predicted to have a Smi result when it had an int32 result. This is a commit of http://codereview.chromium.org/3195004 for Rodolph Perfetta
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5315 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-23 07:53:03 +00:00
ager@chromium.org
0c446a6896 Remove the virtual declaration from a couple of non-virtual JumpTarget
methods to avoid compiler warnings with some gcc versions.

Review URL: http://codereview.chromium.org/3170036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5314 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-23 07:30:09 +00:00
ager@chromium.org
ca9023c0b2 Fix mismatched new[]/delete for external string resources only used
for testing.

Review URL: http://codereview.chromium.org/3165051

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5313 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-23 06:30:00 +00:00
ricow@chromium.org
7fc3fd76e3 Re-enable test-api/RegExpInterruption on arm.
This test has been disabled for a very long time, and the fix in
http://code.google.com/p/v8/source/detail?r=5308 should make this go
away.

I will watch the buildbot continuously over the next few days to make
sure it does not appear again. If it does not I will close bug 240.


Review URL: http://codereview.chromium.org/3127023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5312 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-20 13:00:22 +00:00
erik.corry@gmail.com
0352a60512 We can use the array trim trick in old paged space as well as
new space.
Review URL: http://codereview.chromium.org/3143032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5311 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-20 12:38:33 +00:00
lrn@chromium.org
0210df5848 Use Copy-on-write arrays for cached regexp results.
Review URL: http://codereview.chromium.org/3158020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5310 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-20 09:37:22 +00:00
ricow@chromium.org
2982f5e320 Change code pointer in function objects to a pointer to the first
instruction.

By changing the pointer to the code object to a pointer to the first
instruction we can call directly this instruction directly instead of
looking up the address through the code object.

Review URL: http://codereview.chromium.org/3156028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5309 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-20 07:10:18 +00:00
vitalyr@chromium.org
103d7c7993 Fix local handle leak in RegExpStringModificationTest.
Review URL: http://codereview.chromium.org/3133027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5308 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-19 14:00:58 +00:00
vitalyr@chromium.org
86dcc0091f Remove unused function.
Review URL: http://codereview.chromium.org/3107022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5307 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-19 13:28:28 +00:00
ager@chromium.org
9d5a72673a Fix indentation in utils.h.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5306 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-19 08:49:26 +00:00
ager@chromium.org
cc475ecf47 Landing for Ryan Dahl.
Remove const from BitCast.

Fixes build for old GCCs.

Review URL: http://codereview.chromium.org/3130033/show

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5305 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-19 08:14:29 +00:00
mikhail.naganov@gmail.com
25bdc16f9f Fix issue 833: eliminate race condition in ProfilerEventsProcessor.
When under a load, the ProfilerEventsProcessor thread can start
(enter Run) after Stop has been called, thus resetting running_
data member back to 'true', and starting an infinite loop.

BUG=833

Review URL: http://codereview.chromium.org/3157022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5304 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 15:36:00 +00:00
vegorov@chromium.org
2f76132ae8 Fix two-phase lookup problem in FlexibleBodyVisitor and FixedBodyVisitor.
In FlexibleBodyVisitor and FixedBodyVisitor, the calls to IteratePointers, which lives in the base class BodyVisitorBase<StaticVisitor>, needs to be qualified with the dependent base class to be able to be bound during two-phase lookup.

Review URL: http://codereview.chromium.org/3119026


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5303 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 15:24:52 +00:00
antonm@chromium.org
40788b57c9 Remove unused typedef.
Review URL: http://codereview.chromium.org/3164022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5302 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 13:29:20 +00:00
vitalyr@chromium.org
b5bbf957a8 Make instance_size immediately useful for all fixed size objects.
For variable sized objects this field doesn't really make any sense so
by putting a special value there we can improve SizeFromMap().

Review URL: http://codereview.chromium.org/3127016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5301 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 13:00:38 +00:00
sgjesse@chromium.org
5a25c6d787 Fix Windows x64 build broken by r5299.
Review URL: http://codereview.chromium.org/3158019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5300 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 11:49:40 +00:00
sgjesse@chromium.org
3005fe4a1d Tracks the maximum usage of executable memory allocated by V8 and allows the histogram data to be gathered and reported.
This patch is contains only the usage tracking logic from 3030048 (already LGTM'd). It does not implement the RWX Limit. 

BUG=52122
TEST=Check the V8.ExecutableMemoryMax histogram in the Chrome about:histograms page

Review URL: http://codereview.chromium.org/3161015


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5299 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 10:45:15 +00:00
sgjesse@chromium.org
85718e89ac Use consistent types when calling RegExpImpl::IrregexpExecOnce
Review URL: http://codereview.chromium.org/3167021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 08:54:25 +00:00
mikhail.naganov@gmail.com
e839a1ca58 Heap profiler: allow returning aggregated snapshots via the new API.
This is intended for smoother migration to the new API in Chromium.
Also, aggregated heap snapshots can be used for cheaply obtaining
heap statistics, e.g. in tests.

Review URL: http://codereview.chromium.org/3124024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5297 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 08:19:29 +00:00
ricow@chromium.org
2f5f2cad51 Prepare push of version 2.3.9 to trunk. Now working on versin 2.3.10.
Review URL: http://codereview.chromium.org/3186010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5290 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 07:14:52 +00:00
ager@chromium.org
5ad7734a71 Decrease the DST cache increment to take into account the suspension
of DST in Egypt during Ramadan 2010.

Review URL: http://codereview.chromium.org/3122025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5289 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-18 07:01:07 +00:00
vitalyr@chromium.org
4993bba7cd Fix uninitialized field in Debug::ThreadInit().
Originally reported by Maxim.Mossienko on the isolates branch.

Review URL: http://codereview.chromium.org/3164020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5288 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 17:46:23 +00:00
antonm@chromium.org
7bf19e80cd Various improvements to oom_dump and instance type lists.
1) addresses various Mark's concern;
2) adds some missing instance types and rearranges existing ones to follow
  InstanceType order;
3) various minor cleanups.

Review URL: http://codereview.chromium.org/3119023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5286 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 13:48:03 +00:00
vegorov@chromium.org
7113163145 Fix presubmit and check failures introduced by r5284.
Review URL: http://codereview.chromium.org/3141021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5285 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 12:10:27 +00:00
vegorov@chromium.org
9ed501d95f Merge flush code phase into marking phase.
Review URL: http://codereview.chromium.org/3135026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5284 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 11:44:01 +00:00
sgjesse@chromium.org
1c1f416158 Fix breakpoints on inlined named stores in code from the optimizing compiler
Review URL: http://codereview.chromium.org/3164018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5283 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 11:06:12 +00:00
sgjesse@chromium.org
5f5833d784 Add classname to a static function call.
Review URL: http://codereview.chromium.org/3125014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5282 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 09:27:51 +00:00
erik.corry@gmail.com
6b20299bef Add support for vstr for single precision VFP register. This is a commit of http://codereview.chromium.org/3064045 for Rodolph Perfetta
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5281 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 08:43:45 +00:00
sgjesse@chromium.org
165c0369fb Fix compilation for ARMv4 for OpenBSD/FreeBSD
This is a port of r5260.
Review URL: http://codereview.chromium.org/3165021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5280 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-17 07:17:20 +00:00
vitalyr@chromium.org
03e8d318a0 Array builtins: add inline modifier to help gcc.
Review URL: http://codereview.chromium.org/3181013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5279 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 17:19:38 +00:00
vegorov@chromium.org
102db47c63 Give correct value ranges to enumeration types used as opaque types.
This allows to remove special handling of GCC 4.4 (disabling of Value Range Propagation) from SConstruct.

BUG=http://code.google.com/p/v8/issues/detail?id=830

Review URL: http://codereview.chromium.org/3135022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5278 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 17:14:34 +00:00
vitalyr@chromium.org
3202df6c69 Copy-on-write arrays.
Object model changes
----------------------------------------
New fixed_cow_array_map is used for the elements array of a JSObject
to mark it as COW. The JSObject's map and other fields are not
affected. The JSObject's map still has the "fast elements" bit set. It
means we can do only the receiver map check in keyed loads and the
receiver and the elements map checks in keyed stores. So introducing
COW arrays doesn't hurt performance of these operations. But note that
the elements map check is necessary in all mutating operations because
the "has fast elements" bit now means "has fast elements for reading".
EnsureWritableFastElements can be used in runtime functions to perform
the necessary lazy copying.

Generated code changes
----------------------------------------
Generic keyed load is updated to only do the receiver map check (this
could have been done earlier). FastCloneShallowArrayStub now has two
modes: clone elements and use COW elements. AssertFastElements macro
is added to check the elements when necessary. The custom call IC
generators for Array.prototype.{push,pop} are updated to avoid going
to the slow case (and patching the IC) when calling the builtin should
work.

COW enablement
----------------------------------------
Currently we only put shallow and simple literal arrays in the COW
mode. This is done by the parser.

Review URL: http://codereview.chromium.org/3144002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5275 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 16:06:46 +00:00
ager@chromium.org
cc7af0f7a3 Prepare push of version 2.3.8 to trunk. Now working on version 2.3.9.
Review URL: http://codereview.chromium.org/3117018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5274 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 15:49:02 +00:00
erik.corry@gmail.com
702780ee9a Make the Integer32 type info only cover the signed 32 bit integers.
Fix some bit op bugs introduced last week on IA32:
http://code.google.com/p/chromium/issues/detail?id=52096
Review URL: http://codereview.chromium.org/3151017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5273 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 15:08:32 +00:00
antonm@chromium.org
0ffcace080 Initial implementation of oom_dump utility.
Note: it intentionally lags behind current HeapStats (which now has os_error field)
as these new minidumps could not be produced by current versions of Chrome yet.

Review URL: http://codereview.chromium.org/3170015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5272 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 12:36:02 +00:00
antonm@chromium.org
0d8ec2a8d8 Remove temporary support for two indexed property query APIs.
Review URL: http://codereview.chromium.org/3143015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5271 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 11:53:52 +00:00
erik.corry@gmail.com
e18d07b604 ARM: Ensure that we are not in a spilled scope when calling
Load() or constructing a reference.
Review URL: http://codereview.chromium.org/3125011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5270 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 11:43:30 +00:00
erik.corry@gmail.com
a2d1dad441 Add rcr to disassembler.
Review URL: http://codereview.chromium.org/3108023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5268 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 11:18:42 +00:00
sgjesse@chromium.org
e61bd7bd26 ARM: backend opt for ToBoolean: JIT code generation for ToBool
Upgraded the CodeGenerator::ToBoolean() function in the ARM backend to use complete JIT code generation and not make runtime calls to ToBool (when VFP is enabled). 

This change also includes the vcmp VFP instruction that supports a constant 0.0 as the second operand. 

Patch by Subrato K De <subratokde@codeaurora.org>



git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-16 07:52:49 +00:00
peter.rybin@gmail.com
6fa44eb979 LiveEdit: implement stack manipulations for x64
Review URL: http://codereview.chromium.org/3120011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5264 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 13:54:28 +00:00
sgjesse@chromium.org
4673c5dc4a ARM: Fix another bug in r5252
Also hoist the load of the valueOf symbol out of the loop.
Review URL: http://codereview.chromium.org/3170014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5263 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 12:36:59 +00:00
sgjesse@chromium.org
67b42cdad8 ARM: Fix bug in r5252
Review URL: http://codereview.chromium.org/3123013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5262 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 11:18:16 +00:00
antonm@chromium.org
0ee0a36e72 Add last OS error into heap stats.
That could allow us to understand why commit of from space sometimes fails.
Another option would be start a separate structure with OS-related info, but
as it's a single field, let's put it into HeapStats, at least for now.

Review URL: http://codereview.chromium.org/3118013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5261 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 11:11:36 +00:00
erik.corry@gmail.com
2399aca8be Fix compilation for ARMv4.
Review URL: http://codereview.chromium.org/3161009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5260 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 10:19:45 +00:00
ager@chromium.org
3e936b547a Remove experimental fast-codegen. We are no longer working on this
approach.

Review URL: http://codereview.chromium.org/3152016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5259 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 09:07:09 +00:00
sgjesse@chromium.org
56e0221754 Handle accessors when generating Error.stack
BUG=http://code.google.com/p/v8/issues/detail?id=798
TEST=test/mjsunit/regress/regress-798.js
Review URL: http://codereview.chromium.org/3082012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 08:31:52 +00:00
ager@chromium.org
d40abe3313 Allow allocation in FailedAccessCheckCallback to allow embedders to
for instance throw exceptions in case of failed access checks.

Review URL: http://codereview.chromium.org/3165016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5257 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-13 06:55:44 +00:00
peter.rybin@gmail.com
9ef1670464 Reduce size of function restarter frame.
Review URL: http://codereview.chromium.org/3133007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5256 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-08-12 17:27:07 +00:00