yurys@chromium.org
a6e3d992ba
To resolve functions from the call stack we need at least ids for the scripts of those functions. The information on the scripts is now included into the response.
...
Review URL: http://codereview.chromium.org/65006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-15 01:17:00 +00:00
sgjesse@chromium.org
be7f110adf
Remove definition of _HAS_EXCEPTIONS from source files.
...
The define _HAS_EXCEPTIONS=0 is only required on Windows and is already set in the SCons build file and Visual Studio project files.
Review URL: http://codereview.chromium.org/67116
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1707 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 14:58:23 +00:00
sgjesse@chromium.org
8b4cfc3768
Fix the source position recorded for funtion return
...
Record the function return position as the end of the function source. Don't record function entry and return positions as statement positions.
Added a test for source position for break at function return.
Review URL: http://codereview.chromium.org/67109
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 14:56:03 +00:00
sgjesse@chromium.org
0668a2a355
Fix VirtualFrame::is_used for ARM
...
Caused a compiler warning when compiling on Windows.
Review URL: http://codereview.chromium.org/67108
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 14:54:41 +00:00
kasperl@chromium.org
66f7a367f7
Fix build issue on Mac.
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1703 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 14:01:00 +00:00
kasperl@chromium.org
383821854b
Prepare a push to trunk (version 1.1.9).
...
Review URL: http://codereview.chromium.org/73031
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1701 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 13:29:23 +00:00
kasperl@chromium.org
5decd39b51
Move STATIC_ASSERT to IsShortcutCandidate to fix the
...
broken build.
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/67126
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1700 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 12:10:32 +00:00
kasperl@chromium.org
bca37da6af
Verify the symbol table contents before and after all
...
GCs (not just mark-compacts) and make the mark-compact
shortcutting of cons-strings identical to the scavenge
version.
Review URL: http://codereview.chromium.org/67125
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 12:00:56 +00:00
kasperl@chromium.org
850d5ed380
Fixed issue 303 by not shortcutting cons-symbols and added
...
symbol table verification after mark-compact GCs.
Review URL: http://codereview.chromium.org/73029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1698 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 09:58:42 +00:00
mikhail.naganov@gmail.com
c77875113c
Fixed presubmit errors.
...
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/73025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1697 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 01:33:15 +00:00
mikhail.naganov@gmail.com
3c2a7bdf21
Add name inference for anonymous functions to facilitate debugging and profiling of JS code.
...
Currently function name inference is wired with AST optimization pass to avoid introducing another pass over AST. A better solution would be to rewrite AST visitors so they can be naturally combined together in a single pass, as their current implementation doesn't allow it.
For examples of cases where function names can be inferred, see the tests file.
Review URL: http://codereview.chromium.org/62146
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 00:51:59 +00:00
davemoore@chromium.org
69bdfe255b
Reenable d8 stats timers, using the histogram mechanism
...
Review URL: http://codereview.chromium.org/67100
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-14 00:30:44 +00:00
mikhail.naganov@gmail.com
0eb4dea12d
Implemented "no heap access" mode for JSFrame which is used for stack sampling in profiler.
...
As I discovered that JSFrame accesses SharedFunctionInfo only to calculate caller SP and the latter is not used in profiler's stack sampling, I disabled accessing heap objects in JSFrame when doing stack sampling. This finally made V8's profiling stable when used from Chrome on a real web app.
Review URL: http://codereview.chromium.org/73020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-13 23:12:04 +00:00
mikhail.naganov@gmail.com
ce6d2916b8
Added another check in SafeStackFrameIterator.
...
While playing with profiling in debug version of Chrome, I encontered a
case when assertion in StackHandlerIterator failed.
Review URL: http://codereview.chromium.org/65005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-13 14:42:01 +00:00
kasperl@chromium.org
3b80ddac19
Prepare a push to trunk (version 1.1.8).
...
Review URL: http://codereview.chromium.org/71001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1691 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-11 09:01:45 +00:00
iposva@chromium.org
b5ba35b742
- Fix lint failure.
...
- Add missing files d8-posix.cc and d8-windows.cc to Xcode project.
Review URL: http://codereview.chromium.org/68004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-09 23:17:45 +00:00
iposva@chromium.org
8ce3aae482
Workaround for http://crbug.com/9746 :
...
- Added special cutouts if a Vector has NULL data, which will now happen
if an external string's resource has been deleted.
- Added an verification phase before old gen GC to verify that all real
entries in the SymbolTable are valid symbols.
- Added test that verifies the correct behaviour of the workaround.
Review URL: http://codereview.chromium.org/66011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-09 23:04:00 +00:00
iposva@chromium.org
f7473610c8
- Exclude "build/include_what_you_use" from cpplint.py filters.
...
Review URL: http://codereview.chromium.org/65017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-09 20:07:30 +00:00
asargent@chromium.org
144cca7d3d
Fix v8::Object::DeleteHiddenValue to not bail when there are no hidden properties.
...
Review URL: http://codereview.chromium.org/58016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1687 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-08 21:05:29 +00:00
sgjesse@chromium.org
34064c821a
Remove the PCRE_STATIC define.
...
TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/62103
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1686 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-07 16:01:45 +00:00
erik.corry@gmail.com
59d3cf8403
Fix profiling on Android.
...
Review URL: http://codereview.chromium.org/62102
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1685 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-07 13:33:39 +00:00
sgjesse@chromium.org
835b89b727
Fixed step in handling for function.call.
...
For function.call debug step in did not work as execution did not break in the function called. This has now been fixed using the same means as for function.apply in CL http://codereview.chromium.org/63055 .
Review URL: http://codereview.chromium.org/63058
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1684 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-07 12:11:43 +00:00
sgjesse@chromium.org
a74fcf458c
Fixed the step in handling for function.apply.
...
The generic step-in mechanism floods the function called with break points to ensure a break is hit when entering the function. This generic mechanism was also used for function.apply. The code for function.apply contains a keyed load IC which was patched when stepping into function.apply. However function.apply enteres an internal frame not a JavaScript frame. This caused the logic for returning from the break in function.apply to fail as it forced a jump to the IC on the top JavaScript frame. The top JavaScript frame was the frame for the function calling function.apply not the frame for the apply function. Now returning from the break point in the keyed load IC in the apply code caused a jump to the code for the call IC for the function calling function.apply in the first place. Not a pretty sight.
Step-in now handles function.apply as a separate case where the actual JavaScript function called through apply is flodded with breakpoints instead of the function.apply function.
BUG=269
BUG=8210@chromium.org
Review URL: http://codereview.chromium.org/63055
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-07 09:54:53 +00:00
sgjesse@chromium.org
2336579a11
Apply Matt Hanselman's patch to fix issue 96.
...
Reviewed CL at http://codereview.chromium.org/42686 .
BUG=96
Review URL: http://codereview.chromium.org/62052
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-07 07:16:10 +00:00
kasperl@chromium.org
9c8b187658
Prepare a push to trunk (version 1.1.7).
...
Review URL: http://codereview.chromium.org/62091
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-07 06:00:21 +00:00
davemoore@chromium.org
500281afde
Put back compilation cache
...
Review URL: http://codereview.chromium.org/56185
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-06 18:08:06 +00:00
whesse@chromium.org
5ccfe93c9e
Fix crash with indexed setter on objects without corresponding getter.
...
Review URL: http://codereview.chromium.org/63010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-06 14:55:01 +00:00
whesse@chromium.org
20a6e7e5e9
Rewrite of VisitCountOperation that should speed it up
...
Review URL: http://codereview.chromium.org/56151
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1677 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-03 13:27:14 +00:00
lrn@chromium.org
5dc51480c5
Quick pointer comparison, removed undetectable tests.
...
Special case for NaN in equality test.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-03 12:44:45 +00:00
lrn@chromium.org
3e55df5a57
Tracks static type of strings in frame elements and results.
...
Uses static string type to optimize string additions.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1675 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-03 12:01:56 +00:00
kmillikin@chromium.org
339e2e5244
Add two more invocations of ENTER_V8 to places where we need to write
...
to V8's heap.
Review URL: http://codereview.chromium.org/60089
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1674 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-03 10:30:21 +00:00
kmillikin@chromium.org
2c5ce41876
Move some more ENTER_V8 invocations. The biggest one is to move the
...
one in v8::V8::Initialize to after the early bailout.
Review URL: http://codereview.chromium.org/60083
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-03 08:18:24 +00:00
kmillikin@chromium.org
35d6c8fb03
Remove ENTER_V8 from small API functions that do not need access to
...
V8's heap or only need read access.
This means that IsDeadCeck and EnsureInitialized could sometimes be
called without having already entered the VM. To simplify things,
this is made always the case. A couple of error callbacks do not need
to leave V8 because they haven't entered.
Consistently enter V8 after LOG_API (since LOG_API is sometimes before
EnsureInitialized or IsDeadCheck).
This all should have no effect unless V8 is built with
ENABLE_HEAP_PROTECTION and run with --protect-heap.
Review URL: http://codereview.chromium.org/56211
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1672 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-03 07:49:20 +00:00
ager@chromium.org
8947c308c6
Apply Lei Zhang's patch to add easy import of additional environment
...
variables in our scons setup.
Here is an example of importing an additional environment variable:
export MYVAR='value'
scons importenv="MYVAR"
Review URL: http://codereview.chromium.org/60046
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1671 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-02 13:00:28 +00:00
kmillikin@chromium.org
8389e4f9f8
When computing pairwise merges of frame elements, we should allow
...
constants and copies below the watermark on backward jump targets
(that's the whole point!).
Review URL: http://codereview.chromium.org/60044
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1670 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-02 12:23:49 +00:00
kmillikin@chromium.org
06860982a9
Clean up return statements in the code generator by explicitly
...
counting the reference to the return value and passing it to the
return label. This requires threading it through try/catch and
try/finally. The return value is loaded into eax more lazily than
before.
Also, perform some related refactoring of jump targets.
Review URL: http://codereview.chromium.org/56172
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1669 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-02 08:58:18 +00:00
ager@chromium.org
9bc64e657a
Prepare another push to trunk (version 1.1.6). We pushed an unsafe
...
compiler optimization which has now been reverted.
Review URL: http://codereview.chromium.org/60011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1667 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-01 10:41:37 +00:00
ager@chromium.org
deb0d4cc37
Revert change 1656 which was unsafe until it can be properly fixed.
...
TBR=whesse@chromium.org
Review URL: http://codereview.chromium.org/60010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-01 10:35:20 +00:00
lrn@chromium.org
015164f0f2
String.match tests that wasn't included in the implementation change list.
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-01 09:09:05 +00:00
sgjesse@chromium.org
a737c4239d
Merge r1636 from trunk to bleeding edge.
...
Changelist http://codereview.chromium.org/56056 was committed directly to trunk by addident.
Review URL: http://codereview.chromium.org/60005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-01 07:17:29 +00:00
ager@chromium.org
185aa082c4
Prepare to push version 1.1.5 to trunk. This version contains a
...
number of bug fixes.
Review URL: http://codereview.chromium.org/60004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1661 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-01 06:39:18 +00:00
ager@chromium.org
e39b80c743
The tests pass on the arm hardware of course.
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1660 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 16:48:14 +00:00
ager@chromium.org
2ca0e90da5
Apparently, the --simulator=arm option is not always used when using
...
test.py for running the simulator tests. Mark the exception
propagation tests as failing on ARM in general for now. I'll dig into
it again tomorrow morning.
TRB=christian.plesner.hansen@gmail.com
Review URL: http://codereview.chromium.org/56112
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 16:43:51 +00:00
ager@chromium.org
aacd90314f
Reland exception propagation fix.
...
Fix exception propagation problem where undefined was returned instead
of an empty handle in case of an exception. This problem can break
C++ programs that are not interested in catching exceptions and just
want to propagate them out by testing for empty handles.
The issue is that exceptions are not rescheduled if they are
externally caught. Externally caught exceptions have to be
rescheduled if there is a JavaScript frame on the way to the C++ frame
that holds the external handler.
A couple of tests will fail on the ARM simulator because the simulator
has separate stacks for C++ and JavaScript. I have marked the tests
as failing only on the simulator.
Review URL: http://codereview.chromium.org/56105
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1657 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 15:23:58 +00:00
whesse@chromium.org
e2ed40a1eb
Keep the result of postfix increment and decrement in a register.
...
Review URL: http://codereview.chromium.org/56106
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1656 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 15:03:02 +00:00
kmillikin@chromium.org
c80b013999
Fix issue 294 by ensuring that we don't lose the copy flag on memory
...
frame elements when allocating them to a register as a result of
popping one of their copies.
Review URL: http://codereview.chromium.org/57053
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1655 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 14:01:25 +00:00
erik.corry@gmail.com
5829acb095
Use -mthumb on debug build too.
...
Review URL: http://codereview.chromium.org/57056
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1654 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 13:55:33 +00:00
erik.corry@gmail.com
0b8be08c59
Both thumb and optimized for size.
...
Review URL: http://codereview.chromium.org/57055
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1653 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 13:24:59 +00:00
erik.corry@gmail.com
e8bb6904b0
Switch to thumb mode for runtime system on Android.
...
Review URL: http://codereview.chromium.org/57054
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1652 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 13:19:59 +00:00
erik.corry@gmail.com
45c3cba046
Optimize for size on Android.
...
Review URL: http://codereview.chromium.org/56110
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-31 13:18:43 +00:00