palfia@homejinni.com
b556dc962c
MIPS: Fix LStoreKeyed error when tracing instruction.
...
Port r14951 (01dbfe2)
Original commit message:
LStoreKeyed can have a NULL value(), when we recognize we are storing a constant
hole value.
BUG=
Review URL: https://codereview.chromium.org/16171019
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14959 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 16:45:19 +00:00
palfia@homejinni.com
299563520a
MIPS: Adapt hydrogen-based Array constructor to also support InternalArray and function call versions.
...
Port r14948 (1c2f28c)
BUG=
Review URL: https://codereview.chromium.org/16407004
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14958 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 16:06:38 +00:00
rossberg@chromium.org
9e8279e952
New unified type representation
...
Not used yet, only unit tests.
R=jkummerow@chromium.org , svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/16154027
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14957 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 15:43:53 +00:00
yangguo@chromium.org
55c8294e05
Cosmetic change to the handle dereference check.
...
R=jkummerow@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/16171017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 15:35:14 +00:00
verwaest@chromium.org
2d773e9448
Prepare push to trunk. Now working on version 3.19.10.
...
R=jkummerow@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/16379010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14953 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 13:38:28 +00:00
dcarney@chromium.org
33dabf08f9
Cutover v8 to use new style callbacks internally
...
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/15793007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14952 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 12:36:33 +00:00
mvstanton@chromium.org
e792ae1fcc
Fix LStoreKeyed error when tracing instruction.
...
LStoreKeyed can have a NULL value(), when we recognize we are storing a constant
hole value.
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/15793006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14951 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 12:09:02 +00:00
jkummerow@chromium.org
2272aa71d9
Add LoadIC_Slow builtin and use it for loading properties from primitive values.
...
This fixes recent performance regressions on Dromaeo.
BUG=chromium:242512
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/16226024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14950 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 11:12:49 +00:00
jkummerow@chromium.org
4a70dcf530
Use HSoftDeoptimize instead of HDeoptimize in VisitSwitchStatement, and visit the entire graph
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/15929010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14949 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 11:05:45 +00:00
mvstanton@chromium.org
56f3337ebc
Adapt hydrogen-based Array constructor to also support InternalArray and function call
...
versions.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/14576005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14948 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 10:43:18 +00:00
yangguo@chromium.org
bca226d3e6
Free PerThreadAssertData when possible to avoid memory leak.
...
R=svenpanne@chromium.org
BUG=246567
Review URL: https://chromiumcodereview.appspot.com/16093024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14947 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 09:41:24 +00:00
verwaest@chromium.org
5e8679beea
Remove the optimized construct stub.
...
R=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15993016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14946 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 08:43:25 +00:00
yurys@chromium.org
40a5fc747d
Print accessors execution time in test-cpu-profiler/NativeAccessorNameInProfile1
...
The test is failing on Win64 bot but passes locally I need this debug print to better understand what's different on the bot.
BUG=None
TBR=loislo@chromium.org
Review URL: https://codereview.chromium.org/16359016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14945 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-05 06:15:41 +00:00
adamk@chromium.org
de92d0b0e0
Array.observe emit splices for array length change and update index >= length
...
R=adamk@chromium.org , rossberg@chromium.org
Review URL: https://codereview.chromium.org/15504002
Patch from Rafael Weinstein <rafaelw@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14944 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 23:58:49 +00:00
palfia@homejinni.com
70ce03c19d
MIPS: Turn off allocation site info for crankshafted array constructor calls.
...
Port r14934 (dbddd7e)
Original commit message:
Once we crankshaft a method, we should turn off allocation site info for
constructed arrays. Additionally, the semantics for doing this were
awkward because the constructed array code stubs get an
AllocationSiteMode as a minor key, but it's used as a permission to
determine the final mode locally based on ElementsKind. I refactored
this to a simpler boolean for override or local control.
BUG=
Review URL: https://codereview.chromium.org/16226020
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14943 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 20:17:22 +00:00
palfia@homejinni.com
74a06647cc
MIPS: Deprecate FACTORY helper macro.
...
Port r14931 (a914442)
Original commit message:
This removes the FACTORY helper macro to avoid accidental TLS access
when using the factory. Most internal code has access to the Isolate by
now whereas tests which are not performance critical still heavily use
TLS access through explicit Isolate::Current() calls.
BUG=
Review URL: https://codereview.chromium.org/15994011
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14942 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 20:14:37 +00:00
palfia@homejinni.com
fdc46eea7a
MIPS : Collect type feedback for power-of-2 right operands in BinaryOps.
...
Port r14928 (a2e0e18)
Original commit message:
Improved --trace-ic output for unary/binary ops a bit on the way. Moved int32_t/uint32_t conversion helpers around.
BUG=
Review URL: https://codereview.chromium.org/16361004
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14941 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 20:11:16 +00:00
mstarzinger@chromium.org
be243df7ca
Prevent excessive processing of weak maps while marking.
...
This makes sure processing of Harmony weak maps is only triggerd twice
during a mark-compact collection. Note that the processing itself still
is a fix-point iteration with quadratic worst-case time.
R=hpayer@chromium.org
BUG=v8:2699
Review URL: https://codereview.chromium.org/16286018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14940 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 17:20:06 +00:00
verwaest@chromium.org
95cd146359
Fix win build
...
BUG=
R=hpayer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15934019
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 17:15:32 +00:00
jkummerow@chromium.org
20cedf9a4b
Liveness analysis for environment slots in Hydrogen
...
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/15533004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14938 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 16:41:24 +00:00
verwaest@chromium.org
00addf5adc
Replace log2 with MostSignificantBit
...
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15994015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14937 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 15:39:56 +00:00
dcarney@chromium.org
2380eff265
Remove V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS.
...
Blink has migrated to use the new style visitors.
BUG=
R=dcarney@chromium.org , svenpanne@chromium.org
Review URL: https://codereview.chromium.org/16360005
Patch from Marja Hölttä <marja@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 13:36:18 +00:00
hpayer@chromium.org
599511d0c0
Added pretenuring support for call new.
...
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/16226012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14935 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 13:20:13 +00:00
mvstanton@chromium.org
8a02fd3be3
Turn off allocation site info for crankshafted array constructor calls.
...
Once we crankshaft a method, we should turn off allocation site info for
constructed arrays. Additionally, the semantics for doing this were
awkward because the constructed array code stubs get an
AllocationSiteMode as a minor key, but it's used as a permission to
determine the final mode locally based on ElementsKind. I refactored
this to a simpler boolean for override or local control.
BUG=
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/16206007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 12:48:51 +00:00
verwaest@chromium.org
277ec5d7b2
Infer the range of XOR as limited by the highest possible changed bit.
...
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16361003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14933 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 12:26:39 +00:00
yurys@chromium.org
106a477443
CPU profiler should support names of accessors set via v8::Object::SetAccessor
...
This change fixes the case when the accessors are invoked from JSObject::{Get,Set}PropertyWithCallback.
It already works for inlined calls generated by StoreStubCompiler::CompileStoreCallback. The same still needs to be fixed for getter invocations generated by BaseLoadStubCompiler::CompileLoadCallback, corresponding case is commented out in the new test.
This is a slightly modified version of r14915 which was rolled back due to test timeout on Windows. Compared to r14915 the new tests use OS::TimeCurrentMillis instead of OS::Ticks as OS::Ticks has ms precision on Windows and trying to wait 10 ticks (us) will result in at least 1 ms pause.
BUG=244580
R=jkummerow@chromium.org , loislo@chromium.org
Review URL: https://codereview.chromium.org/15995017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 10:57:32 +00:00
mstarzinger@chromium.org
f8db2414f2
Deprecate FACTORY helper macro.
...
This removes the FACTORY helper macro to avoid accidental TLS access
when using the factory. Most internal code has access to the Isolate by
now whereas tests which are not performance critical still heavily use
TLS access through explicit Isolate::Current() calls.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/16337005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14931 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 10:30:05 +00:00
mstarzinger@chromium.org
d7975dfdab
Deprecate HAllocateObject in favor of HAllocate.
...
This models the instantiation of an implicit receiver for CallNew nodes
in hydrogen using HAllocate together with generic stores instead of one
specialized HAllocateObject instruction, hence creating a single choking
point for inlined allocation in optimized code.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/15714005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14930 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 08:28:33 +00:00
yangguo@chromium.org
b10a3abdfe
Revert accidental change to SealHandleScope.
...
R=dslomov@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/16226007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14929 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 08:06:53 +00:00
svenpanne@chromium.org
b9e025a8dc
Collect type feedback for power-of-2 right operands in BinaryOps.
...
Improved --trace-ic output for unary/binary ops a bit on the way. Moved int32_t/uint32_t conversion helpers around.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/15735005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14928 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 07:49:45 +00:00
yurys@chromium.org
d1387b2ff5
Mark test-cpu-profiler/SampleWhenFrameIsNotSetup as flaky on MIPS simulator
...
Relanding r14916 that was rolled back in r14918
BUG=v8:2628
TBR=danno
Review URL: https://codereview.chromium.org/16355004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14927 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-04 06:17:53 +00:00
verwaest@chromium.org
179ac2cd0c
Improve smi support in crankshaft
...
- Recover smi in phis if inputs are smi-typed
- Don't record smi-typed values as pointers
BUG=
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16240003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14926 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 16:57:36 +00:00
yangguo@chromium.org
99dfe8753a
Fix windows build.
...
R=rossberg@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/15927012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 16:01:51 +00:00
rossberg@chromium.org
8b936d07fc
Prepare push to trunk. Now working on version 3.19.9.
...
R=danno@chromium.org
BUG=
Review URL: https://codereview.chromium.org/16140010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 15:43:11 +00:00
yangguo@chromium.org
7f8a3d803c
Make assertion scopes thread safe.
...
R=svenpanne@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/15691017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14919 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 15:32:22 +00:00
danno@chromium.org
5344161ee6
Revert 14916: Mark test-cpu-profiler/SampleWhenFrameIsNotSetup as flaky on MIPS simulator
...
Revert 14915: CPU profiler should support names of accessors set via v8::Object::SetAccessor
Due to Windows failures
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/16335005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14918 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 15:25:28 +00:00
mvstanton@chromium.org
3d3c6b1599
Special Array constructor type feedback erroneously recorded when Array
...
was called as a function. Issue was found with optimize_constructed_array
turned on. This patch makes the fix, and turns the flag back on.
BUG=244461
R=danno@chromium.org
Review URL: https://codereview.chromium.org/16057005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14917 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 14:46:23 +00:00
yurys@chromium.org
ab38804e35
Mark test-cpu-profiler/SampleWhenFrameIsNotSetup as flaky on MIPS simulator
...
The test started failing again, disabling it for now.
BUG=v8:2628
TBR=jkummerow
Review URL: https://codereview.chromium.org/16329004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14916 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 12:58:25 +00:00
yurys@chromium.org
710c245a41
CPU profiler should support names of accessors set via v8::Object::SetAccessor
...
This change fixes the case when the accessors are invoked from JSObject::{Get,Set}PropertyWithCallback.
It already works for inlined calls generated by StoreStubCompiler::CompileStoreCallback. The same still needs to be fixed for getter invocations generated by BaseLoadStubCompiler::CompileLoadCallback, corresponding case is commented out in the new test.
BUG=244580
R=jkummerow@chromium.org , loislo@chromium.org
Review URL: https://codereview.chromium.org/16004007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14915 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 12:50:03 +00:00
dcarney@chromium.org
7d55c16389
remove V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT and V8_ALLOW_ACCESS_TO_PERSISTENT_ARROW
...
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/15979014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14914 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 10:02:02 +00:00
yurys@chromium.org
880934b1a8
Remove unnecessary check from Logger::LogCodeObject
...
Logger::LogCodeObjects is the only caller of the method. And all its
call sites check for at least one of the coditions before calling
LogCodeObjects. So there is no need to check it again.
BUG=None
R=jkummerow@chromium.org , loislo@chromium.org
Review URL: https://codereview.chromium.org/15980007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14913 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 09:46:32 +00:00
verwaest@chromium.org
7956992448
Remove unnecessary code from the json-parser.
...
R=yangguo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16306005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14912 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 09:08:00 +00:00
dcarney@chromium.org
595d0ea8b0
remove old MakeWeak
...
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/16160010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 08:17:04 +00:00
yurys@chromium.org
f6499289f6
Simulator specific code that is the same on all platforms as well as TickSample instance retrieval extracted into SampleHelper class.
...
Drive-by: extracted platform-independent pieces of Sampler::PlatformData into PlatformDataCommon.
BUG=None
R=loislo@chromium.org , svenpanne@chromium.org
Review URL: https://codereview.chromium.org/15957005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-03 07:52:08 +00:00
verwaest@chromium.org
6f5d9f9af2
Move field index into property details, freeing up the value slot of fields.
...
BUG=
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15941016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14909 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-31 19:11:09 +00:00
jkummerow@chromium.org
b4058a3bd4
Fast literals: fixed initialization of non-copied in-object property fields
...
BUG=chromium:245424
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/16190008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14906 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-31 15:50:19 +00:00
yurys@chromium.org
a5c629cc11
Fix function name inferring inside closures
...
BUG=224884
R=loislo@chromium.org , yangguo@chromium.org
Review URL: https://codereview.chromium.org/16125007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14903 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-31 12:52:28 +00:00
mstarzinger@chromium.org
b8154d9353
Fix non-idempotent modification in JSObject::AddFastProperty.
...
R=verwaest@chromium.org
BUG=mozilla/ecma/Array/15.4.5.2-2
Review URL: https://codereview.chromium.org/15955010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-31 11:58:39 +00:00
rossberg@chromium.org
3718dae502
Prepare push to trunk. Now working on version 3.19.8.
...
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/15959021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14899 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-31 11:38:36 +00:00
dcarney@chromium.org
0fbfdf1699
ReturnValue::Set needs to check for empty handles
...
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/16073010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14898 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-05-31 11:06:50 +00:00