Commit Graph

25 Commits

Author SHA1 Message Date
machenbach
a23ef7d88b Remove presubmit bot from 'git cl try'.
'git cl try' is often executed before an lgtm was given - in
this case the bot always fails.

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/820463004

Cr-Commit-Position: refs/heads/master@{#26182}
2015-01-21 08:56:26 +00:00
machenbach
fc1007027e Keep trybot definitions in sync with CQ.
"git cl try" should execute the same set of trybots as the
CQ.

Review URL: https://codereview.chromium.org/860043002

Cr-Commit-Position: refs/heads/master@{#26171}
2015-01-20 16:09:38 +00:00
marja
770d866823 Check author of a CL against the AUTHORS file.
The code is copied from Chromium presubmit.

BUG=

Review URL: https://codereview.chromium.org/837503003

Cr-Commit-Position: refs/heads/master@{#26077}
2015-01-15 13:10:09 +00:00
machenbach
2d1fd2b566 Update default trybots.
Add new gn trybot and remove nosnap dbg for being too slow.
It can be used on demand.

BUG=chromium:353487
LOG=n

Review URL: https://codereview.chromium.org/743643002

Cr-Commit-Position: refs/heads/master@{#25419}
2014-11-19 13:00:16 +00:00
jochen@chromium.org
24aead2a5a Add a PRESUBMIT check that production code does not call test code
This is based on a regular expression matching anything in a namespace
ending in test, or a method containing the words ForTest, ForTesting,
for_test, or for_testing.

It is possible to blacklist entire directories or individual files.

BUG=none
LOG=n
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/589123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-23 08:14:06 +00:00
machenbach@chromium.org
2822920331 Only include compile-only win64 trybot in default set.
BUG=chromium:353487
LOG=n
R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/570113002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-15 15:52:16 +00:00
jkummerow@chromium.org
5cc34b6b52 Delete generated runtime tests
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/548383002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-09 12:24:43 +00:00
yangguo@chromium.org
0fb57e51d4 Check that external references are registered in the serializer.
Inspired by a patch by Slava Chigrin <vchigrin@yandex-team.ru>

R=jkummerow@chromium.org, vchigrin@yandex-team.ru

Review URL: https://codereview.chromium.org/441983002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22896 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-06 07:20:14 +00:00
machenbach@chromium.org
38b13b0adf Add compile-only win64 trybot.
BUG=353487
LOG=n
R=jochen@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/385583004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22334 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-10 19:24:33 +00:00
jochen@chromium.org
b0956fb1a2 Add clang-format to presubmit checks
The check doesn't modify the patch, instead, you'll have to use "git cl
format" manually.

BUG=none
R=danno@google.com, danno@chromium.org, jkummerow@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/362263002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-02 14:11:44 +00:00
jkummerow@chromium.org
426061d3d0 Sync 'git cl presubmit' and 'tools/presubmit.py'
More precisely, add CheckGeneratedRuntimeTests to checks performed by
'git cl presubmit'.

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/352583005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21970 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-24 13:56:54 +00:00
jochen@chromium.org
a980e51471 Add DEPS files and run checkdeps in presubmit check
BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/312763002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-03 13:39:42 +00:00
machenbach@chromium.org
8bca653ca7 Add layout dbg trybot to default list.
BUG=353487
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/281013003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21302 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-14 11:11:22 +00:00
machenbach@chromium.org
061a51267e Update tryserver configuration with new linux and arm bots.
BUG=353487
TBR=jarin@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/220453007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-01 13:43:32 +00:00
machenbach@chromium.org
6a5004b6a9 Update list of V8 try bots.
R=jarin@chromium.org
TBR=jarin@chromium.org
BUG=353487
LOG=n

Review URL: https://codereview.chromium.org/219493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-31 15:47:18 +00:00
machenbach@chromium.org
bebe520950 Add try server configuration for 'git cl try'.
BUG=
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/177533029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-04 01:29:27 +00:00
machenbach@chromium.org
fe69172e4b Revert "Add debug output to presubmit script for investigating tree check behavior." and "Add more temporary debugging output to PRESUBMIT.py".
This reverts commits r18538 and r18528, since the investigated problem was found.

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/133993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-10 15:17:49 +00:00
jkummerow@chromium.org
9fdee384c3 Add more temporary debugging output to PRESUBMIT.py
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/133863002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-10 13:48:43 +00:00
machenbach@chromium.org
6d2ff2f8d5 Add debug output to presubmit script for investigating tree check behavior.
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/133603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-10 10:50:59 +00:00
machenbach@chromium.org
901e4f60c5 Add ChangeLog presubmit check.
LOG=
BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/61733023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-11-14 14:49:07 +00:00
yangguo@chromium.org
b8534d6a82 Scripts should not care about closed tree when committing.
I just got bitten by this when merging to branch.

R=jkummerow@chromium.org, machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24254005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-24 13:35:45 +00:00
machenbach@chromium.org
f6b81d10fc Add gate keeper logic to presubmit commit check.
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/21338002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15978 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-07-31 09:16:31 +00:00
yangguo@chromium.org
02674ee414 Keep two empty lines between declarations for cpp files
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/18509003

Patch from Haitao Feng <haitao.feng@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15510 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-07-05 09:52:11 +00:00
jkummerow@chromium.org
06c26f5722 Run style checks also when uploading.
The right moment for fixing style errors is when working on the CL, not when
committing it. And this makes non-committers bump into this check too when
uploading changes.

BUG=none

Review URL: https://codereview.chromium.org/14070005
Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-04-11 12:41:31 +00:00
danno@chromium.org
037558c1c0 Add PRESUBMIT script to V8
Currently, it executes the OWNERS check and tools/presubmit.py, as well as a
check for a non-empty commit message

BUG=none
TEST=run git cl presubmit

Review URL: https://codereview.chromium.org/11092002
Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-10-08 13:49:57 +00:00