AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
80,197 Commits 1 Branch 0 Tags 839 MiB
455d38ff8d
Commit Graph

103 Commits

Author SHA1 Message Date
Michael Achenbach
38c5e82f11 [test] Enforce tracker prefix for all BUG entries 
This enforces the prefix for v8 and chromium, as otherwise the links don't work in code review. Also prevents using html links to not confuse bugdroid.

NOTRY=true

Change-Id: Iaf3b97c9a7d7a87c27736d4b1f8c286daaffd452
Reviewed-on: https://chromium-review.googlesource.com/454796
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43792}
 2017-03-14 16:16:22 +00:00
Michael Achenbach
d9978e94dc [test] Enforce correct BUG numbers in commit messages 
NOTRY=true

Change-Id: Idfcc2481ae65f8098ecc94c20f992f3f3b874b8c
Reviewed-on: https://chromium-review.googlesource.com/454716
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43790}
 2017-03-14 15:04:33 +00:00
Michael Achenbach
219c14d14b [test] Do status-file presubmit check for any test file changes. 
Before this change, presubmit on upload/commit would miss checking status files when e.g. test files were deleted.

But the status file check in CI will enforce that all referenced test files exist.

NOTRY=true

Change-Id: I6069563a0a4e98406977dbce2ae44b299f7cd4b0
Reviewed-on: https://chromium-review.googlesource.com/443467
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43270}
 2017-02-17 10:14:02 +00:00
machenbach
dd0202a786 [test] Only run presubmit for changed status files 
This turns the status files check into a source processor similar to
lint and copyright check. On upload and on trybots it will only run
on the affected files.

BUG=v8:5603
NOTRY=true

Review-Url: https://codereview.chromium.org/2553633002
Cr-Commit-Position: refs/heads/master@{#41516}
 2016-12-06 11:42:11 +00:00
machenbach
d50108adc8 [test] Refactoring - move presubmit method 
Move a method that is not referenced in tools/presubmit.py.

BUG=v8:5603
NOTRY=true

Review-Url: https://codereview.chromium.org/2553623002
Cr-Commit-Position: refs/heads/master@{#41513}
 2016-12-06 11:31:32 +00:00
machenbach
c69f8fbd78 [test] Don't run presubmit over deleted files. 
BUG=v8:5603
NOTRY=true

Review-Url: https://codereview.chromium.org/2534813002
Cr-Commit-Position: refs/heads/master@{#41297}
 2016-11-28 08:30:26 +00:00
machenbach
fa37f96e35 [test] Let presubmit only run over affected files. 
Presubmit on upload and on trybot will use the affected files as
determined by the presubmit input_api.

The continuously run presubmit will use the old method and search all
files.

BUG=v8:5603
NOTRY=true

Review-Url: https://codereview.chromium.org/2523993003
Cr-Commit-Position: refs/heads/master@{#41248}
 2016-11-24 08:10:54 +00:00
yangguo
c759a3d847 [serializer] small fixes for blink snapshot. 
Changes include:
 - Adding V8_EXPORT macro for SnapshotCreator
 - Removing outdated DCHECKs.
 - Allow nullptr as external reference. This required a...
 - Refactoring of hashmaps used by the serializer.
 - Remove external references for counters. These are not used
   anywhere for isolates that are being serialized.
 - Put template infos into the partial snapshot cache.
 - Remove unnecessary presubmit check for external references.
   mksnapshot crashes if external references are missing.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892

Review-Url: https://codereview.chromium.org/2490783004
Cr-Commit-Position: refs/heads/master@{#40949}
 2016-11-14 07:17:59 +00:00
jochen
d7ef0b8c97 Fix BUILD.gn files and add presubmit step 
Remove files that were removed from the build files but never deleted.

R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2346103002
Cr-Commit-Position: refs/heads/master@{#39499}
 2016-09-19 10:59:41 +00:00
jochen
284f50c53f Enable check for non-gender neutral pronouns 
R=danno@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2088393002
Cr-Commit-Position: refs/heads/master@{#37206}
 2016-06-23 07:15:18 +00:00
adamk
ab3f008b8a Remove LOG line checking from presubmit 
As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ,
this check is not useful, and mostly serves to be a speed bump that simply forces
developers to add "LOG=N" to their commits.

The ChangeLog is already sparse enough (see detail stats at
https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's
very unlikely to be a useful signal compared to reading the commit log directly.

LOG=y
NOTRY=true

Review-Url: https://codereview.chromium.org/1956993002
Cr-Commit-Position: refs/heads/master@{#36147}
 2016-05-10 17:21:56 +00:00
machenbach
45ec73da15 [cq] Automatically use the same bots for git cl try. 
Depot tools now uses the project's cq.cfg by default on
git cl try, if no other method is specified.

Based on:
https://codereview.chromium.org/1579423004/
https://codereview.chromium.org/1587893003/

BUG=chromium:565952
TBR=tandrii@chromium.org
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1583233002

Cr-Commit-Position: refs/heads/master@{#33289}
 2016-01-14 11:15:16 +00:00
machenbach
3b6f913fe7 Revert of [cq] Keep presubmit trybots and cq automatically in sync. (patchset #1 id:1 of https://codereview.chromium.org/1580193004/ ) 
Reason for revert:
Doesn't work with triggered bots. Waiting for this fix: https://codereview.chromium.org/1587893003/

Original issue's description:
> [cq] Keep presubmit trybots and cq automatically in sync.
>
> Code copied 1:1 from chromium.
>
> BUG=chromium:565952
> LOG=n
> NOTRY=true
>
> Committed: https://crrev.com/039dce1e355be6422c672badef5f3895f3b16ead
> Cr-Commit-Position: refs/heads/master@{#33264}

TBR=tandrii@chromium.org,kjellander@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:565952

Review URL: https://codereview.chromium.org/1579223004

Cr-Commit-Position: refs/heads/master@{#33284}
 2016-01-14 08:01:06 +00:00
machenbach
039dce1e35 [cq] Keep presubmit trybots and cq automatically in sync. 
Code copied 1:1 from chromium.

BUG=chromium:565952
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1580193004

Cr-Commit-Position: refs/heads/master@{#33264}
 2016-01-13 15:07:30 +00:00
machenbach
1c07a0c8ab [cq] Use more next gen trybots. 
This uses the bots introduced here:
https://codereview.chromium.org/1581803003/

BUG=chromium:535160
LOG=n
NOTRY=true
NOPRESUBMIT=true
TBR=tandrii@chromium.org, kjellander@chromium.org

Review URL: https://codereview.chromium.org/1588543002

Cr-Commit-Position: refs/heads/master@{#33263}
 2016-01-13 14:05:42 +00:00
machenbach
235eff9574 [CQ] Add new triggered win trybots to CQ. 
TBR=sergiyb@chromium.org,tandrii@chromium.org
NOTRY=true
BUG=chromium:561530
LOG=n

Review URL: https://codereview.chromium.org/1497743002

Cr-Commit-Position: refs/heads/master@{#32568}
 2015-12-03 15:01:06 +00:00
machenbach
e8bfedab96 [test] Add status-file presubmit check. 
This loads all test suites and status files to catch subtle
syntax errors. It also checks basic status file integrity
and common mistakes.

NOTRY=true

Review URL: https://codereview.chromium.org/1475663002

Cr-Commit-Position: refs/heads/master@{#32271}
 2015-11-25 13:19:33 +00:00
thechargingvolcano
4e05854068 Remove unused function in presubmit script 
FilterFiles function is defined but unused in the code.

BUG=

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/1364643002

Cr-Commit-Position: refs/heads/master@{#30882}
 2015-09-23 10:52:45 +00:00
yangguo
6bef1d0a13 Remove builtin/runtime name clash presubmit check. 
It has become obsolete since we do the name lookup at compile time.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1319893004

Cr-Commit-Position: refs/heads/master@{#30405}
 2015-08-27 11:14:09 +00:00
mstarzinger
ee4a639681 Add presubmit check for header inclusion violation. 
This warns about include directives of inline headers within normal
header files. Note that this warning should not close the tree or
prevent the CQ from landing the patch.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1293273005

Cr-Commit-Position: refs/heads/master@{#30228}
 2015-08-18 16:41:17 +00:00
jochen
bea3791426 Improve presubmit check for BUG line 
Don't chicken out on upload already, and ignore 'none' value

BUG=none
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/1237353003

Cr-Commit-Position: refs/heads/master@{#29724}
 2015-07-17 12:21:47 +00:00
machenbach
ab25d39349 [test] Add avx2 bot to CQ. 
BUG=chromium:478460
LOG=n
NOTRY=true
TBR=bmeurer@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/1107973007

Cr-Commit-Position: refs/heads/master@{#28149}
 2015-04-30 08:47:49 +00:00
machenbach
bd92c27144 [cq] Add mips compile trybots. 
NOTRY=true

Review URL: https://codereview.chromium.org/1051093004

Cr-Commit-Position: refs/heads/master@{#27820}
 2015-04-14 13:43:32 +00:00
machenbach
107dbc96fe [cq] Add win nosnap shared trybot. 
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/1078703002

Cr-Commit-Position: refs/heads/master@{#27704}
 2015-04-09 12:43:31 +00:00
machenbach
9dac60ad2d Add public version macros. 
Side note: tools/v8-info.sh seems to have been broken ever
since the move to git.  At least it's not more broken now.

BUG=v8:3075
LOG=y

TEST=./script_test.py

Review URL: https://codereview.chromium.org/959713003

Cr-Commit-Position: refs/heads/master@{#26873}
 2015-02-26 08:59:23 +00:00
machenbach
7fdcd4f705 Add linux dbg coverage to CQ. 
NOTRY=true

Review URL: https://codereview.chromium.org/953913002

Cr-Commit-Position: refs/heads/master@{#26830}
 2015-02-24 16:39:23 +00:00
machenbach
0c38744579 Keep cl trybots in sync with cq. 
TBR=bmeurer@chromium.org
BUG=chromium:353487
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/930203003

Cr-Commit-Position: refs/heads/master@{#26750}
 2015-02-19 13:48:36 +00:00
machenbach
09bd2c1533 Keep cl trybots in sync with cq. 
NOTRY=true

Review URL: https://codereview.chromium.org/929793005

Cr-Commit-Position: refs/heads/master@{#26730}
 2015-02-18 19:31:48 +00:00
machenbach
a23ef7d88b Remove presubmit bot from 'git cl try'. 
'git cl try' is often executed before an lgtm was given - in
this case the bot always fails.

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/820463004

Cr-Commit-Position: refs/heads/master@{#26182}
 2015-01-21 08:56:26 +00:00
machenbach
fc1007027e Keep trybot definitions in sync with CQ. 
"git cl try" should execute the same set of trybots as the
CQ.

Review URL: https://codereview.chromium.org/860043002

Cr-Commit-Position: refs/heads/master@{#26171}
 2015-01-20 16:09:38 +00:00
marja
770d866823 Check author of a CL against the AUTHORS file. 
The code is copied from Chromium presubmit.

BUG=

Review URL: https://codereview.chromium.org/837503003

Cr-Commit-Position: refs/heads/master@{#26077}
 2015-01-15 13:10:09 +00:00
machenbach
2d1fd2b566 Update default trybots. 
Add new gn trybot and remove nosnap dbg for being too slow.
It can be used on demand.

BUG=chromium:353487
LOG=n

Review URL: https://codereview.chromium.org/743643002

Cr-Commit-Position: refs/heads/master@{#25419}
 2014-11-19 13:00:16 +00:00
jochen@chromium.org
24aead2a5a Add a PRESUBMIT check that production code does not call test code 
This is based on a regular expression matching anything in a namespace
ending in test, or a method containing the words ForTest, ForTesting,
for_test, or for_testing.

It is possible to blacklist entire directories or individual files.

BUG=none
LOG=n
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/589123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-23 08:14:06 +00:00
machenbach@chromium.org
2822920331 Only include compile-only win64 trybot in default set. 
BUG=chromium:353487
LOG=n
R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/570113002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-15 15:52:16 +00:00
jkummerow@chromium.org
5cc34b6b52 Delete generated runtime tests 
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/548383002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-09 12:24:43 +00:00
yangguo@chromium.org
0fb57e51d4 Check that external references are registered in the serializer. 
Inspired by a patch by Slava Chigrin <vchigrin@yandex-team.ru>

R=jkummerow@chromium.org, vchigrin@yandex-team.ru

Review URL: https://codereview.chromium.org/441983002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22896 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 07:20:14 +00:00
machenbach@chromium.org
38b13b0adf Add compile-only win64 trybot. 
BUG=353487
LOG=n
R=jochen@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/385583004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22334 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-10 19:24:33 +00:00
jochen@chromium.org
b0956fb1a2 Add clang-format to presubmit checks 
The check doesn't modify the patch, instead, you'll have to use "git cl
format" manually.

BUG=none
R=danno@google.com, danno@chromium.org, jkummerow@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/362263002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-02 14:11:44 +00:00
jkummerow@chromium.org
426061d3d0 Sync 'git cl presubmit' and 'tools/presubmit.py' 
More precisely, add CheckGeneratedRuntimeTests to checks performed by
'git cl presubmit'.

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/352583005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21970 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-06-24 13:56:54 +00:00
jochen@chromium.org
a980e51471 Add DEPS files and run checkdeps in presubmit check 
BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/312763002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-06-03 13:39:42 +00:00
machenbach@chromium.org
8bca653ca7 Add layout dbg trybot to default list. 
BUG=353487
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/281013003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21302 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-05-14 11:11:22 +00:00
machenbach@chromium.org
061a51267e Update tryserver configuration with new linux and arm bots. 
BUG=353487
TBR=jarin@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/220453007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-01 13:43:32 +00:00
machenbach@chromium.org
6a5004b6a9 Update list of V8 try bots. 
R=jarin@chromium.org
TBR=jarin@chromium.org
BUG=353487
LOG=n

Review URL: https://codereview.chromium.org/219493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-03-31 15:47:18 +00:00
machenbach@chromium.org
bebe520950 Add try server configuration for 'git cl try'. 
BUG=
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/177533029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-03-04 01:29:27 +00:00
machenbach@chromium.org
fe69172e4b Revert "Add debug output to presubmit script for investigating tree check behavior." and "Add more temporary debugging output to PRESUBMIT.py". 
This reverts commits r18538 and r18528, since the investigated problem was found.

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/133993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-01-10 15:17:49 +00:00
jkummerow@chromium.org
9fdee384c3 Add more temporary debugging output to PRESUBMIT.py 
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/133863002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-01-10 13:48:43 +00:00
machenbach@chromium.org
6d2ff2f8d5 Add debug output to presubmit script for investigating tree check behavior. 
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/133603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-01-10 10:50:59 +00:00
machenbach@chromium.org
901e4f60c5 Add ChangeLog presubmit check. 
LOG=
BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/61733023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-11-14 14:49:07 +00:00
yangguo@chromium.org
b8534d6a82 Scripts should not care about closed tree when committing. 
I just got bitten by this when merging to branch.

R=jkummerow@chromium.org, machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24254005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-09-24 13:35:45 +00:00
machenbach@chromium.org
f6b81d10fc Add gate keeper logic to presubmit commit check. 
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/21338002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15978 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-07-31 09:16:31 +00:00
yangguo@chromium.org
02674ee414 Keep two empty lines between declarations for cpp files 
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/18509003

Patch from Haitao Feng <haitao.feng@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15510 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-07-05 09:52:11 +00:00
jkummerow@chromium.org
06c26f5722 Run style checks also when uploading. 
The right moment for fixing style errors is when working on the CL, not when
committing it. And this makes non-committers bump into this check too when
uploading changes.

BUG=none

Review URL: https://codereview.chromium.org/14070005
Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-04-11 12:41:31 +00:00
danno@chromium.org
037558c1c0 Add PRESUBMIT script to V8 
Currently, it executes the OWNERS check and tools/presubmit.py, as well as a
check for a non-empty commit message

BUG=none
TEST=run git cl presubmit

Review URL: https://codereview.chromium.org/11092002
Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2012-10-08 13:49:57 +00:00