Commit Graph

2579 Commits

Author SHA1 Message Date
kozyatinskiy
dc1c71c0dc [inspector] added inspector test runner [part 1]
- added a inspector folder,
- added related GN and gyp files,
- added task handling infrastructure for test runner.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2361623006
Cr-Commit-Position: refs/heads/master@{#39866}
2016-09-29 13:46:06 +00:00
cbruni
4714069473 [tools] Add support for replacing the default content in callstats.html
BUG=
NOTRY=true

Review-Url: https://codereview.chromium.org/2376103003
Cr-Commit-Position: refs/heads/master@{#39865}
2016-09-29 13:31:31 +00:00
kozyatinskiy
e9ceb376e4 [inspector] add presubmit.py to compile inspector-related scripts
BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2354263003
Cr-Commit-Position: refs/heads/master@{#39846}
2016-09-29 00:57:04 +00:00
cbruni
d67aafa6af [tools] Fix typo in callstats.py and show stdout/stderr with replay
BUG=

Review-Url: https://codereview.chromium.org/2379613002
Cr-Commit-Position: refs/heads/master@{#39835}
2016-09-28 15:59:50 +00:00
cbruni
8e283057aa [tools] Add support to launch the replay server separately for callstats.py
BUG=
NOTRY=true

Review-Url: https://codereview.chromium.org/2380643002
Cr-Commit-Position: refs/heads/master@{#39816}
2016-09-28 09:37:50 +00:00
cbruni
c5c117a70d [tools] Improve callstats.html
- Select Total group by default, this way graphs show up immediately
- Groups can now be toggled much like pages and versions

BUG=
NOTRY=true

Review-Url: https://codereview.chromium.org/2368393005
Cr-Commit-Position: refs/heads/master@{#39806}
2016-09-28 07:50:02 +00:00
machenbach
4f02ff7ee5 [test] Make test runner more rubust on startup.
The test driver fails once in a while with no output when
listing the tests on windows, causing the testing to not
even start.

This should make that less likely if there's a flaky crash
when listing the tests.

BUG=v8:5438

Review-Url: https://codereview.chromium.org/2373043002
Cr-Commit-Position: refs/heads/master@{#39779}
2016-09-27 15:14:01 +00:00
cbruni
381aa94d37 [tools] Run callstats.py with --enable-benchmarking
Without --enable-benchmarking we might get flaky results due to active
finch experiments.

BUG=
NOTRY=true

Review-Url: https://codereview.chromium.org/2369903002
Cr-Commit-Position: refs/heads/master@{#39752}
2016-09-27 08:02:30 +00:00
kozyatinskiy
5925793d83 [inspector] enabled presubmit for inspector sub folder
BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2343733002
Cr-Commit-Position: refs/heads/master@{#39727}
2016-09-26 13:59:38 +00:00
cbruni
248b7a08b4 [tools] Revert callstats.py group regexp changes
The previous change accidentally shifted categories around which broke our
performance graphs.

BUG=

Review-Url: https://codereview.chromium.org/2369863002
Cr-Commit-Position: refs/heads/master@{#39721}
2016-09-26 13:06:51 +00:00
cbruni
a9ed516ceb [tools] Add Group-Total-V8 category to callstats.py
Group-Total-V8 contains all but Group-Callback times which should lead to more
stable data.

R=hablich@chromium.org
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2366523002
Cr-Commit-Position: refs/heads/master@{#39668}
2016-09-23 13:36:55 +00:00
cbruni
c0485c18a3 [tools] Improve callstats.html
callstats.html now directly tries to load a results.json file in the same
directory when hosted over http. Additionally, avoiding innerHTML speeds up
initial data creation.

BUG=chromium:611010
NOTRY=true

Review-Url: https://codereview.chromium.org/2361953002
Cr-Commit-Position: refs/heads/master@{#39645}
2016-09-22 20:58:36 +00:00
machenbach
6cd5d73c6c [build] Fix race in v8gen
BUG=chromium:648583
NOTRY=true

Review-Url: https://codereview.chromium.org/2365573002
Cr-Commit-Position: refs/heads/master@{#39626}
2016-09-22 13:31:41 +00:00
mtrofin
154548c2ba [tools] added unity suite to known benchmark set
try_perf.py knows now of the "unity" benchmark suite

NOTRY=true

Review-Url: https://codereview.chromium.org/2358873002
Cr-Commit-Position: refs/heads/master@{#39615}
2016-09-22 08:18:16 +00:00
kozyatinskiy
a1612d2456 [inspector] change implementation file extension from cpp to cc
BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
TBR=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2338413003
Cr-Commit-Position: refs/heads/master@{#39608}
2016-09-21 23:55:15 +00:00
machenbach
a8951a96ab [gn] Add gn support to gcmole
This also adds sources missing for PPC and x87, fixes a few
missing files in gyp due to wrong quotation and a few that
were simply not included.

The gn files are now authoritative, but the gcmole gyp and
gn source lists are enforced to match exactly.

This additional enforcement helped finding the bugs above
and will be removed when we deprecate the gyp files.

BUG=614645
NOTRY=true

Review-Url: https://codereview.chromium.org/2352103002
Cr-Commit-Position: refs/heads/master@{#39592}
2016-09-21 11:45:24 +00:00
cbruni
031a04c6e9 [tools] Reduce grokdump output size
Minidumps have gotten bigger stack ranges leading to long load times when using
grokdump's web interface. A major factor seems to be the output size of the
generated table. Using shorter class names and avoiding quotes for most
attributes we can get a significant size reduction.

BUG=

Review-Url: https://codereview.chromium.org/2352303002
Cr-Commit-Position: refs/heads/master@{#39589}
2016-09-21 11:07:44 +00:00
jochen
5e113c7241 Use git ls-tree to collect source files instead of walking the fs
Also remove obsolete oom_dump sources.

R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2343423002
Cr-Commit-Position: refs/heads/master@{#39527}
2016-09-20 07:28:14 +00:00
bradnelson
7e07d3f669 [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline.
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406
LOG=N
R=mstarzinger@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2309833003
Cr-Commit-Position: refs/heads/master@{#39521}
2016-09-19 23:57:13 +00:00
jochen
1d75f17c63 Update comment about TODO in verify_source_deps.py
Forgot to include that in the previous CL

TBR=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2354513002
Cr-Commit-Position: refs/heads/master@{#39500}
2016-09-19 11:40:59 +00:00
jochen
d7ef0b8c97 Fix BUILD.gn files and add presubmit step
Remove files that were removed from the build files but never deleted.

R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2346103002
Cr-Commit-Position: refs/heads/master@{#39499}
2016-09-19 10:59:41 +00:00
jochen
0e938d4ac0 Add files missing from gn and fix verify script
R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2342663004
Cr-Commit-Position: refs/heads/master@{#39447}
2016-09-15 13:15:16 +00:00
Alexander.Gilday2
4a64e9497b [turbolizer] Improved display of perf profiling information.
All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=

Review-Url: https://codereview.chromium.org/2228553004
Cr-Commit-Position: refs/heads/master@{#39408}
2016-09-14 09:45:41 +00:00
bgeron
5a4cbaedb1 [turbolizer] Give the HTML file a title, for bookmarks and tab labels.
BUG=

Review-Url: https://codereview.chromium.org/2293483002
Cr-Commit-Position: refs/heads/master@{#39297}
2016-09-08 21:29:01 +00:00
machenbach
6c51c7d3a1 [gn] Add generic subcommands and provide list command
This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true

Review-Url: https://codereview.chromium.org/2300333002
Cr-Commit-Position: refs/heads/master@{#39136}
2016-09-02 13:07:30 +00:00
dgozman
130d0486c0 [inspector] Initial import of v8_inspector.
Attempt #2, formatted and disabled lint for src/inspector.

BUG=chromium:635948
NOPRESUBMIT=true (for grammar check in license code)

Review-Url: https://codereview.chromium.org/2292573002
Cr-Commit-Position: refs/heads/master@{#39107}
2016-09-01 20:28:33 +00:00
jochen
50d54ee2e3 Rename SloppyBlockWithEvalContextExtension to ContextExtension
The plan is to also use it for With and Catch scopes, so all kinds of
contexts have a pointer back to their ScopeInfo

R=neis@chromium.org,marja@chromium.org
BUG=v8:5215

Review-Url: https://codereview.chromium.org/2301913002
Cr-Commit-Position: refs/heads/master@{#39092}
2016-09-01 15:04:01 +00:00
machenbach
9c9d1e18c7 [mb] Copy MB from Chromium repo
This prepares deletion of MB on the Chromium side.

This runs validation of the v8 configs as presubmit and
removes some obsolete code that required chromium.

BUG=chromium:616035

Review-Url: https://codereview.chromium.org/2299953002
Cr-Commit-Position: refs/heads/master@{#39082}
2016-09-01 12:20:20 +00:00
machenbach
081d4870d0 Revert of [inspector] Initial import of v8_inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2292573002/ )
Reason for revert:
Presubmit

Original issue's description:
> [inspector] Initial import of v8_inspector.
>
> BUG=chromium:635948
> NOPRESUBMIT=true (for code style)
>
> Committed: https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee
> Cr-Commit-Position: refs/heads/master@{#39057}

TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:635948

Review-Url: https://codereview.chromium.org/2300823002
Cr-Commit-Position: refs/heads/master@{#39058}
2016-08-31 21:48:40 +00:00
dgozman
e29594ea3c [inspector] Initial import of v8_inspector.
BUG=chromium:635948
NOPRESUBMIT=true (for code style)

Review-Url: https://codereview.chromium.org/2292573002
Cr-Commit-Position: refs/heads/master@{#39057}
2016-08-31 21:34:59 +00:00
jochen
8a086d8cc3 Print the name of the auto-detected gn build when running tests
Both x64.optdebug and x64.debug map to the x64.debug config, so
just printing arch/mode is still confusing.

R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2299623002
Cr-Commit-Position: refs/heads/master@{#39047}
2016-08-31 12:52:31 +00:00
jochen
c3e1b5f87c Add an option --gn to run-tests.py that just runs the latest gn build
R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2295703002
Cr-Commit-Position: refs/heads/master@{#39011}
2016-08-30 12:21:27 +00:00
bradnelson
08639b5b77 [WASM] Adding fuzzing binaries for wasm, and script to update them.
This adds:
* A script (tools/update-wasm-fuzzers.sh), which creates a new fuzzing seed
  corpus and uploads to google storage (you must have the right credentials).
* A new pair of DEPS entries to pull in the current version of the corpus
  based on a checked in pair of hash files.

BUG=None
TEST=None
R=ahaas@chromium.org,kcc@chromium.org,mvstanton@chromium.org

Review-Url: https://codereview.chromium.org/2273303002
Cr-Commit-Position: refs/heads/master@{#38987}
2016-08-29 19:01:48 +00:00
verwaest
1493bc8c8b Replace CollectVariables with locals(), update callsites to walk locals instead
This additionally gets rid of old approach to global shortcuts.

BUG=v8:5209

Review-Url: https://codereview.chromium.org/2287173002
Cr-Commit-Position: refs/heads/master@{#38980}
2016-08-29 12:49:35 +00:00
bgeron
d90d76bdb5 [turbofan] Improve inline-exception tests.
- Make constants more interesting.
- Add an addition to be done after the inlined call in the try-block.
- On command line, have a bit more output.
- New alternative that deopts from unoptimized code.

BUG=
R=jarin

Review-Url: https://codereview.chromium.org/2285743002
Cr-Commit-Position: refs/heads/master@{#38974}
2016-08-29 11:17:16 +00:00
bgeron
244d9ccd40 [turbofan] Tests for inlining calls, constructors, property access inside try..catch..finally.
These tests were spliced out of changelist 2216353002 and extended.

BUG=

Review-Url: https://codereview.chromium.org/2245263003
Cr-Commit-Position: refs/heads/master@{#38906}
2016-08-25 12:50:48 +00:00
marja
f9d6076115 Cleanup: Move ParseInfo to a separate file.
This makes us able to get rid of dependencies to parser.h from places
which only need the ParseInfo, and also gets rid of the curious Parser
<-> Compiler circular dependency.

Also IWYUd where necessary.

BUG=

Review-Url: https://codereview.chromium.org/2268513002
Cr-Commit-Position: refs/heads/master@{#38777}
2016-08-22 11:33:58 +00:00
jkummerow
95db63ab6b [js2c] Fix ordering issue of TextMacro expansion
If a key is a substring of an earlier value, then the earlier value
will unintentionally be clobbered. For example with:
  macro SET_PRIVATE(obj, sym, val) = (obj[sym] = val);
  SET_PRIVATE(iterator, arrayIteratorObjectSymbol, object);
if the mapping is:
  {'val': 'object',
   'obj': 'iterator',
   'sym': 'arrayIteratorObjectSymbol'}
then 'obj' -> 'iterator' will clobber 'val' -> 'object', resulting in
'val' -> 'iteratorect'. To fix this, replace all substitutions
simultaneously.

Patch from Zoe Clifford <zoeclifford@google.com>

Review-Url: https://codereview.chromium.org/2249873004
Cr-Commit-Position: refs/heads/master@{#38665}
2016-08-16 16:51:39 +00:00
bgeron
ec9465eb9b [turbolizer] Enlarge node labels and bubbles. Fix dead node display on old JSON.
BUG=

Review-Url: https://codereview.chromium.org/2230313002
Cr-Commit-Position: refs/heads/master@{#38588}
2016-08-11 16:46:18 +00:00
dgozman
ab53a8b9ec [inspector] Remove inspector_protocol_parser_test target.
This target introduces a dependency on WebKit/platform which is not the way we want it.
Keeping the build files in src/inspector, as they are not used and will be useful later on.

BUG=none
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2239603002
Cr-Commit-Position: refs/heads/master@{#38587}
2016-08-11 16:45:14 +00:00
bgeron
1cefcd4db1 [turbolizer] Display labels when they're at most 40 chars, not 30.
BUG=
R=danno

Review-Url: https://codereview.chromium.org/2232933002
Cr-Commit-Position: refs/heads/master@{#38562}
2016-08-10 20:23:57 +00:00
bgeron
a9fe26ef2e [turbolizer] Use a 300ms transition for expanding/collapsing panes, not 1000ms.
BUG=
R=danno

Review-Url: https://codereview.chromium.org/2230783005
Cr-Commit-Position: refs/heads/master@{#38561}
2016-08-10 20:09:26 +00:00
epertoso
c78c499a64 Disables readability/fn_sizes for v8.
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2231083002
Cr-Commit-Position: refs/heads/master@{#38546}
2016-08-10 15:15:21 +00:00
danno
d3905561b9 [turbolizer] Use locations rather than ranges everywhere
Also convert CodeView to a class and fix a host of selection
bugs in the process, as well as move the logic and data to
"enrich" location with one type of location data with location
data known globally to the whole graph in the selection broker.

Review-Url: https://codereview.chromium.org/2230083004
Cr-Commit-Position: refs/heads/master@{#38544}
2016-08-10 14:46:11 +00:00
danno
3899776f28 [turbolizer] Fix selection bugs and performance problems
Review-Url: https://codereview.chromium.org/2234523002
Cr-Commit-Position: refs/heads/master@{#38520}
2016-08-10 08:16:59 +00:00
bgeron
01766cd8cc [turbolizer] Visualize also the dead nodes.
R=danno,jarin
BUG=

Review-Url: https://codereview.chromium.org/2226293002
Cr-Commit-Position: refs/heads/master@{#38502}
2016-08-09 16:20:32 +00:00
bgeron
a57b243c0f [turbolizer] Show operator properties and arity in tooltip.
BUG=

Review-Url: https://codereview.chromium.org/2225683009
Cr-Commit-Position: refs/heads/master@{#38500}
2016-08-09 15:45:43 +00:00
mstarzinger
c403ab7f57 [test] Fully deprecate NO_IGNITION directive.
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2228853002
Cr-Commit-Position: refs/heads/master@{#38494}
2016-08-09 13:08:09 +00:00
bgeron
0d9ce3acff [turbolizer] Allow selecting inputs also with numeric keyboard.
R=danno
BUG=

Review-Url: https://codereview.chromium.org/2227643002
Cr-Commit-Position: refs/heads/master@{#38442}
2016-08-08 13:07:25 +00:00
machenbach
a2a5972395 [test] Deprecate test data download for most test suites
This removes the test-download method for all but
promises-aplus. They all only contain legacy code for
deleting old archives.

Only test262 needs to prepare sources on swarming, which is
moved to a new method, called unconditionally.

All references to --download-data and --download-data-only
in the infrastructure can be removed after this.

BUG=

Review-Url: https://codereview.chromium.org/2227613002
Cr-Commit-Position: refs/heads/master@{#38439}
2016-08-08 12:39:48 +00:00