sgjesse@chromium.org
2b1e19fe45
Fix presubmit error.
...
TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/2117010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4669 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-18 06:59:23 +00:00
sgjesse@chromium.org
d25c36deee
ARM: Pass arguments to keyed store IC in registers
...
The calling convention for keyed store IC on ARM is changed to receive the arguments value, key and receiver in registers r0, r1 and r2 instead of on the stack. When calling keyed store IC with a virtual frame the arguments are passed through the virtual frame and consumed by the call.
Changed the register usage in the IC code to postpone spilling the registers holding value, key and receiver to the stack until making a call into the runtime system.
Runs all the tests with:
--special-command="@ --nofull-compiler"
--special-command="@ --always-full-compiler"
--special-command="@ --noenable-vfp3"
Review URL: http://codereview.chromium.org/2116003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-18 06:57:12 +00:00
sgjesse@chromium.org
02ca5fd8b2
ARM: Fix generating two ldr instructions in place of ldrd.
...
When ldrd is not available two ldr instructions are generated. This fixes these in the case where the register used in the memory operand is the same as the first register in the register pair receiving the values.
All tests now run on ARM with the flag --special-command="@ --noenable-vfp3". Running without VFP3 support in the simulator causes more ldrd instructions to be used, and the default build configuration does not utilize ldrd, but generated tow ldr instructions.
Review URL: http://codereview.chromium.org/2078013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4667 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-18 06:38:42 +00:00
mark@chromium.org
e9b5d7855b
Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac
...
Chromium build.
v8.gyp no longer sets any V8_TARGET_ARCH_* macro on the Mac. Instead, the
proper V8_TARGET_ARCH_* macro will be set by src/globals.h in the same way as
the V8_HOST_ARCH_* macro when it detects that no target macro is currently
defined. The Mac build will attempt to compile all ia32 and x86_64 .cc files.
#ifdef guards in each of these target-specific source files prevent their
compilation when the associated target is not selected. For completeness,
these #ifdef guards are also provided for the arm and mips .cc files.
BUG=706
TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes)
Review URL: http://codereview.chromium.org/2133003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 15:41:35 +00:00
mark@chromium.org
6046ae7bcd
Fix dtoa for the LP64 model on 64-bit systems, where long is 64 bits.
...
dtoa.c:69 states: #define Long int on machines with 32-bit ints and 64-bit
longs. This change was made in Chromium's version of dtoa in r21901. I don't
know why this apparently hasn't caused a problem in v8 until now. I was
unable to build a snapshot on x86_64 Mac without this change.
BUG=706
TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes)
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 15:41:16 +00:00
antonm@chromium.org
c7b2af37ba
Use direct loop when filling small arrays.
...
r3995 (http://code.google.com/p/v8/source/detail?r=3995 ) introduce performance
regression for the case when arrat size is small (think new Array(4)).
It turns out that in those cases rep stos is slower than plain loop (apprently
due to ecx increment, but I didn't check this hypothesis.) The next thing
to try could be direct jump into right place of long sequence of stos'es.
Review URL: http://codereview.chromium.org/2082006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4664 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 14:14:34 +00:00
erik.corry@gmail.com
a31c578f25
Push/pop is just one peephole optimization. Puth them all
...
under one flag. Also other cosmetic changes to peephole
optimization.
Review URL: http://codereview.chromium.org/2104006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4663 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 11:19:10 +00:00
erik.corry@gmail.com
afe8c296a4
Better peephole optimization for ARM. This is a commit of
...
http://codereview.chromium.org/2004006 for Subrato De.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 10:51:41 +00:00
vegorov@chromium.org
5e91f6fa2f
Prepare push to trunk. We are now vorking on version 2.2.11.
...
Review URL: http://codereview.chromium.org/2108006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 09:01:39 +00:00
kasperl@chromium.org
c590fb94d6
Incorporate feedback from issue 679 and issue 690 into the
...
benchmark suite thus forming a new candidate benchmark revision:
* Remove dead code from RayTrace benchmark.
* Avoid repeated number-to-string conversion in Splay.
Review URL: http://codereview.chromium.org/2086005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4658 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 05:59:20 +00:00
peter.rybin@gmail.com
0fb04e3460
Remove tabs
...
Review URL: http://codereview.chromium.org/2132003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4657 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-14 19:20:07 +00:00
peter.rybin@gmail.com
1e8bf9db94
Add listbreakpoints command to protocol
...
Review URL: http://codereview.chromium.org/2050007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4656 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-14 15:24:25 +00:00
sgjesse@chromium.org
3a7bf08847
Modified codegen-arm.cc to no longer use V8_NATIVE_REGEXP, but to use
...
V8_INTERPRETED_REGEXP (as per Issue 1635001).
BUG=none
TEST=Ran v8 tests, as well as against current Chromium browser.
Review URL: http://codereview.chromium.org/2078005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4655 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-14 13:53:26 +00:00
vitalyr@chromium.org
3260fb9465
Add stack traces to mjsunit tests.
...
Review URL: http://codereview.chromium.org/2094005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4654 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-14 10:00:24 +00:00
lrn@chromium.org
773c503d30
Simplified replace JS.
...
Refactored code so global/non-global regexps are handled in separate functions.
Inlined ApplyReplaceFunction at its only call point.
Review URL: http://codereview.chromium.org/1994019
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4653 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-13 12:13:27 +00:00
antonm@chromium.org
d24efe5348
Remove unused labels.
...
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/2033009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4652 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 16:42:51 +00:00
peter.rybin@gmail.com
07f95278e7
Apply "Update mjsunit.status rules for LiveEdit test" again
...
Review URL: http://codereview.chromium.org/2015017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 14:46:09 +00:00
antonm@chromium.org
46263611c7
Initialize jsfunction caches earlier.
...
If --nolazy is on, we compile ArraySort which requires these caches
to be set up.
Review URL: http://codereview.chromium.org/2025006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 12:44:00 +00:00
antonm@chromium.org
e8e35eccac
Properly process arrays with overridden prototype in various Array's functions.
...
Bailout to JS Array builtins if array's prototype is different from
Array.prototype. Otherwise there might be inherited elements coming
from this prototype.
Review URL: http://codereview.chromium.org/2037008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 12:22:09 +00:00
lrn@chromium.org
44fb6cc8d3
X64: Made bit-fiddling fallback for double-to-int32 conversion.
...
Review URL: http://codereview.chromium.org/2048007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4648 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 11:16:35 +00:00
ricow@chromium.org
39e248602f
Fix arm debug build.
...
Review URL: http://codereview.chromium.org/2054010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4647 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 11:15:55 +00:00
ager@chromium.org
a33720502d
Build fix. Remove unused variable.
...
TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/2058005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4646 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 09:20:58 +00:00
ager@chromium.org
75cd61a912
Refactor the fast-case code for loading local/global variables and
...
arguments in the presence of eval to avoid code duplication. Almost
the same code was duplicated for loading properties and calling
properties.
Review URL: http://codereview.chromium.org/2053003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 09:12:23 +00:00
erik.corry@gmail.com
e5a188c2fc
ARM: Fix jumptargets to actually merge virtual frames.
...
Make use of the new functionality to make ++ and --
non-spilled operations.
Review URL: http://codereview.chromium.org/2041010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4644 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-12 09:00:29 +00:00
sgjesse@chromium.org
48d38e3063
ia32: Helper function for getting an element of a fixed array from object pointer and smi index.
...
Review URL: http://codereview.chromium.org/1990012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4643 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-11 12:38:30 +00:00
whesse@chromium.org
596adcf675
Optimize loading the global object for a named load on x64.
...
This is a port of r3911 to x64.
Review URL: http://codereview.chromium.org/1983005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-11 08:32:13 +00:00
erik.corry@gmail.com
663f8fa240
ARM: Optimize shifts by constant integers, especially
...
shifts by zero or arithmetic shifts. Updated to also
eliminate ASR followed by LSL as per part two of
http://codereview.chromium.org/1987008/show
Review URL: http://codereview.chromium.org/2054007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-11 08:27:56 +00:00
lrn@chromium.org
764dc66556
Made format string match arguments for GenericBinaryOpStub::GetName.
...
Review URL: http://codereview.chromium.org/2014010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-11 08:07:42 +00:00
lrn@chromium.org
e867e63281
RegExp: Remove use of 16-bit immediates on ia32/x64.
...
Also check more than one character at a time.
16-bit immediates requires a prefix that changes the length of the instruction.
This causes predecoder mispredictions and subsequent pipeline stalls.
Also removed redundant "atStart" local variable which is equivalent to startIndex == 0.
Review URL: http://codereview.chromium.org/1988009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-11 07:29:10 +00:00
erik.corry@gmail.com
b8f5c5e1ac
Move __C99FEATURES__ define to compile for Solaris
...
Patch from ry.
http://codereview.chromium.org/1990010/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4638 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-11 07:04:42 +00:00
peter.rybin@gmail.com
b49b954d32
Revert "Update mjsunit.status rules for LiveEdit test"
...
Review URL: http://codereview.chromium.org/2019007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4637 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 17:57:42 +00:00
ager@chromium.org
afdb1dd2bd
Added Heap:: prefix to kFixedArrayMapRootIndex in ARM
...
codegenerator. The missing scoping breaks the build with some
compilers.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/2036007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 17:19:48 +00:00
peter.rybin@gmail.com
0b9fb1e0aa
Update mjsunit.status rules for LiveEdit test
...
Review URL: http://codereview.chromium.org/1952001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4635 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 17:09:38 +00:00
sgjesse@chromium.org
1ae585b0a2
Support both TOS register combinations in inlined keyed load
...
When popping key and receiver for an inlined keyed load support either order of r0/r1. The possible swap to have key in r0 and receiver in r1 is postponed to the deferred code calling the keyed load IC.
Review URL: http://codereview.chromium.org/1992012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4634 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 13:23:42 +00:00
ager@chromium.org
f54b7767c6
Implement fast load and call of arguments in the presence of eval.
...
Load the arguments object from the context if there are no extensions
objects on the way. Then load the argument with a keyed load ic.
Review URL: http://codereview.chromium.org/2033004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4633 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 12:20:06 +00:00
lrn@chromium.org
9f859fef26
Make X64 double-to-int32 conversion use the 64-bit version of cvttsd2si.
...
Use type info to allow ia32 to use the 32-bit versions in some cases.
Remove sse3-specific code from X64 GenericBinaryOpStub.
Review URL: http://codereview.chromium.org/1992011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4632 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 11:38:58 +00:00
erik.corry@gmail.com
fa7c92eaf5
First step towards making JumpTarget work on ARM. Instead
...
of having a list of virtual frame pointers in the jump
target we have one virtual frame, which is the frame that
all have to merge to to branch to that frame. The virtual
frame in the JumpTarget is inside the JumpTarget, rather than
being an allocated object that is pointed to. Unfortunately
this means that the JumpTarget class has to be able to see
the size of a VirtualFrame object to compile, which in turn
lead to a major reorganization of related .h files. The
actual change of functionality in this change is intended
to be minimal (we now assert that the virtual frames match
when using JumpTarget instead of just assuming that they do).
Review URL: http://codereview.chromium.org/1961004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4631 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 11:32:25 +00:00
sgjesse@chromium.org
0631dab992
Add missing constant
...
Missed this file in last commit (r4629)
TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/2028007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 11:29:07 +00:00
sgjesse@chromium.org
b7df730e69
Fix inlined keyed property load on ARM
...
The change r4608 accidently disabled the inlined keyed load as the key/receiver registers was mixed up. Also make sure that the registers for the keyed load IC is not clobbered before bailout to deferred code. This adds one instriction to the inlined code path.
Review URL: http://codereview.chromium.org/2018005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4629 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 10:45:18 +00:00
sandholm@chromium.org
67c04c8744
One element cache for localtime.
...
Review URL: http://codereview.chromium.org/2023005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4628 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 09:27:37 +00:00
ricow@chromium.org
b9df5aa295
Create IS_SPEC_OBJECT macro to simplify javescript code.
...
v8natives and runtime.js updated to use new macro and simplified when possible.
Review URL: http://codereview.chromium.org/2006008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4626 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 08:58:41 +00:00
sgjesse@chromium.org
94288590a8
Prepare push to trunk. We are now vorking on version 2.2.10.
...
Review URL: http://codereview.chromium.org/1996011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 07:04:43 +00:00
ager@chromium.org
e2014fb1a3
Export SetResourceConstraints so it can be used with
...
visibility=hidden.
Review URL: http://codereview.chromium.org/2050004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4624 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 06:24:18 +00:00
sgjesse@chromium.org
6d54362dbd
Fixes bug with v8::StackTrace for non-zero script line offsets
...
Change by jaimeyap see http://codereview.chromium.org/1985004 for details.
Review URL: http://codereview.chromium.org/2049004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4623 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-10 06:24:01 +00:00
ricow@chromium.org
8d51195778
Fixed issue 619 allowing Object.create to be called with a function.
...
This change allows Object.create to take a function as input in the
proto argument. The spec says that Type(O) for the proto argument
should be true but our IS_OBJECT does not check for this. I will make a
IS_SPEC_OBJECT in macros.py and refactor v8natives in another CL.
Review URL: http://codereview.chromium.org/2051001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4622 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-09 08:43:59 +00:00
ager@chromium.org
4c628ec1bc
Fix typo in process sample. The initialization of the map template is
...
guarded by an IsEmpty check on the request template instead of the map
template.
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/2036006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4621 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-08 14:45:32 +00:00
erik.corry@gmail.com
44c17de1b3
Add friend declaration.
...
http://codereview.chromium.org/2024008/show
Committed for evan@chromium.org with apologies for getting
his email address wrong last time.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4620 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-08 06:54:36 +00:00
erik.corry@gmail.com
429f0065fe
Mark a function in assembler-x64-inl.h inline.
...
Without this annotation, it can be multiply-defined when it is
included in multiple source files. This is a commit for
evanm@chromium.org . See http://codereview.chromium.org/2044004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4619 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-07 20:31:24 +00:00
erik.corry@gmail.com
d5738c0e6d
Add ldrd and strd instructions to the ARM port. This is a
...
commit for zhangk@codeaurora.org . See
http://codereview.chromium.org/568029 and
http://codereview.chromium.org/2019003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4618 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-07 20:02:57 +00:00
sgjesse@chromium.org
ae4cc3c287
Add a flag to the ARM version of new space allocation in generated code
...
The flag SIZE_IN_WORDS indicate that the requested size is in words and not in bytes, The default is to specify the size in bytes.
Review URL: http://codereview.chromium.org/2047002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4617 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-07 14:06:55 +00:00