Commit Graph

21175 Commits

Author SHA1 Message Date
ishell
b85cd71002 Put extra information to the stack when crbug/454297 happens.
Review URL: https://codereview.chromium.org/930243002

Cr-Commit-Position: refs/heads/master@{#26683}
2015-02-17 11:23:42 +00:00
titzer
07599f3565 [turbofan] Refactor JSInliner to be a Reducer.
Next step: fix copying of the graph in inlining.

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/934723002

Cr-Commit-Position: refs/heads/master@{#26682}
2015-02-17 10:31:08 +00:00
verwaest
8e53e31eeb Implement most common usecase for elements kind generalization
BUG=

Review URL: https://codereview.chromium.org/931083002

Cr-Commit-Position: refs/heads/master@{#26681}
2015-02-17 10:07:06 +00:00
loislo
e60ec273cc CpuProfiler: move InlinedFunctionInfo class from HGraphBuilder to CompilationInfo.
A function could be deoptimized due to a deopt in the inlined code.
The inlined function might be defined in another script. So we need to
track the information about the inlined functions (scriptId and offset).
We already have the tracking code which is behind FLAG_hydrogen_track_position.
So as the first step we need to make the info accessible by CPU profiler.
In the follow-up patches I'll add the code which will enable position
tracking and push the info into CodeEntry entries.

BUG=452067
LOG=n

Review URL: https://codereview.chromium.org/914413007

Cr-Commit-Position: refs/heads/master@{#26680}
2015-02-17 09:44:52 +00:00
verwaest
839efa2e26 Reduce field type tracking to a single stable map per field.
BUG=

Review URL: https://codereview.chromium.org/930983003

Cr-Commit-Position: refs/heads/master@{#26679}
2015-02-17 08:58:05 +00:00
vegorov
305c73477c CodeTracer should open file in binary mode to avoid line endings normalization.
Review URL: https://codereview.chromium.org/924943006

Cr-Commit-Position: refs/heads/master@{#26678}
2015-02-17 07:55:49 +00:00
mstarzinger
b82a49e6fb Cleanup AstGraphBuilder::AddHomeObjectIfNeeded a bit.
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/925363003

Cr-Commit-Position: refs/heads/master@{#26677}
2015-02-16 21:19:10 +00:00
machenbach
066d1633a2 Fix typo in merge script.
BUG=chromium:451975
TBR=tandrii@chromium.org
NOTRY=true
LOG=n

TEST=./script_test.py

Review URL: https://codereview.chromium.org/932703002

Cr-Commit-Position: refs/heads/master@{#26676}
2015-02-16 19:07:38 +00:00
machenbach
4fdac75d9f Revert of MIPS: Fix 'Assembler support for internal references.' (patchset #1 id:1 of https://codereview.chromium.org/922043005/)
Reason for revert:
Breaks http://build.chromium.org/p/chromium.fyi/builders/Android%20MIPS%20Builder%20(dbg)

Original issue's description:
> MIPS: Fix 'Assembler support for internal references.'
>
> Added new INTERNAL_REFERENCE_ENCODED RelocInfo type to differentiate MIPS existing use of internal references in instructions from the new raw pointer reference needed for dd(Label*).
>
> BUG=
> TEST=cctest/test-assembler-mips/jump_tables1, cctest/test-assembler-mips/jump_tables2, cctest/test-assembler-mips/jump_tables3, cctest/test-run-machops/RunSwitch1
>
> Committed: https://crrev.com/244ac6de8316259bc5878480e05348a369c08e2f
> Cr-Commit-Position: refs/heads/master@{#26651}

TBR=danno@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org,paul.lind@imgtec.com,gergely.kis@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,balazs.kilvady@imgtec.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/934623003

Cr-Commit-Position: refs/heads/master@{#26675}
2015-02-16 18:49:45 +00:00
ishell@chromium.org
90734ca186 GCMole issues fixes (part 2).
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/927153002

Cr-Commit-Position: refs/heads/master@{#26674}
2015-02-16 18:48:21 +00:00
caitpotter88
663a9eeae4 [parsing]: eval/arguments parameter names are ok in sloppy mode
BUG=v8:3891
LOG=N
R=arv@chromium.org, marja@chromium.org

Review URL: https://codereview.chromium.org/924403002

Cr-Commit-Position: refs/heads/master@{#26673}
2015-02-16 18:18:20 +00:00
mstarzinger
03cad07aca Move DeadControl into the JSGraph so that it can be reused.
R=titzer@chromium.org

Review URL: https://codereview.chromium.org/929123002

Cr-Commit-Position: refs/heads/master@{#26672}
2015-02-16 18:16:57 +00:00
marja
868470ddc9 [strong] Adding regression cases which should always continue working.
1) Mutually recursive functions
2) Strong code using non-strong var before declaration.

These test cases ensure that we don't accidentally kill these wanted behaviors
when adding restrictions to strong mode.

BUG=

Review URL: https://codereview.chromium.org/927143002

Cr-Commit-Position: refs/heads/master@{#26671}
2015-02-16 17:57:43 +00:00
ishell
b7458cfa5e Fixed GCMole issues after r26667.
Review URL: https://codereview.chromium.org/927133002

Cr-Commit-Position: refs/heads/master@{#26670}
2015-02-16 17:46:31 +00:00
machenbach
b351e3020f Fix v8rel script after adding roll branches.
Use git hashes as keys when referring to releases, not
pure commit position numbers as those are not unique.

Better bailout to only check for recent releases.

Add new branching method with a roll branch in heads to
the v8rel test case.

Fix the way v8 is referred to in DEPS files in the test
cases. The test still had svn-number style.

BUG=chromium:451975
TBR=tandrii@chromium.org
NOTRY=true
LOG=n

TEST=./script_test.py

Review URL: https://codereview.chromium.org/928243002

Cr-Commit-Position: refs/heads/master@{#26669}
2015-02-16 17:01:00 +00:00
ishell@chromium.org
3d824f020d Fix for the compilation failure due to multi-line comments in test-migrations.cc
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/923943003

Cr-Commit-Position: refs/heads/master@{#26668}
2015-02-16 15:50:06 +00:00
ishell
35841b5055 Property reconfiguring implemented.
Previous approach for property reconfiguration was to create a free-floating map with generalized representations of all fields. This patch does it right.

When property is reconfigured either by changing its kind (kData <-> kAccessor) or its attributes it implies creation of a new branch in transition tree. If such a branch already existed before reconfiguration then it should be merged with the old (or source) branch of the transition tree. Merging procedure includes all the heavy machinery such as property location changes (kDescriptor -> kField), field representation/field type generalization, map deprecation, etc.

Review URL: https://codereview.chromium.org/888623002

Cr-Commit-Position: refs/heads/master@{#26667}
2015-02-16 15:25:54 +00:00
titzer
c5f7d2bb82 [turbofan] Fix control reducer with re-reducing branches.
R=jarin@chromium.org
LOG=Y
BUG=chromium:458876

Review URL: https://codereview.chromium.org/917383004

Cr-Commit-Position: refs/heads/master@{#26666}
2015-02-16 14:56:49 +00:00
jarin
d0758949e1 [turbofan] Clear pending exception from unsuccessful compilation.
BUG=chromium:458987
LOG=n
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/932603002

Cr-Commit-Position: refs/heads/master@{#26665}
2015-02-16 14:25:23 +00:00
svenpanne
0914181d97 Build stack frames for stubs only when needed.
The heuristic is quite naive at the moment (build a frame iff the
register allocator needed spill slots), we can improve that later.

Review URL: https://codereview.chromium.org/933603002

Cr-Commit-Position: refs/heads/master@{#26664}
2015-02-16 13:44:58 +00:00
rodolph.perfetta
20b4d6fe32 gcc 4.6 fix.
BUG=

Review URL: https://codereview.chromium.org/927083002

Cr-Commit-Position: refs/heads/master@{#26663}
2015-02-16 13:26:16 +00:00
verwaest
a1f7b01ccf Remove prototype key from the prototype transitions since its also embedded in the target map.
BUG=

Review URL: https://codereview.chromium.org/932583002

Cr-Commit-Position: refs/heads/master@{#26662}
2015-02-16 13:10:06 +00:00
jarin
0b8063cec8 [turbofan] Avoid ToNumber conversions if they could deoptimize.
BUG=chromium:454158
LOG=n
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/922623002

Cr-Commit-Position: refs/heads/master@{#26661}
2015-02-16 12:59:20 +00:00
yangguo
e7c235fa2d Track code cache reject reason via histogram buckets.
R=vogelheim@chromium.org
BUG=chromium:441896
LOG=N

Review URL: https://codereview.chromium.org/922573003

Cr-Commit-Position: refs/heads/master@{#26660}
2015-02-16 12:39:18 +00:00
machenbach
15c269b760 Include range summary when rolling into chromium.
BUG=chromium:457022
TBR=tandrii@chromium.org
NOTRY=true
LOG=n

TEST=./script_test.py

Review URL: https://codereview.chromium.org/918953003

Cr-Commit-Position: refs/heads/master@{#26659}
2015-02-16 12:21:47 +00:00
tfarina
2968496335 Rename source_prereqs to inputs in the GN Build file.
See more information in the gn-dev mailing list:
https://groups.google.com/a/chromium.org/d/msg/gn-dev/j-P5hlvZ13M/4CSw2WworlkJ

Also in
61a6fca4bc

BUG=374271
R=machenbach@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/917243002

Cr-Commit-Position: refs/heads/master@{#26658}
2015-02-16 12:09:42 +00:00
machenbach
bbb639adb7 Fix branch name in merge script.
BUG=chromium:451975
TBR=tandrii@chromium.org
NOTRY=true
LOG=n

TEST=./script_test.py

Review URL: https://codereview.chromium.org/925313002

Cr-Commit-Position: refs/heads/master@{#26657}
2015-02-16 11:57:41 +00:00
ishell
6834d3abdf ifdefs around LayoutDescriptor::IsConsistenWithMap() removed.
This avoids potential mess with different compilation modes.

Review URL: https://codereview.chromium.org/934533002

Cr-Commit-Position: refs/heads/master@{#26656}
2015-02-16 11:29:49 +00:00
svenpanne
56f9cca8f1 Get code flags from compilation info.
Removed useless (and in the future incorrect) DCHECKs on the way.

Review URL: https://codereview.chromium.org/921443004

Cr-Commit-Position: refs/heads/master@{#26655}
2015-02-16 11:04:30 +00:00
svenpanne
acd6715dd9 Removed the funky 2-stage initialization of PipelineData.
Use simple old-skool constructors instead. Note that the long repeated
member initializer lists could be reduced a bit by using C++11's
brace-or-equal initializers, which are actually recommended by the
Google C++ style guide in this case, but the ARM toolchain is still
buggy in this area (see patch sets 1 and 2).  :-/

Review URL: https://codereview.chromium.org/913993004

Cr-Commit-Position: refs/heads/master@{#26654}
2015-02-16 09:30:28 +00:00
yangguo
e66d39a6be Revert "Fix JSArrayBufferView visitor template to fix ARM build."
and "Just visit young array buffers during scavenge. Additionally keep the views in new space in a separate global list and move them to the corresponding array buffers when they get promoted."

This reverts commit 295ab27830
and commit bd61a85faf.

TBR=hpayer@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/929973002

Cr-Commit-Position: refs/heads/master@{#26653}
2015-02-16 09:21:02 +00:00
v8-autoroll
b8ec6fbf5d Update V8 DEPS.
Rolling v8/tools/clang to 21c0f1864716dbe8d8d4061c18efbde7c49b6a6a

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/930743002

Cr-Commit-Position: refs/heads/master@{#26652}
2015-02-16 04:33:05 +00:00
balazs.kilvady
244ac6de83 MIPS: Fix 'Assembler support for internal references.'
Added new INTERNAL_REFERENCE_ENCODED RelocInfo type to differentiate MIPS existing use of internal references in instructions from the new raw pointer reference needed for dd(Label*).

BUG=
TEST=cctest/test-assembler-mips/jump_tables1, cctest/test-assembler-mips/jump_tables2, cctest/test-assembler-mips/jump_tables3, cctest/test-run-machops/RunSwitch1

Review URL: https://codereview.chromium.org/922043005

Cr-Commit-Position: refs/heads/master@{#26651}
2015-02-15 12:50:47 +00:00
machenbach
38d0749c8d Revert of Don't always bail out of GenerateTypedArrayInitialize (patchset #1 id:1 of https://codereview.chromium.org/922393003/)
Reason for revert:
Speculative revert. This CL seems to break octane.

Original issue's description:
> Don't always bail out of GenerateTypedArrayInitialize
>
> In an innocuous cleanup patch, https://code.google.com/p/v8/source/detail?r=21621,
> some boolean logic got mixed up and the Hydrogen code for TypedArrayInitialize
> was changed to always bail out. This swaps the logic appropriately.
>
> Committed: https://crrev.com/907f0b6ce573333f1cbca00db5cb1df1ead175bb
> Cr-Commit-Position: refs/heads/master@{#26643}

TBR=dslomov@chromium.org,adamk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/929773002

Cr-Commit-Position: refs/heads/master@{#26650}
2015-02-15 10:14:45 +00:00
chunyang.dai
34d5cc6486 X87: Implement ES6 rest parameters.
port 8bb2e39774 (r26645).

original commit message:

BUG=

Review URL: https://codereview.chromium.org/929763002

Cr-Commit-Position: refs/heads/master@{#26649}
2015-02-15 07:40:08 +00:00
chunyang.dai
a10ed727bc X87: Assembler support for internal references.
port 5c119485b4 (r26478).

original commit message:

  Assembler support for internal references.

BUG=

Review URL: https://codereview.chromium.org/920503002

Cr-Commit-Position: refs/heads/master@{#26648}
2015-02-15 06:50:11 +00:00
chunyang.dai
a34ed97234 X87: new classes: no longer experimental.
port 2707d4c9f4 (r26628).

original commit message:

   This CL fixes tests that no longer valid and also fixes two issues:
    1. 'super()' in non derived constructors.
    2. Failure to step into derived constructors.

BUG=

Review URL: https://codereview.chromium.org/920543005

Cr-Commit-Position: refs/heads/master@{#26647}
2015-02-15 01:50:57 +00:00
v8-autoroll
de7527bcda Update V8 DEPS.
Rolling v8/buildtools to 5c5e924788fe40f7d6e0a3841ac572de2475e689

Rolling v8/tools/clang to d5f568673280ba9180bbf0b913b571786c9f352a

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/929643002

Cr-Commit-Position: refs/heads/master@{#26646}
2015-02-14 04:36:51 +00:00
caitpotter88
8bb2e39774 Implement ES6 rest parameters
LOG=Y
BUG=v8:2159
R=dslomov@chromium.org, arv@chromium.org, marja@chromium.org

Review URL: https://codereview.chromium.org/816913003

Cr-Commit-Position: refs/heads/master@{#26645}
2015-02-14 00:15:12 +00:00
arv
d0c2c2b32c ES6 Classes: Remove tracking of super construct calls.
With the new ES6 semantics super construct calls are only valid in
a constructor in a derived class. This is something that is
statically known and we report early SyntaxError in case it occurs.
We therefore do not need to track this any more.

BUG=v8:3330
LOG=N
R=dslomov@chromium.org, adamk

Review URL: https://codereview.chromium.org/924123002

Cr-Commit-Position: refs/heads/master@{#26644}
2015-02-13 22:26:34 +00:00
adamk
907f0b6ce5 Don't always bail out of GenerateTypedArrayInitialize
In an innocuous cleanup patch, https://code.google.com/p/v8/source/detail?r=21621,
some boolean logic got mixed up and the Hydrogen code for TypedArrayInitialize
was changed to always bail out. This swaps the logic appropriately.

Review URL: https://codereview.chromium.org/922393003

Cr-Commit-Position: refs/heads/master@{#26643}
2015-02-13 20:50:34 +00:00
arv
765e002a4f Fix lazy parsing for functions that use super.
The preparser needs to log the usage of super properties and then update
the scope when we create the function later.

BUG=v8:3888
LOG=N
R=dslomov@chromium.org, marja

Review URL: https://codereview.chromium.org/923683002

Cr-Commit-Position: refs/heads/master@{#26642}
2015-02-13 18:35:09 +00:00
arv
d273636e01 TF: Add support for [[HomeObject]]
BUG=None
LOG=N
R=mstarzinger@chromium.org, dslomov@chromium.org

Review URL: https://codereview.chromium.org/926013002

Cr-Commit-Position: refs/heads/master@{#26641}
2015-02-13 18:34:00 +00:00
bratell
cc36222776 Make the statistics generation data driven.
StatisticsExtension::GetCounters() has grown to repeat a lot of code
so to make it more maintainable and generate less machine code,
make it data driven. This makes a 64 bit Linux build 50 KB smaller.

Total change: -51677 bytes
==========================
  1 shrunk, for a net change of -51677 bytes (64222 bytes before, 12545 bytes after) across 1 sources
  279691 unchanged, totalling 51423668 bytes

Per-source Analysis:

-------------------------------------------------------------------------------------------------------------------
 -51677 - Source: /home/bratell/src/chromium/src/v8/src/extensions/statistics-extension.cc - (gained 0, lost 51677)
-------------------------------------------------------------------------------------------------------------------
  Shrunk symbols:
     -51677: v8::internal::StatisticsExtension::GetCounters(v8::FunctionCallbackInfo<v8::Value> const&) type=t, (was 64222 bytes, now 12545 bytes)

BUG=

Review URL: https://codereview.chromium.org/912413003

Cr-Commit-Position: refs/heads/master@{#26640}
2015-02-13 10:57:05 +00:00
loislo
a82d3dc8f9 Move identical code from platform specific assemblers to assembler.cc
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/922153002

Cr-Commit-Position: refs/heads/master@{#26639}
2015-02-13 10:45:36 +00:00
Ross McIlroy
1da1e34788 Protect access to the external_snapshot_blob global with a lock.
The external_snapshot_blob is a global and might be accessed from multiple
threads.  Protect it with a lock.

BUG=457656
LOG=N
R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/918213002

Cr-Commit-Position: refs/heads/master@{#26638}
2015-02-13 10:35:58 +00:00
Sven Panne
e9fd6b0836 Refactored the final parts of the TurboFan pipeline a bit.
This removed some inconsistent/duplicated code and made the testing
side entrance much simpler: Now it simply constructs a pipeline and
hands off to the "tail" of the normal pipeline.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/924823002

Cr-Commit-Position: refs/heads/master@{#26637}
2015-02-13 10:35:34 +00:00
loislo
2cfebcf92e Fix compilation for the case dcheck_always_on=1.
It is a default option for some try bots.

otherwise compilation fails on
DCHECK(layout_descriptor->IsConsistentWithMap(*map));

BUG=none
LOG=n

Review URL: https://codereview.chromium.org/920993003

Cr-Commit-Position: refs/heads/master@{#26636}
2015-02-13 10:29:30 +00:00
Akos Palfi
db13f0847b MIPS: new classes: no longer experimental.
Port 2707d4c9f4

Original commit message:
This CL fixes tests that no longer valid and also fixes two issues:
1. 'super()' in non derived constructors.
2. Failure to step into derived constructors.

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/920173002

Cr-Commit-Position: refs/heads/master@{#26635}
2015-02-13 01:26:20 +00:00
Akos Palfi
58d8e169f1 MIPS: new classes: implement correct check for uninitialized this in 'super()'
Port fdcf3e59ba

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/920543004

Cr-Commit-Position: refs/heads/master@{#26634}
2015-02-13 01:22:40 +00:00