kozyatinskiy
d5055bc932
Roll third_party/inspector_protocol to cf45a6e89b17cdc9eeacdef4c003fcc55f7ec2a0
...
This roll includes one change: "[inspector_protocol] support fall through and moveable Maybe" [1].
[1] https://codereview.chromium.org/2468923002/
BUG=none
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2469063002
Cr-Commit-Position: refs/heads/master@{#40687}
2016-11-01 22:33:39 +00:00
kozyatinskiy
f7f591ab6b
[inspector] migrate scriptParsed and getCompiledScripts to native
...
* Introduced DebugInterface::Script - native wrapper on internal::Script.
* Migrated getCompildScripts and scriptParsed to native wrapper.
BUG=chromium:652939, v8:5510
R=yangguo@chromium.org ,dgozman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Review-Url: https://codereview.chromium.org/2449213002
Cr-Commit-Position: refs/heads/master@{#40660}
2016-10-29 02:18:16 +00:00
clemensh
1cac34ed6b
Fix detection of BUILTIN functions
...
In the asm.js to wasm pipeline, we generate an entry function with
BUILTIN code, but still attached to a TYPE_NORMAL script.
This fix avoids trying to set a breakpoint there, resulting in a crash
on DCHECK(shared->HasDebugInfo()).
Also add two inspector tests to track regressions.
BUG=v8:5568
R=titzer@chromium.org ,mstarzinger@chromium.org
Review-Url: https://codereview.chromium.org/2457433002
Cr-Commit-Position: refs/heads/master@{#40633}
2016-10-28 06:48:44 +00:00
rob
cb2a39d367
Avoid using stale InspectedContext pointers
...
BUG=657568
TEST=Manually, see bug report
Review-Url: https://codereview.chromium.org/2432163004
Cr-Commit-Position: refs/heads/master@{#40605}
2016-10-26 20:27:12 +00:00
kozyatinskiy
d7a18896bd
[inspector] enable inspector by default
...
To achieve this:
- fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else.
- fixed asan for d8 - unique_ptr on array has single element type.
- force Debugger.disable at the end of test.
BUG=chromium:635948
R=dgozman@chromium.org ,yangguo@chromium.org,machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2450653002
Cr-Commit-Position: refs/heads/master@{#40546}
2016-10-25 07:13:48 +00:00
yangguo
8971b6b6c3
[inspector] conditionally copy files for inspector test.
...
R=machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2424313004
Cr-Commit-Position: refs/heads/master@{#40528}
2016-10-24 10:57:37 +00:00
hablich
555a725810
Revert of [inspector] align console implementation with spec (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428473003/ )
...
Reason for revert:
Breaks roll: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164610
See https://chromiumcodereview.appspot.com/2434733002/ for more context
Original issue's description:
> [inspector] align console implementation with spec
>
> console should be non enumerable.
>
> BUG=chromium:656826
> R=dgozman@chromium.org
TBR=dgozman@chromium.org ,kozyatinskiy@chromium.org
NOTRY=true
BUG=chromium:656826
Review-Url: https://chromiumcodereview.appspot.com/2435013002
Cr-Commit-Position: refs/heads/master@{#40464}
2016-10-20 11:57:48 +00:00
kozyatinskiy
ea511e769e
[inspector] finish test runner gracefully..
...
.. to make windows bot happy.
BUG=chromium:635948
R=dgozman@chromium.org
Review-Url: https://chromiumcodereview.appspot.com/2428213002
Cr-Commit-Position: refs/heads/master@{#40415}
2016-10-19 02:04:48 +00:00
kozyatinskiy
550910445f
[inspector] align console implementation with spec
...
console should be non enumerable.
BUG=chromium:656826
R=dgozman@chromium.org
Review-Url: https://chromiumcodereview.appspot.com/2428473003
Cr-Commit-Position: refs/heads/master@{#40414}
2016-10-19 02:02:20 +00:00
kozyatinskiy
377533fc06
[inspector] move changeBreakpointState from debugger-script to native
...
* introduced v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.
BUG=chromium:652939,v8:5510
R=dgozman@chromium.org ,yangguo@chromium.org
Review-Url: https://chromiumcodereview.appspot.com/2396193002
Cr-Commit-Position: refs/heads/master@{#40413}
2016-10-19 02:00:57 +00:00
jochen
d1daae6221
Fix inspector test in components build
...
R=jgruber@chromium.org ,machenbach@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2421303002
Cr-Commit-Position: refs/heads/master@{#40410}
2016-10-18 20:08:12 +00:00
clemensh
5b6e391354
[wasm] Add inspector test for stack traces
...
This ensures that the stack traces show up correctly in
DevTools. I will later extend it for source view.
R=kozyatinskiy@chromium.org , yangguo@chromium.org , titzer@chromium.org
BUG=chromium:613110
Review-Url: https://codereview.chromium.org/2420093002
Cr-Commit-Position: refs/heads/master@{#40392}
2016-10-18 09:58:46 +00:00
clemensh
ea51b8a764
[debug] [reland] Consistently use script from FrameMirror
...
... instead of getting it from the FunctionMirror. For WASM frames
(including asm.js -> WASM), the function is either unresolved or does
not contain the script.
The added test case failed before this CL.
R=kozyatinskiy@chromium.org , yangguo@chromium.org , titzer@chromium.org
BUG=v8:4203, chromium:656622
Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615
Review-Url: https://codereview.chromium.org/2415073003
Cr-Original-Commit-Position: refs/heads/master@{#40348}
Cr-Commit-Position: refs/heads/master@{#40387}
2016-10-18 08:19:28 +00:00
machenbach
f5d333c297
Revert of [debug] Consistently use script from FrameMirror (patchset #3 id:40001 of https://codereview.chromium.org/2415073003/ )
...
Reason for revert:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10706
https://github.com/v8/v8/wiki/Blink-layout-tests
Original issue's description:
> [debug] Consistently use script from FrameMirror
>
> ... instead of getting it from the FunctionMirror. For WASM frames
> (including asm.js -> WASM), the function is either unresolved or does
> not contain the script.
>
> The added test case failed before this CL.
>
> R=kozyatinskiy@chromium.org , yangguo@chromium.org , titzer@chromium.org
> BUG=v8:4203
>
> Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615
> Cr-Commit-Position: refs/heads/master@{#40348}
TBR=kozyatinskiy@chromium.org ,yangguo@chromium.org,titzer@chromium.org,clemensh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4203
Review-Url: https://codereview.chromium.org/2427633002
Cr-Commit-Position: refs/heads/master@{#40362}
2016-10-17 12:38:12 +00:00
clemensh
ce32e2ffd8
[debug] Consistently use script from FrameMirror
...
... instead of getting it from the FunctionMirror. For WASM frames
(including asm.js -> WASM), the function is either unresolved or does
not contain the script.
The added test case failed before this CL.
R=kozyatinskiy@chromium.org , yangguo@chromium.org , titzer@chromium.org
BUG=v8:4203
Review-Url: https://codereview.chromium.org/2415073003
Cr-Commit-Position: refs/heads/master@{#40348}
2016-10-17 09:41:44 +00:00
kozyatinskiy
7ba222ffcb
[inspector] fix timestamp formatting with non C locales
...
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted.
BUG=chromium:653424
R=dgozman@chromium.org
Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
Review-Url: https://codereview.chromium.org/2410933002
Cr-Original-Commit-Position: refs/heads/master@{#40190}
Cr-Commit-Position: refs/heads/master@{#40288}
2016-10-13 20:32:07 +00:00
machenbach
36ebaf21c6
Revert of [inspector] fix timestamp formatting with non C locales (patchset #7 id:120001 of https://codereview.chromium.org/2410933002/ )
...
Reason for revert:
Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10548
See also:
https://github.com/v8/v8/wiki/Blink-layout-tests
Original issue's description:
> [inspector] fix timestamp formatting with non C locales
>
> If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted.
>
> BUG=chromium:653424
> R=dgozman@chromium.org
>
> Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4
> Cr-Commit-Position: refs/heads/master@{#40190}
TBR=dgozman@chromium.org ,kozyatinskiy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:653424
Review-Url: https://codereview.chromium.org/2419453002
Cr-Commit-Position: refs/heads/master@{#40200}
2016-10-12 08:18:36 +00:00
machenbach
3195f19e87
[inspector] Add swarming support to inspector tests
...
BUG=chromium:635948
Review-Url: https://codereview.chromium.org/2393863002
Cr-Commit-Position: refs/heads/master@{#40194}
2016-10-12 07:32:06 +00:00
kozyatinskiy
dde5ef75cb
[inspector] fix timestamp formatting with non C locales
...
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted.
BUG=chromium:653424
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2410933002
Cr-Commit-Position: refs/heads/master@{#40190}
2016-10-11 23:22:07 +00:00
kozyatinskiy
085a445775
[inspector] fix minor issue in test/inspector.gyp
...
* Inspector should depend on v8_libbase, v8 depedency is added in conditions section.
* Inlined sources since they aren't used outside of this gyp file.
BUG=chromium:635948
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2408833002
Cr-Commit-Position: refs/heads/master@{#40139}
2016-10-10 19:08:46 +00:00
kozyatinskiy
3b6c7f04a9
[inspector] fixed one more size_t -> int conversion
...
This problem was detected only on linux64_gyp bot.
It's safe to convert length string into int from size_t.
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2402583004
Cr-Commit-Position: refs/heads/master@{#40101}
2016-10-07 22:16:04 +00:00
kozyatinskiy
2d5cc49b72
[inspector] don't use String16 in inspector test runner
...
String16 is not public part of src/inspector. All usage are replaced with vector of char/unit16_t to avoid potential linker problems.
BUG=chromium:635948
R=dgozman@chromium.org ,machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2403493002
Cr-Commit-Position: refs/heads/master@{#40098}
2016-10-07 21:16:55 +00:00
kozyatinskiy
fac3b6fa46
[inspector] filter useless in preview internal properties
...
Only subset of internal properties can be useful in preview, report only them.
BUG=chromium:653610
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2399003003
Cr-Commit-Position: refs/heads/master@{#40064}
2016-10-07 01:16:28 +00:00
kozyatinskiy
88702e08bc
[inspector] fix test expectations for command-line-api-with-bound-function
...
TBR=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2397193002
Cr-Commit-Position: refs/heads/master@{#40052}
2016-10-06 16:20:15 +00:00
kozyatinskiy
6ea067a40c
[inspector] fix integer conversion
...
v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy.
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2394973002
Cr-Commit-Position: refs/heads/master@{#40016}
2016-10-05 22:56:56 +00:00
kozyatinskiy
5ff4d02da5
[inspector] command line api debug and monitor works with bound functions
...
BUG=chromium:496666
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2391323002
Cr-Commit-Position: refs/heads/master@{#40007}
2016-10-05 17:59:06 +00:00
kozyatinskiy
186e7db8dd
[inspector] fix compilation on win and linux
...
BUG=chromium:635948
R=dgozman@chromium.org ,machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2389133004
Cr-Commit-Position: refs/heads/master@{#40003}
2016-10-05 17:07:46 +00:00
kozyatinskiy
e90a79c637
[inspector] introduced exceptionThrown support in test runner
...
BUG=chromium:635948
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2384373002
Cr-Commit-Position: refs/heads/master@{#39998}
2016-10-05 15:08:14 +00:00
kozyatinskiy
24beac30ee
[inspector] Make InspectorTest.sendCommand* private
...
Introduce Protocol.Domain.method(args) and Protocol.Domain.onEventName() instead.
Renamed InspectorTest.evaluateInPage -> InspectorTest.addScript.
Improved InspectorTest.logMessage.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2390733002
Cr-Commit-Position: refs/heads/master@{#39942}
2016-10-03 23:33:07 +00:00
kozyatinskiy
60ab52e78e
[inspector] test Runtime.getProperties for set and map [[Entries]]
...
Added a test that Runtime.getProperties doesn't truncate Set and Map properties in [[Entries]] in internalProperties.
BUG=chromium:650729
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2376863002
Cr-Commit-Position: refs/heads/master@{#39940}
2016-10-03 21:22:11 +00:00
kozyatinskiy
759581ea93
[inspector] test for fixed empty stack processing in console.count
...
BUG=chromium:644629
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2370033003
Cr-Commit-Position: refs/heads/master@{#39938}
2016-10-03 21:10:53 +00:00
kozyatinskiy
c9391d15ca
[inspector] added a test for crash in wrapping async evaluate result
...
BUG=chromium:651211
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2381693002
Cr-Commit-Position: refs/heads/master@{#39933}
2016-10-03 15:51:30 +00:00
kozyatinskiy
270db7903a
[inspector] added inspector test runner [part 5]
...
- added most part of inspector tests that depends only on JavaScript domains.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Review-Url: https://codereview.chromium.org/2369753004
Cr-Original-Commit-Position: refs/heads/master@{#39897}
Cr-Commit-Position: refs/heads/master@{#39931}
2016-10-02 21:23:03 +00:00
kozyatinskiy
d1191e1b8a
[inspector] added inspector test runner [part 4]
...
- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15
Review-Url: https://codereview.chromium.org/2370743003
Cr-Original-Commit-Position: refs/heads/master@{#39895}
Cr-Commit-Position: refs/heads/master@{#39930}
2016-10-02 19:41:28 +00:00
kozyatinskiy
f0649c8f08
[inspector] added inspector test runner [part 3]
...
- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b
Review-Url: https://codereview.chromium.org/2372793002
Cr-Original-Commit-Position: refs/heads/master@{#39891}
Cr-Commit-Position: refs/heads/master@{#39929}
2016-10-02 18:10:39 +00:00
kozyatinskiy
751814a128
[inspector] added inspector test runner [part 2]
...
- added the channel implementation,
- added inspector implementation,
- added v8::Extension for communication between backend and frontend.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Committed: https://crrev.com/cceaa1225c6a96a28d2c7410d1db520423fb8c31
Review-Url: https://codereview.chromium.org/2368393003
Cr-Original-Commit-Position: refs/heads/master@{#39888}
Cr-Commit-Position: refs/heads/master@{#39928}
2016-10-02 16:45:46 +00:00
kozyatinskiy
80d400641f
[inspector] added inspector test runner [part 1]
...
- added a inspector folder,
- added related GN and gyp files,
- added task handling infrastructure for test runner.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Committed: https://crrev.com/dc1c71c0dc8a5c4ade4aa291f2ddcd02e90c64b2
Review-Url: https://codereview.chromium.org/2361623006
Cr-Original-Commit-Position: refs/heads/master@{#39866}
Cr-Commit-Position: refs/heads/master@{#39918}
2016-09-30 15:52:46 +00:00
machenbach
0e704cdac6
Revert "[inspector] added inspector test runner [part 1-2]"
...
Revert "[inspector] added inspector test runner [part 1]"
This reverts commit dc1c71c0dccceaa1225chttps://codereview.chromium.org/2379053003/
In particular android debug:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/137605
BUG=chromium:635948
TBR=kozyatinskiy@chromium.org ,
NOTRY=true
Review-Url: https://codereview.chromium.org/2387603002
Cr-Commit-Position: refs/heads/master@{#39909}
2016-09-30 09:56:00 +00:00
machenbach
ee0d69910b
Revert "[inspector] added inspector test runner [part 3-5]"
...
Revert "[inspector] added inspector test runner [part 3]"
This reverts commit f3f9f4448d4a5f5d09919ddbdab195https://codereview.chromium.org/2379053003/
BUG=chromium:635948
TBR=kozyatinskiy@chromium.org ,
NOTRY=true
Review-Url: https://codereview.chromium.org/2379303002
Cr-Commit-Position: refs/heads/master@{#39908}
2016-09-30 09:25:31 +00:00
kozyatinskiy
9ddbdab195
[inspector] added inspector test runner [part 5]
...
- added most part of inspector tests that depends only on JavaScript domains.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2369753004
Cr-Commit-Position: refs/heads/master@{#39897}
2016-09-30 04:50:17 +00:00
kozyatinskiy
4a5f5d0991
[inspector] added inspector test runner [part 4]
...
- added inspector test suite definition in testcfg.py
- added JS infrastructure for tests in protocol-test.js
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2370743003
Cr-Commit-Position: refs/heads/master@{#39895}
2016-09-30 01:35:42 +00:00
kozyatinskiy
f3f9f4448d
[inspector] added inspector test runner [part 3]
...
- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2372793002
Cr-Commit-Position: refs/heads/master@{#39891}
2016-09-29 22:23:47 +00:00
kozyatinskiy
cceaa1225c
[inspector] added inspector test runner [part 2]
...
- added the channel implementation,
- added inspector implementation,
- added v8::Extension for communication between backend and frontend.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2368393003
Cr-Commit-Position: refs/heads/master@{#39888}
2016-09-29 21:40:48 +00:00
kozyatinskiy
dc1c71c0dc
[inspector] added inspector test runner [part 1]
...
- added a inspector folder,
- added related GN and gyp files,
- added task handling infrastructure for test runner.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2361623006
Cr-Commit-Position: refs/heads/master@{#39866}
2016-09-29 13:46:06 +00:00
