jkummerow
186f67085c
[proxies] Add all-can-read/String/Symbol filtering support to GetKeys()
...
Not exposed/used yet, therefore also not testable yet.
Review URL: https://codereview.chromium.org/1491743008
Cr-Commit-Position: refs/heads/master@{#32571}
2015-12-03 15:08:54 +00:00
jkummerow
4a246c1fff
[cleanup] Introduce PropertyFilter
...
Split out of PropertyAttributes, and used for all filtering purposes.
Also moved PropertyAttributes into the v8::internal:: namespace.
No change in behavior intended.
Review URL: https://codereview.chromium.org/1492653004
Cr-Commit-Position: refs/heads/master@{#32525}
2015-12-02 16:30:24 +00:00
jkummerow
e478a8ac39
[proxies] Implement Symbol/DONT_ENUM filtering for GetKeys()
...
And use it to fix Object.keys() for proxies.
BUG=v8:1543
LOG=n
R=cbruni@chromium.org
Review URL: https://codereview.chromium.org/1488873003
Cr-Commit-Position: refs/heads/master@{#32496}
2015-12-02 10:19:59 +00:00
jkummerow
2fee8a0f1d
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]
...
Both are integrated into JSReceiver::GetKeys().
For now, the implementation ignores Symbol/DONT_ENUM filtering.
BUG=v8:1543
LOG=n
Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
Review URL: https://codereview.chromium.org/1474083003
Cr-Commit-Position: refs/heads/master@{#32386}
2015-11-28 15:03:13 +00:00
machenbach
97def40dc0
Revert of [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]] (patchset #3 id:40001 of https://codereview.chromium.org/1474083003/ )
...
Reason for revert:
[Sheriff] Speculative revert for gc mole:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/5164
Original issue's description:
> [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]
>
> Both are integrated into JSReceiver::GetKeys().
>
> For now, the implementation ignores Symbol/DONT_ENUM filtering.
>
> BUG=v8:1543
> LOG=n
>
> Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
> Cr-Commit-Position: refs/heads/master@{#32384}
TBR=verwaest@chromium.org ,bmeurer@chromium.org,jkummerow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:1543
Review URL: https://codereview.chromium.org/1482113002
Cr-Commit-Position: refs/heads/master@{#32385}
2015-11-28 14:16:29 +00:00
jkummerow
42c6056e6f
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]
...
Both are integrated into JSReceiver::GetKeys().
For now, the implementation ignores Symbol/DONT_ENUM filtering.
BUG=v8:1543
LOG=n
Review URL: https://codereview.chromium.org/1474083003
Cr-Commit-Position: refs/heads/master@{#32384}
2015-11-28 10:48:43 +00:00
cbruni
e7154a0b78
[runtime] Support Symbols in KeyAccumulator
...
BUG=
Review URL: https://codereview.chromium.org/1425403002
Cr-Commit-Position: refs/heads/master@{#31788}
2015-11-04 14:05:36 +00:00
