AuroraMiddleware/v8

Fork 0

Commit Graph

Author	SHA1	Message	Date
mikhail.naganov@gmail.com	30a0a7de43	Split nested namespaces declaration in two lines in accordance with C++ Style Guide. This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact. Review URL: http://codereview.chromium.org/115756 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2009-05-25 10:05:56 +00:00
mikhail.naganov@gmail.com	7aacf00933	Allow multiple function literals to be assigned to the same var / property. In such a case all functions get the same name. I think it's a good performance / usability tradeoff. In case a developer wants more clarity, it's up to him to give names to functions. Review URL: http://codereview.chromium.org/67168 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2009-04-16 16:34:24 +00:00
mikhail.naganov@gmail.com	3c2a7bdf21	Add name inference for anonymous functions to facilitate debugging and profiling of JS code. Currently function name inference is wired with AST optimization pass to avoid introducing another pass over AST. A better solution would be to rewrite AST visitors so they can be naturally combined together in a single pass, as their current implementation doesn't allow it. For examples of cases where function names can be inferred, see the tests file. Review URL: http://codereview.chromium.org/62146 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2009-04-14 00:51:59 +00:00

Author

SHA1

Message

Date

mikhail.naganov@gmail.com

30a0a7de43

Split nested namespaces declaration in two lines in accordance with C++ Style Guide.

This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact.

Review URL: http://codereview.chromium.org/115756


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2009-05-25 10:05:56 +00:00

mikhail.naganov@gmail.com

7aacf00933

Allow multiple function literals to be assigned to the same var / property.

In such a case all functions get the same name. I think it's a good performance / usability tradeoff. In case a developer wants more clarity, it's up to him to give names to functions.

Review URL: http://codereview.chromium.org/67168

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2009-04-16 16:34:24 +00:00

mikhail.naganov@gmail.com

3c2a7bdf21

Add name inference for anonymous functions to facilitate debugging and profiling of JS code.

Currently function name inference is wired with AST optimization pass to avoid introducing another pass over AST. A better solution would be to rewrite AST visitors so they can be naturally combined together in a single pass, as their current implementation doesn't allow it.

For examples of cases where function names can be inferred, see the tests file.

Review URL: http://codereview.chromium.org/62146

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2009-04-14 00:51:59 +00:00

3 Commits