Commit Graph

4 Commits

Author SHA1 Message Date
hablich
87e7cd7f3f Revert of Use GCC for snapshot_toolchain when is_clang=false. (patchset #1 id:1 of https://codereview.chromium.org/1809643003/ )
Reason for revert:
Blocks roll: https://codereview.chromium.org/1874173002/

Original issue's description:
> Use GCC for snapshot_toolchain when is_clang=false.
>
> Currently, snapshot_toolchain is hardcoded to use a clang host
> toolchain. Use a GCC toolchain if is_clang is false.
>
> Revert this when this is root-caused (see crbug.com/601486)
>
> LOG=Y
> BUG=601486
>
> Committed: https://crrev.com/920370d1a910681bf464bd91aced316058ea2f6c
> Cr-Commit-Position: refs/heads/master@{#35341}

TBR=jochen@chromium.org,alokp@chromium.org,dpranke@chromium.org,slan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=601486
LOG=Y

Review URL: https://codereview.chromium.org/1873113002

Cr-Commit-Position: refs/heads/master@{#35372}
2016-04-11 08:30:22 +00:00
slan
920370d1a9 Use GCC for snapshot_toolchain when is_clang=false.
Currently, snapshot_toolchain is hardcoded to use a clang host
toolchain. Use a GCC toolchain if is_clang is false.

Revert this when this is root-caused (see crbug.com/601486)

LOG=Y
BUG=601486

Review URL: https://codereview.chromium.org/1809643003

Cr-Commit-Position: refs/heads/master@{#35341}
2016-04-07 16:23:10 +00:00
agrieve
ba1d9af8bf Map arm64 and mips64el -> x64 for mksnapshot
BUG=chromium:568883
LOG=n

Review URL: https://codereview.chromium.org/1517983002

Cr-Commit-Position: refs/heads/master@{#32907}
2015-12-16 15:17:37 +00:00
dpranke
7d5d1570d9 Split the GN 'snapshot_toolchain' logic out into an include file.
We need to build parts of v8 with a toolchain that might be different
from both the default (target) toolchain and the regular host toolchain,
because we need the snapshot to have the same bit-width as the target.
V8's build defines a 'snapshot_toolchain' setting for this.

It turns out that we need the value of this toolchain to be exposed
to the Chromium build because some of the test targets (in browser_tests)
depend on d8 and need to be able to built using the same toolchain.

R=brett@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1350223004

Cr-Commit-Position: refs/heads/master@{#30854}
2015-09-22 02:28:40 +00:00