Commit Graph

15 Commits

Author SHA1 Message Date
Michael Lippautz
df4cbb4dff google_benchmark: Manually roll and fix build
Manually roll forward `google_benchmark` and rely on the shipped
export header file. Adjust the build rules to always imply a static
build though as that's how the library is used in v8.

Bug: chromium:1346538
Change-Id: Ia94ad976f533a1c1d8099f1bc931b491d6fb17dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782798
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81907}
2022-07-25 07:47:46 +00:00
Michael Achenbach
983f0c1c46 [google_benchmark] Suppress -Wdeprecated-declarations
This ports:
https://crrev.com/c/3773795

Bug: chromium:1344570, chromium:1345621
Change-Id: Ie3f8019a259f66900ea6dda878040edec20d4f38
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773777
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81831}
2022-07-19 19:39:05 +00:00
Michael Achenbach
9230a278e1 Reland "Update V8 DEPS"
This is a reland of commit c66a80172e

The reland suppresses the deprecation warning on windows for
google_benchmark.

Original change's description:
> Update  V8 DEPS
>
> Rolling both trusted-versions and trusted-origins and an additional patch coming from https://crrev.com/c/3706887.
>
> Rolling v8/buildtools/third_party/libc++/trunk: b126981..88bf407
>
> Rolling v8/buildtools/third_party/libunwind/trunk: 49191c5..955e2ff
>
> Rolling v8/third_party/depot_tools: 8168f76..f05fcf7
>
> Rolling v8/build: 679de1e..6e435d6
>
> Rolling v8/buildtools: 5cee6a2..a4506d5
>
>
>
> R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com
>
> Bug: chromium:1345621
> Change-Id: I0659a5f98c83bbc6f061259e798a4b85a7cd7c63
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3766889
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#81815}

Bug: chromium:1345621
Change-Id: I2975ca6ae04c99a9e53f3bbd6872b7d114febb7c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773775
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81823}
2022-07-19 17:14:13 +00:00
Michael Lippautz
4224c85f70 Manually update google_benchmark
- Roll forward to Update google_benchmark
- Add export header that is usually generated by the build system of
  google benchmark. We can ignore the export macro as we always just use
  the library in a source set.

Bug: v8:12666
Change-Id: Ifec570745c0258aa541b7aea41ba557a7e0fe563
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3512575
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79429}
2022-03-09 19:49:16 +00:00
Michael Lippautz
4009aacbb0 Manually update google_benchmark
https://github.com/google/benchmark/pull/1256 has been upstreamed.
Manually roll forward and immediately remove the build-time work
around.

Change-Id: I567dc0bdfda128656c874b6555dc6a89eeaa8100
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236991
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77502}
2021-10-21 16:36:41 +00:00
Michael Lippautz
ae4832e5cb Manually update google_benchmark
V8 fix: Temporarily allow using deprecated methods until upstream is fixed.

Rolling v8/third_party/google_benchmark/src: 59bbc7f..1e3ab7f

Merge remote-tracking branch 'upstream/pr/1240' (Roman Lebedev)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/1e3ab7f

cmake: allow to use package config from build directory (Sergiu Deitsch)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/1be88c0

Merge remote-tracking branch 'upstream/pr/1244' (Roman Lebedev)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/3395949

cmake: make package config relocatable (Sergiu Deitsch)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/eb9100b

GoogleTest.cmake.in: mention BENCHMARK_USE_BUNDLED_GTEST (Roman Lebedev)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/2f30903

GoogleTest.cmake.in: immediately error-out after failure message, Closes #1255 (Roman Lebedev)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/8c8052a

Introduce additional memory metrics (#1238) (Vy Nguyen)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/7fad964

Fix -Wdeprecated-declarations warning triggered by clang-cl. (#1245) (Byoungchan Lee)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/f730846

...

Change-Id: Ia10c33f512fae7bcc889e36a9cb368d8628f3e5f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234197
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77474}
2021-10-20 13:43:30 +00:00
Michael Lippautz
9a311bcb34 Manually update google_benchmark
Rolling v8/third_party/google_benchmark/src: 0e1255a..5b75184

Manually roll forward to:
- roll across a compile-time failure
- adjust BUILD.gn

Change-Id: I4733fbc1ba565293a15d5360815c92b293eedc34
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966378
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75175}
2021-06-16 10:40:47 +00:00
Michael Lippautz
22135c13b5 Manually update google_benchmark
Rolling v8/third_party/google_benchmark/src: e539e80..db2de74

Fix pedantic compilation flag violation (#1156) (Mariusz Wachowicz)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/db2de74

fix version recorded in releases (#1047) (Kai Germaschewski)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/a4bcd93

Implementation of random interleaving.  (#1105) (haih-g)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/a6a738c

remove appveyor and add libera.chat as IRC resource (Dominic Hamon)
https://chromium.googlesource.com/external/github.com/google/benchmark/+/c983c3e

TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mlippautz@chromium.org

Bug: chromium:1213169
Change-Id: Ic89fd04b6f121e8997b54dcbbbd4a43b2ce8ecb8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919959
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74812}
2021-05-27 10:42:13 +00:00
Dan Elphick
6bb5688fe0 Reland "[build] Fix gn check failures in v8/third_party"
This is a reland of e13a744a45

Fixed jsoncpp BUILD.gn errors by removing missing files.

Original change's description:
> [build] Fix gn check failures in v8/third_party
>
> This removes the blanket exclusion for third_party but leaves
> third_party/icu excluded (which is the same as chrome).
>
> Most fixed issues are to do with previously removed header files and
> missing dependencies.
>
> Bug: v8:7330
> Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838
> Auto-Submit: Dan Elphick <delphick@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#74295}

Bug: v8:7330
Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng
Change-Id: I4c2c63cc3cb6fb3fabe33717b20ac4a1efeec09b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862772
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74308}
2021-04-30 16:26:19 +00:00
Nico Hartmann
8ae6f77f49 Update V8 DEPS.
Rolling v8/base/trace_event/common: cab90cb..d5bb24e

Rolling v8/build: 94367a1..8cc6617

Rolling v8/buildtools: 5dbd89c..5da6005

Rolling v8/buildtools/linux64: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e

Rolling v8/buildtools/third_party/libc++abi/trunk: f6a8e55..5f51521

Rolling v8/third_party/aemu-linux-x64: KmvDYKZZ-xQz7ZzzSKBh3HrWPpQv89vfFY9mBp6RDq4C..kswh0qF56RoEDBXJbyo1IWPAJ9F7WGAvMHGyWGbpBtUC

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ca2c407..bbfed50

Rolling v8/third_party/depot_tools: ae1b2b1..0d1afc9

Rolling v8/third_party/google_benchmark/src: 835951a..64cb55e

Rolling v8/third_party/zlib: 0949050..e8da4da

Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155

Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155

Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155

TBR=v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id081f2b8d4214852d1bb19eab4df82379db03ba5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862144
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74305}
2021-04-30 15:12:39 +00:00
Michael Achenbach
78dbc1439d Revert "[build] Fix gn check failures in v8/third_party"
This reverts commit e13a744a45.

Reason for revert: breaks perfetto:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20perfetto%20-%20builder/12849

Original change's description:
> [build] Fix gn check failures in v8/third_party
>
> This removes the blanket exclusion for third_party but leaves
> third_party/icu excluded (which is the same as chrome).
>
> Most fixed issues are to do with previously removed header files and
> missing dependencies.
>
> Bug: v8:7330
> Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838
> Auto-Submit: Dan Elphick <delphick@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#74295}

Bug: v8:7330
Change-Id: I05cf897c0aeb6bf87f9889b878358c0d02600081
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862767
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#74300}
2021-04-30 12:21:10 +00:00
Dan Elphick
e13a744a45 [build] Fix gn check failures in v8/third_party
This removes the blanket exclusion for third_party but leaves
third_party/icu excluded (which is the same as chrome).

Most fixed issues are to do with previously removed header files and
missing dependencies.

Bug: v8:7330
Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74295}
2021-04-30 11:23:19 +00:00
Dan Elphick
e3d63e962f [build] Fix gn check errors in test/benchmarks/cpp
Expose third_party/google_benchmark:google_benchmark as a public dep
from third_party/google_benchmark:benchmark_main and a v8_libbase
dependency to empty_benchmark to expose base/macros.h.

Bug: v8:7330
Change-Id: I5205af365da2ac7c35647acff90ed65d831cfa07
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851888
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74217}
2021-04-27 10:35:33 +00:00
Almothana Athamneh
4a9810d85f Make Google benchmark dependency a default
Bug: v8:11639
Change-Id: I3352261c5593c33154aa8f1a931bf3ee351f536a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831487
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74098}
2021-04-21 12:19:40 +00:00
Michael Lippautz
b804266f72 Add google_benchmark depdendency
This adds Google benchmark for microbenchmarking C++ code as an
optional dependency.

To enable, add the following to the .gclient before syncing
  "custom_vars": {
      "checkout_google_benchmark": True
  }

Change-Id: Id0eab772dd71558906658ef4bb60e31acd665948
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275964
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68663}
2020-07-02 20:11:29 +00:00