AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
19,802 Commits 1 Branch 0 Tags 839 MiB
d7f8ea2c68
Commit Graph

19802 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
jkummerow@chromium.org
e525e76f21 Fix a few nits found by PVS Studio 
BUG=v8:3192
LOG=n
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/185563004

Cr-Commit-Position: refs/heads/master@{#25086}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25086 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 19:45:25 +00:00
titzer@chromium.org
ce06f447d6 Fix build because of dead fields. 
TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/699673002

Cr-Commit-Position: refs/heads/master@{#25085}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25085 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 17:53:22 +00:00
titzer@chromium.org
5bba6b20e6 Make visualizer robust to graphs with NULL inputs. 
R=mstarzinger@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/652263002

Cr-Commit-Position: refs/heads/master@{#25084}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 17:42:17 +00:00
erikcorry@chromium.org
3d62e24c5f Introduce phantom weak handles in the API and use them internally for debug info 
R=ulan@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/687003005

Cr-Commit-Position: refs/heads/master@{#25083}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25083 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 17:24:22 +00:00
ishell@chromium.org
a19c18ac6d Reland "Limit the number of transitions allowed per hidden class." 
BUG=chromium:427813
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/676393002

Cr-Commit-Position: refs/heads/master@{#25082}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25082 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 16:46:29 +00:00
balazs.kilvady@imgtec.com
8960f5d856 MIPS: [turbofan] Also optimize unsigned division by constant. 
Port r25061 (7fe697f)

TEST=cctest,mjsunit,unittests
BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/701543002

Cr-Commit-Position: refs/heads/master@{#25081}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 16:41:18 +00:00
dusan.milosavljevic@imgtec.com
14e2d5d029 Unbreak build fon non-TF targets. 
Mips64 is affected but not for long.

TEST=
BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/689113003

Cr-Commit-Position: refs/heads/master@{#25080}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25080 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 15:48:43 +00:00
machenbach@chromium.org
29552a4004 Fix auto roll update. 
Auto roll requires an additional "git fetch" now that it uses
a workdir. Before, the checkout used to be updated
externally.

BUG=408523
LOG=n
TEST=script_test.py
R=tandrii@chromium.org
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/695323002

Cr-Commit-Position: refs/heads/master@{#25079}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 15:39:43 +00:00
bmeurer@chromium.org
744c66bc29 [turbofan] Introduce separate SelectLowering reducer. 
Split lowering of Select nodes into a separate graph reducer and be more
clever when lowering to diamonds, i.e. reuse diamonds that have the same
condition and only add more phis to it.

TEST=unittests
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/702463002

Cr-Commit-Position: refs/heads/master@{#25078}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 15:17:47 +00:00
jarin@chromium.org
1c1a1a1ae6 Fix uninitialized fields in the BinaryOperation ast node. 
R=jkummerow@chromium.org, svenpanne@chromium.org
BUG=chromium:429194
LOG=n

Review URL: https://codereview.chromium.org/701533002

Cr-Commit-Position: refs/heads/master@{#25077}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25077 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 14:59:49 +00:00
verwaest@chromium.org
3ea82aa917 Don't double-check elements in the prototype chain in array builtins 
BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/701513002

Cr-Commit-Position: refs/heads/master@{#25076}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 14:06:15 +00:00
jarin@chromium.org
83806d568d [turbofan] Fix Typer::Rangify to handle integral bitset types. 
R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/688413003

Cr-Commit-Position: refs/heads/master@{#25074}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 13:59:16 +00:00
dcarney@chromium.org
273a9ad200 build fix after 25072 
TBR=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/688323005

Cr-Commit-Position: refs/heads/master@{#25073}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25073 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 13:55:44 +00:00
dcarney@chromium.org
e17194ba52 build fix after r25071 
TBR=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/684523003

Cr-Commit-Position: refs/heads/master@{#25072}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25072 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 13:42:13 +00:00
dcarney@chromium.org
0d1cdebad2 [turbofan] initial framework for unittesting of register allocator 
BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/683133005

Cr-Commit-Position: refs/heads/master@{#25071}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 13:27:23 +00:00
machenbach@chromium.org
37092e40b9 Fix svn commit for deleted files in release scripts. 
BUG=408523
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/685623004

Cr-Commit-Position: refs/heads/master@{#25070}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25070 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 13:17:15 +00:00
bmeurer@chromium.org
84355c8295 Revert "[turbofan] Fix bug in Rangify." 
This reverts commit r25067 for breaking Win64.

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/697093002

Cr-Commit-Position: refs/heads/master@{#25069}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25069 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 12:36:45 +00:00
bmeurer@chromium.org
c95fb279d1 [turbofan] Fix bug in Rangify. 
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/699603002

Cr-Commit-Position: refs/heads/master@{#25067}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 11:51:18 +00:00
bmeurer@chromium.org
5dc9365bc0 [turbofan] Enforce allocation of register for imull/mull. 
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/697073002

Cr-Commit-Position: refs/heads/master@{#25066}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25066 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 11:50:43 +00:00
bmeurer@chromium.org
832a5b930d [turbofan] Positive dividends are heavily favored for Int32Mod. 
Mark negative dividend case as deferred, as modulus by power of two with
negative dividend almost never appears in practice.

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/699573002

Cr-Commit-Position: refs/heads/master@{#25065}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25065 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 10:44:44 +00:00
mstarzinger@chromium.org
c63deb9b56 Make generic algorithm less generic. 
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/701473002

Cr-Commit-Position: refs/heads/master@{#25064}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25064 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 10:31:11 +00:00
baptiste.afsa@arm.com
bb78f231ab [turbofan] Select tbz/tbnz when possible on ARM64. 
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/697653002

Cr-Commit-Position: refs/heads/master@{#25063}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25063 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 10:29:11 +00:00
titzer@chromium.org
c62bb3e2eb Now with more checkings! Skip the CallFunctionStub when the callee function can be statically determined. 
R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/696223002

Cr-Commit-Position: refs/heads/master@{#25062}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25062 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 10:22:44 +00:00
bmeurer@chromium.org
498920f91c [turbofan] Also optimize unsigned division by constant. 
TEST=cctest,mjsunit,unittests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/697663003

Cr-Commit-Position: refs/heads/master@{#25061}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25061 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 10:05:46 +00:00
yangguo@chromium.org
e634bdb290 Fix constant in Math.tan implementation. 
R=jkummerow@chromium.org, rtoy@chromium.org
BUG=chromium:427468
LOG=Y

Review URL: https://codereview.chromium.org/695263002

Cr-Commit-Position: refs/heads/master@{#25060}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25060 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 09:40:44 +00:00
machenbach@chromium.org
06f17c14c1 Fix workdir feature for release scripts. 
BUG=408523
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/700493002

Cr-Commit-Position: refs/heads/master@{#25058}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25058 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 09:31:48 +00:00
mvstanton@chromium.org
c65edf93b1 Fix for bug 429168, PdfJs regression. We pay a very high cost for AllocationResult being a > kPointerSize struct. This can be avoided by using Smis to indicate failure with retry spaces. 
BUG=429168
LOG=N
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/699473002

Cr-Commit-Position: refs/heads/master@{#25057}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25057 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 08:43:40 +00:00
machenbach@chromium.org
310000ae85 Add workdir feature to release scripts. 
BUG=408523
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/701463002

Cr-Commit-Position: refs/heads/master@{#25056}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25056 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 08:41:48 +00:00
machenbach@chromium.org
c63f059624 More retries when tagging in release scripts. 
BUG=408523
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/697433003

Cr-Commit-Position: refs/heads/master@{#25055}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25055 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 08:18:43 +00:00
bmeurer@chromium.org
017c518321 [x86] Fix register constraints for multiply high and modulus. 
R=jarin@chromium.org
TEST=mjsunit/compiler/regress-register-allocator2

Review URL: https://codereview.chromium.org/697053002

Cr-Commit-Position: refs/heads/master@{#25054}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 06:28:12 +00:00
jarin@chromium.org
2d07d76244 [turbofan] Do not use the generic graph algorithm for widening in the typer. 
This change uses an explicit queue for type-widening instead of the
generic algorithm. The trouble with the generic algorithm was that it
called the visitor on the same phi many times in a row (and thus caused
unnecessary retyping). I also think that the queue-based fixpoint is
more readable.

The CL cuts running time of the nbody-java benchmark from ~19s to ~15s,
the time spent in the typer goes from 4.5s to 1s. This is still a lot
- the root cause appears to be slow handling of union subtyping
(m*n for unions of sizes m and n). I see a re-typing of a
single phi node taking > 100ms. I will work on a fix with Andreas,
hopefully we can come up with some canonical representation
of unions at least for the common cases (union of Smi constants).

I have also changed the initial typer run to always compute a type, even
if we already had a type for the node. This fixes one assert failure
where context specialization updates a node without updating the type,
which confuses the typer when widening (as some types suddenly narrow).

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/689403002

Cr-Commit-Position: refs/heads/master@{#25053}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25053 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 06:10:18 +00:00
bmeurer@chromium.org
8c5fdd0575 IA: Double arithmetic binops support memory operand 
BUG=
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/662813002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

Cr-Commit-Position: refs/heads/master@{#25052}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25052 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-03 05:57:17 +00:00
machenbach@chromium.org
803872ecbd Fix push script for autoroll account. 
Push tags to the repo not to the remote - which is a cache
checkout on the bots.

Add new files when doing pure svn commits. Otherwise, new
files are silently ignored and not committed.

BUG=408523
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/699493004

Cr-Commit-Position: refs/heads/master@{#25049}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25049 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-02 13:13:17 +00:00
machenbach@chromium.org
a4ee4d608b Teach push script to commit with roll account. 
BUG=410721
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/693333002

Cr-Commit-Position: refs/heads/master@{#25046}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25046 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-11-01 21:53:48 +00:00
jarin@chromium.org
4a9579feeb [turbofan] Avoid unnecessary (u)int32<->float64 changes in simplified lowering. 
BUG=
R=bmeurer@chromium.org, titzer@chromium.org

Review URL: https://codereview.chromium.org/683873002

Cr-Commit-Position: refs/heads/master@{#25045}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25045 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 19:53:48 +00:00
jarin@chromium.org
6935e0131c Revert "Skip the CallFunctionStub when the callee function can be statically determined." 
This reverts commit 9845dfadd2 (r25042) for failing tests.

TBR=titzer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/693103004

Cr-Commit-Position: refs/heads/master@{#25044}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25044 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 19:06:18 +00:00
dusan.milosavljevic@imgtec.com
66dd92f754 MIPS64: Fix simulator arguments handling on generated code entry. 
Removed workaround for this issue.

TEST=mjsunit, cctest on sim64
BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/695933002

Cr-Commit-Position: refs/heads/master@{#25043}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25043 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 18:33:46 +00:00
titzer@chromium.org
9845dfadd2 Skip the CallFunctionStub when the callee function can be statically determined. 
R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/694773002

Cr-Commit-Position: refs/heads/master@{#25042}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25042 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 16:36:13 +00:00
mstarzinger@chromium.org
74903488aa Minor cleanup about unscheduled use count for fixed nodes. 
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/696643002

Cr-Commit-Position: refs/heads/master@{#25041}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25041 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 15:09:46 +00:00
verwaest@chromium.org
604672e87f Changing the aging mechanism for script and eval caches. 
Instead of using multiple generations for the code, first only store the hash that gets aged. Once a hash matched on a next probe, actually cache the code. Use regular code aging to remove entries from the cache.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/675013004

Cr-Commit-Position: refs/heads/master@{#25040}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25040 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 14:52:27 +00:00
yangguo@chromium.org
3a3d5e741a Break allocations in the code serializer into correct chunk sizes. 
This change has been inspired by Slava Chigrin <vchigrin@yandex-team.ru> (https://codereview.chromium.org/689663002/)

R=mvstanton@chromium.org, vchigrin@yandex-team.ru

Review URL: https://codereview.chromium.org/686103004

Cr-Commit-Position: refs/heads/master@{#25039}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25039 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 14:43:43 +00:00
mstarzinger@chromium.org
cd3273b562 Properly handle stack overflows in the AST graph builder. 
R=jarin@chromium.org
BUG=chromium:429159
TEST=mjsunit/regress/regress-crbug-429159
LOG=N

Review URL: https://codereview.chromium.org/697473006

Cr-Commit-Position: refs/heads/master@{#25037}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25037 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 14:02:46 +00:00
rossberg@chromium.org
b4a49dfb48 Upgrade test262-es6 
TBR=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/695763003

Cr-Commit-Position: refs/heads/master@{#25036}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25036 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 13:39:44 +00:00
machenbach@chromium.org
6bd521a549 Skip tests for mips. 
TBR=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/698513003

Cr-Commit-Position: refs/heads/master@{#25035}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 13:36:49 +00:00
machenbach@chromium.org
79b2f6ced7 Switch auto push script to git. 
BUG=410721
LOG=n
TEST=script_test.py
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/698513002

Cr-Commit-Position: refs/heads/master@{#25033}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25033 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 13:15:46 +00:00
ulan@chromium.org
de672226c7 Clear old backing store of WeakCollection on updates. 
Not clearing can lead to a crash under following conditions:
1. Backing store of a weak map is allocated in large object space.
2. The backing store is marked incrementaly via the weak map.
3. The weak map is updated and gets a new backing store.
4. The store buffer overflows and marks the chunk of the old backing store as
"scan on scavenge."
5. Mark-compact collection kills some elements of the weak map. Note that the
old backing store survives because it was marked incrementally, but its dead
elements are not cleared.
6. Scavenger iterates over the old backing store, tries to move a dead object
and crashes.

BUG=v8:3631
LOG=N
TEST=cctest/test-heap/Regress3631
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/686783003

Cr-Commit-Position: refs/heads/master@{#25032}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25032 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 13:11:44 +00:00
marja@chromium.org
1bb79539f3 Scanner: remove PushBack calls when we're going to return ILLEGAL. 
This simplifies escape handling and makes it easier to extend escapes for ES6.

PushBack just before detecting ILLEGAL is unnecessary, since we will abort the
scanning / parsing anyway at that point, and it doesn't matter where the cursor
exactly is. The error messages w/ PushBack are not any better or more correct
than without.

In addition: remove a comment about handling invalid escapes gracefully when we
no longer do. (*)

This CL includes a behavioral change: For input "var r = /foobar/g\urrrr;" we
used to report "unexpected_token: ILLEGAL" for "\u", but now we report
malformed_regexp_flags which is a more correct error message. (Note that the
code for reporting invalid_regexp_flags was dead, and invalid_regexp_flags is
not the right error message.)

Note that the V8 is more relaxed about unicode escapes in regexp flags than ES6
(see
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-regular-expressions )
and this CL doesn't change it. (V8 accepts any \uxxxx, ES6 spec says only a
certain value range is acceptable.)

(*) Code archaeology:

Originally, doing PushBack in ScanHexEscape made sense (see e.g., here
https://codereview.chromium.org/5063003/diff/6001/src/prescanner.h ), since we
wouldn't return ILLEGAL but treat an invalid escape sequence "\uxxxx" as
"uxxxx".

(The repo at that point contains another instance of the same function, from the
initial commit. The logic is the same.)

This behavior was changed in a "renaming" commit
https://codereview.chromium.org/7739020.

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/684873002

Cr-Commit-Position: refs/heads/master@{#25031}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25031 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 13:03:45 +00:00
dcarney@chromium.org
3cace296ee convert BitVector to use pointer size blocks 
additionally rename data-flow.* to bit-vector.* as at some point these file became very inaccurately named

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/683243005

Cr-Commit-Position: refs/heads/master@{#25030}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25030 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 10:44:47 +00:00
yangguo@chromium.org
f01e08315f Assert that unoptimized code does not embed context-specific objects. 
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/690713003

Cr-Commit-Position: refs/heads/master@{#25029}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25029 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 09:31:12 +00:00
verwaest@chromium.org
48584766d9 Ensure we don't try to inline raw access to indexed interceptor receivers. 
BUG=chromium:419220
LOG=y
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/697643002

Cr-Commit-Position: refs/heads/master@{#25028}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25028 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-31 09:22:14 +00:00