machenbach
da6dbe78bc
Revert of Use same blob format for internal and external snapshots. (patchset #2 id:20001 of https://codereview.chromium.org/787033002/ )
...
Reason for revert:
[sheriff] breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1293
Original issue's description:
> Use same blob format for internal and external snapshots.
>
> R=vogelheim@chromium.org
TBR=vogelheim@chromium.org ,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/792563002
Cr-Commit-Position: refs/heads/master@{#25729}
2014-12-09 16:19:57 +00:00
yangguo
d9de2aaa17
Revert of Do not embed constant functions in StoreTransition stub. (patchset #3 id:40001 of https://codereview.chromium.org/769733003/ )
...
Reason for revert:
GC stress failure: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress%20-%201/builds/1038
Original issue's description:
> Do not embed constant functions in StoreTransition stub.
>
> BUG=v8:3629
> LOG=N
TBR=ishell@google.com ,ishell@chromium.org,ulan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3629
Review URL: https://codereview.chromium.org/785253002
Cr-Commit-Position: refs/heads/master@{#25728}
2014-12-09 16:09:44 +00:00
yangguo
03ba4becbf
Use same blob format for internal and external snapshots.
...
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/787033002
Cr-Commit-Position: refs/heads/master@{#25727}
2014-12-09 15:12:27 +00:00
ulan
876a1ddd80
Do not embed constant functions in StoreTransition stub.
...
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/769733003
Cr-Commit-Position: refs/heads/master@{#25726}
2014-12-09 15:11:11 +00:00
titzer
aeda76c5cf
[turbofan] Fix control reducer bug with NTLs.
...
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/789773002
Cr-Commit-Position: refs/heads/master@{#25725}
2014-12-09 15:09:59 +00:00
chunyang.dai
56f8ba13d5
Fix a typo error.
...
This error is introduced by baafb8f92e
.
BUG=
Review URL: https://codereview.chromium.org/791543003
Cr-Commit-Position: refs/heads/master@{#25724}
2014-12-09 15:08:55 +00:00
jochen
581747c869
Make it possible to turn on OBJECT_PRINT without DEBUG
...
BUG=none
R=machenbach@chromium.org
LOG=n
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/771323006
Cr-Commit-Position: refs/heads/master@{#25723}
2014-12-09 14:20:16 +00:00
Benedikt Meurer
48a6766e78
[x86] Disable invalid checked load/store optimization.
...
TEST=mjsunit/compiler/regress-lena
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/784153006
Cr-Commit-Position: refs/heads/master@{#25722}
2014-12-09 14:16:34 +00:00
jochen
93f3531051
Really enable DEBUG code on android unless full debug is specified
...
R=machenbach@chromium.rg
LOG=n
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/786203003
Cr-Commit-Position: refs/heads/master@{#25721}
2014-12-09 11:32:36 +00:00
jochen
7216f37ce7
Also ignore NDEBUG for chromium code
...
BUG=none
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/792513002
Cr-Commit-Position: refs/heads/master@{#25720}
2014-12-09 10:57:23 +00:00
jochen
8a7a81141f
Temporarily restore make dependencies
...
We will remove dependencies in about a week again.
BUG=none
R=machenbach@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/733203008
Cr-Commit-Position: refs/heads/master@{#25719}
2014-12-09 10:55:47 +00:00
bmeurer
baafb8f92e
[turbofan] Turn JSToBoolean and JSUnaryNot into pure operators.
...
Also fix the pushing of JSToBoolean into Phis and generalize it to
also include pushing into Selects.
TEST=cctest,unittests
Review URL: https://codereview.chromium.org/792463003
Cr-Commit-Position: refs/heads/master@{#25718}
2014-12-09 07:35:12 +00:00
mstarzinger
8acf387620
Make --no-turbo-types work on all paths through the pipeline.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/785933002
Cr-Commit-Position: refs/heads/master@{#25717}
2014-12-09 04:47:59 +00:00
Dmitry Lomov
90a297a8e0
Ignore tests that fail on nosnap apparently for infa reasons.
...
TBR=arv@chromium.org
BUG=v8:3744
LOG=N
NOTRY=true
Review URL: https://codereview.chromium.org/746743003
Cr-Commit-Position: refs/heads/master@{#25716}
2014-12-08 18:41:39 +00:00
adamk
243764b04b
Optimize add/set/delete operations for string keys in Maps and Sets
...
This was previously landed in commit 8599f5f
, but failed the
collections mjsunit test on ia32 with --deopt-every-n=1. The fixed
patch adds a ClearFlag(HValue::kCanOverflow) call after every
arithmetic operation, which should remove all the deopt points in these
intrinsics.
Ideally, it seems like there should be a way to verify that there are
no deopt points for these inline optimized functions, since there's
nothing to deopt to. But I don't currently know of such a thing.
Review URL: https://codereview.chromium.org/782073002
Cr-Commit-Position: refs/heads/master@{#25715}
2014-12-08 18:03:39 +00:00
dslomov
b4f3250712
Better message location for 'super(...)' restriction error.
...
R=arv@chromium.org
BUG=v8:3330
LOG=N
Review URL: https://codereview.chromium.org/776563002
Cr-Commit-Position: refs/heads/master@{#25714}
2014-12-08 15:55:03 +00:00
chunyang.dai
e980c7e41b
update test case for "Disable neutering on embedded arraybuffers"
...
This test case ( added by git: 4c7effe56e
).
should has different implementation for Turbofan and crankshaft.
BUG=
Review URL: https://codereview.chromium.org/774163005
Cr-Commit-Position: refs/heads/master@{#25713}
2014-12-08 15:14:56 +00:00
dslomov
1954ad8bc1
Do not reflect uninitialized 'let' and 'const' in scope mirrors.
...
R=yangguo@chromium.org ,aandrey@chromium.org
BUG=v8:3743
LOG=N
Review URL: https://codereview.chromium.org/758603004
Cr-Commit-Position: refs/heads/master@{#25712}
2014-12-08 14:59:28 +00:00
Jochen Eisinger
4ba9e967e9
Fix ARM64 build
...
The android toolchain for L now has a proper version (21)
BUG=none
TBR=rossberg@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/777273004
Cr-Commit-Position: refs/heads/master@{#25711}
2014-12-08 13:04:17 +00:00
jochen
779076e006
Update all DEPS to match chromium's DEPS at edb488e
...
Also remove the now disfunctinal 'builddeps' and 'dependencies' targets
BUG=none
R=machenbach@chromium.org ,jkummerow@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/788613002
Cr-Commit-Position: refs/heads/master@{#25710}
2014-12-08 12:27:26 +00:00
mstarzinger
abe5c29077
Silence --trace-turbo a bit and behave graceful in sandbox.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/786763002
Cr-Commit-Position: refs/heads/master@{#25709}
2014-12-08 12:26:22 +00:00
marja
6680fd1591
Handle invalid parser cache gracefully (move invalid cache handling to embedder).
...
Blink already has code for handling invalid cached data. The attached test
ensures that cached data is gracefully rejected if it cannot be used.
This also unifies parser cache and code cache handling.
R=yangguo@chromium.org
BUG=439889
LOG=N
Review URL: https://codereview.chromium.org/781203003
Cr-Commit-Position: refs/heads/master@{#25708}
2014-12-08 11:47:50 +00:00
Benedikt Meurer
a92adc5803
[turbofan] Remove obsolete pure flag.
...
Use the Operator::kPure flag instead, which determines whether the JS
operator has effect/control edges.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/720233006
Cr-Commit-Position: refs/heads/master@{#25707}
2014-12-08 11:25:46 +00:00
ulan
9a60180487
Temporarily skip test-mark-compact/MarkCompactCollector.
...
BUG=v8:3742
LOG=N
Review URL: https://codereview.chromium.org/764783003
Cr-Commit-Position: refs/heads/master@{#25706}
2014-12-08 11:05:56 +00:00
ulan
513d1261e1
Fix typo in r25689 (Refactor Map::ConstructionCount.)
...
BUG=chromium:439868
LOG=N
Review URL: https://codereview.chromium.org/779293003
Cr-Commit-Position: refs/heads/master@{#25705}
2014-12-08 10:46:19 +00:00
dcarney
a26a5440a5
[turbofan] reuse spill slots for phis
...
R=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/777403003
Cr-Commit-Position: refs/heads/master@{#25704}
2014-12-08 10:45:13 +00:00
yangguo
58fe6e732e
Clear cached line ends array when serializing script object.
...
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/790433002
Cr-Commit-Position: refs/heads/master@{#25703}
2014-12-08 10:23:13 +00:00
Jochen Eisinger
7a21cf2f77
Fix compilation with verify heap on in release mode
...
BUG=none
TBR=rossberg@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/788603002
Cr-Commit-Position: refs/heads/master@{#25702}
2014-12-08 09:52:51 +00:00
jochen
97c1f4b15c
Turn on DCHECKs and other debugging code if dcheck_always_on is 1
...
When compiling with the macro DCHECK_ALWAYS_ON defined, DCHECKs and
supporting code gets compiled and enabled.
This increases test coverage for chromium release buildbots
BUG=v8:3731
R=jkummerow@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/760213005
Cr-Commit-Position: refs/heads/master@{#25701}
2014-12-08 09:26:16 +00:00
machenbach
46762966c4
Correct clean up in android perf runner.
...
BUG=chromium:374740
LOG=n
TEST=python -m unittest run_perf_test
NOTRY=true
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/776223003
Cr-Commit-Position: refs/heads/master@{#25700}
2014-12-08 09:10:48 +00:00
Benedikt Meurer
11b52971d9
Make cpplint happy.
...
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/783913003
Cr-Commit-Position: refs/heads/master@{#25699}
2014-12-08 08:53:20 +00:00
Benedikt Meurer
1a05ece305
[turbofan] Improve typing of JSToNumber.
...
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/786703002
Cr-Commit-Position: refs/heads/master@{#25698}
2014-12-08 08:28:25 +00:00
adamk
75dbd0d352
Add myself to OWNERS
...
Review URL: https://codereview.chromium.org/780323002
Cr-Commit-Position: refs/heads/master@{#25697}
2014-12-08 05:46:46 +00:00
adamk
1988251044
Revert of Optimize add/set/delete operations for string keys in Maps and Sets (patchset #1 id:1 of https://codereview.chromium.org/777663003/ )
...
Reason for revert:
Deopt fuzzer reports that something's still broken, reverting until
I can create a minimal repro.
Original issue's description:
> Optimize add/set/delete operations for string keys in Maps and Sets
>
> This was previously landed in commit 66e2f60
, but failed the
> collections mjsunit test with --deopt-every-n=1 due to a typo
> in the shrinking code. This patch corrects and simplifies the
> shrinking logic, and the tests now pass.
>
> R=dslomov@chromium.org
>
> Committed: 8599f5f047
TBR=dslomov@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/742353006
Cr-Commit-Position: refs/heads/master@{#25696}
2014-12-05 22:25:11 +00:00
Adam Klein
8599f5f047
Optimize add/set/delete operations for string keys in Maps and Sets
...
This was previously landed in commit 66e2f60
, but failed the
collections mjsunit test with --deopt-every-n=1 due to a typo
in the shrinking code. This patch corrects and simplifies the
shrinking logic, and the tests now pass.
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/777663003
Cr-Commit-Position: refs/heads/master@{#25695}
2014-12-05 21:04:00 +00:00
arv
c8c7395644
Optimize GetPrototype
...
This introduces Hydrogen for %_GetPrototype. The code falls back on
runtime if the object needs access checks or if its prototype is a
hidden prototype.
BUG=None
LOG=Y
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/756423006
Cr-Commit-Position: refs/heads/master@{#25694}
2014-12-05 20:36:50 +00:00
paul.lind
761891d201
MIPS64: Fix port of Refactor Map::ConstructionCount.
...
Port 35ff259b63
.
BUG=
Review URL: https://codereview.chromium.org/756383005
Cr-Commit-Position: refs/heads/master@{#25693}
2014-12-05 19:30:59 +00:00
balazs.kilvady
1a033e5df4
MIPS: Refactor Map::ConstructionCount.
...
Port 35ff259b63
Original commit message:
This combines Map::DoneInobjectSlackTracking and Map::ConstructionCount into one more generic 4-bit counter.
Counter values from 15 down to 8 are used for in-object slack tracking, values from 7 down to 0 are free to be used for a new counter when in-object slack tracking is inactive
BUG=
Review URL: https://codereview.chromium.org/780303003
Cr-Commit-Position: refs/heads/master@{#25692}
2014-12-05 17:49:42 +00:00
baixo
cd0a53bca2
GN: Enable embedder to decide whether or not the external V8 snapshot is enabled.
...
BUG=421063
Review URL: https://codereview.chromium.org/749213004
Cr-Commit-Position: refs/heads/master@{#25691}
2014-12-05 17:22:53 +00:00
dslomov
293f898a6f
Make sure that individual shipping features can be disabled.
...
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/779203005
Cr-Commit-Position: refs/heads/master@{#25690}
2014-12-05 15:35:37 +00:00
ulan
35ff259b63
Refactor Map::ConstructionCount.
...
This combines Map::DoneInobjectSlackTracking and Map::ConstructionCount into one more generic 4-bit counter.
Counter values from 15 down to 8 are used for in-object slack tracking, values from 7 down to 0 are free to be used for a new counter when in-object slack tracking is inactive.
Review URL: https://codereview.chromium.org/767253002
Cr-Commit-Position: refs/heads/master@{#25689}
2014-12-05 15:28:22 +00:00
dcarney
5ce364d817
new api for adding indexed interceptors
...
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/765883003
Cr-Commit-Position: refs/heads/master@{#25688}
2014-12-05 15:21:27 +00:00
ulan
a9f692eca8
Fix %GetWeakSetValues to work correctly with GC.
...
This fixes mjsunit/es6/mirror-collections failure in arm64 gc-stress bot.
BUG=
Review URL: https://codereview.chromium.org/783673002
Cr-Commit-Position: refs/heads/master@{#25687}
2014-12-05 13:27:17 +00:00
verwaest
7fb5f74d20
Allow eval in detached contexts
...
BUG=
Review URL: https://codereview.chromium.org/781953002
Cr-Commit-Position: refs/heads/master@{#25686}
2014-12-05 13:25:10 +00:00
dcarney
4c7effe56e
[turbofan] disable neutering on embedded arraybuffers
...
R=titzer@chromium.org ,
BUG=
Review URL: https://codereview.chromium.org/781933002
Cr-Commit-Position: refs/heads/master@{#25685}
2014-12-05 13:08:03 +00:00
dslomov
bd04e6cdad
Fix the order of context binding/simulate insertion for BlockContexts.
...
R=jarin@chromium.org
BUG=v8:3741
LOG=N
Review URL: https://codereview.chromium.org/762393008
Cr-Commit-Position: refs/heads/master@{#25684}
2014-12-05 13:06:50 +00:00
danno
1150cf7f9a
[turbofan] Fix Corrections tankage on x64.
...
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/771073003
Cr-Commit-Position: refs/heads/master@{#25683}
2014-12-05 13:05:46 +00:00
mstarzinger
9ed88f1789
Switch two ZoneLists to ZoneVector in register allocator.
...
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/778093003
Cr-Commit-Position: refs/heads/master@{#25682}
2014-12-05 13:04:43 +00:00
yangguo
ab234760d7
Reland "Encode reservation meta data in the snapshot blob."
...
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_nosnap_rel
Review URL: https://codereview.chromium.org/781943002
Cr-Commit-Position: refs/heads/master@{#25681}
2014-12-05 13:03:30 +00:00
mstarzinger
aae8fe7550
Cleanup deoptimizer relocation slot preparation.
...
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/782703002
Cr-Commit-Position: refs/heads/master@{#25680}
2014-12-05 13:02:13 +00:00