caitpotter88
e160e6debb
[parser] report SyntaxError if rest parameter used in Setter MethodDefinition
...
BUG=v8:4107, v8:2159
LOG=N
R=arv@chromium.org
Review URL: https://codereview.chromium.org/1141223002
Cr-Commit-Position: refs/heads/master@{#28454}
2015-05-18 15:52:45 +00:00
titzer
178c0f5f05
[turbofan] Fix Node::TrimInputCount() followed by Node::AppendInput() bug.
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1132353004
Cr-Commit-Position: refs/heads/master@{#28452}
2015-05-18 15:49:04 +00:00
machenbach
91f38435ea
Revert of [V8] Added Script::is_opaque flag for embedders (patchset #5 id:80001 of https://codereview.chromium.org/1140673002/ )
...
Reason for revert:
[Sheriff] Breaks chromium win compilation:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/96
Original issue's description:
> [V8] Added Script::is_opaque flag for embedders
>
> When the page is controlled by a ServiceWorker, the ServiceWorker can return an opaque (non-CORS cross origin) resource response.
> We need to treat the messages from such script resource as opaque.
>
> Committed: https://crrev.com/7a599c5e1242d3c5ab7515ee149623da90ae69ec
> Cr-Commit-Position: refs/heads/master@{#28445}
TBR=mkwst@chromium.org ,jochen@chromium.org,yangguo@chromium.org,horo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1135343005
Cr-Commit-Position: refs/heads/master@{#28449}
2015-05-18 14:54:42 +00:00
arv
55a7500343
[strong] Fix super in strong classes
...
The functions of strong classes are born non extensible. But, when
the class is created we need to add an own private symbol representing
the [[HomeObject]] slot in the spec.
Like for the hidden_string property, we allow adding private own
symbols to non extensible objects.
BUG=v8:4077
LOG=N
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/1138603003
Cr-Commit-Position: refs/heads/master@{#28447}
2015-05-18 14:18:38 +00:00
horo
7a599c5e12
[V8] Added Script::is_opaque flag for embedders
...
When the page is controlled by a ServiceWorker, the ServiceWorker can return an opaque (non-CORS cross origin) resource response.
We need to treat the messages from such script resource as opaque.
Review URL: https://codereview.chromium.org/1140673002
Cr-Commit-Position: refs/heads/master@{#28445}
2015-05-18 13:54:24 +00:00
rossberg
fe6598cffb
[strong] Object literals create strong objects
...
R=dslomov@chromium.org
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/1134333005
Cr-Commit-Position: refs/heads/master@{#28444}
2015-05-18 13:23:17 +00:00
verwaest
4268141ca6
Reland "Mark internal AccessorInfo properties as 'special data properties'"
...
This reverts commit ac5336baca
.
BUG=
Review URL: https://codereview.chromium.org/1138483005
Cr-Commit-Position: refs/heads/master@{#28442}
2015-05-18 12:36:40 +00:00
titzer
029a2d61a6
[turbofan] JSTypeFeedbackSpecializer is now an AdvancedReducer.
...
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1136413002
Cr-Commit-Position: refs/heads/master@{#28441}
2015-05-18 11:54:00 +00:00
dusan.milosavljevic
8d7633c5cc
MIPS: Fix bogus line in assembler test.
...
TEST=cctest/test-assembler-mips/MIPS11
BUG=
Review URL: https://codereview.chromium.org/1133663007
Cr-Commit-Position: refs/heads/master@{#28440}
2015-05-18 10:55:26 +00:00
yangguo
fc65e55116
Migrate error messages, part 12.
...
Review URL: https://codereview.chromium.org/1130133003
Cr-Commit-Position: refs/heads/master@{#28439}
2015-05-18 08:33:51 +00:00
machenbach
ac5336baca
Revert of Mark internal AccessorInfo properties as "special data properties" (patchset #2 id:20001 of https://codereview.chromium.org/1123163005/ )
...
Reason for revert:
[Sheriff] Blocks current roll:
https://codereview.chromium.org/1124403007/
Bisection (https://codereview.chromium.org/1142753002/ ) points to this CL.
Original issue's description:
> Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling.
>
> BUG=
>
> Committed: https://crrev.com/188297160d2b82a4e2a206ebbddfc21dd99a9d8d
> Cr-Commit-Position: refs/heads/master@{#28369}
TBR=rossberg@chromium.org ,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1142763002
Cr-Commit-Position: refs/heads/master@{#28437}
2015-05-17 16:50:17 +00:00
machenbach
f453416b7f
Revert of Debugger: preserve stepping state after evaluating breakpoint condition. (patchset #1 id:1 of https://codereview.chromium.org/1132643004/ )
...
Reason for revert:
[Sheriff] This breaks TSAN (makes some tests marked as flaky permanently fail):
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/3882
Original issue's description:
> Debugger: preserve stepping state after evaluating breakpoint condition.
>
> R=ulan@chromium.org , yurys@chromium.org
> BUG=chromium:467180
> LOG=N
TBR=ulan@chromium.org ,yurys@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:467180
Review URL: https://codereview.chromium.org/1130123007
Cr-Commit-Position: refs/heads/master@{#28436}
2015-05-17 06:21:39 +00:00
yangguo
ee6666a55a
Debugger: preserve stepping state after evaluating breakpoint condition.
...
R=ulan@chromium.org , yurys@chromium.org
BUG=chromium:467180
LOG=N
Review URL: https://codereview.chromium.org/1132643004
Cr-Commit-Position: refs/heads/master@{#28432}
2015-05-15 22:50:55 +00:00
hpayer
055d4ee19c
Clean-up aligned allocation logic.
...
BUG=
Review URL: https://codereview.chromium.org/1138643005
Cr-Commit-Position: refs/heads/master@{#28430}
2015-05-15 17:04:41 +00:00
hpayer
6ead193b51
Make sure that idle scavenges are just performed when enough objects are allocated in new space.
...
BUG=
Review URL: https://codereview.chromium.org/1138643003
Cr-Commit-Position: refs/heads/master@{#28428}
2015-05-15 16:06:08 +00:00
arv
834a8e9f63
[es6] Iterators and generators should "extend" %IteratorPrototype%
...
All the builtin iterators as well as the generator objects have an
object called %IteratorPrototype% in the spec between them and
%ObjectPrototype%.
BUG=v8:3568
LOG=N
Review URL: https://codereview.chromium.org/1128233008
Cr-Commit-Position: refs/heads/master@{#28426}
2015-05-15 15:09:38 +00:00
yangguo
d8e9f3a484
Add regression test for resolving "this" in debug evaluate.
...
R=hablich@chromium.org
BUG=chromium:487289
LOG=N
Review URL: https://codereview.chromium.org/1137293002
Cr-Commit-Position: refs/heads/master@{#28424}
2015-05-15 13:57:31 +00:00
yangguo
f3f0b2724b
Migrate error messages, part 11.
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1140053002
Cr-Commit-Position: refs/heads/master@{#28423}
2015-05-15 13:32:26 +00:00
mvstanton
323ced9e27
Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag.
...
BUG=
Review URL: https://codereview.chromium.org/1129853002
Cr-Commit-Position: refs/heads/master@{#28422}
2015-05-15 13:25:22 +00:00
mvstanton
de3a1ca02e
Bug: Runtime_GrowArrayElements provoked unnecessary lazy deopt.
...
Unnecessary, and unhandled as well.
BUG=488398
R=jarin@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/1141163004
Cr-Commit-Position: refs/heads/master@{#28421}
2015-05-15 13:05:00 +00:00
bmeurer
1643671f1b
[turbofan] Pass closure as node to FrameState.
...
First step towards support for inlining based on SharedFunctionInfo
instead of JSFunction.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1134713004
Cr-Commit-Position: refs/heads/master@{#28419}
2015-05-15 12:17:05 +00:00
ishell
3c1487db60
Map::ReconfigureProperty() should mark map as unstable when there is an element kind transition somewhere in the middle of the transition tree.
...
BUG=chromium:485548
LOG=N
Review URL: https://codereview.chromium.org/1128043005
Cr-Commit-Position: refs/heads/master@{#28418}
2015-05-15 10:39:51 +00:00
dslomov
7f6ae2300b
[destructuring] Adapting PatternRewriter to work in C-style for-statements.
...
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/1128043006
Cr-Commit-Position: refs/heads/master@{#28417}
2015-05-15 09:56:24 +00:00
hpayer
bc9e53406e
When context disposal rate is high and we cannot perform a full GC, we do nothing until the context disposal rate becomes lower.
...
BUG=chromium:473351
LOG=n
Review URL: https://codereview.chromium.org/1118303004
Cr-Commit-Position: refs/heads/master@{#28416}
2015-05-15 07:48:07 +00:00
yangguo
abbaac4845
Reland "Prevent stack overflow in the serializer/deserializer."
...
TBR=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1124403006
Cr-Commit-Position: refs/heads/master@{#28415}
2015-05-15 07:42:35 +00:00
martyn.capewell
cdc43bc5fd
ARM64: Enable shorten-64-to-32 warning
...
Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
that arise.
BUG=
Review URL: https://codereview.chromium.org/1131573006
Cr-Commit-Position: refs/heads/master@{#28412}
2015-05-15 05:13:11 +00:00
dehrenberg
85c91f639e
Test that TypedArray methods don't read length
...
ES6 specifies that methods on TypedArrays reference an internal length
slot, rather than their length property. This patch tests that for the
TypedArray methods that exist currently.
R=arv@chromium.org
BUG=v8:3578
LOG=Y
Review URL: https://codereview.chromium.org/1130413010
Cr-Commit-Position: refs/heads/master@{#28409}
2015-05-15 02:03:44 +00:00
caitpotter88
3a18b9b71b
[es6] support spread-calling Super-accessing properties
...
BUG=v8:4105, v8:3018
LOG=N
R=arv@chromium.org
Review URL: https://codereview.chromium.org/1132933003
Cr-Commit-Position: refs/heads/master@{#28405}
2015-05-14 22:59:14 +00:00
paul.lind
d090469cdd
Revert of MIPS: Add float instructions and test coverage, part one
...
Reason for revert:
Simulator test failures in RunChangeFloat64ToInt.., RunChangeTaggedToInt32,
div-mul-minus-one
Original issue's description:
> Implement assembler, disassembler tests for all instructions for mips32
> and mips64. Additionally, add missing single precision float instructions
> for r2 and r6 architecture variants in assembler, simulator and disassembler
> with corresponding tests.
BUG=
Review URL: https://codereview.chromium.org/1143473003
Cr-Commit-Position: refs/heads/master@{#28404}
2015-05-14 18:44:41 +00:00
machenbach
e1b5db6c8d
Revert of Prevent stack overflow in the serializer/deserializer. (patchset #6 id:100001 of https://codereview.chromium.org/1125073004/ )
...
Reason for revert:
[Sheriff] Breaks msan:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2266
Original issue's description:
> Prevent stack overflow in the serializer/deserializer.
>
> We keep an eye on the recursion depth. Once it exceeds a limit, we serialize
> only the object header and size, but defer serializing the object body for
> after we have unwound the stack.
>
> R=mvstanton@chromium.org
>
> Committed: https://crrev.com/36b4a498d6614243454d5a182e4946b0dad24f0a
> Cr-Commit-Position: refs/heads/master@{#28385}
TBR=mvstanton@chromium.org ,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1139113002
Cr-Commit-Position: refs/heads/master@{#28403}
2015-05-14 14:59:23 +00:00
Djordje.Pesic
2a6a87d71a
MIPS: Add float instructions and test coverage, part one
...
Implement assembler, disassembler tests for all instructions for mips32 and mips64. Additionally, add missing single precision float instructions for r2 and r6 architecture variants in assembler, simulator and disassembler with corresponding tests.
Review URL: https://codereview.chromium.org/1119203003
Cr-Commit-Position: refs/heads/master@{#28402}
2015-05-14 14:02:36 +00:00
rossberg
9be59492f9
[strong] Introduce strong bit
...
Only set on strong functions so far to test basic operation.
R=dslomov@chromium.org
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/1138243002
Cr-Commit-Position: refs/heads/master@{#28396}
2015-05-13 13:31:12 +00:00
yangguo
e24b31f003
Revert "Resolve references to "this" the same way as normal variables"
...
... and the following two
"PPC: Resolve references to "this" the same way as normal variables"
"Remove Scope::scope_uses_this_ flag"
R=hablich@chromium.org
BUG=chromium:487289
LOG=N
Review URL: https://codereview.chromium.org/1134003003
Cr-Commit-Position: refs/heads/master@{#28395}
2015-05-13 13:30:01 +00:00
titzer
29e15dad16
[turbofan] Add FrameStates before all property accesses.
...
R=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1133303006
Cr-Commit-Position: refs/heads/master@{#28392}
2015-05-13 12:29:32 +00:00
wingo
e73594c7fb
Use ExpressionClassifier to identify valid arrow function formals
...
R=dslomov@chromium.org
LOG=N
BUG=
Review URL: https://codereview.chromium.org/1138153003
Cr-Commit-Position: refs/heads/master@{#28391}
2015-05-13 11:45:02 +00:00
bmeurer
5494920a18
[turbofan] Use frame state before for shift operations as well.
...
This was already done for other binary operations, so it's basically
copying the existing functionality to shift left and shift right
logical/arithmetic.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1140883003
Cr-Commit-Position: refs/heads/master@{#28389}
2015-05-13 11:17:28 +00:00
yangguo
36b4a498d6
Prevent stack overflow in the serializer/deserializer.
...
We keep an eye on the recursion depth. Once it exceeds a limit, we serialize
only the object header and size, but defer serializing the object body for
after we have unwound the stack.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1125073004
Cr-Commit-Position: refs/heads/master@{#28385}
2015-05-13 10:18:26 +00:00
bmeurer
2111d18dba
[turbofan] Add frame state before JavaScript comparisons.
...
Use these check points to optimize comparisons where we already know
that one side cannot be a String (or turn into a string via
ToPrimitive).
Also remove bunch of useless DoNotCrash tests for the scheduler that are
painful to maintain and add almost no value.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1140583004
Cr-Commit-Position: refs/heads/master@{#28383}
2015-05-13 07:38:35 +00:00
dehrenberg
b57428e9ef
Implement %TypedArray%.{fill,find,findIndex}
...
This patch adds three methods to TypedArrays which are already
implemented for arrays. The implementations are made by calling
out to the underlying code used by Arrays.
R=adamk@chromium.org
BUG=v8:3578
LOG=Y
Review URL: https://codereview.chromium.org/1136663005
Cr-Commit-Position: refs/heads/master@{#28382}
2015-05-13 04:32:08 +00:00
dehrenberg
a863c4d3d8
TypedArray.prototype.copyWithin method
...
This patch adds the copyWithin method to TypedArrays. For the first
pass, the internals of Array.copyWithin are used. Eventually, a more
efficient form based on memcpy could be used instead.
BUG=v8:3578
LOG=Y
R=adamk@chromium.org , arv@chromium.org , caitpotter88@gmail.com
Review URL: https://codereview.chromium.org/1131113002
Cr-Commit-Position: refs/heads/master@{#28381}
2015-05-12 19:20:56 +00:00
dslomov
0b620ad5e5
Fix test formatting
...
TBR=arv@chromium.org
Review URL: https://codereview.chromium.org/1129713004
Cr-Commit-Position: refs/heads/master@{#28380}
2015-05-12 18:12:54 +00:00
arv
547a641e2c
[strong] Add more function arity tests
...
This is a follow up to https://codereview.chromium.org/1115263004/
BUG=v8:3956
LOG=N
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/1141603002
Cr-Commit-Position: refs/heads/master@{#28379}
2015-05-12 17:37:25 +00:00
ulan
bbca83c398
Make transition to reduce memory mode more conservative in idle time handler.
...
BUG=chromium:486005
LOG=NO
Review URL: https://codereview.chromium.org/1131943004
Cr-Commit-Position: refs/heads/master@{#28378}
2015-05-12 17:24:58 +00:00
dslomov
30b771a662
Fix the behavior of 'super.foo' assignment when receiver is not an object.
...
R=arv@chromium.org ,verwaest@chromium.org
BUG=v8:4097
LOG=N
Review URL: https://codereview.chromium.org/1132203005
Cr-Commit-Position: refs/heads/master@{#28377}
2015-05-12 17:13:07 +00:00
conradw
03ef40b46c
[strong] Disallow implicit conversions for comparison
...
Implements the strong mode proposal's restrictions on implicit conversions
for the binary >, >=, <, and <= operators.
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/1130283002
Cr-Commit-Position: refs/heads/master@{#28370}
2015-05-12 15:23:50 +00:00
verwaest
188297160d
Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling.
...
BUG=
Review URL: https://codereview.chromium.org/1123163005
Cr-Commit-Position: refs/heads/master@{#28369}
2015-05-12 15:11:13 +00:00
yangguo
46f992ddd0
Reland "Use function wrapper argument to expose internal arrays to native scripts."
...
Review URL: https://codereview.chromium.org/1138173002
Cr-Commit-Position: refs/heads/master@{#28367}
2015-05-12 14:00:45 +00:00
yangguo
0bbe787448
Migrate error messages, part 10.
...
R=mvstanton@chromium.org
Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f
Cr-Commit-Position: refs/heads/master@{#28357}
Review URL: https://codereview.chromium.org/1126043004
Cr-Commit-Position: refs/heads/master@{#28366}
2015-05-12 13:52:23 +00:00
titzer
e5d5cac7d9
[turbofan] Add AdvancedReducer::ReplaceWithValue() method and convert JSInlining to an AdvancedReducer.
...
Note that this is just a duplication for now. We'll want to get rid of the
NodeProperties::ReplaceWithValue() method in the long run.
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1135483004
Cr-Commit-Position: refs/heads/master@{#28363}
2015-05-12 12:41:36 +00:00
yangguo
26cb29b891
Revert of Migrate error messages, part 10. (patchset #2 id:20001 of https://codereview.chromium.org/1126043004/ )
...
Reason for revert:
patch didn't apply correctly.
Original issue's description:
> Migrate error messages, part 10.
>
> R=mvstanton@chromium.org
>
> Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f
> Cr-Commit-Position: refs/heads/master@{#28357}
TBR=mvstanton@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1130073005
Cr-Commit-Position: refs/heads/master@{#28358}
2015-05-12 08:33:28 +00:00