v8/test
Toon Verwaest 00845abb32 [debug] Include Token::CLASS in class scopes and ContainsPosition
While evaluating a class literal the containing function points to
Token::CLASS. It may have pushed a context for that class that uses
the range of the class scope. So far the class scope had a range that
started after the class name or class token in case of anonymous
classes. That means the source position of the function frame doesn't
point to a position that is included in the active context range. This
breaks the debugger because it relies on being able to find the
matching parser scope for the active context by looking at the source
position.

The fix is two-fold:
- extend the class scope source range to include Token::CLASS
- update ScopeChainRetriever::ContainsPosition to include the start
  position of class scopes as a valid source position. We can't always
  include start due to arrow functions that don't have braces.

Bug: chromium:1156498
Change-Id: I9ec640c6326289dadcb154bb0a329ca6f8188f8b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857957
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74268}
2021-04-29 08:43:23 +00:00
..
benchmarks [build] Fix gn check errors in test/benchmarks/cpp 2021-04-27 10:35:33 +00:00
cctest [ptr-cage] Factor CodeRange out of MemoryAllocator and share along with ptr cage 2021-04-28 19:17:00 +00:00
common [wasm] Fix interpreter EH stack height bug 2021-04-12 18:00:33 +00:00
debugger [debug] Include Token::CLASS in class scopes and ContainsPosition 2021-04-29 08:43:23 +00:00
debugging [wasm] Rename kWasmStmt -> kWasmVoid 2021-03-22 07:58:18 +00:00
fuzzer [test] Filter tests for third party heap 2021-04-27 10:17:33 +00:00
fuzzilli Fix unhandled promise rejections in REPRL mode 2020-09-30 13:34:23 +00:00
inspector [debug] Disallow LiveEdit of active frames. 2021-04-28 13:00:19 +00:00
intl [Intl] Update ICU to 69-1 2021-04-20 22:37:09 +00:00
js-perf-test Update OWNERS in test/* 2021-02-25 14:26:24 +00:00
memory [snapshot] Fix the Memory.json benchmark 2021-04-28 07:54:34 +00:00
message [wasm-simd] Rename no_simd_sse to no_simd_hardware to be generic 2021-04-23 00:25:29 +00:00
mjsunit [wasm] Fix BigInt imports to asm.js modules 2021-04-29 07:33:03 +00:00
mkgrokdump [build] Fold v8_wrappers into v8_libbase 2021-02-25 10:56:20 +00:00
mozilla [compiler, infra] Add a --stress-concurrent-inlining flag and a bot 2021-01-29 12:05:03 +00:00
test262 [test262] Roll test262 2021-04-26 15:23:18 +00:00
torque [torque] Add LazyNode support 2021-02-23 16:51:53 +00:00
unittests cppgc: fix unittest compilation on gcc 8 2021-04-27 18:12:15 +00:00
wasm-api-tests [test] Filter tests for third party heap 2021-04-27 10:17:33 +00:00
wasm-js [wasm] Update spec tests 2021-04-14 13:48:55 +00:00
wasm-spec-tests [wasm-simd] Rename no_simd_sse to no_simd_hardware to be generic 2021-04-23 00:25:29 +00:00
webkit Disallow \8 and \9 in strict mode and template literals 2020-08-03 18:05:14 +00:00
BUILD.gn [no-wasm] Exclude more targets from build 2021-03-09 11:25:54 +00:00
OWNERS Use relative paths to OWNERS files 2019-08-12 13:52:52 +00:00