Go to file
vogelheim@chromium.org 2c3ba95841 Revert of Prevent calls to ReturnValue::Set with pointer-valued types. (https://codereview.chromium.org/240013004/)
Reason for revert:
Looks like this broke the "V8 Linux64 ASAN" build.

Original issue's description:
> Prevent calls to ReturnValue::Set with pointer-valued types.
>
> Currently, this code will compile:
>   SomePointer* p = ...;
>   ReturnValue r = ...;
>   r.Set(p);
>
> What happens is that ReturnValue::Set has no pointer-ish overloads, but
> a bool one, and hence C++ will convert the pointer to a bool and use
> the Set(bool) overload. In other words, the example above is equivalent
> to: r.Set(p ? true : false); Which probably isn't what the author had
> in mind. This change adds a Set(void*) overload whose body forces a
> compile error, to prevent this from happening inadvertently. The only
> use of this indeed turned out to be an error.
>
> (Said error was fixed/removed in crrev.com/267393002.)
>
> BUG=
> R=dcarney@chromium.org
>
> Committed: https://code.google.com/p/v8/source/detail?r=21217

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/271113002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-09 12:33:29 +00:00
benchmarks Fix bug in nextWeaker function of deltablue benchmark. 2013-10-25 13:21:46 +00:00
build Always include debugger support. 2014-04-25 11:00:37 +00:00
include Revert of Prevent calls to ReturnValue::Set with pointer-valued types. (https://codereview.chromium.org/240013004/) 2014-05-09 12:33:29 +00:00
samples Unbreak samples and tools. 2014-05-08 06:52:35 +00:00
src Fix new space array check limit. 2014-05-09 12:19:59 +00:00
test Clean up Debugger::NotifyMessageHandler. 2014-05-09 09:24:32 +00:00
tools Add test case generator for runtime functions 2014-05-08 13:11:59 +00:00
.clang-format Change clang-format config to allow for two empty lines between functions 2013-12-03 10:39:21 +00:00
.DEPS.git Introduce .DEPS.git file to support full git checkouts 2014-04-23 12:28:43 +00:00
.gitignore Update .gitignore wrt promise test files. 2014-04-24 14:15:06 +00:00
AUTHORS Add ARM contributors to AUTHORS. 2014-02-12 11:54:34 +00:00
BUILD.gn Merge counters and v8-counters 2014-05-07 07:15:24 +00:00
ChangeLog Sync change log and version file with trunk. 2014-05-09 11:17:45 +00:00
codereview.settings Add settings for try server. 2013-12-17 12:24:25 +00:00
DEPS Introduce .DEPS.git file to support full git checkouts 2014-04-23 12:28:43 +00:00
LICENSE Update LICENSE date. 2014-02-18 10:50:22 +00:00
LICENSE.strongtalk Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.v8 Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.valgrind Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
Makefile Always include debugger support. 2014-04-25 11:00:37 +00:00
Makefile.android [Android]: Update Makefile.android to use platform-14 as minimum. 2014-05-06 09:08:32 +00:00
Makefile.nacl This should make the NaCl build jobs green again. 2014-04-17 14:22:20 +00:00
OWNERS Add rmcilroy@chromium.org to src/OWNERS. 2014-04-11 08:55:18 +00:00
PRESUBMIT.py Update tryserver configuration with new linux and arm bots. 2014-04-01 13:43:32 +00:00
WATCHLISTS Add myself to a watchlist for the public API. 2013-10-10 11:37:48 +00:00