2c3ba95841
Reason for revert: Looks like this broke the "V8 Linux64 ASAN" build. Original issue's description: > Prevent calls to ReturnValue::Set with pointer-valued types. > > Currently, this code will compile: > SomePointer* p = ...; > ReturnValue r = ...; > r.Set(p); > > What happens is that ReturnValue::Set has no pointer-ish overloads, but > a bool one, and hence C++ will convert the pointer to a bool and use > the Set(bool) overload. In other words, the example above is equivalent > to: r.Set(p ? true : false); Which probably isn't what the author had > in mind. This change adds a Set(void*) overload whose body forces a > compile error, to prevent this from happening inadvertently. The only > use of this indeed turned out to be an error. > > (Said error was fixed/removed in crrev.com/267393002.) > > BUG= > R=dcarney@chromium.org > > Committed: https://code.google.com/p/v8/source/detail?r=21217 R=ishell@chromium.org Review URL: https://codereview.chromium.org/271113002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 |
||
|---|---|---|
| .. | ||
| v8-debug.h | ||
| v8-platform.h | ||
| v8-profiler.h | ||
| v8-testing.h | ||
| v8-util.h | ||
| v8.h | ||
| v8config.h | ||
| v8stdint.h | ||