73a5db9d06
Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is repeated. This has broken the DrMemory builder - see first failing chromium build https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%29/builds/17857 which included a v8 roll.
For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp
gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp
gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp
Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'
>
> Port
|
||
|---|---|---|
| .. | ||
| config/win | ||
| mac | ||
| all.gyp | ||
| coverage_wrapper.py | ||
| detect_v8_host_arch.py | ||
| download_gold_plugin.py | ||
| features.gypi | ||
| get_landmines.py | ||
| gyp_environment.py | ||
| gyp_v8 | ||
| gyp_v8.py | ||
| isolate.gypi | ||
| landmine_utils.py | ||
| landmines.py | ||
| OWNERS | ||
| README.txt | ||
| set_clang_warning_flags.gypi | ||
| shim_headers.gypi | ||
| standalone.gypi | ||
| toolchain.gypi | ||
| vs_toolchain.py | ||
For build instructions, please refer to: https://code.google.com/p/v8/wiki/BuildingWithGYP TL;DR version on *nix: $ make dependencies # Only needed once. $ make ia32.release -j8 $ make ia32.release.check # Optionally: run tests.