7371c34b6b
1. Replaces --crankshaft with --opt in tests. 2. Also fixes presubmit to check for --opt flag when assertOptimized is used. 3. Updates testrunner/local/variants.py and v8_foozie.py to use --opt flag. This would mean, nooptimize variant means there are no optimizations. Not even with %OptimizeFunctionOnNextCall. Bug:v8:6325 Change-Id: I638e743d0773a6729c6b9749e2ca1e2537f12ce6 Reviewed-on: https://chromium-review.googlesource.com/490206 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44985}
43 lines
1.2 KiB
JavaScript
43 lines
1.2 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-always-opt
|
|
|
|
var v = 0;
|
|
|
|
// Test that elements setters/getters on prototype chain set after the fact are
|
|
// property detected and don't lead to overzealous optimization.
|
|
var my_array_proto = {};
|
|
my_array_proto.__proto__ = [].__proto__;
|
|
|
|
function push_wrapper_2(array, value) {
|
|
array.push(value);
|
|
}
|
|
array = [];
|
|
array.__proto__ = my_array_proto;
|
|
push_wrapper_2(array, 66);
|
|
assertEquals(1, array.length);
|
|
assertEquals(0, v);
|
|
assertEquals(66, array[0]);
|
|
push_wrapper_2(array, 77);
|
|
assertEquals(2, array.length);
|
|
assertEquals(0, v);
|
|
assertEquals(77, array[1]);
|
|
%OptimizeFunctionOnNextCall(push_wrapper_2);
|
|
push_wrapper_2(array, 88);
|
|
assertEquals(3, array.length);
|
|
assertEquals(0, v);
|
|
assertEquals(88, array[2]);
|
|
assertOptimized(push_wrapper_2);
|
|
// Defining accessor should deopt optimized push.
|
|
Object.defineProperty(my_array_proto, "3", {
|
|
get: function() { return "get " + v; },
|
|
set: function(value) { v += value; }
|
|
});
|
|
assertUnoptimized(push_wrapper_2);
|
|
push_wrapper_2(array, 99);
|
|
assertEquals(4, array.length);
|
|
assertEquals(99, v);
|
|
assertEquals("get 99", array[3]);
|