ce3ce2f66d
New revision: 7a44a37f66b58358dd8ab85ccde1998fafa95e53 Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1899564 Previously, we used a wrapper library, v8-inspector-protocol-encoding.h to inject the string<->number conversion into the cbor parser. This meant that the unittests, in third_party/inspector_protocol/crdtp/json_test.cc inadvertently did not run with the same string<->number conversion code. Thus, we missed that the production implementation would return INF for out of range double literals, as opposed to rejecting the incoming JSON. When switching the library to the build dependency on json_platform_v8.cc as it's in this change, the test immediately failed which made it trivial to fix the implementation. Old implementation: https://chromium-review.googlesource.com/c/v8/v8/+/1913424/6/src/inspector/v8-inspector-protocol-encoding.cc New implementation (checks std::isfinite): https://chromium-review.googlesource.com/c/v8/v8/+/1913424/6/third_party/inspector_protocol/crdtp/json_platform_v8.cc Change-Id: Ia48fe1f4e359eea47d0ede9ceadea1fd635292e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1913424 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65219}
19 lines
698 B
Markdown
19 lines
698 B
Markdown
# Chromium inspector (devtools) protocol
|
|
|
|
This package contains code generators and templates for the Chromium
|
|
inspector protocol.
|
|
|
|
The canonical location of this package is at
|
|
https://chromium.googlesource.com/deps/inspector_protocol/
|
|
|
|
In the Chromium tree, it's rolled into
|
|
https://cs.chromium.org/chromium/src/third_party/inspector_protocol/
|
|
|
|
In the V8 tree, it's rolled into
|
|
https://cs.chromium.org/chromium/src/v8/third_party/inspector_protocol/
|
|
|
|
See also [Contributing to Chrome Devtools Protocol](https://docs.google.com/document/d/1c-COD2kaK__5iMM5SEx-PzNA7HFmgttcYfOHHX0HaOM/edit).
|
|
|
|
To build and run the tests of the crdtp library, see
|
|
[CRDTP - Chrome DevTools Protocol](crdtp/README.md).
|