AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
ae5ae1ccee
v8/test/inspector
History
bmeurer ae5ae1ccee Revert of [js] Avoid %_ClassOf for collection builtins. (patchset #4 id:60001 of https://codereview.chromium.org/2814773005/ ) 
Reason for revert:
Breaks node.js integration bot: https://build.chromium.org/p/client.v8.fyi/builders/V8%20-%20node.js%20integration/builds/5374/steps/build%20addons%20and%20test%20node.js/logs/stdio

Original issue's description:
> [js] Avoid %_ClassOf for collection builtins.
>
> The collection builtins (Map, Set, WeakMap, WeakSet) are still written
> in JavaScript and make heavy use of %_ClassOf, which is kind of
> expensive compared to a simple instance type check. Change that to use
> simple instance type checks instead.
>
> R=jarin@chromium.org
> BUG=v8:6261,v8:6278,v8:6344
>
> Review-Url: https://codereview.chromium.org/2814773005
> Cr-Commit-Position: refs/heads/master@{#45106}
> Committed: 28170099fd

TBR=jarin@chromium.org,adamk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6261,v8:6278,v8:6344

Review-Url: https://codereview.chromium.org/2860123002
Cr-Commit-Position: refs/heads/master@{#45108}
2017-05-04 18:43:45 +00:00
..
console [test/inspector] remove any usage of v8::Extension 2017-04-21 23:41:07 +00:00
cpu-profiler Use --opt instead of --crankshaft in tests. 2017-04-28 14:20:39 +00:00
debugger [inspector] entered into context before getPossibleBreakpoints call 2017-05-01 19:44:13 +00:00
heap-profiler [test/inspector] remove any usage of v8::Extension 2017-04-21 23:41:07 +00:00
runtime [inspector] console property should be enumerable 2017-04-25 22:17:24 +00:00
BUILD.gn [build] Remove remaining disable-inspector options in GN 2017-04-05 17:59:07 +00:00
DEPS [inspector] introduce limit for amount of stored async stacks 2016-12-18 17:04:40 +00:00
inspector-impl.cc [inspector] improved V8Debugger::breakProgram method 2017-04-25 22:55:45 +00:00
inspector-impl.h [inspector] improved V8Debugger::breakProgram method 2017-04-25 22:55:45 +00:00
inspector-test.cc [inspector] always include user scripts in the snapshot. 2017-04-26 15:13:14 +00:00
inspector.gyp Fix inspector test in components build 2016-10-18 20:08:12 +00:00
inspector.isolate [build] Remove remaining disable-inspector options in GN 2017-04-05 17:59:07 +00:00
inspector.status Revert of [js] Avoid %_ClassOf for collection builtins. (patchset #4 id:60001 of https://codereview.chromium.org/2814773005/ ) 2017-05-04 18:43:45 +00:00
json-parse-expected.txt [inspector] added inspector test runner [part 5] 2016-10-02 21:23:03 +00:00
json-parse.js [inspector] added inspector test runner [part 5] 2016-10-02 21:23:03 +00:00
OWNERS [inspector] added inspector test runner [part 1] 2016-09-30 15:52:46 +00:00
protocol-test.js [test/inspector] migrate utils to ObjectTemplate 2017-04-20 18:04:24 +00:00
task-runner.cc [inspector] always include user scripts in the snapshot. 2017-04-26 15:13:14 +00:00
task-runner.h [inspector] always include user scripts in the snapshot. 2017-04-26 15:13:14 +00:00
testcfg.py [inspector] always include user scripts in the snapshot. 2017-04-26 15:13:14 +00:00