a48d7ce226
Reason for revert: With the Windows bots fixed in https://chromium-review.googlesource.com/445786 , this should be good to reland. Thanks, Michael! Original issue's description: > Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ ) > > Reason for revert: > Breaks all windows bots: > https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811 > > Original issue's description: > > [test] Remove local-tests from test262 archive and add to .isolate > > > > This might help fix the bots, which are broken in e.g., > > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011 > > > > The archive was added in order to transmit test262 tests more rapidly. > > It doesn't serve much of a purpose for local-tests. I naively added > > local-tests there out of symmetry. However, the BUILD.gn file does not > > regenerate an archive when files are only deleted and not added or > > changed. Since the performance concern is not present for the small > > volume of local-tests, this patch reverts to the more normal mechanism > > for sending over dependencies, with test262.isolate. > > > > R=adamk > > > > Review-Url: https://codereview.chromium.org/2643983002 > > Cr-Commit-Position: refs/heads/master@{#42485} > > Committed:9f545ea96f> > TBR=adamk@chromium.org,littledan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2640223003 > Cr-Commit-Position: refs/heads/master@{#42491} > Committed:4ffe0850dbTBR=adamk@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2725643002 Cr-Commit-Position: refs/heads/master@{#43488}
39 lines
1.1 KiB
Python
Executable File
39 lines
1.1 KiB
Python
Executable File
#!/usr/bin/env python
|
|
# Copyright 2016 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import os
|
|
import sys
|
|
import tarfile
|
|
import time
|
|
|
|
# In GN we expect the path to a stamp file as an argument.
|
|
if len(sys.argv) == 2:
|
|
STAMP_FILE = os.path.abspath(sys.argv[1])
|
|
|
|
os.chdir(os.path.dirname(os.path.abspath(__file__)))
|
|
|
|
# Workaround for slow grp and pwd calls.
|
|
tarfile.grp = None
|
|
tarfile.pwd = None
|
|
|
|
def filter_git(tar_info):
|
|
if tar_info.name.startswith(os.path.join('data', '.git')) or \
|
|
tar_info.name.startswith(os.path.join('harness', '.git')):
|
|
return None
|
|
else:
|
|
tar_info.uname = tar_info.gname = "test262"
|
|
return tar_info
|
|
|
|
with tarfile.open('data.tar', 'w') as tar:
|
|
tar.add('data', filter=filter_git)
|
|
tar.add('harness', filter=filter_git)
|
|
|
|
# Workaround for GN. We can't specify the tarfile as output because it's
|
|
# not in the product directory. Therefore we track running of this script
|
|
# with an extra stamp file in the product directory.
|
|
if len(sys.argv) == 2:
|
|
with open(STAMP_FILE, 'w') as f:
|
|
f.write(str(time.time()))
|