AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
c1190cf9b7
v8/test/cctest/interpreter/bytecode_expectations
History
Bill Budge b261213fcc Revert "Improve error messages for property access on null/undefined" 
This reverts commit 24c626c1f7.

Reason for revert: Blocks V8 roll into Chromium (changed error messages cause tests to fail):
https://ci.chromium.org/p/chromium/builders/try/linux-rel/724109?

Original change's description:
> Improve error messages for property access on null/undefined
>
> Only print the property name when accessing null/undefined if we can
> convert it to a string without causing side effects.
> If we can't, omit the property name in the error message.
> This should avoid confusion when the key is an object with toString().
> E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
> Object]' anymore, which was misleading since the property accessed would
> be 'a', but we can't evaluate the key without side effects.
>
> Bug: v8:11365
> Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Commit-Queue: Patrick Thier <pthier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#75250}

Bug: v8:11365
Change-Id: Ic63f34033254f55b3871041633d84ea48586a75d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977374
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75282}
2021-06-21 23:06:41 +00:00
..
ArrayLiterals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
AssignmentsInBinaryExpression.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
AsyncGenerators.golden [debug] Don't put a source position on internal Returns. 2021-03-02 08:42:10 +00:00
AsyncModules.golden [debugger] Don't attach source positions to implicit returns. 2021-04-30 12:33:29 +00:00
BasicBlockToBoolean.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
BasicLoops.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
BreakableBlocks.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CallAndSpread.golden [interpreter] Apply Reflect.apply transform in BytecodeGenerator 2021-03-19 11:02:43 +00:00
CallGlobal.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CallLookupSlot.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CallNew.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CallRuntime.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ClassAndSuperClass.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ClassDeclarations.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CompareNil.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CompareTypeOf.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
CompoundExpressions.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
Conditional.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ConstVariable.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ConstVariableContextSlot.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ContextParameters.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ContextVariables.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CountOperators.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CreateArguments.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
CreateRestParameter.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
DeadCodeRemoval.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
DeclareGlobals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
Delete.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
DeleteLookupSlotInEval.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
DestructuringAssignment.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
DoDebugger.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
Eval.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ForAwaitOf.golden [debugger] Don't attach source positions to implicit returns. 2021-04-30 12:33:29 +00:00
ForIn.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ForOf.golden [debug] Don't put a source position on internal Returns. 2021-03-02 08:42:10 +00:00
ForOfLoop.golden [debugger] Don't attach source positions to implicit returns. 2021-04-30 12:33:29 +00:00
FunctionLiterals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
GenerateTestUndetectable.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
Generators.golden [debug] Don't put a source position on internal Returns. 2021-03-02 08:42:10 +00:00
GlobalCompoundExpressions.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
GlobalCountOperators.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
GlobalDelete.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
HeapNumberConstants.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
IfConditions.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
IIFE.golden Remove one-shot function optimizations. 2021-05-21 12:38:18 +00:00
IntegerConstants.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
LetVariable.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
LetVariableContextSlot.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
LoadGlobal.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
LogicalExpressions.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
LookupSlot.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
LookupSlotInEval.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
Modules.golden [debug] Don't put a source position on internal Returns. 2021-03-02 08:42:10 +00:00
NewAndSpread.golden [interpreter] Apply Reflect.construct transform in BytecodeGenerator 2021-03-19 18:56:24 +00:00
NewTarget.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
ObjectLiterals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
OuterContextVariables.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
Parameters.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
PrimitiveExpressions.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PrimitiveReturnStatements.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
PrivateAccessorAccess.golden Revert "Improve error messages for property access on null/undefined" 2021-06-21 23:06:41 +00:00
PrivateAccessorDeclaration.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PrivateClassFieldAccess.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PrivateClassFields.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PrivateMethodAccess.golden Revert "Improve error messages for property access on null/undefined" 2021-06-21 23:06:41 +00:00
PrivateMethodDeclaration.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PropertyCall.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PropertyLoads.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PropertyLoadStore.golden Remove one-shot function optimizations. 2021-05-21 12:38:18 +00:00
PropertyStores.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
PublicClassFields.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
RegExpLiterals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
RemoveRedundantLdar.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
StandardForLoop.golden [debugger] Don't attach source positions to implicit returns. 2021-04-30 12:33:29 +00:00
StaticClassFields.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
StaticPrivateMethodAccess.golden Revert "Improve error messages for property access on null/undefined" 2021-06-21 23:06:41 +00:00
StaticPrivateMethodDeclaration.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
StoreGlobal.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
StringConcat.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
StringConstants.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
SuperCallAndSpread.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
Switch.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
TemplateLiterals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
ThisFunction.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00
Throw.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
TopLevelObjectLiterals.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
TryCatch.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
TryFinally.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
Typeof.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
UnaryOperators.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
WideRegisters.golden Reland "[interpreter] Short Star bytecode" 2021-02-17 16:18:26 +00:00
WithStatement.golden [interpreter] Make FunctionEntry StackCheck bytecodes implicit 2020-02-10 17:05:23 +00:00