7be64db45f
This is a reland of cf93071c91
Original change's description:
> [interpreter] Short Star bytecode
>
> Design doc:
> https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit
>
> This change adds 16 new interpreter opcodes, kStar0 through kStar15, so
> that we can use a single byte to represent the common operation of
> storing to a low-numbered register. This generally reduces the quantity
> of bytecode generated on web sites by 8-9%.
>
> In order to not degrade speed, a couple of other changes are required:
>
> The existing lookahead logic to check for Star after certain other
> bytecode handlers is updated to check for these new short Star codes
> instead. Furthermore, that lookahead logic is updated to contain its own
> copy of the dispatch jump rather than merging control flow with the
> lookahead-failed case, to improve branch prediction.
>
> A bunch of constants use bytecode size in bytes as a proxy for the size
> or complexity of a function, and are adjusted downward proportionally to
> the decrease in generated bytecode size.
>
> Other small drive-by fix: update generate-bytecode-expectations to emit
> \n instead of \r\n on Windows.
>
> Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#72773}
Change-Id: I1afb670c25694498b3989de615858f984a8c7f6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698057
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72821}
154 lines
4.2 KiB
Plaintext
154 lines
4.2 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 19
|
|
bytecodes: [
|
|
/* 93 E> */ B(CreateRestParameter),
|
|
B(Star2),
|
|
B(Mov), R(closure), R(1),
|
|
/* 93 S> */ B(Ldar), R(1),
|
|
B(GetSuperConstructor), R(4),
|
|
B(ThrowIfNotSuperConstructor), R(4),
|
|
B(Ldar), R(0),
|
|
/* 93 E> */ B(ConstructWithSpread), R(4), R(2), U8(1), U8(0),
|
|
/* 93 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 9
|
|
parameter count: 1
|
|
bytecode array length: 38
|
|
bytecodes: [
|
|
/* 128 E> */ B(CreateRestParameter),
|
|
B(Star3),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(3), R(2),
|
|
/* 140 S> */ B(Ldar), R(closure),
|
|
B(GetSuperConstructor), R(5),
|
|
B(LdaSmi), I8(1),
|
|
B(Star6),
|
|
/* 152 E> */ B(ThrowIfNotSuperConstructor), R(5),
|
|
B(Ldar), R(0),
|
|
B(Mov), R(3), R(7),
|
|
/* 140 E> */ B(ConstructWithSpread), R(5), R(6), U8(2), U8(0),
|
|
B(Star8),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(8), R(this),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 159 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var test;
|
|
(function() {
|
|
class A {
|
|
constructor(...args) { this.baseArgs = args; }
|
|
}
|
|
class B extends A {
|
|
constructor(...args) { super(1, ...args, 1); }
|
|
}
|
|
test = new B(1, 2, 3).constructor;
|
|
})();
|
|
"
|
|
frame size: 11
|
|
parameter count: 1
|
|
bytecode array length: 111
|
|
bytecodes: [
|
|
/* 128 E> */ B(CreateRestParameter),
|
|
B(Star3),
|
|
B(Mov), R(closure), R(1),
|
|
B(Mov), R(3), R(2),
|
|
/* 140 S> */ B(Ldar), R(closure),
|
|
B(GetSuperConstructor), R(5),
|
|
B(CreateEmptyArrayLiteral), U8(0),
|
|
B(Star7),
|
|
B(LdaZero),
|
|
B(Star6),
|
|
B(LdaSmi), I8(1),
|
|
B(StaInArrayLiteral), R(7), R(6), U8(1),
|
|
B(Ldar), R(6),
|
|
B(Inc), U8(3),
|
|
/* 152 S> */ B(Star6),
|
|
/* 152 E> */ B(GetIterator), R(3), U8(4), U8(6),
|
|
B(Mov), R(1), R(4),
|
|
B(JumpIfJSReceiver), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
|
|
B(Star9),
|
|
B(LdaNamedProperty), R(9), U8(0), U8(8),
|
|
B(Star8),
|
|
B(CallProperty0), R(8), R(9), U8(14),
|
|
B(Star10),
|
|
B(JumpIfJSReceiver), U8(7),
|
|
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(10), U8(1),
|
|
B(LdaNamedProperty), R(10), U8(1), U8(16),
|
|
B(JumpIfToBooleanTrue), U8(18),
|
|
B(LdaNamedProperty), R(10), U8(2), U8(10),
|
|
B(StaInArrayLiteral), R(7), R(6), U8(1),
|
|
B(Ldar), R(6),
|
|
B(Inc), U8(3),
|
|
B(Star6),
|
|
B(JumpLoop), U8(31), I8(0),
|
|
B(LdaSmi), I8(1),
|
|
B(StaInArrayLiteral), R(7), R(6), U8(1),
|
|
B(ThrowIfNotSuperConstructor), R(5),
|
|
B(Mov), R(5), R(6),
|
|
B(Mov), R(0), R(8),
|
|
/* 140 E> */ B(CallJSRuntime), U8(%reflect_construct), R(6), U8(3),
|
|
B(Star9),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperAlreadyCalledIfNotHole),
|
|
B(Mov), R(9), R(this),
|
|
B(Ldar), R(this),
|
|
B(ThrowSuperNotCalledIfHole),
|
|
/* 162 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|