AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
c92572ba2f
v8/test/cctest/heap
History
Santiago Aboy Solanes c92572ba2f Revert "[objects] Remove MakeExternal case for uncached internal strings" 
This reverts commit 3a6f75ac94.

Reason for revert: performance regressions https://bugs.chromium.org/p/chromium/issues/detail?id=1163063

Original change's description:
> [objects] Remove MakeExternal case for uncached internal strings
>
> Concurrently accessing internal external uncached strings is not
> thread-safe. We are removing a case where we can make such a string
> through MakeExternal.
>
> Bug: v8:7790
> Change-Id: I958062c15cf40ccc330600bb572de98620866e54
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565511
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#71573}

TBR=leszeks@chromium.org,solanes@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7790
Change-Id: I5dcc734869c3c921eacd89426309141127a85f47
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633547
Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72123}
2021-01-15 20:57:04 +00:00
..
heap-tester.h Reland "Reland "[deoptimizer] Change deopt entries into builtins"" 2020-10-21 06:01:38 +00:00
heap-utils.cc [test] Test for maximum capacity before growing 2020-12-15 16:37:34 +00:00
heap-utils.h [config] Add V8_NODISCARD for Scope classes 2020-11-26 11:08:45 +00:00
test-alloc.cc [factory] Remove unneeded JSFunctionBuilder::set_map calls 2020-11-11 10:46:18 +00:00
test-array-buffer-tracker.cc [cleanup][wasm] Replace min/max with std::min/std::max 2020-11-09 01:50:30 +00:00
test-compaction.cc [cleanup] Replace all remaining Min/Max uses with std::min/max 2020-11-24 17:32:01 +00:00
test-concurrent-allocation.cc Reland "[heap] Introduce LocalIsolate for main thread" 2020-11-19 10:44:43 +00:00
test-concurrent-marking.cc [heap] Split ConcurrentMarking::Stop and update priority 2020-10-23 15:57:50 +00:00
test-embedder-tracing.cc global-handles: Fix ASAN fake stack handling 2020-10-30 13:56:36 +00:00
test-external-string-tracker.cc Reland^2 "[heap] Move start of incremental marking in allocation" 2020-07-14 12:07:34 +00:00
test-heap.cc Revert "[objects] Remove MakeExternal case for uncached internal strings" 2021-01-15 20:57:04 +00:00
test-incremental-marking.cc [test]: Fix platform lifetime in IncrementalMarkingUsingTasks. 2020-11-27 06:58:21 +00:00
test-invalidated-slots.cc [factory] Remove deprecated JSFunction ctors 2020-11-11 06:12:35 +00:00
test-iterators.cc Reland "[heap] Make ReadOnlySpace use bump pointer allocation" 2020-06-18 11:48:38 +00:00
test-lab.cc [torque] Use generated instance types, part 1 2019-10-28 18:30:31 +00:00
test-mark-compact.cc [factory] Remove deprecated JSFunction ctors 2020-11-11 06:12:35 +00:00
test-memory-measurement.cc [factory] Remove deprecated JSFunction ctors 2020-11-11 06:12:35 +00:00
test-page-promotion.cc [test] Tests should only invoke NewSpace::Grow in safepoint 2020-09-24 16:14:10 +00:00
test-spaces.cc [config] Add V8_NODISCARD for Scope classes 2020-11-26 11:08:45 +00:00
test-unmapper.cc [test]: Fix platform lifetime in EagerUnmappingInCollectAllAvailableGarbage. 2020-10-28 09:12:05 +00:00
test-weak-references.cc Reland "Reland "[deoptimizer] Change deopt entries into builtins"" 2020-10-21 06:01:38 +00:00
test-write-barrier.cc [heap] Consolidate marking write barrier logic in MarkingBarrier 2020-07-07 10:34:37 +00:00