AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
dac86be251
v8/test/cctest
History
Clemens Hammacher daa2667990 Remove FixedArray::GetValueChecked 
This method is rarely used, and has several problems:
1) It CHECKs that the value is not undefined, then creates a
   {Handle<T>} which again DCHECKs that the value is of type {T}.
2) It is called on a raw {FixedArray} but returns a handle.
3) It is often used when no handle is actually needed, adding
   unnecessary overhead.
4) It adds complexity and hides actual checks and handlification.

This CL removes that method, replacing some uses by explicit CHECKs (in
tests) and relying on the DCHECKs in the casts otherwise.

R=mstarzinger@chromium.org

Bug: v8:9183
Change-Id: I90ff59e8b78c909a9a207029d8cc9ab16c0c7b56
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621939
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61710}
2019-05-21 17:50:21 +00:00
..
compiler Remove FixedArray::GetValueChecked 2019-05-21 17:50:21 +00:00
heap [roheap] Make all HeapIterators have matching APIs 2019-05-21 16:39:29 +00:00
interpreter Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
libplatform [tracing] Convert COMPLETE events to BEGIN/END pairs for perfetto 2019-05-20 09:13:25 +00:00
libsampler
parsing Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
torque Add StaticAssert in Torque 2019-05-21 15:39:57 +00:00
wasm Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
assembler-helper-arm.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
assembler-helper-arm.h
BUILD.gn Move src/collector.h to test/cctest 2019-05-16 20:55:17 +00:00
cctest.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
cctest.h Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
cctest.status [cleanup] Split stack trace related API cctests into new file 2019-05-15 11:27:04 +00:00
collector.h Move src/collector.h to test/cctest 2019-05-16 20:55:17 +00:00
DEPS
expression-type-collector-macros.h
gay-fixed.cc
gay-fixed.h
gay-precision.cc
gay-precision.h
gay-shortest.cc
gay-shortest.h
log-eq-of-logging-and-traversal.js
OWNERS
print-extension.cc
print-extension.h
profiler-extension.cc
profiler-extension.h
scope-test-helper.h
setup-isolate-for-tests.cc
setup-isolate-for-tests.h Move initialization code into src/init 2019-05-16 12:36:15 +00:00
test-access-checks.cc
test-accessor-assembler.cc
test-accessors.cc Move string-related files to src/strings 2019-05-21 07:17:48 +00:00
test-allocation.cc [zone] Fix peak memory accounting 2019-03-28 13:39:11 +00:00
test-api-accessors.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-api-interceptors.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-api-stack-traces.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-api.cc Reland "[stack-trace] Include API functions in Error.stack stack trace" 2019-05-21 10:40:30 +00:00
test-api.h Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-array-list.cc
test-assembler-arm64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-assembler-arm.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-assembler-ia32.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-assembler-mips64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-assembler-mips.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-assembler-ppc.cc Reland "Move logging and diagnostics related source files" 2019-05-20 09:54:57 +00:00
test-assembler-s390.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-assembler-x64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-atomicops.cc
test-bignum-dtoa.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-bignum.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-bit-vector.cc
test-circular-queue.cc
test-code-layout.cc [cleanup] Switch to CodeBuilder everywhere 2019-04-29 16:48:39 +00:00
test-code-stub-assembler.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-compiler.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-constantpool.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-conversions.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-cpu-profiler.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-date.cc Move date-related files 2019-05-15 13:39:34 +00:00
test-debug.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-decls.cc [Test] Add PrepareForOptimization to cctests 2019-04-30 15:49:02 +00:00
test-deoptimization.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-dictionary.cc
test-disasm-arm64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-arm.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-ia32.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-mips64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-mips.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-ppc.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-s390.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-disasm-x64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-diy-fp.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-double.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-dtoa.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-elements-kind.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-extra.js
test-factory.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-fast-dtoa.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-feedback-vector.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-feedback-vector.h [lite] Allocate feedback vectors lazily 2019-03-25 16:02:38 +00:00
test-field-type-tracking.cc Move relevant files to src/objects 2019-05-20 08:57:47 +00:00
test-fixed-dtoa.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-flags.cc [flags] Receive length as size_t 2019-04-24 10:43:17 +00:00
test-func-name-inference.cc Move string-related files to src/strings 2019-05-21 07:17:48 +00:00
test-fuzz-arm64.cc
test-global-handles.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-global-object.cc
test-hashcode.cc [cleanup] Free 400 targets from the draconic reign of.. 2019-03-26 10:56:21 +00:00
test-hashmap.cc
test-heap-profiler.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-icache.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-identity-map.cc
test-inobject-slack-tracking.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-inspector.cc
test-intl.cc Move relevant files to src/objects 2019-05-20 08:57:47 +00:00
test-javascript-arm64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-js-arm64-variables.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-js-weak-refs.cc
test-liveedit.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-lockers.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-log-stack-tracer.cc Reland "Move logging and diagnostics related source files" 2019-05-20 09:54:57 +00:00
test-log.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-macro-assembler-arm.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-macro-assembler-mips64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-macro-assembler-mips.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-macro-assembler-x64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-managed.cc
test-mementos.cc
test-modules.cc
test-object.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-orderedhashtable.cc
test-parsing.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-platform.cc
test-poison-disasm-arm.cc Reland "Move logging and diagnostics related source files" 2019-05-20 09:54:57 +00:00
test-profile-generator.cc Reland "Move logging and diagnostics related source files" 2019-05-20 09:54:57 +00:00
test-random-number-generator.cc
test-regexp.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-representation.cc Move relevant files to src/objects 2019-05-20 08:57:47 +00:00
test-roots.cc
test-sampler-api.cc PPC/s390: [Profiler] Ensure ticks in frameless bytecode handlers are interpreted frames. 2019-05-02 14:22:13 +00:00
test-serialize.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-smi-lexicographic-compare.cc
test-stack-unwinding-x64.cc [Test] Add PrepareForOptimization to cctests 2019-04-30 15:49:02 +00:00
test-strings.cc Move string-related files to src/strings 2019-05-21 07:17:48 +00:00
test-strtod.cc Move number related files to src/numbers 2019-05-15 19:34:44 +00:00
test-symbols.cc
test-sync-primitives-arm64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-sync-primitives-arm.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-thread-termination.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-threads.cc Clean up ThreadId 2019-03-11 10:37:05 +00:00
test-trace-event.cc [cleanup] Clean up trace event tests by removing macros 2019-03-25 13:46:58 +00:00
test-traced-value.cc [tracing] Improve tracing signals for compilation/optimization. 2019-03-25 14:49:08 +00:00
test-transitions.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-transitions.h Move relevant files to src/objects 2019-05-20 08:57:47 +00:00
test-typedarrays.cc
test-types.cc
test-unboxed-doubles.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-unscopables-hidden-prototype.cc
test-unwinder.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-usecounters.cc
test-utils-arm64.cc Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-utils-arm64.h Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
test-utils.cc Reland "Move API-related files" 2019-05-17 12:52:27 +00:00
test-version.cc [cleanup] Use Vector::begin instead of Vector::start 2019-04-29 12:43:16 +00:00
test-weakmaps.cc Reland "[heap] Clean-up keys of oldspace weakmaps during scavenge" 2019-04-01 13:59:56 +00:00
test-weaksets.cc Retire PretenureFlag and use AllocationType everywhere. 2019-03-12 08:10:44 +00:00
testcfg.py Reland "Preparing v8 to use with python3 /test" 2019-03-20 09:56:06 +00:00
trace-extension.cc
trace-extension.h
unicode-helpers.cc Move string-related files to src/strings 2019-05-21 07:17:48 +00:00
unicode-helpers.h Move string-related files to src/strings 2019-05-21 07:17:48 +00:00