2017-08-18 23:52:05 +00:00
|
|
|
/*
|
2016-08-30 17:04:33 +00:00
|
|
|
* Copyright (c) 2016-present, Yann Collet, Facebook, Inc.
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
2017-08-18 23:52:05 +00:00
|
|
|
* This source code is licensed under both the BSD-style license (found in the
|
|
|
|
* LICENSE file in the root directory of this source tree) and the GPLv2 (found
|
|
|
|
* in the COPYING file in the root directory of this source tree).
|
2017-09-08 07:09:23 +00:00
|
|
|
* You may select, at your option, one of the above-listed licenses.
|
2016-08-30 17:04:33 +00:00
|
|
|
*/
|
2015-01-24 00:58:16 +00:00
|
|
|
|
|
|
|
|
2017-01-20 00:59:56 +00:00
|
|
|
/* **************************************
|
|
|
|
* Tuning parameters
|
|
|
|
****************************************/
|
|
|
|
#ifndef BMK_TIMETEST_DEFAULT_S /* default minimum time per test */
|
|
|
|
#define BMK_TIMETEST_DEFAULT_S 3
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
2015-10-22 14:31:46 +00:00
|
|
|
/* *************************************
|
2015-01-24 00:58:16 +00:00
|
|
|
* Includes
|
2015-10-22 14:31:46 +00:00
|
|
|
***************************************/
|
2016-12-21 14:08:44 +00:00
|
|
|
#include "platform.h" /* Large Files support */
|
2016-12-21 12:23:34 +00:00
|
|
|
#include "util.h" /* UTIL_getFileSize, UTIL_sleep */
|
2015-01-24 00:58:16 +00:00
|
|
|
#include <stdlib.h> /* malloc, free */
|
2018-12-21 01:27:08 +00:00
|
|
|
#include <string.h> /* memset, strerror */
|
2016-12-31 02:31:26 +00:00
|
|
|
#include <stdio.h> /* fprintf, fopen */
|
2018-12-21 01:20:07 +00:00
|
|
|
#include <errno.h>
|
2018-02-20 22:48:09 +00:00
|
|
|
#include <assert.h> /* assert */
|
2016-03-29 12:52:13 +00:00
|
|
|
|
2019-04-10 19:37:03 +00:00
|
|
|
#include "timefn.h" /* UTIL_time_t */
|
2018-11-13 19:01:59 +00:00
|
|
|
#include "benchfn.h"
|
2015-10-22 14:31:46 +00:00
|
|
|
#include "mem.h"
|
2016-06-04 17:47:02 +00:00
|
|
|
#define ZSTD_STATIC_LINKING_ONLY
|
|
|
|
#include "zstd.h"
|
2016-04-28 10:23:33 +00:00
|
|
|
#include "datagen.h" /* RDG_genBuffer */
|
2015-01-24 00:58:16 +00:00
|
|
|
#include "xxhash.h"
|
2018-11-13 19:01:59 +00:00
|
|
|
#include "benchzstd.h"
|
2018-06-23 00:25:16 +00:00
|
|
|
#include "zstd_errors.h"
|
2015-01-24 00:58:16 +00:00
|
|
|
|
|
|
|
|
2015-10-22 14:31:46 +00:00
|
|
|
/* *************************************
|
2015-01-24 00:58:16 +00:00
|
|
|
* Constants
|
2015-10-22 14:31:46 +00:00
|
|
|
***************************************/
|
2016-06-22 13:42:26 +00:00
|
|
|
#ifndef ZSTD_GIT_COMMIT
|
2016-06-22 14:13:25 +00:00
|
|
|
# define ZSTD_GIT_COMMIT_STRING ""
|
|
|
|
#else
|
|
|
|
# define ZSTD_GIT_COMMIT_STRING ZSTD_EXPAND_AND_QUOTE(ZSTD_GIT_COMMIT)
|
2016-06-22 13:42:26 +00:00
|
|
|
#endif
|
|
|
|
|
2018-02-20 22:48:09 +00:00
|
|
|
#define TIMELOOP_MICROSEC (1*1000000ULL) /* 1 second */
|
|
|
|
#define TIMELOOP_NANOSEC (1*1000000000ULL) /* 1 second */
|
|
|
|
#define ACTIVEPERIOD_MICROSEC (70*TIMELOOP_MICROSEC) /* 70 seconds */
|
2016-04-28 11:16:01 +00:00
|
|
|
#define COOLPERIOD_SEC 10
|
2015-01-24 00:58:16 +00:00
|
|
|
|
|
|
|
#define KB *(1 <<10)
|
|
|
|
#define MB *(1 <<20)
|
|
|
|
#define GB *(1U<<30)
|
|
|
|
|
2018-08-28 18:21:09 +00:00
|
|
|
#define BMK_RUNTEST_DEFAULT_MS 1000
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
static const size_t maxMemory = (sizeof(size_t)==4) ?
|
|
|
|
/* 32-bit */ (2 GB - 64 MB) :
|
|
|
|
/* 64-bit */ (size_t)(1ULL << ((sizeof(size_t)*8)-31));
|
|
|
|
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2015-10-22 14:31:46 +00:00
|
|
|
/* *************************************
|
2015-12-16 01:37:24 +00:00
|
|
|
* console display
|
2015-10-22 14:31:46 +00:00
|
|
|
***************************************/
|
2015-12-16 01:37:24 +00:00
|
|
|
#define DISPLAY(...) fprintf(stderr, __VA_ARGS__)
|
2018-06-11 14:59:05 +00:00
|
|
|
#define DISPLAYLEVEL(l, ...) if (displayLevel>=l) { DISPLAY(__VA_ARGS__); }
|
|
|
|
/* 0 : no display; 1: errors; 2 : + result + interaction + warnings; 3 : + progression; 4 : + information */
|
2015-12-16 01:37:24 +00:00
|
|
|
|
2017-11-30 03:11:12 +00:00
|
|
|
static const U64 g_refreshRate = SEC_TO_MICRO / 6;
|
|
|
|
static UTIL_time_t g_displayClock = UTIL_TIME_INITIALIZER;
|
|
|
|
|
2018-06-11 14:59:05 +00:00
|
|
|
#define DISPLAYUPDATE(l, ...) { if (displayLevel>=l) { \
|
|
|
|
if ((UTIL_clockSpanMicro(g_displayClock) > g_refreshRate) || (displayLevel>=4)) \
|
2017-11-30 03:11:12 +00:00
|
|
|
{ g_displayClock = UTIL_getTime(); DISPLAY(__VA_ARGS__); \
|
2018-06-11 14:59:05 +00:00
|
|
|
if (displayLevel>=4) fflush(stderr); } } }
|
2016-08-02 21:48:13 +00:00
|
|
|
|
2015-12-16 01:37:24 +00:00
|
|
|
|
|
|
|
/* *************************************
|
|
|
|
* Exceptions
|
|
|
|
***************************************/
|
|
|
|
#ifndef DEBUG
|
2018-07-13 00:30:39 +00:00
|
|
|
# define DEBUG 0
|
2015-12-16 01:37:24 +00:00
|
|
|
#endif
|
2017-06-19 22:23:19 +00:00
|
|
|
#define DEBUGOUTPUT(...) { if (DEBUG) DISPLAY(__VA_ARGS__); }
|
2018-06-12 19:54:43 +00:00
|
|
|
|
2019-10-15 23:09:18 +00:00
|
|
|
#define RETURN_ERROR_INT(errorNum, ...) { \
|
2017-06-19 22:23:19 +00:00
|
|
|
DEBUGOUTPUT("%s: %i: \n", __FILE__, __LINE__); \
|
2018-06-12 19:54:43 +00:00
|
|
|
DISPLAYLEVEL(1, "Error %i : ", errorNum); \
|
2018-06-11 14:59:05 +00:00
|
|
|
DISPLAYLEVEL(1, __VA_ARGS__); \
|
|
|
|
DISPLAYLEVEL(1, " \n"); \
|
2018-06-12 19:54:43 +00:00
|
|
|
return errorNum; \
|
2015-12-16 01:37:24 +00:00
|
|
|
}
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-12-07 03:27:37 +00:00
|
|
|
#define CHECK_Z(zf) { \
|
|
|
|
size_t const zerr = zf; \
|
|
|
|
if (ZSTD_isError(zerr)) { \
|
|
|
|
DEBUGOUTPUT("%s: %i: \n", __FILE__, __LINE__); \
|
|
|
|
DISPLAY("Error : "); \
|
|
|
|
DISPLAY("%s failed : %s", \
|
|
|
|
#zf, ZSTD_getErrorName(zerr)); \
|
|
|
|
DISPLAY(" \n"); \
|
|
|
|
exit(1); \
|
|
|
|
} \
|
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
#define RETURN_ERROR(errorNum, retType, ...) { \
|
2018-06-12 19:54:43 +00:00
|
|
|
retType r; \
|
|
|
|
memset(&r, 0, sizeof(retType)); \
|
|
|
|
DEBUGOUTPUT("%s: %i: \n", __FILE__, __LINE__); \
|
|
|
|
DISPLAYLEVEL(1, "Error %i : ", errorNum); \
|
|
|
|
DISPLAYLEVEL(1, __VA_ARGS__); \
|
|
|
|
DISPLAYLEVEL(1, " \n"); \
|
2018-08-23 21:21:18 +00:00
|
|
|
r.tag = errorNum; \
|
2018-06-12 19:54:43 +00:00
|
|
|
return r; \
|
|
|
|
}
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-06-15 20:21:08 +00:00
|
|
|
|
2015-10-22 14:31:46 +00:00
|
|
|
/* *************************************
|
2015-01-24 00:58:16 +00:00
|
|
|
* Benchmark Parameters
|
2015-10-22 14:31:46 +00:00
|
|
|
***************************************/
|
2016-03-23 19:30:26 +00:00
|
|
|
|
2018-08-22 01:19:27 +00:00
|
|
|
BMK_advancedParams_t BMK_initAdvancedParams(void) {
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_advancedParams_t const res = {
|
2018-06-14 18:46:17 +00:00
|
|
|
BMK_both, /* mode */
|
2018-06-12 19:54:43 +00:00
|
|
|
BMK_TIMETEST_DEFAULT_S, /* nbSeconds */
|
|
|
|
0, /* blockSize */
|
|
|
|
0, /* nbWorkers */
|
|
|
|
0, /* realTime */
|
|
|
|
0, /* additionalParam */
|
2018-08-22 01:19:27 +00:00
|
|
|
0, /* ldmFlag */
|
2018-06-12 19:54:43 +00:00
|
|
|
0, /* ldmMinMatch */
|
|
|
|
0, /* ldmHashLog */
|
2018-06-23 00:25:16 +00:00
|
|
|
0, /* ldmBuckSizeLog */
|
2019-02-15 23:24:55 +00:00
|
|
|
0, /* ldmHashRateLog */
|
|
|
|
ZSTD_lcm_auto /* literalCompressionMode */
|
2018-06-12 19:54:43 +00:00
|
|
|
};
|
|
|
|
return res;
|
|
|
|
}
|
2018-06-11 14:59:05 +00:00
|
|
|
|
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
/* ********************************************************
|
|
|
|
* Bench functions
|
|
|
|
**********************************************************/
|
|
|
|
typedef struct {
|
|
|
|
const void* srcPtr;
|
|
|
|
size_t srcSize;
|
|
|
|
void* cPtr;
|
|
|
|
size_t cRoom;
|
|
|
|
size_t cSize;
|
|
|
|
void* resPtr;
|
|
|
|
size_t resSize;
|
|
|
|
} blockParam_t;
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
#undef MIN
|
|
|
|
#undef MAX
|
|
|
|
#define MIN(a,b) ((a) < (b) ? (a) : (b))
|
|
|
|
#define MAX(a,b) ((a) > (b) ? (a) : (b))
|
2018-06-11 14:59:05 +00:00
|
|
|
|
2019-01-25 23:11:50 +00:00
|
|
|
static void
|
|
|
|
BMK_initCCtx(ZSTD_CCtx* ctx,
|
|
|
|
const void* dictBuffer, size_t dictBufferSize,
|
|
|
|
int cLevel,
|
|
|
|
const ZSTD_compressionParameters* comprParams,
|
|
|
|
const BMK_advancedParams_t* adv)
|
|
|
|
{
|
2018-11-16 00:12:39 +00:00
|
|
|
ZSTD_CCtx_reset(ctx, ZSTD_reset_session_and_parameters);
|
2018-06-12 19:54:43 +00:00
|
|
|
if (adv->nbWorkers==1) {
|
2018-12-07 03:27:37 +00:00
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_nbWorkers, 0));
|
2018-06-12 19:54:43 +00:00
|
|
|
} else {
|
2018-12-07 03:27:37 +00:00
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_nbWorkers, adv->nbWorkers));
|
2018-06-12 19:54:43 +00:00
|
|
|
}
|
2018-12-07 03:27:37 +00:00
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_compressionLevel, cLevel));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_enableLongDistanceMatching, adv->ldmFlag));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_ldmMinMatch, adv->ldmMinMatch));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_ldmHashLog, adv->ldmHashLog));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_ldmBucketSizeLog, adv->ldmBucketSizeLog));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_ldmHashRateLog, adv->ldmHashRateLog));
|
2019-01-25 23:11:50 +00:00
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_windowLog, (int)comprParams->windowLog));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_hashLog, (int)comprParams->hashLog));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_chainLog, (int)comprParams->chainLog));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_searchLog, (int)comprParams->searchLog));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_minMatch, (int)comprParams->minMatch));
|
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_targetLength, (int)comprParams->targetLength));
|
2019-02-15 23:24:55 +00:00
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_literalCompressionMode, (int)adv->literalCompressionMode));
|
2018-12-07 03:27:37 +00:00
|
|
|
CHECK_Z(ZSTD_CCtx_setParameter(ctx, ZSTD_c_strategy, comprParams->strategy));
|
|
|
|
CHECK_Z(ZSTD_CCtx_loadDictionary(ctx, dictBuffer, dictBufferSize));
|
2015-10-21 07:22:25 +00:00
|
|
|
}
|
|
|
|
|
2018-08-22 01:19:27 +00:00
|
|
|
static void BMK_initDCtx(ZSTD_DCtx* dctx,
|
2018-06-12 19:54:43 +00:00
|
|
|
const void* dictBuffer, size_t dictBufferSize) {
|
2018-12-07 03:27:37 +00:00
|
|
|
CHECK_Z(ZSTD_DCtx_reset(dctx, ZSTD_reset_session_and_parameters));
|
|
|
|
CHECK_Z(ZSTD_DCtx_loadDictionary(dctx, dictBuffer, dictBufferSize));
|
2017-01-20 00:59:56 +00:00
|
|
|
}
|
2017-11-17 08:02:37 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
typedef struct {
|
2018-08-23 21:21:18 +00:00
|
|
|
ZSTD_CCtx* cctx;
|
2018-06-12 19:54:43 +00:00
|
|
|
const void* dictBuffer;
|
|
|
|
size_t dictBufferSize;
|
|
|
|
int cLevel;
|
|
|
|
const ZSTD_compressionParameters* comprParams;
|
|
|
|
const BMK_advancedParams_t* adv;
|
|
|
|
} BMK_initCCtxArgs;
|
|
|
|
|
|
|
|
static size_t local_initCCtx(void* payload) {
|
|
|
|
BMK_initCCtxArgs* ag = (BMK_initCCtxArgs*)payload;
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_initCCtx(ag->cctx, ag->dictBuffer, ag->dictBufferSize, ag->cLevel, ag->comprParams, ag->adv);
|
2018-06-12 19:54:43 +00:00
|
|
|
return 0;
|
2017-11-17 08:02:37 +00:00
|
|
|
}
|
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
typedef struct {
|
|
|
|
ZSTD_DCtx* dctx;
|
|
|
|
const void* dictBuffer;
|
|
|
|
size_t dictBufferSize;
|
|
|
|
} BMK_initDCtxArgs;
|
|
|
|
|
|
|
|
static size_t local_initDCtx(void* payload) {
|
|
|
|
BMK_initDCtxArgs* ag = (BMK_initDCtxArgs*)payload;
|
|
|
|
BMK_initDCtx(ag->dctx, ag->dictBuffer, ag->dictBufferSize);
|
|
|
|
return 0;
|
2017-11-17 08:22:55 +00:00
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
|
|
|
|
/* `addArgs` is the context */
|
2018-06-12 19:54:43 +00:00
|
|
|
static size_t local_defaultCompress(
|
2018-08-23 21:21:18 +00:00
|
|
|
const void* srcBuffer, size_t srcSize,
|
|
|
|
void* dstBuffer, size_t dstSize,
|
|
|
|
void* addArgs)
|
|
|
|
{
|
|
|
|
ZSTD_CCtx* const cctx = (ZSTD_CCtx*)addArgs;
|
2018-11-30 19:16:26 +00:00
|
|
|
return ZSTD_compress2(cctx, dstBuffer, dstSize, srcBuffer, srcSize);
|
2017-07-28 22:51:33 +00:00
|
|
|
}
|
2016-12-27 06:19:36 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
/* `addArgs` is the context */
|
2018-06-12 19:54:43 +00:00
|
|
|
static size_t local_defaultDecompress(
|
2018-08-23 21:21:18 +00:00
|
|
|
const void* srcBuffer, size_t srcSize,
|
2018-08-28 22:47:07 +00:00
|
|
|
void* dstBuffer, size_t dstCapacity,
|
2018-08-23 21:21:18 +00:00
|
|
|
void* addArgs)
|
|
|
|
{
|
2018-06-12 19:54:43 +00:00
|
|
|
size_t moreToFlush = 1;
|
2018-08-23 21:21:18 +00:00
|
|
|
ZSTD_DCtx* const dctx = (ZSTD_DCtx*)addArgs;
|
2018-06-12 19:54:43 +00:00
|
|
|
ZSTD_inBuffer in;
|
|
|
|
ZSTD_outBuffer out;
|
2018-08-23 21:21:18 +00:00
|
|
|
in.src = srcBuffer; in.size = srcSize; in.pos = 0;
|
2018-08-28 22:47:07 +00:00
|
|
|
out.dst = dstBuffer; out.size = dstCapacity; out.pos = 0;
|
2018-06-12 19:54:43 +00:00
|
|
|
while (moreToFlush) {
|
2018-06-23 00:25:16 +00:00
|
|
|
if(out.pos == out.size) {
|
|
|
|
return (size_t)-ZSTD_error_dstSize_tooSmall;
|
|
|
|
}
|
2018-12-04 18:28:36 +00:00
|
|
|
moreToFlush = ZSTD_decompressStream(dctx, &out, &in);
|
2018-06-12 19:54:43 +00:00
|
|
|
if (ZSTD_isError(moreToFlush)) {
|
|
|
|
return moreToFlush;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return out.pos;
|
2017-09-01 21:52:51 +00:00
|
|
|
|
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
|
|
|
|
/* ================================================================= */
|
|
|
|
/* Benchmark Zstandard, mem-to-mem scenarios */
|
|
|
|
/* ================================================================= */
|
|
|
|
|
|
|
|
int BMK_isSuccessful_benchOutcome(BMK_benchOutcome_t outcome)
|
|
|
|
{
|
|
|
|
return outcome.tag == 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
BMK_benchResult_t BMK_extract_benchResult(BMK_benchOutcome_t outcome)
|
|
|
|
{
|
|
|
|
assert(outcome.tag == 0);
|
|
|
|
return outcome.internal_never_use_directly;
|
|
|
|
}
|
|
|
|
|
2018-08-24 22:59:57 +00:00
|
|
|
static BMK_benchOutcome_t BMK_benchOutcome_error(void)
|
2018-08-23 21:21:18 +00:00
|
|
|
{
|
|
|
|
BMK_benchOutcome_t b;
|
|
|
|
memset(&b, 0, sizeof(b));
|
|
|
|
b.tag = 1;
|
|
|
|
return b;
|
|
|
|
}
|
|
|
|
|
|
|
|
static BMK_benchOutcome_t BMK_benchOutcome_setValidResult(BMK_benchResult_t result)
|
|
|
|
{
|
|
|
|
BMK_benchOutcome_t b;
|
|
|
|
b.tag = 0;
|
|
|
|
b.internal_never_use_directly = result;
|
|
|
|
return b;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-06-19 17:58:22 +00:00
|
|
|
/* benchMem with no allocation */
|
2018-11-08 20:36:39 +00:00
|
|
|
static BMK_benchOutcome_t
|
|
|
|
BMK_benchMemAdvancedNoAlloc(
|
|
|
|
const void** srcPtrs, size_t* srcSizes,
|
|
|
|
void** cPtrs, size_t* cCapacities, size_t* cSizes,
|
|
|
|
void** resPtrs, size_t* resSizes,
|
|
|
|
void** resultBufferPtr, void* compressedBuffer,
|
|
|
|
size_t maxCompressedSize,
|
|
|
|
BMK_timedFnState_t* timeStateCompress,
|
|
|
|
BMK_timedFnState_t* timeStateDecompress,
|
|
|
|
|
|
|
|
const void* srcBuffer, size_t srcSize,
|
|
|
|
const size_t* fileSizes, unsigned nbFiles,
|
|
|
|
const int cLevel,
|
|
|
|
const ZSTD_compressionParameters* comprParams,
|
|
|
|
const void* dictBuffer, size_t dictBufferSize,
|
|
|
|
ZSTD_CCtx* cctx, ZSTD_DCtx* dctx,
|
|
|
|
int displayLevel, const char* displayName,
|
|
|
|
const BMK_advancedParams_t* adv)
|
2015-01-24 00:58:16 +00:00
|
|
|
{
|
2018-08-24 01:04:50 +00:00
|
|
|
size_t const blockSize = ((adv->blockSize>=32 && (adv->mode != BMK_decodeOnly)) ? adv->blockSize : srcSize) + (!srcSize); /* avoid div by 0 */
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_benchResult_t benchResult;
|
2016-12-07 01:46:49 +00:00
|
|
|
size_t const loadedCompressedSize = srcSize;
|
|
|
|
size_t cSize = 0;
|
|
|
|
double ratio = 0.;
|
2016-03-20 14:46:10 +00:00
|
|
|
U32 nbBlocks;
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
assert(cctx != NULL); assert(dctx != NULL);
|
2018-06-11 14:59:05 +00:00
|
|
|
|
2016-03-20 14:46:10 +00:00
|
|
|
/* init */
|
2018-08-24 01:04:50 +00:00
|
|
|
memset(&benchResult, 0, sizeof(benchResult));
|
2018-08-23 21:21:18 +00:00
|
|
|
if (strlen(displayName)>17) displayName += strlen(displayName) - 17; /* display last 17 characters */
|
2018-06-14 18:46:17 +00:00
|
|
|
if (adv->mode == BMK_decodeOnly) { /* benchmark only decompression : source must be already compressed */
|
2017-04-04 22:35:06 +00:00
|
|
|
const char* srcPtr = (const char*)srcBuffer;
|
|
|
|
U64 totalDSize64 = 0;
|
2016-12-07 01:46:49 +00:00
|
|
|
U32 fileNb;
|
|
|
|
for (fileNb=0; fileNb<nbFiles; fileNb++) {
|
2017-02-07 21:50:09 +00:00
|
|
|
U64 const fSize64 = ZSTD_findDecompressedSize(srcPtr, fileSizes[fileNb]);
|
2018-08-23 21:21:18 +00:00
|
|
|
if (fSize64==0) RETURN_ERROR(32, BMK_benchOutcome_t, "Impossible to determine original size ");
|
2017-04-04 22:35:06 +00:00
|
|
|
totalDSize64 += fSize64;
|
2016-12-07 01:46:49 +00:00
|
|
|
srcPtr += fileSizes[fileNb];
|
|
|
|
}
|
2017-04-04 22:35:06 +00:00
|
|
|
{ size_t const decodedSize = (size_t)totalDSize64;
|
2018-08-23 21:21:18 +00:00
|
|
|
assert((U64)decodedSize == totalDSize64); /* check overflow */
|
2018-06-18 18:59:45 +00:00
|
|
|
free(*resultBufferPtr);
|
|
|
|
*resultBufferPtr = malloc(decodedSize);
|
|
|
|
if (!(*resultBufferPtr)) {
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(33, BMK_benchOutcome_t, "not enough memory");
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-08-23 21:21:18 +00:00
|
|
|
if (totalDSize64 > decodedSize) { /* size_t overflow */
|
2018-08-22 01:19:27 +00:00
|
|
|
free(*resultBufferPtr);
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(32, BMK_benchOutcome_t, "original size is too large");
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2016-12-07 01:46:49 +00:00
|
|
|
cSize = srcSize;
|
|
|
|
srcSize = decodedSize;
|
|
|
|
ratio = (double)srcSize / (double)cSize;
|
2018-08-22 01:19:27 +00:00
|
|
|
}
|
2018-06-12 19:54:43 +00:00
|
|
|
}
|
2016-12-07 01:46:49 +00:00
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
/* Init data blocks */
|
2016-12-07 01:46:49 +00:00
|
|
|
{ const char* srcPtr = (const char*)srcBuffer;
|
2015-10-21 07:22:25 +00:00
|
|
|
char* cPtr = (char*)compressedBuffer;
|
2018-06-18 18:59:45 +00:00
|
|
|
char* resPtr = (char*)(*resultBufferPtr);
|
2016-03-17 18:37:33 +00:00
|
|
|
U32 fileNb;
|
2016-03-20 14:46:10 +00:00
|
|
|
for (nbBlocks=0, fileNb=0; fileNb<nbFiles; fileNb++) {
|
2015-12-16 02:01:03 +00:00
|
|
|
size_t remaining = fileSizes[fileNb];
|
2018-06-14 18:46:17 +00:00
|
|
|
U32 const nbBlocksforThisFile = (adv->mode == BMK_decodeOnly) ? 1 : (U32)((remaining + (blockSize-1)) / blockSize);
|
2016-03-17 18:37:33 +00:00
|
|
|
U32 const blockEnd = nbBlocks + nbBlocksforThisFile;
|
2016-01-30 02:14:15 +00:00
|
|
|
for ( ; nbBlocks<blockEnd; nbBlocks++) {
|
2016-03-20 14:46:10 +00:00
|
|
|
size_t const thisBlockSize = MIN(remaining, blockSize);
|
2018-08-23 21:21:18 +00:00
|
|
|
srcPtrs[nbBlocks] = srcPtr;
|
2018-06-12 19:54:43 +00:00
|
|
|
srcSizes[nbBlocks] = thisBlockSize;
|
2018-08-23 21:21:18 +00:00
|
|
|
cPtrs[nbBlocks] = cPtr;
|
2018-07-20 21:35:09 +00:00
|
|
|
cCapacities[nbBlocks] = (adv->mode == BMK_decodeOnly) ? thisBlockSize : ZSTD_compressBound(thisBlockSize);
|
2018-08-23 21:21:18 +00:00
|
|
|
resPtrs[nbBlocks] = resPtr;
|
2018-06-14 18:46:17 +00:00
|
|
|
resSizes[nbBlocks] = (adv->mode == BMK_decodeOnly) ? (size_t) ZSTD_findDecompressedSize(srcPtr, thisBlockSize) : thisBlockSize;
|
2015-12-16 01:37:24 +00:00
|
|
|
srcPtr += thisBlockSize;
|
2018-07-20 21:35:09 +00:00
|
|
|
cPtr += cCapacities[nbBlocks];
|
2015-12-16 01:37:24 +00:00
|
|
|
resPtr += thisBlockSize;
|
|
|
|
remaining -= thisBlockSize;
|
2018-11-13 22:15:12 +00:00
|
|
|
if (adv->mode == BMK_decodeOnly) {
|
2018-11-08 20:47:46 +00:00
|
|
|
assert(nbBlocks==0);
|
|
|
|
cSizes[nbBlocks] = thisBlockSize;
|
|
|
|
benchResult.cSize = thisBlockSize;
|
|
|
|
}
|
2018-08-22 01:19:27 +00:00
|
|
|
}
|
|
|
|
}
|
2018-06-12 19:54:43 +00:00
|
|
|
}
|
2015-10-21 07:22:25 +00:00
|
|
|
|
2019-04-12 18:18:11 +00:00
|
|
|
/* warming up `compressedBuffer` */
|
2018-06-14 18:46:17 +00:00
|
|
|
if (adv->mode == BMK_decodeOnly) {
|
2018-03-05 21:50:07 +00:00
|
|
|
memcpy(compressedBuffer, srcBuffer, loadedCompressedSize);
|
|
|
|
} else {
|
|
|
|
RDG_genBuffer(compressedBuffer, maxCompressedSize, 0.10, 0.50, 1);
|
|
|
|
}
|
2015-01-24 00:58:16 +00:00
|
|
|
|
|
|
|
/* Bench */
|
2018-08-23 21:21:18 +00:00
|
|
|
{ U64 const crcOrig = (adv->mode == BMK_decodeOnly) ? 0 : XXH64(srcBuffer, srcSize, 0);
|
2016-08-01 11:37:17 +00:00
|
|
|
# define NB_MARKS 4
|
2018-08-23 21:21:18 +00:00
|
|
|
const char* marks[NB_MARKS] = { " |", " /", " =", " \\" };
|
2016-08-01 11:37:17 +00:00
|
|
|
U32 markNb = 0;
|
2018-08-23 21:21:18 +00:00
|
|
|
int compressionCompleted = (adv->mode == BMK_decodeOnly);
|
|
|
|
int decompressionCompleted = (adv->mode == BMK_compressOnly);
|
2018-11-13 21:05:39 +00:00
|
|
|
BMK_benchParams_t cbp, dbp;
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_initCCtxArgs cctxprep;
|
|
|
|
BMK_initDCtxArgs dctxprep;
|
2018-11-13 21:05:39 +00:00
|
|
|
|
2019-10-15 23:09:18 +00:00
|
|
|
cbp.benchFn = local_defaultCompress; /* ZSTD_compress2 */
|
2018-11-13 21:05:39 +00:00
|
|
|
cbp.benchPayload = cctx;
|
2019-10-15 23:09:18 +00:00
|
|
|
cbp.initFn = local_initCCtx; /* BMK_initCCtx */
|
2018-11-13 21:05:39 +00:00
|
|
|
cbp.initPayload = &cctxprep;
|
|
|
|
cbp.errorFn = ZSTD_isError;
|
|
|
|
cbp.blockCount = nbBlocks;
|
|
|
|
cbp.srcBuffers = srcPtrs;
|
|
|
|
cbp.srcSizes = srcSizes;
|
|
|
|
cbp.dstBuffers = cPtrs;
|
|
|
|
cbp.dstCapacities = cCapacities;
|
|
|
|
cbp.blockResults = cSizes;
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
cctxprep.cctx = cctx;
|
|
|
|
cctxprep.dictBuffer = dictBuffer;
|
|
|
|
cctxprep.dictBufferSize = dictBufferSize;
|
|
|
|
cctxprep.cLevel = cLevel;
|
|
|
|
cctxprep.comprParams = comprParams;
|
|
|
|
cctxprep.adv = adv;
|
2018-11-13 21:05:39 +00:00
|
|
|
|
|
|
|
dbp.benchFn = local_defaultDecompress;
|
|
|
|
dbp.benchPayload = dctx;
|
|
|
|
dbp.initFn = local_initDCtx;
|
|
|
|
dbp.initPayload = &dctxprep;
|
|
|
|
dbp.errorFn = ZSTD_isError;
|
|
|
|
dbp.blockCount = nbBlocks;
|
|
|
|
dbp.srcBuffers = (const void* const *) cPtrs;
|
|
|
|
dbp.srcSizes = cSizes;
|
|
|
|
dbp.dstBuffers = resPtrs;
|
|
|
|
dbp.dstCapacities = resSizes;
|
|
|
|
dbp.blockResults = NULL;
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
dctxprep.dctx = dctx;
|
|
|
|
dctxprep.dictBuffer = dictBuffer;
|
|
|
|
dctxprep.dictBufferSize = dictBufferSize;
|
|
|
|
|
|
|
|
DISPLAYLEVEL(2, "\r%70s\r", ""); /* blank line */
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAYLEVEL(2, "%2s-%-17.17s :%10u ->\r", marks[markNb], displayName, (unsigned)srcSize);
|
2018-06-25 22:01:03 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
while (!(compressionCompleted && decompressionCompleted)) {
|
|
|
|
if (!compressionCompleted) {
|
2018-11-13 21:05:39 +00:00
|
|
|
BMK_runOutcome_t const cOutcome = BMK_benchTimedFn( timeStateCompress, cbp);
|
2018-08-23 21:21:18 +00:00
|
|
|
|
2018-08-25 00:28:38 +00:00
|
|
|
if (!BMK_isSuccessful_runOutcome(cOutcome)) {
|
2018-08-23 21:21:18 +00:00
|
|
|
return BMK_benchOutcome_error();
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-06-25 22:01:03 +00:00
|
|
|
|
2018-08-25 00:28:38 +00:00
|
|
|
{ BMK_runTime_t const cResult = BMK_extract_runTime(cOutcome);
|
2018-08-23 21:21:18 +00:00
|
|
|
cSize = cResult.sumOfReturn;
|
|
|
|
ratio = (double)srcSize / cSize;
|
2018-08-24 01:04:50 +00:00
|
|
|
{ BMK_benchResult_t newResult;
|
2019-01-25 23:11:50 +00:00
|
|
|
newResult.cSpeed = (U64)((double)srcSize * TIMELOOP_NANOSEC / cResult.nanoSecPerRun);
|
2018-08-24 01:04:50 +00:00
|
|
|
benchResult.cSize = cSize;
|
|
|
|
if (newResult.cSpeed > benchResult.cSpeed)
|
|
|
|
benchResult.cSpeed = newResult.cSpeed;
|
|
|
|
} }
|
|
|
|
|
|
|
|
{ int const ratioAccuracy = (ratio < 10.) ? 3 : 2;
|
2018-08-23 21:21:18 +00:00
|
|
|
DISPLAYLEVEL(2, "%2s-%-17.17s :%10u ->%10u (%5.*f),%6.*f MB/s\r",
|
2018-08-24 01:04:50 +00:00
|
|
|
marks[markNb], displayName,
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
(unsigned)srcSize, (unsigned)cSize,
|
2018-08-23 21:21:18 +00:00
|
|
|
ratioAccuracy, ratio,
|
2018-08-23 23:03:30 +00:00
|
|
|
benchResult.cSpeed < (10 MB) ? 2 : 1, (double)benchResult.cSpeed / MB_UNIT);
|
2018-08-23 21:21:18 +00:00
|
|
|
}
|
2018-08-27 04:30:18 +00:00
|
|
|
compressionCompleted = BMK_isCompleted_TimedFn(timeStateCompress);
|
2018-08-23 21:21:18 +00:00
|
|
|
}
|
2018-06-18 18:59:45 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
if(!decompressionCompleted) {
|
2018-11-13 21:05:39 +00:00
|
|
|
BMK_runOutcome_t const dOutcome = BMK_benchTimedFn(timeStateDecompress, dbp);
|
2018-08-14 21:44:47 +00:00
|
|
|
|
2018-08-25 00:28:38 +00:00
|
|
|
if(!BMK_isSuccessful_runOutcome(dOutcome)) {
|
2018-08-23 21:21:18 +00:00
|
|
|
return BMK_benchOutcome_error();
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-08-14 21:44:47 +00:00
|
|
|
|
2018-08-25 00:28:38 +00:00
|
|
|
{ BMK_runTime_t const dResult = BMK_extract_runTime(dOutcome);
|
2019-01-25 23:11:50 +00:00
|
|
|
U64 const newDSpeed = (U64)((double)srcSize * TIMELOOP_NANOSEC / dResult.nanoSecPerRun);
|
2018-08-24 01:04:50 +00:00
|
|
|
if (newDSpeed > benchResult.dSpeed)
|
|
|
|
benchResult.dSpeed = newDSpeed;
|
|
|
|
}
|
2018-08-07 00:13:36 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
{ int const ratioAccuracy = (ratio < 10.) ? 3 : 2;
|
|
|
|
DISPLAYLEVEL(2, "%2s-%-17.17s :%10u ->%10u (%5.*f),%6.*f MB/s ,%6.1f MB/s \r",
|
2018-08-24 01:04:50 +00:00
|
|
|
marks[markNb], displayName,
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
(unsigned)srcSize, (unsigned)benchResult.cSize,
|
2018-08-23 21:21:18 +00:00
|
|
|
ratioAccuracy, ratio,
|
2018-08-23 23:03:30 +00:00
|
|
|
benchResult.cSpeed < (10 MB) ? 2 : 1, (double)benchResult.cSpeed / MB_UNIT,
|
2018-08-24 01:04:50 +00:00
|
|
|
(double)benchResult.dSpeed / MB_UNIT);
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-08-27 04:30:18 +00:00
|
|
|
decompressionCompleted = BMK_isCompleted_TimedFn(timeStateDecompress);
|
2017-11-18 23:54:32 +00:00
|
|
|
}
|
2018-11-08 20:36:39 +00:00
|
|
|
markNb = (markNb+1) % NB_MARKS;
|
2018-08-24 01:04:50 +00:00
|
|
|
} /* while (!(compressionCompleted && decompressionCompleted)) */
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
/* CRC Checking */
|
2018-08-23 21:21:18 +00:00
|
|
|
{ const BYTE* resultBuffer = (const BYTE*)(*resultBufferPtr);
|
2018-06-18 18:59:45 +00:00
|
|
|
U64 const crcCheck = XXH64(resultBuffer, srcSize, 0);
|
2018-06-14 18:46:17 +00:00
|
|
|
if ((adv->mode == BMK_both) && (crcOrig!=crcCheck)) {
|
2018-06-12 19:54:43 +00:00
|
|
|
size_t u;
|
2018-11-08 20:36:39 +00:00
|
|
|
DISPLAY("!!! WARNING !!! %14s : Invalid Checksum : %x != %x \n",
|
|
|
|
displayName, (unsigned)crcOrig, (unsigned)crcCheck);
|
2018-06-12 19:54:43 +00:00
|
|
|
for (u=0; u<srcSize; u++) {
|
2018-08-23 21:21:18 +00:00
|
|
|
if (((const BYTE*)srcBuffer)[u] != resultBuffer[u]) {
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
unsigned segNb, bNb, pos;
|
2018-06-12 19:54:43 +00:00
|
|
|
size_t bacc = 0;
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAY("Decoding error at pos %u ", (unsigned)u);
|
2018-06-12 19:54:43 +00:00
|
|
|
for (segNb = 0; segNb < nbBlocks; segNb++) {
|
|
|
|
if (bacc + srcSizes[segNb] > u) break;
|
|
|
|
bacc += srcSizes[segNb];
|
2016-01-21 01:21:17 +00:00
|
|
|
}
|
2018-06-12 19:54:43 +00:00
|
|
|
pos = (U32)(u - bacc);
|
|
|
|
bNb = pos / (128 KB);
|
|
|
|
DISPLAY("(sample %u, block %u, pos %u) \n", segNb, bNb, pos);
|
2019-01-25 23:11:50 +00:00
|
|
|
{ size_t const lowest = (u>5) ? 5 : u;
|
|
|
|
size_t n;
|
2018-06-12 19:54:43 +00:00
|
|
|
DISPLAY("origin: ");
|
2019-01-25 23:11:50 +00:00
|
|
|
for (n=lowest; n>0; n--)
|
|
|
|
DISPLAY("%02X ", ((const BYTE*)srcBuffer)[u-n]);
|
2018-06-12 19:54:43 +00:00
|
|
|
DISPLAY(" :%02X: ", ((const BYTE*)srcBuffer)[u]);
|
2019-01-25 23:11:50 +00:00
|
|
|
for (n=1; n<3; n++)
|
|
|
|
DISPLAY("%02X ", ((const BYTE*)srcBuffer)[u+n]);
|
2018-06-12 19:54:43 +00:00
|
|
|
DISPLAY(" \n");
|
|
|
|
DISPLAY("decode: ");
|
2019-01-25 23:11:50 +00:00
|
|
|
for (n=lowest; n>0; n++)
|
|
|
|
DISPLAY("%02X ", resultBuffer[u-n]);
|
2018-08-23 21:21:18 +00:00
|
|
|
DISPLAY(" :%02X: ", resultBuffer[u]);
|
2019-01-25 23:11:50 +00:00
|
|
|
for (n=1; n<3; n++)
|
|
|
|
DISPLAY("%02X ", resultBuffer[u+n]);
|
2018-06-12 19:54:43 +00:00
|
|
|
DISPLAY(" \n");
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (u==srcSize-1) { /* should never happen */
|
|
|
|
DISPLAY("no difference detected\n");
|
2018-08-22 01:19:27 +00:00
|
|
|
}
|
2019-10-15 23:09:18 +00:00
|
|
|
} /* for (u=0; u<srcSize; u++) */
|
|
|
|
} /* if ((adv->mode == BMK_both) && (crcOrig!=crcCheck)) */
|
2018-06-12 19:54:43 +00:00
|
|
|
} /* CRC Checking */
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
if (displayLevel == 1) { /* hidden display mode -q, used by python speed benchmark */
|
2018-08-23 23:03:30 +00:00
|
|
|
double const cSpeed = (double)benchResult.cSpeed / MB_UNIT;
|
|
|
|
double const dSpeed = (double)benchResult.dSpeed / MB_UNIT;
|
2018-08-23 21:21:18 +00:00
|
|
|
if (adv->additionalParam) {
|
|
|
|
DISPLAY("-%-3i%11i (%5.3f) %6.2f MB/s %6.1f MB/s %s (param=%d)\n", cLevel, (int)cSize, ratio, cSpeed, dSpeed, displayName, adv->additionalParam);
|
|
|
|
} else {
|
|
|
|
DISPLAY("-%-3i%11i (%5.3f) %6.2f MB/s %6.1f MB/s %s\n", cLevel, (int)cSize, ratio, cSpeed, dSpeed, displayName);
|
|
|
|
}
|
2018-06-21 18:16:53 +00:00
|
|
|
}
|
2018-08-23 21:21:18 +00:00
|
|
|
|
|
|
|
DISPLAYLEVEL(2, "%2i#\n", cLevel);
|
2018-06-14 18:46:17 +00:00
|
|
|
} /* Bench */
|
2018-08-23 21:21:18 +00:00
|
|
|
|
|
|
|
benchResult.cMem = (1ULL << (comprParams->windowLog)) + ZSTD_sizeof_CCtx(cctx);
|
|
|
|
return BMK_benchOutcome_setValidResult(benchResult);
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_benchOutcome_t BMK_benchMemAdvanced(const void* srcBuffer, size_t srcSize,
|
2018-08-22 01:19:27 +00:00
|
|
|
void* dstBuffer, size_t dstCapacity,
|
2018-06-19 17:58:22 +00:00
|
|
|
const size_t* fileSizes, unsigned nbFiles,
|
2018-08-24 22:59:57 +00:00
|
|
|
int cLevel, const ZSTD_compressionParameters* comprParams,
|
2018-06-19 17:58:22 +00:00
|
|
|
const void* dictBuffer, size_t dictBufferSize,
|
|
|
|
int displayLevel, const char* displayName, const BMK_advancedParams_t* adv)
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-06-19 17:58:22 +00:00
|
|
|
{
|
2018-08-23 21:21:18 +00:00
|
|
|
int const dstParamsError = !dstBuffer ^ !dstCapacity; /* must be both NULL or none */
|
|
|
|
|
2018-06-19 17:58:22 +00:00
|
|
|
size_t const blockSize = ((adv->blockSize>=32 && (adv->mode != BMK_decodeOnly)) ? adv->blockSize : srcSize) + (!srcSize) /* avoid div by 0 */ ;
|
|
|
|
U32 const maxNbBlocks = (U32) ((srcSize + (blockSize-1)) / blockSize) + nbFiles;
|
|
|
|
|
|
|
|
/* these are the blockTable parameters, just split up */
|
2018-07-27 15:49:25 +00:00
|
|
|
const void ** const srcPtrs = (const void**)malloc(maxNbBlocks * sizeof(void*));
|
|
|
|
size_t* const srcSizes = (size_t*)malloc(maxNbBlocks * sizeof(size_t));
|
2018-06-19 17:58:22 +00:00
|
|
|
|
2018-07-20 21:35:09 +00:00
|
|
|
|
2018-07-27 15:49:25 +00:00
|
|
|
void ** const cPtrs = (void**)malloc(maxNbBlocks * sizeof(void*));
|
|
|
|
size_t* const cSizes = (size_t*)malloc(maxNbBlocks * sizeof(size_t));
|
|
|
|
size_t* const cCapacities = (size_t*)malloc(maxNbBlocks * sizeof(size_t));
|
2018-06-19 17:58:22 +00:00
|
|
|
|
2018-07-27 15:49:25 +00:00
|
|
|
void ** const resPtrs = (void**)malloc(maxNbBlocks * sizeof(void*));
|
|
|
|
size_t* const resSizes = (size_t*)malloc(maxNbBlocks * sizeof(size_t));
|
2018-06-19 17:58:22 +00:00
|
|
|
|
2018-08-28 18:21:09 +00:00
|
|
|
BMK_timedFnState_t* timeStateCompress = BMK_createTimedFnState(adv->nbSeconds * 1000, BMK_RUNTEST_DEFAULT_MS);
|
|
|
|
BMK_timedFnState_t* timeStateDecompress = BMK_createTimedFnState(adv->nbSeconds * 1000, BMK_RUNTEST_DEFAULT_MS);
|
2018-06-23 00:25:16 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
ZSTD_CCtx* const cctx = ZSTD_createCCtx();
|
|
|
|
ZSTD_DCtx* const dctx = ZSTD_createDCtx();
|
2018-08-09 19:07:57 +00:00
|
|
|
|
2018-06-18 18:59:45 +00:00
|
|
|
const size_t maxCompressedSize = dstCapacity ? dstCapacity : ZSTD_compressBound(srcSize) + (maxNbBlocks * 1024);
|
|
|
|
|
2018-07-27 15:49:25 +00:00
|
|
|
void* const internalDstBuffer = dstBuffer ? NULL : malloc(maxCompressedSize);
|
|
|
|
void* const compressedBuffer = dstBuffer ? dstBuffer : internalDstBuffer;
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_benchOutcome_t outcome = BMK_benchOutcome_error(); /* error by default */
|
2018-08-14 21:44:47 +00:00
|
|
|
|
|
|
|
void* resultBuffer = srcSize ? malloc(srcSize) : NULL;
|
|
|
|
|
2018-08-22 01:19:27 +00:00
|
|
|
int allocationincomplete = !srcPtrs || !srcSizes || !cPtrs ||
|
|
|
|
!cSizes || !cCapacities || !resPtrs || !resSizes ||
|
2018-08-23 21:21:18 +00:00
|
|
|
!timeStateCompress || !timeStateDecompress ||
|
|
|
|
!cctx || !dctx ||
|
|
|
|
!compressedBuffer || !resultBuffer;
|
|
|
|
|
|
|
|
|
|
|
|
if (!allocationincomplete && !dstParamsError) {
|
|
|
|
outcome = BMK_benchMemAdvancedNoAlloc(srcPtrs, srcSizes,
|
|
|
|
cPtrs, cCapacities, cSizes,
|
|
|
|
resPtrs, resSizes,
|
|
|
|
&resultBuffer,
|
|
|
|
compressedBuffer, maxCompressedSize,
|
|
|
|
timeStateCompress, timeStateDecompress,
|
|
|
|
srcBuffer, srcSize,
|
|
|
|
fileSizes, nbFiles,
|
|
|
|
cLevel, comprParams,
|
|
|
|
dictBuffer, dictBufferSize,
|
|
|
|
cctx, dctx,
|
|
|
|
displayLevel, displayName, adv);
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-08-22 01:19:27 +00:00
|
|
|
|
2015-12-16 01:37:24 +00:00
|
|
|
/* clean up */
|
2018-08-22 01:19:27 +00:00
|
|
|
BMK_freeTimedFnState(timeStateCompress);
|
|
|
|
BMK_freeTimedFnState(timeStateDecompress);
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
ZSTD_freeCCtx(cctx);
|
2018-08-09 19:07:57 +00:00
|
|
|
ZSTD_freeDCtx(dctx);
|
|
|
|
|
2018-07-27 15:49:25 +00:00
|
|
|
free(internalDstBuffer);
|
2015-01-24 00:58:16 +00:00
|
|
|
free(resultBuffer);
|
2018-06-12 19:54:43 +00:00
|
|
|
|
2018-08-22 01:19:27 +00:00
|
|
|
free((void*)srcPtrs);
|
|
|
|
free(srcSizes);
|
|
|
|
free(cPtrs);
|
2018-06-12 19:54:43 +00:00
|
|
|
free(cSizes);
|
2018-07-20 21:35:09 +00:00
|
|
|
free(cCapacities);
|
2018-06-12 19:54:43 +00:00
|
|
|
free(resPtrs);
|
|
|
|
free(resSizes);
|
|
|
|
|
2018-06-19 17:58:22 +00:00
|
|
|
if(allocationincomplete) {
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(31, BMK_benchOutcome_t, "allocation error : not enough memory");
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-08-22 01:19:27 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
if(dstParamsError) {
|
|
|
|
RETURN_ERROR(32, BMK_benchOutcome_t, "Dst parameters not coherent");
|
2018-07-27 15:49:25 +00:00
|
|
|
}
|
2018-08-23 21:21:18 +00:00
|
|
|
return outcome;
|
2018-06-04 23:32:37 +00:00
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_benchOutcome_t BMK_benchMem(const void* srcBuffer, size_t srcSize,
|
2018-06-12 19:54:43 +00:00
|
|
|
const size_t* fileSizes, unsigned nbFiles,
|
2018-08-23 21:21:18 +00:00
|
|
|
int cLevel, const ZSTD_compressionParameters* comprParams,
|
2018-06-12 19:54:43 +00:00
|
|
|
const void* dictBuffer, size_t dictBufferSize,
|
|
|
|
int displayLevel, const char* displayName) {
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_advancedParams_t const adv = BMK_initAdvancedParams();
|
2018-06-12 19:54:43 +00:00
|
|
|
return BMK_benchMemAdvanced(srcBuffer, srcSize,
|
2018-06-18 18:59:45 +00:00
|
|
|
NULL, 0,
|
2018-06-12 19:54:43 +00:00
|
|
|
fileSizes, nbFiles,
|
|
|
|
cLevel, comprParams,
|
|
|
|
dictBuffer, dictBufferSize,
|
|
|
|
displayLevel, displayName, &adv);
|
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
static BMK_benchOutcome_t BMK_benchCLevel(const void* srcBuffer, size_t benchedSize,
|
2015-12-18 00:26:48 +00:00
|
|
|
const size_t* fileSizes, unsigned nbFiles,
|
2018-08-23 21:21:18 +00:00
|
|
|
int cLevel, const ZSTD_compressionParameters* comprParams,
|
2016-12-13 12:03:41 +00:00
|
|
|
const void* dictBuffer, size_t dictBufferSize,
|
2018-06-12 19:54:43 +00:00
|
|
|
int displayLevel, const char* displayName,
|
|
|
|
BMK_advancedParams_t const * const adv)
|
2015-01-24 00:58:16 +00:00
|
|
|
{
|
2016-03-14 17:10:30 +00:00
|
|
|
const char* pch = strrchr(displayName, '\\'); /* Windows */
|
2018-08-23 21:21:18 +00:00
|
|
|
if (!pch) pch = strrchr(displayName, '/'); /* Linux */
|
2016-03-14 17:10:30 +00:00
|
|
|
if (pch) displayName = pch+1;
|
|
|
|
|
2018-06-12 19:54:43 +00:00
|
|
|
if (adv->realTime) {
|
2018-06-11 14:59:05 +00:00
|
|
|
DISPLAYLEVEL(2, "Note : switching to real-time priority \n");
|
2017-02-07 15:48:01 +00:00
|
|
|
SET_REALTIME_PRIORITY;
|
|
|
|
}
|
2016-04-25 11:09:06 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
if (displayLevel == 1 && !adv->additionalParam) /* --quiet mode */
|
|
|
|
DISPLAY("bench %s %s: input %u bytes, %u seconds, %u KB blocks\n",
|
|
|
|
ZSTD_VERSION_STRING, ZSTD_GIT_COMMIT_STRING,
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
(unsigned)benchedSize, adv->nbSeconds, (unsigned)(adv->blockSize>>10));
|
2016-03-14 17:10:30 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
return BMK_benchMemAdvanced(srcBuffer, benchedSize,
|
|
|
|
NULL, 0,
|
|
|
|
fileSizes, nbFiles,
|
|
|
|
cLevel, comprParams,
|
|
|
|
dictBuffer, dictBufferSize,
|
|
|
|
displayLevel, displayName, adv);
|
|
|
|
}
|
|
|
|
|
|
|
|
BMK_benchOutcome_t BMK_syntheticTest(int cLevel, double compressibility,
|
|
|
|
const ZSTD_compressionParameters* compressionParams,
|
|
|
|
int displayLevel, const BMK_advancedParams_t* adv)
|
|
|
|
{
|
|
|
|
char name[20] = {0};
|
|
|
|
size_t const benchedSize = 10000000;
|
|
|
|
void* srcBuffer;
|
|
|
|
BMK_benchOutcome_t res;
|
|
|
|
|
|
|
|
if (cLevel > ZSTD_maxCLevel()) {
|
|
|
|
RETURN_ERROR(15, BMK_benchOutcome_t, "Invalid Compression Level");
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Memory allocation */
|
|
|
|
srcBuffer = malloc(benchedSize);
|
|
|
|
if (!srcBuffer) RETURN_ERROR(21, BMK_benchOutcome_t, "not enough memory");
|
|
|
|
|
|
|
|
/* Fill input buffer */
|
|
|
|
RDG_genBuffer(srcBuffer, benchedSize, compressibility, 0.0, 0);
|
|
|
|
|
|
|
|
/* Bench */
|
|
|
|
snprintf (name, sizeof(name), "Synthetic %2u%%", (unsigned)(compressibility*100));
|
|
|
|
res = BMK_benchCLevel(srcBuffer, benchedSize,
|
|
|
|
&benchedSize /* ? */, 1 /* ? */,
|
|
|
|
cLevel, compressionParams,
|
|
|
|
NULL, 0, /* dictionary */
|
|
|
|
displayLevel, name, adv);
|
|
|
|
|
|
|
|
/* clean up */
|
|
|
|
free(srcBuffer);
|
2018-06-11 14:59:05 +00:00
|
|
|
|
2018-06-15 20:21:08 +00:00
|
|
|
return res;
|
2015-12-16 01:37:24 +00:00
|
|
|
}
|
2015-01-24 00:58:16 +00:00
|
|
|
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
|
|
|
|
static size_t BMK_findMaxMem(U64 requiredMem)
|
|
|
|
{
|
|
|
|
size_t const step = 64 MB;
|
|
|
|
BYTE* testmem = NULL;
|
|
|
|
|
|
|
|
requiredMem = (((requiredMem >> 26) + 1) << 26);
|
|
|
|
requiredMem += step;
|
|
|
|
if (requiredMem > maxMemory) requiredMem = maxMemory;
|
|
|
|
|
|
|
|
do {
|
|
|
|
testmem = (BYTE*)malloc((size_t)requiredMem);
|
|
|
|
requiredMem -= step;
|
|
|
|
} while (!testmem && requiredMem > 0);
|
|
|
|
|
|
|
|
free(testmem);
|
|
|
|
return (size_t)(requiredMem);
|
|
|
|
}
|
|
|
|
|
2016-03-26 00:48:27 +00:00
|
|
|
/*! BMK_loadFiles() :
|
2018-03-12 02:56:48 +00:00
|
|
|
* Loads `buffer` with content of files listed within `fileNamesTable`.
|
|
|
|
* At most, fills `buffer` entirely. */
|
2018-06-12 19:54:43 +00:00
|
|
|
static int BMK_loadFiles(void* buffer, size_t bufferSize,
|
2018-08-30 18:02:08 +00:00
|
|
|
size_t* fileSizes,
|
|
|
|
const char* const * fileNamesTable, unsigned nbFiles,
|
|
|
|
int displayLevel)
|
2015-12-16 01:37:24 +00:00
|
|
|
{
|
2016-04-13 08:48:04 +00:00
|
|
|
size_t pos = 0, totalSize = 0;
|
2016-03-17 18:37:33 +00:00
|
|
|
unsigned n;
|
2016-01-30 02:14:15 +00:00
|
|
|
for (n=0; n<nbFiles; n++) {
|
2019-10-15 23:09:18 +00:00
|
|
|
U64 fileSize = UTIL_getFileSize(fileNamesTable[n]); /* last file may be shortened */
|
2016-04-28 10:23:33 +00:00
|
|
|
if (UTIL_isDirectory(fileNamesTable[n])) {
|
2018-06-11 14:59:05 +00:00
|
|
|
DISPLAYLEVEL(2, "Ignoring %s directory... \n", fileNamesTable[n]);
|
2016-04-29 13:19:40 +00:00
|
|
|
fileSizes[n] = 0;
|
2016-04-13 08:48:04 +00:00
|
|
|
continue;
|
|
|
|
}
|
2017-10-17 23:14:25 +00:00
|
|
|
if (fileSize == UTIL_FILESIZE_UNKNOWN) {
|
2018-06-11 14:59:05 +00:00
|
|
|
DISPLAYLEVEL(2, "Cannot evaluate size of %s, ignoring ... \n", fileNamesTable[n]);
|
2017-10-17 23:14:25 +00:00
|
|
|
fileSizes[n] = 0;
|
|
|
|
continue;
|
|
|
|
}
|
2019-10-15 23:09:18 +00:00
|
|
|
{ FILE* const f = fopen(fileNamesTable[n], "rb");
|
|
|
|
if (f==NULL) RETURN_ERROR_INT(10, "impossible to open file %s", fileNamesTable[n]);
|
|
|
|
DISPLAYUPDATE(2, "Loading %s... \r", fileNamesTable[n]);
|
|
|
|
if (fileSize > bufferSize-pos) fileSize = bufferSize-pos, nbFiles=n; /* buffer too small - stop after this file */
|
|
|
|
{ size_t const readSize = fread(((char*)buffer)+pos, 1, (size_t)fileSize, f);
|
|
|
|
if (readSize != (size_t)fileSize) RETURN_ERROR_INT(11, "could not read %s", fileNamesTable[n]);
|
|
|
|
pos += readSize;
|
|
|
|
}
|
|
|
|
fileSizes[n] = (size_t)fileSize;
|
|
|
|
totalSize += (size_t)fileSize;
|
|
|
|
fclose(f);
|
|
|
|
} }
|
2016-05-01 08:26:30 +00:00
|
|
|
|
2019-10-15 23:09:18 +00:00
|
|
|
if (totalSize == 0) RETURN_ERROR_INT(12, "no data to bench");
|
2018-06-12 19:54:43 +00:00
|
|
|
return 0;
|
2015-12-16 01:37:24 +00:00
|
|
|
}
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_benchOutcome_t BMK_benchFilesAdvanced(
|
|
|
|
const char* const * fileNamesTable, unsigned nbFiles,
|
|
|
|
const char* dictFileName, int cLevel,
|
|
|
|
const ZSTD_compressionParameters* compressionParams,
|
|
|
|
int displayLevel, const BMK_advancedParams_t* adv)
|
2015-12-16 01:37:24 +00:00
|
|
|
{
|
2018-06-23 00:25:16 +00:00
|
|
|
void* srcBuffer = NULL;
|
2015-12-16 01:37:24 +00:00
|
|
|
size_t benchedSize;
|
2015-12-18 00:26:48 +00:00
|
|
|
void* dictBuffer = NULL;
|
|
|
|
size_t dictBufferSize = 0;
|
2018-06-23 00:25:16 +00:00
|
|
|
size_t* fileSizes = NULL;
|
2018-08-25 04:38:09 +00:00
|
|
|
BMK_benchOutcome_t res;
|
2016-05-20 09:24:35 +00:00
|
|
|
U64 const totalSizeToLoad = UTIL_getTotalFileSize(fileNamesTable, nbFiles);
|
2015-12-16 01:37:24 +00:00
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
if (!nbFiles) {
|
|
|
|
RETURN_ERROR(14, BMK_benchOutcome_t, "No Files to Benchmark");
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2015-12-18 00:26:48 +00:00
|
|
|
|
2018-06-19 17:58:22 +00:00
|
|
|
if (cLevel > ZSTD_maxCLevel()) {
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(15, BMK_benchOutcome_t, "Invalid Compression Level");
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
fileSizes = (size_t*)calloc(nbFiles, sizeof(size_t));
|
2018-08-23 21:21:18 +00:00
|
|
|
if (!fileSizes) RETURN_ERROR(12, BMK_benchOutcome_t, "not enough memory for fileSizes");
|
|
|
|
|
2015-12-18 00:26:48 +00:00
|
|
|
/* Load dictionary */
|
2016-01-30 02:14:15 +00:00
|
|
|
if (dictFileName != NULL) {
|
2017-10-17 23:14:25 +00:00
|
|
|
U64 const dictFileSize = UTIL_getFileSize(dictFileName);
|
2018-12-21 01:20:07 +00:00
|
|
|
if (dictFileSize == UTIL_FILESIZE_UNKNOWN) {
|
|
|
|
DISPLAYLEVEL(1, "error loading %s : %s \n", dictFileName, strerror(errno));
|
|
|
|
free(fileSizes);
|
|
|
|
RETURN_ERROR(9, BMK_benchOutcome_t, "benchmark aborted");
|
|
|
|
}
|
2018-06-19 17:58:22 +00:00
|
|
|
if (dictFileSize > 64 MB) {
|
|
|
|
free(fileSizes);
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(10, BMK_benchOutcome_t, "dictionary file %s too large", dictFileName);
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2015-12-18 00:26:48 +00:00
|
|
|
dictBufferSize = (size_t)dictFileSize;
|
|
|
|
dictBuffer = malloc(dictBufferSize);
|
2018-06-19 17:58:22 +00:00
|
|
|
if (dictBuffer==NULL) {
|
|
|
|
free(fileSizes);
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(11, BMK_benchOutcome_t, "not enough memory for dictionary (%u bytes)",
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
(unsigned)dictBufferSize);
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2018-08-23 21:21:18 +00:00
|
|
|
|
|
|
|
{ int const errorCode = BMK_loadFiles(dictBuffer, dictBufferSize,
|
|
|
|
fileSizes, &dictFileName /*?*/,
|
|
|
|
1 /*?*/, displayLevel);
|
|
|
|
if (errorCode) {
|
|
|
|
res = BMK_benchOutcome_error();
|
2018-06-23 00:25:16 +00:00
|
|
|
goto _cleanUp;
|
2018-08-23 21:21:18 +00:00
|
|
|
} }
|
2015-12-18 00:26:48 +00:00
|
|
|
}
|
|
|
|
|
2015-12-16 01:37:24 +00:00
|
|
|
/* Memory allocation & restrictions */
|
|
|
|
benchedSize = BMK_findMaxMem(totalSizeToLoad * 3) / 3;
|
|
|
|
if ((U64)benchedSize > totalSizeToLoad) benchedSize = (size_t)totalSizeToLoad;
|
|
|
|
if (benchedSize < totalSizeToLoad)
|
fix confusion between unsigned <-> U32
as suggested in #1441.
generally U32 and unsigned are the same thing,
except when they are not ...
case : 32-bit compilation for MIPS (uint32_t == unsigned long)
A vast majority of transformation consists in transforming U32 into unsigned.
In rare cases, it's the other way around (typically for internal code, such as seeds).
Among a few issues this patches solves :
- some parameters were declared with type `unsigned` in *.h,
but with type `U32` in their implementation *.c .
- some parameters have type unsigned*,
but the caller user a pointer to U32 instead.
These fixes are useful.
However, the bulk of changes is about %u formating,
which requires unsigned type,
but generally receives U32 values instead,
often just for brevity (U32 is shorter than unsigned).
These changes are generally minor, or even annoying.
As a consequence, the amount of code changed is larger than I would expect for such a patch.
Testing is also a pain :
it requires manually modifying `mem.h`,
in order to lie about `U32`
and force it to be an `unsigned long` typically.
On a 64-bit system, this will break the equivalence unsigned == U32.
Unfortunately, it will also break a few static_assert(), controlling structure sizes.
So it also requires modifying `debug.h` to make `static_assert()` a noop.
And then reverting these changes.
So it's inconvenient, and as a consequence,
this property is currently not checked during CI tests.
Therefore, these problems can emerge again in the future.
I wonder if it is worth ensuring proper distinction of U32 != unsigned in CI tests.
It's another restriction for coding, adding more frustration during merge tests,
since most platforms don't need this distinction (hence contributor will not see it),
and while this can matter in theory, the number of platforms impacted seems minimal.
Thoughts ?
2018-12-22 00:19:44 +00:00
|
|
|
DISPLAY("Not enough memory; testing %u MB only...\n", (unsigned)(benchedSize >> 20));
|
2018-08-14 21:44:47 +00:00
|
|
|
|
|
|
|
srcBuffer = benchedSize ? malloc(benchedSize) : NULL;
|
2018-06-19 17:58:22 +00:00
|
|
|
if (!srcBuffer) {
|
|
|
|
free(dictBuffer);
|
|
|
|
free(fileSizes);
|
2018-08-23 21:21:18 +00:00
|
|
|
RETURN_ERROR(12, BMK_benchOutcome_t, "not enough memory");
|
2018-06-19 17:58:22 +00:00
|
|
|
}
|
2015-12-16 01:37:24 +00:00
|
|
|
|
|
|
|
/* Load input buffer */
|
2018-08-23 21:21:18 +00:00
|
|
|
{ int const errorCode = BMK_loadFiles(srcBuffer, benchedSize,
|
|
|
|
fileSizes, fileNamesTable, nbFiles,
|
|
|
|
displayLevel);
|
|
|
|
if (errorCode) {
|
|
|
|
res = BMK_benchOutcome_error();
|
2018-06-23 00:25:16 +00:00
|
|
|
goto _cleanUp;
|
2018-08-23 21:21:18 +00:00
|
|
|
} }
|
|
|
|
|
2015-10-22 15:55:40 +00:00
|
|
|
/* Bench */
|
2018-08-23 21:21:18 +00:00
|
|
|
{ char mfName[20] = {0};
|
2017-11-17 08:22:55 +00:00
|
|
|
snprintf (mfName, sizeof(mfName), " %u files", nbFiles);
|
2018-08-23 21:21:18 +00:00
|
|
|
{ const char* const displayName = (nbFiles > 1) ? mfName : fileNamesTable[0];
|
2018-08-22 01:19:27 +00:00
|
|
|
res = BMK_benchCLevel(srcBuffer, benchedSize,
|
2018-08-23 21:21:18 +00:00
|
|
|
fileSizes, nbFiles,
|
|
|
|
cLevel, compressionParams,
|
|
|
|
dictBuffer, dictBufferSize,
|
|
|
|
displayLevel, displayName,
|
|
|
|
adv);
|
2017-11-17 08:22:55 +00:00
|
|
|
} }
|
2015-01-24 00:58:16 +00:00
|
|
|
|
2018-06-23 00:25:16 +00:00
|
|
|
_cleanUp:
|
2015-01-24 00:58:16 +00:00
|
|
|
free(srcBuffer);
|
2015-12-18 00:26:48 +00:00
|
|
|
free(dictBuffer);
|
2015-12-16 02:01:03 +00:00
|
|
|
free(fileSizes);
|
2018-06-12 19:54:43 +00:00
|
|
|
return res;
|
2015-01-24 00:58:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_benchOutcome_t BMK_benchFiles(
|
|
|
|
const char* const * fileNamesTable, unsigned nbFiles,
|
|
|
|
const char* dictFileName,
|
|
|
|
int cLevel, const ZSTD_compressionParameters* compressionParams,
|
|
|
|
int displayLevel)
|
2015-01-24 00:58:16 +00:00
|
|
|
{
|
2018-08-23 21:21:18 +00:00
|
|
|
BMK_advancedParams_t const adv = BMK_initAdvancedParams();
|
2018-06-15 20:21:08 +00:00
|
|
|
return BMK_benchFilesAdvanced(fileNamesTable, nbFiles, dictFileName, cLevel, compressionParams, displayLevel, &adv);
|
2015-01-24 00:58:16 +00:00
|
|
|
}
|