Takahito Tejima
5e5fc97b0c
fix glBatchViewer
2013-05-09 19:18:32 -07:00
Takahito Tejima
23ba172397
First draft of OsdUtil batching API
2013-05-09 19:18:05 -07:00
Takahito Tejima
1b879d706f
fix FarMultiMeshFactory to work with refactored FarPatchTables.
2013-05-09 19:16:51 -07:00
Takahito Tejima
42f84b78d0
add levelBaseUniform and gregoryQuadOffsetBaseUniform locations as default member
2013-05-09 19:15:50 -07:00
Takahito Tejima
7b6630cf40
fix simpleCpu and ptexViewer to be compilable with new patch tables.
2013-05-09 13:48:00 -07:00
Takahito Tejima
3eaf0362bd
split patch descriptor into two parts, far intrinsic properties and osd's.
...
more OsdGLDrawContext clean up.
2013-05-09 13:14:02 -07:00
Takahito Tejima
ecced51814
factor out createPatchArray function into drawContext.
...
cleanup glDrawContext
2013-05-09 10:53:58 -07:00
Takahito Tejima
31f7a215d0
reorder less than comparison to match with descriptor iterator
2013-05-09 10:53:22 -07:00
Takahito Tejima
a2bbed2a8b
Merge branch 'dev' of https://github.com/manuelk/OpenSubdiv into dev
...
Conflicts:
opensubdiv/far/patchTables.h
opensubdiv/far/patchTablesFactory.h
2013-05-09 09:34:58 -07:00
Takahito Tejima
f592e90067
fix OsdGLDrawContext to follow far patchtables refactoring.
2013-05-09 09:23:01 -07:00
manuelk
20641e3b2c
code cleanup / comments
2013-05-08 18:47:36 -07:00
manuelk
4230e12d95
first pass at refactoring FarPatchTables
2013-05-08 17:06:59 -07:00
manuelk
cd380e0a1a
Refactoring :
...
- moving the SubdivisionTables enum from osd/tables.h to FarSubdivisionTables
- renaming various buffer names to _devicePtr for consistency
2013-05-07 15:25:49 -07:00
manuelk
fbcb02d39e
Fixed dyu's fix (we do need the window title in Osd Regression with GLFW 3.0)
2013-05-07 14:25:37 -07:00
manuelk
5ec2320d9a
adding doxy comments to Compute Controllers
...
fixes #138
2013-05-07 13:55:14 -07:00
manuelk
4c0c6161d4
Feature adaptive refinement causes Hbr::GuaranteeNeighbors() to leave behind
...
some un-connected face-vertices. FarSubdivisionTablesFactory has been hardened
so as to not trip over these, but apparently Gregory patch valence tables
generation is tripping over one of those in FarPatchTablesFactory.
fixes #162
2013-05-07 12:32:05 -07:00
David G Yu
2a12b21ab2
Removed mutex implementation.
...
We added this to support earlier versions
of hbr, but it is no longer needed.
2013-05-07 11:27:14 -07:00
David G Yu
e4afec5388
Disabled paintTest on OS X
2013-05-06 23:59:58 -07:00
David G Yu
93476a368d
Fixed a few OS X build errors.
2013-05-06 23:59:58 -07:00
David G Yu
9e371e4e89
Fixed DX11 build errors from KernelBatch refactoring
2013-05-06 23:59:58 -07:00
David G Yu
6b96d531bd
Fixed GCD build errors from KernelBatch refactoring
2013-05-06 23:59:54 -07:00
manuelk
3ea2a3e472
fixing / adding doxy comments
...
fixes #138
2013-05-06 19:05:50 -07:00
manuelk
aed197628c
KernelBatch tables refactor / cleanup :
...
- FarKernelBatch becomes a class w/ accessors
- split the FarKernelBatchFactory to its own header file
- add doxy doc
- propagate fallout to the rest of the code base
2013-05-06 17:50:58 -07:00
manuelk
7554321413
Minor code clean-up of FarPatchTablesFactory :
...
- removed redundant counter / pointer struct
- renamed some of the variables to be less confusing
2013-05-06 15:00:39 -07:00
manuelk
9860e1921f
clean up some function prototypes
2013-05-06 10:36:18 -07:00
manuelk
711c693d6b
Exposing a previously unused private method that scans an Hbr mesh for
...
creases and other features and determine the isolation level needed.
Minor improvements:
- we now have a custom "corner" isolation level : with edge-only boundary
interpolation rules, corner vertices are rounded and would require an
isolation level of 10. In practice however, 5 appears to be more than
enough to produce a perfectly rounded shape and is set as a default
for this value.
- the logic has been made a little more efficient by moving the vertex
sharpness tags tests to a separate loop so as not to repeat the check
multiple times for a given vertex
Also added some doxy comments
fixes #161
2013-05-03 12:15:20 -07:00
manuelk
26601c5fb7
More 0th. STL vector accesses checked in FarSubdivisionTables factories.
...
fixes #155
2013-05-03 12:04:04 -07:00
manuelk
309c7f085e
More 0th. STL vector accesses checked in FarSubdivisionTables factories.
...
fixes #155
2013-05-03 12:02:22 -07:00
manuelk
d4a06a078c
adding a convenience "inst" directory to ignore
2013-05-03 09:02:34 -07:00
manuelk
20d61cd93c
A quad face with 2 non-consecutive boundary edges causes the 4 vertices
...
of this quad to be tagged as boundary. These vertices will cause the
feature adaptive pass to generate sub-faces where appropriate, however
the face itself will not be identified as "non-patch", which causes the
FarPatchTables factory to mis-identify it and fall-back on an assert.
This fix flags these particular quad faces in the first adaptive pass.
The particular shape that caused the crash has also been addded to our
regression suite.
fixes #159
2013-05-02 19:37:34 -07:00
manuelk
65c92bbe72
oops : osd_dynamic_gpu and osd_dynamic_cpu don't always build under windows, so they
...
don't always have an install target.
fixes #154
2013-05-02 12:02:52 -07:00
manuelk
12eea1cf0b
Checking all accesses to 0th. element of std::vectors in FarPatchTablesFactory for empty vectors.
...
This should fix the exceptions thrown by Windows checking STL vector boundaries.
fixes #155
2013-05-01 19:36:28 -07:00
Takahito Tejima
3df04db2cd
FarSubdivisionTables: fixed vertsOffsets and removed unused members.
...
a new function is added to avoid confusion.
-GetNumVertices() returns number of vertices
-GetNumVerticesTotal() returns total number of vertices includins number of lower levels.
#closes 156
2013-04-25 12:01:06 -07:00
manuelk
643b664067
the limitEval example appears to be building properly... adding it to the collection
2013-04-24 10:40:32 -07:00
manuelk
f41843b767
turns out we are using a features from more recent versions of cmake than the minimum required...
...
fixes #154
2013-04-23 14:47:46 -07:00
manuelk
40df0198ad
rpaths were missing paths to the osd libraries and other dependencies - these cmake variables seem to be fixing the problem.
...
fixes #154
2013-04-23 11:58:49 -07:00
manuelk
b815aff333
First pass at fixing the installation part of the Cmake build : now CMAKE_INSTALL_PREFIX can
...
be used as intended to specify an installation directory, which can be located anywhere on the
file system.
Also improved the doxygen target and made the doxy build "quiet".
fixes #154
2013-04-22 19:35:41 -07:00
manuelk
eadd1b3ce4
fixing some doxygen @param tags not matching variable names in the code
...
fixes #138
2013-04-22 18:26:53 -07:00
manuelk
d82ce253eb
minor fix for a doxygen typo : its @param (singular, not plural)
...
fixes #138
2013-04-22 18:17:30 -07:00
manuelk
4bf24d9b95
First pass at our "Eval" API : this checkin is a mileston and is still missing
...
code paths for certain types of feature adaptive patches.
The check-in adds a new "limitEval" code example.
More to come soon...
fixes #45
2013-04-18 19:55:05 -07:00
manuelk
24356cc680
making MSVC++ happy...
...
fixes #153
2013-04-18 19:22:20 -07:00
manuelk
fd0af2dbb6
minor fixes to the GLFW motion callback to fix MSVC++ build errors.
...
fixes #149
2013-04-18 19:15:30 -07:00
manuelk
7e63b20c58
Small refactoring of the DrawContext code to remove duplication of vertex / patch counting code.
...
fixes #153
2013-04-18 17:54:12 -07:00
manuelk
4bab37310d
minor clean up of the patch parametric bitfields API
...
note : this is not using traditional bit-fields as we cannot guarantee that the CPU-side
compiler will match the bit-packing of the compilers used on the GPU-side.
2013-04-11 14:26:03 -07:00
manuelk
57808e4abe
fix the function prototype for the motion callbacks in our example viewers
...
fixes #149
2013-04-08 10:37:36 -07:00
David G Yu
ec9f97c1d6
Added a note about our use of git flow
2013-04-03 13:48:34 -07:00
David G Yu
81887feb00
Merge branches 'dev' and 'dev' of https://github.com/PixarAnimationStudios/OpenSubdiv into dev
2013-04-02 11:25:42 -07:00
manuelk
9a6e84800b
fix a comment in FarMeshFactory to reflect the changes in FarPtexCoord
...
fixes #143
2013-04-01 16:45:15 -07:00
David G Yu
ecd5419718
Fixed type of depth var in computePtexCoordinate
...
Fixes #143
2013-03-25 10:55:03 -07:00
David G Yu
4a6ba2de64
Fixed function proto mismatch in d3d11DrawContext
...
Fixes #143
2013-03-25 10:54:40 -07:00