Diego Novillo
3983d15a1d
Fix rebuilding types with circular references ( #5623 ). ( #5637 )
...
This fixes the problem reported in #5623 using the observation that if
we are re-building a type that already exists in the type pool, we
should just return that type.
This makes type rebuilding more efficient, and it also prevents the
type builder from getting itself into infinite recursion (as reported in
this issue).
In fixing this, I found a couple of other bugs in the type builder:
- When rebuilding an Array type, we were not re-building the element
type. This caused stale type references in the rebuilt type.
- This bug had not been caught by the test, because the test itself had
a bug in it: the test was rebuilding types on top of the same ID (the
ID counter was never incremented).
Initially, the bug in the test caused a failure with the new logic in
the builder because we now return types from the pool directly, which
causes a failure when two incompatible types are registered under the
same ID.
Fixing that issue in the test exposed another bug in the rebuilder: we
were not re-building the element type for Array types. This was causing
a stale type reference inside Array types which was later caught by the
type removal logic in the test.
2024-04-09 10:36:21 -04:00
Jeremy Hayes
ade1f7cfd7
Add AliasedPointer decoration ( #5635 )
...
Fix #5607
When inlining, decorate return variable with AliasedPointer if the
storage class of the pointee type is PhysicalStorageBuffer.
2024-04-05 11:45:55 -06:00
dependabot[bot]
24f2cdad8e
build(deps): bump the github-actions group with 1 update ( #5634 )
...
Bumps the github-actions group with 1 update: [lukka/get-cmake](https://github.com/lukka/get-cmake ).
Updates `lukka/get-cmake` from 3.29.0 to 3.29.1
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](9438b96ac9...b111a57714
2024-04-04 13:39:15 -04:00
Nathan Gauër
58ab8baf72
docs: explain LunarG is the source of truth for releases ( #5627 )
...
GitHub releases were just the exact same as the LunarG releases,
since the same commit were used for both.
For this reason, we don't think it brings any value, and will stop
publishing new releases on the GitHub page.
Signed-off-by: Nathan Gauër <brioche@google.com>
2024-04-02 09:39:12 -07:00
github-actions[bot]
7fe5f75e58
Roll external/re2/ 6598a8ecd..917047f36 (3 commits) ( #5626 )
...
6598a8ecd5...917047f360
2024-03-29 22:34:40 +00:00
github-actions[bot]
87721a1009
Roll external/spirv-headers/ 7d500c4d7..4f7b471f1 (1 commit) ( #5625 )
...
7d500c4d75...4f7b471f1a#424 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
2024-03-28 13:53:59 -07:00
Kevin Gibson
fe7bae0906
Minor fix to cmakelists to avoid rerunning command each build ( #5620 )
2024-03-25 14:21:09 -07:00
dependabot[bot]
fc42865562
build(deps): bump the github-actions group with 2 updates ( #5621 )
...
Bumps the github-actions group with 2 updates: [lukka/get-cmake](https://github.com/lukka/get-cmake ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `lukka/get-cmake` from 3.28.4 to 3.29.0
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](70abef7192...9438b96ac9https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](05963f47d8...1b1aada464
2024-03-25 14:08:39 -04:00
github-actions[bot]
67451ebf6d
Roll external/spirv-headers/ 04db24d69..7d500c4d7 (1 commit) ( #5619 )
...
04db24d691...7d500c4d75#423 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
2024-03-25 17:50:54 +00:00
dependabot[bot]
dda7731e91
build(deps): bump the github-actions group with 2 updates ( #5618 )
...
Bumps the github-actions group with 2 updates: [actions/cache](https://github.com/actions/cache ) and [lukka/get-cmake](https://github.com/lukka/get-cmake ).
Updates `actions/cache` from 4.0.1 to 4.0.2
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](ab5e6d0c87...0c45773b62https://github.com/lukka/get-cmake/releases )
- [Commits](139aae9631...70abef7192
2024-03-21 12:13:11 -04:00
github-actions[bot]
3fafcc20e6
Roll external/spirv-headers/ 8b246ff75..04db24d69 (1 commit) ( #5617 )
...
8b246ff75c...04db24d691#399 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
2024-03-21 03:47:00 +00:00
dependabot[bot]
3a0471c3b6
build(deps): bump the github-actions group with 1 update ( #5615 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.24.7 to 3.24.8
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](3ab4101902...05963f47d8
2024-03-19 12:49:03 -04:00
github-actions[bot]
6c3f632a2c
roll deps ( #5614 )
...
* Roll external/googletest/ c231e6f5b..eff443c6e (1 commit)
c231e6f5b1...eff443c6efdb46d1e11e...6598a8ecd5
2024-03-19 04:19:53 +00:00
github-actions[bot]
c6615779ef
Roll external/googletest/ b479e7a3c..c231e6f5b (1 commit) ( #5613 )
...
* Roll external/googletest/ b479e7a3c..c231e6f5b (1 commit)
b479e7a3c1...c231e6f5b1108914d28a...db46d1e11e
2024-03-18 16:58:32 +00:00
Romaric Jodin
f20663ca7f
add support for vulkan-shader-profiler external passes ( #5512 )
2024-03-15 13:46:42 -04:00
github-actions[bot]
f74f4e74c5
Roll external/re2/ ed9fc269e..d00d1e937 (2 commits) ( #5589 )
...
* Roll external/googletest/ 5df0241ea..b479e7a3c (11 commits)
5df0241ea4...b479e7a3c19756ee7cba9756ee7cbadbf15a205c...108914d28a
2024-03-15 16:27:52 +00:00
dependabot[bot]
e39cabca20
build(deps): bump the github-actions group with 2 updates ( #5610 )
...
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/checkout` from 4.1.1 to 4.1.2
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](b4ffde65f4...9bb56186c3https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8a470fddaf...3ab4101902
2024-03-14 18:15:11 -04:00
Cassandra Beckley
efb0fce2d6
Use bazel 7 and bzlmod ( #5601 )
...
* Use bazel 7 and bzlmod
Many of our dependencies are now using bazel 7 and the new bzlmod module
system. This has been breaking our autoroll; this PR should fix the
issues we've been having with that.
It may or may not be worthwhile to update effcee to use bzlmod as well;
this would let us get rid of WORKSPACE entirely.
* Try to force cla check to rerun
2024-03-14 14:42:12 -07:00
Cassandra Beckley
02c79e9082
kokoro: Update bazel to 7.0.2 for Linux builds ( #5609 )
2024-03-13 13:21:35 -04:00
Kévin Petit
f869d391a5
[OPT] Fix handling of analyses rebuild ( #5608 )
...
All tests treat kAnalysisEnd like STL end iterators, which
means its value must be greater than that of the last valid
Analysis.
Change-Id: Ibfaaf60bb450c508af0528dbe9c0729e6aa07b3b
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
2024-03-12 09:09:46 +00:00
David Neto
d15a7aa25d
kokoro: Update bazel to 7.0.2 for Mac builds ( #5606 )
2024-03-11 09:57:43 -07:00
Michael Anttila
04896c462d
Prepare release v2024.1 ( #5605 )
...
* Roll external/spirv-headers/ b73e168ca..8b246ff75 (1 commit)
b73e168ca5...8b246ff75c#417 )
Created with:
roll-dep external/spirv-headers
* Prepare release 2024.1
2024-03-07 10:31:14 -05:00
Rodrigo Locatti
7c363050de
Add operand types for SPV_NV_raw_access_chains ( #5602 )
...
This is needed to unblock builds with updated SPIR-V headers.
It is not a replacement for #5568 .
2024-03-06 10:42:22 -05:00
dependabot[bot]
5bc7c28763
build(deps): bump the github-actions group with 2 updates ( #5598 )
...
Bumps the github-actions group with 2 updates: [actions/cache](https://github.com/actions/cache ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/cache` from 4.0.0 to 4.0.1
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](13aacd865c...ab5e6d0c87https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](47b3d888fe...8a470fddaf
2024-03-04 13:00:12 -05:00
Kévin Petit
75ad1345d4
Remove redundant function declarations from source/operand.h ( #5584 )
...
Flagged by -Wredundant-decls
I'm assuming the declarations in libspirv.h are part of the external
interface and need to be kept.
Change-Id: I6b138d3322a7a4ee49ee33b0fbcf0ca35dd92261
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
2024-02-29 17:46:38 +00:00
Wooyoung Kim
9bd44d028e
Suppot for SPV_QCOM_image_processing2 ( #5582 )
2024-02-28 16:26:28 -05:00
Viktoria Maximova
0b027bafa5
Support operand kind for SPV_INTEL_maximum_registers ( #5580 )
...
* Support operand kind for SPV_INTEL_maximum_registers
* improvements
* Update DEPS
2024-02-28 13:58:09 -05:00
alan-baker
fbc7a14b3e
Fix access chain struct checks ( #5592 )
...
* Fix access chain struct checks
Fixes https://crbug.com/oss-fuzz/66948
* Negative indices are invalid for struct access
* Fix typos
* formatting
2024-02-27 15:54:08 -05:00
dependabot[bot]
99a3ad32ff
build(deps): bump the github-actions group with 1 update ( #5594 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.24.4 to 3.24.5
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e2e140ad14...47b3d888fe
2024-02-26 12:51:21 -05:00
dependabot[bot]
c3a9ffd74f
build(deps): bump the github-actions group with 1 update ( #5593 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.24.3 to 3.24.4
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](379614612a...e2e140ad14
2024-02-23 12:36:47 -05:00
Spencer Fricke
1b643eac5d
spirv-val: Make Constant evaluation consistent ( #5587 )
...
Bring 64-bit evaluation in line with 32-bit evaluation.
2024-02-21 17:52:13 -05:00
github-actions[bot]
dc6676445b
Roll external/googletest/ 6eb225cb8..5df0241ea (2 commits) ( #5583 )
...
* Roll external/googletest/ 6eb225cb8..5df0241ea (2 commits)
6eb225cb88...5df0241ea4b4c6fe091b...ed9fc269e2
2024-02-16 19:28:03 -05:00
Cassandra Beckley
7da2c941f0
Update WORKSPACE ( #5588 )
...
* Update WORKSPACE
Same purpose as #5585 , but a bit less intrusive perhaps.
* Update WORKSPACE
Add `rules_license`, needed by `platforms`.
2024-02-16 15:09:08 -08:00
dependabot[bot]
16af142c15
build(deps): bump the github-actions group with 1 update ( #5586 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.24.1 to 3.24.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e675ced7a7...379614612a
2024-02-16 12:04:01 -05:00
Jeff Bolz
b0a5c4ac12
SPV_NV_shader_atomic_fp16_vector ( #5581 )
2024-02-14 15:58:12 -05:00
dependabot[bot]
55cb3989ec
build(deps): bump the github-actions group with 1 update ( #5578 )
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.24.0 to 3.24.1
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e8893c57a1...e675ced7a7
2024-02-14 13:53:33 -05:00
github-actions[bot]
11afeb4bb1
roll deps ( #5576 )
...
* Roll external/googletest/ b75ecf1be..6eb225cb8 (1 commit)
b75ecf1bed...6eb225cb88ab7c5918b4...b4c6fe091b
2024-02-14 18:25:53 +00:00
Steven Perron
7604147c25
[OPT] Add removed unused interface var pass to legalization passes ( #5579 )
...
DXC does not do a good job of recognizing which variables need to be
on the entry point for which functions. This is because it does not
want to have to walk the call tree to determine which instructions
are reachable from which entry points.
This is also useful if the same input variable gets used from two
different shader, but the uses in one get optimized away.
Will parially fix
https://github.com/microsoft/DirectXShaderCompiler/issues/4621 . Will not
fix code compiled with -fcgl.
2024-02-14 13:08:25 -05:00
Spencer Fricke
f9184c6501
spirv-val: Revert Validate PhysicalStorageBuffer Stage Interface ( #5575 )
2024-02-13 21:24:20 -05:00
Spencer Fricke
20ad38c18d
spirv-val: Multiple interface var with same SC ( #5528 )
2024-02-13 15:55:43 -05:00
Steven Perron
e08c012b19
[OPT] Identify arrays with unknown length in copy prop arrays ( #5570 )
...
* [OPT] Identify arrays with unknown length in copy prop arrays
The code in copy propagate arrays assumes that the length of an
OpTypeArray is known at compile time, but that is not true when the size
is an OpSpecConstant. We try to fix that assumption.
Fixes https://crbug.com/oss-fuzz/66634
2024-02-13 14:41:38 -05:00
github-actions[bot]
56a51dd947
Roll external/spirv-headers/ e77d03080..d3c2a6fa9 (1 commit) ( #5574 )
...
e77d03080b...d3c2a6fa95#413 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
Co-authored-by: Cassandra Beckley <cbeckley@google.com>
2024-02-13 14:19:09 -05:00
Ben Ashbaugh
0c986f596d
update image enum tests to remove Kernel capability ( #5562 )
...
We are removing Kernel from the image channel order and image
channel data type enums because Kernel is already required
transitively, so we need to update the tests to match.
2024-02-13 11:07:39 -05:00
Steven Perron
b7413609cf
[OPT] Use new instruction folder for for all opcodes in spec consti folding ( #5569 )
...
* [OPT] Use new instruction folder for for all opcodes in spec consti folding
When folding and OpSpecConstantOp, we use the new instruction folder for
a small number of opcodes. This enable the new instruction folder for
all opcodes and uses the old one as a fall back. This allows us to
remove some code from the older folder that is now covered by the new
one.
Fixes #5499
2024-02-12 19:52:55 +00:00
Spencer Fricke
784b064f90
spirv-val: Validate PhysicalStorageBuffer Stage Interface ( #5539 )
...
Disallow PhysicalStorageBuffer pointers in Input and Output storage classes.
2024-02-12 09:51:38 -05:00
Steven Perron
a8959dc653
Fold 64-bit int operations ( #5561 )
...
Adds folding rules that will fold basic artimetic for signed and
unsigned integers of all sizes, including 64-bit.
Also folds OpSConvert and OpUConvert.
2024-02-09 14:02:48 -05:00
github-actions[bot]
80926d97ab
roll deps ( #5566 )
...
* Roll external/googletest/ 64be1c79f..b75ecf1be (2 commits)
64be1c79fa...b75ecf1bed1c9115b562...e77d03080b#414 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2024-02-08 19:47:36 +00:00
dependabot[bot]
9a7b1af906
build(deps): bump the github-actions group with 1 update ( #5564 )
...
Bumps the github-actions group with 1 update: [lukka/get-cmake](https://github.com/lukka/get-cmake ).
Updates `lukka/get-cmake` from 3.28.2 to 3.28.3
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](23a189c2ed...139aae9631
2024-02-07 14:15:04 -05:00
github-actions[bot]
1a2cbabd8b
Roll external/googletest/ 48729681a..64be1c79f (1 commit) ( #5563 )
...
48729681ad...64be1c79fa
2024-02-07 18:27:25 +00:00
dependabot[bot]
7657cb1c69
build(deps): bump the github-actions group with 3 updates ( #5560 )
...
Bumps the github-actions group with 3 updates: [lukka/get-cmake](https://github.com/lukka/get-cmake ), [actions/upload-artifact](https://github.com/actions/upload-artifact ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `lukka/get-cmake` from 3.28.1 to 3.28.2
- [Release notes](https://github.com/lukka/get-cmake/releases )
- [Commits](2654d8ee38...23a189c2edhttps://github.com/actions/upload-artifact/releases )
- [Commits](26f96dfa69...5d5d22a312https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b7bf0a3ed3...e8893c57a1
2024-02-06 11:09:41 -08:00
