Go to file
Joseph Myers db6c4935fa Fix memmove call in vfprintf-internal.c:group_number
A recent GCC mainline change introduces errors of the form:

vfprintf-internal.c: In function 'group_number':
vfprintf-internal.c:2093:15: error: 'memmove' specified bound between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
 2093 |               memmove (w, s, (front_ptr -s) * sizeof (CHAR_T));
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is a genuine bug in the glibc code: s > front_ptr is always true
at this point in the code, and the intent is clearly for the
subtraction to be the other way round.  The other arguments to the
memmove call here also appear to be wrong; w and s point just *after*
the destination and source for copying the rest of the number, so the
size needs to be subtracted to get appropriate pointers for the
copying.  Adjust the memmove call to conform to the apparent intent of
the code, so fixing the -Wstringop-overflow error.

Now, if the original code were ever executed, a buffer overrun would
result.  However, I believe this code (introduced in commit
edc1686af0, "vfprintf: Reuse work_buffer
in group_number", so in glibc 2.26) is unreachable in prior glibc
releases (so there is no need for a bug in Bugzilla, no need to
consider any backports unless someone wants to build older glibc
releases with GCC 12 and no possibility of this buffer overrun
resulting in a security issue).

work_buffer is 1000 bytes / 250 wide characters.  This case is only
reachable if an initial part of the number, plus a grouped copy of the
rest of the number, fail to fit in that space; that is, if the grouped
number fails to fit in the space.  In the wide character case,
grouping is always one wide character, so even with a locale (of which
there aren't any in glibc) grouping every digit, a number would need
to occupy at least 125 wide characters to overflow, and a 64-bit
integer occupies at most 23 characters in octal including a leading 0.
In the narrow character case, the multibyte encoding of the grouping
separator would need to be at least 42 bytes to overflow, again
supposing grouping every digit, but MB_LEN_MAX is 16.  So even if we
admit the case of artificially constructed locales not shipped with
glibc, given that such a locale would need to use one of the character
sets supported by glibc, this code cannot be reached at present.  (And
POSIX only actually specifies the ' flag for grouping for decimal
output, though glibc acts on it for other bases as well.)

With binary output (if you consider use of grouping there to be
valid), you'd need a 15-byte multibyte character for overflow; I don't
know if any supported character set has such a character (if, again,
we admit constructed locales using grouping every digit and a grouping
separator chosen to have a multibyte encoding as long as possible, as
well as accepting use of grouping with binary), but given that we have
this code at all (clearly it's not *correct*, or in accordance with
the principle of avoiding arbitrary limits, to skip grouping on
running out of internal space like that), I don't think it should need
any further changes for binary printf support to go in.

On the other hand, support for large sizes of _BitInt in printf (see
the N2858 proposal) *would* require something to be done about such
arbitrary limits (presumably using dynamic allocation in printf again,
for sufficiently large _BitInt arguments only - currently only
floating-point uses dynamic allocation, and, as previously discussed,
that could actually be replaced by bounded allocation given smarter
code).

Tested with build-many-glibcs.py for aarch64-linux-gnu (GCC mainline).
Also tested natively for x86_64.
2021-11-08 19:11:51 +00:00
argp Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
assert Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
benchtests benchtests: Add partial overlap case in bench-memmove-walk.c 2021-11-06 16:17:59 -05:00
bits Add missing braces to bsearch inline implementation [BZ #28400] 2021-09-30 20:40:12 +02:00
catgets Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
ChangeLog.old Update ChangeLog.old/ChangeLog.23. 2021-08-01 21:33:43 -04:00
conform Use $(pie-default) with conformtest 2021-09-17 19:24:14 +00:00
crypt Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
csu Extend struct r_debug to support multiple namespaces [BZ #15971] 2021-09-19 13:51:35 -07:00
ctype Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
debug debug: Add tests for _FORTIFY_SOURCE=3 2021-10-20 18:13:05 +05:30
dirent Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
dlfcn Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
elf elf: Earlier missing dynamic segment check in _dl_map_object_from_fd 2021-11-05 19:34:16 +01:00
gmon Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
gnulib Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
grp Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
gshadow Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
hesiod Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
htl htl: Fix sigset of main thread 2021-09-26 02:40:26 +02:00
hurd Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
iconv iconv: Use TIMEOUTFACTOR for iconv test timeout 2021-10-21 11:11:07 -03:00
iconvdata gconv: Do not emit spurious NUL character in ISO-2022-JP-3 (bug 28524) 2021-11-04 19:59:42 +01:00
include String: Add hidden defs for __memcmpeq() to enable internal usage 2021-10-26 16:51:29 -05:00
inet Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
intl Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
io Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
libio Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
locale locale: Add missing second argument to _Static_assert in C-collate-seq.c 2021-09-06 19:43:37 +02:00
localedata locale: Fix localedata/sort-test undefined behavior 2021-11-08 15:28:48 -03:00
login login: Add back libutil as an empty library 2021-10-29 06:18:55 +09:00
mach Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
malloc Disable -Waggressive-loop-optimizations warnings in tst-dynarray.c 2021-10-29 14:40:45 +00:00
manual elf: Fix slow DSO sorting behavior in dynamic loader (BZ #17645) 2021-10-21 11:23:53 -03:00
math math: Also xfail the new j0f tests for ibm128-libgcc 2021-10-06 10:50:31 -03:00
mathvec Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
misc Add alloc_align attribute to memalign et al 2021-10-21 00:19:20 +01:00
nis Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
nptl nptl: Fix tst-cancel7 and tst-cancelx7 pidfile race 2021-10-18 13:30:10 -03:00
nptl_db Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
nscd Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
nss nss: Unnest nested function add_key 2021-10-19 09:36:43 -07:00
po po/nl.po: Update Dutch translation. 2021-08-01 20:52:28 -04:00
posix regex: Unnest nested functions in regcomp.c 2021-11-02 10:07:59 -07:00
pwd Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
resolv resolv: Avoid GCC 12 false positive warning [BZ #28439]. 2021-10-11 09:36:57 -06:00
resource y2038: Add support for 64-bit time on legacy ABIs 2021-06-15 10:42:11 -03:00
rt Remove unreliable parts of rt/tst-cpuclock2 2021-10-07 22:38:49 -04:00
scripts Configure GCC with --enable-initfini-array [BZ #27945] 2021-11-05 15:30:02 -07:00
setjmp nptl: Move __pthread_unwind_next into libc 2021-04-21 19:49:50 +02:00
shadow Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
signal Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
socket Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
soft-fp Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
stdio-common Fix memmove call in vfprintf-internal.c:group_number 2021-11-08 19:11:51 +00:00
stdlib Add alloc_align attribute to memalign et al 2021-10-21 00:19:20 +01:00
string test-memcpy.c: Double TIMEOUT to (8 * 60) 2021-11-07 10:09:33 -08:00
sunrpc Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
support elf: Testing infrastructure for ld.so DSO sorting (BZ #17645) 2021-10-21 11:23:53 -03:00
sysdeps hurd: Remove unused __libc_close_range 2021-11-07 16:23:51 +01:00
sysvipc Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
termios Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
time Fix subscript error with odd TZif file [BZ #28338] 2021-10-07 11:09:16 -03:00
timezone Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
wcsmbs Make sure that the fortified function conditionals are constant 2021-10-20 18:12:41 +05:30
wctype Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
.gitattributes
.gitignore
abi-tags
aclocal.m4 Fix LIBC_PROG_BINUTILS for -fuse-ld=lld 2021-10-29 09:21:37 -03:00
config.h.in elf: Remove Intel MPX support (lazy PLT, ld.so profile, and LD_AUDIT) 2021-10-11 11:14:02 -07:00
config.make.in Add pthread-in-libc, libpthread-routines-var, librt-routines-var 2021-05-03 08:13:32 +02:00
configure Check if linker also support -mtls-dialect=gnu2 2021-10-29 09:21:37 -03:00
configure.ac Check if linker also support -mtls-dialect=gnu2 2021-10-29 09:21:37 -03:00
CONTRIBUTED-BY Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
COPYING
COPYING.LIB
extra-lib.mk
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL Update install.texi, and regenerate INSTALL. 2021-08-01 16:48:43 -04:00
libc-abis riscv: support GNU indirect function 2021-01-10 21:25:13 -05:00
libof-iterator.mk
LICENSES Prefer https to http for gnu.org and fsf.org URLs 2019-09-07 02:43:31 -07:00
MAINTAINERS
Makeconfig Run conform/ tests using newly built libc 2021-09-17 13:12:10 +00:00
Makefile testrun.sh: Add support for --tool=rpctrace 2021-09-10 01:24:10 +02:00
Makefile.help Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Makefile.in
Makerules Remove the last trace of generate-md5 [BZ #28554] 2021-11-06 06:21:44 -07:00
NEWS NEWS: Add item for __memcmpeq 2021-10-26 16:51:29 -05:00
o-iterator.mk
README Documentation for the RISC-V 32-bit port 2020-08-27 08:17:44 -07:00
Rules Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
SHARED-FILES Mention today's regex merge in SHARED-FILES 2021-09-21 18:00:10 -07:00
shlib-versions Move malloc hooks into a compat DSO 2021-07-22 18:37:59 +05:30
test-skeleton.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
version.h Open master branch for glibc 2.35 development 2021-08-01 21:54:40 -04:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arc*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv32-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.