2008-06-10 Carlos Garnacho <carlos@imendio.com>
* configure.in:
* gtk/Makefile.am:
* gtk/xdgmime: removed local xdgmime copy as Matthias suggested in bug
#520874, comment #8. It's no longer used directly by GTK+.
svn path=/trunk/; revision=20343
2008-06-10 Carlos Garnacho <carlos@imendio.com>
Bug 520874 - Should use gio directly.
* gtk/gtkfilesystem.[ch]: Turn into a private object, which mostly
provides helper functions for asynchronous calls, folder abstraction
and uniform handling of volumes/drives/mounts.
* gtk/gtkfilesystemwin32.[ch]:
* gtk/gtkfilesystemunix.[ch]: Removed, these are no longer required.
* gtk/gtkfilechooser.c:
* gtk/gtkfilechooserbutton.c:
* gtk/gtkfilechooserdefault.c:
* gtk/gtkfilechooserentry.[ch]:
* gtk/gtkfilechooserprivate.h:
* gtk/gtkfilechooserutils.c:
* gtk/gtkfilesystemmodel.[ch]:
* gtk/gtkpathbar.[ch]: Use GIO internally. Adapt to GtkFileSystem API.
Do not load filesystem implementation modules.
* gtk/Makefile.am:
* gtk/gtk.symbols: the gtkfilesystem.h private header isn't installed
anymore, nor the unix/win32 implementations.
* README.in: Add blurb about these changes.
svn path=/trunk/; revision=20342
2008-06-09 Kristian Rietveld <kris@gtk.org>
Bug 526987 - GtkCellRendererCombo should allow model to be NULL
* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init),
(gtk_cell_renderer_combo_set_property),
(gtk_cell_renderer_combo_editing_done),
(gtk_cell_renderer_combo_start_editing): introduce private class
struct, allow model to be set to NULL.
svn path=/trunk/; revision=20340
2008-06-08 Björn Lindqvist <bjourne@gmail.com>
Bug 131920 – gtkNotebook sends incorrect switch_page value
* gtk/gtknotebook.c (gtk_notebook_real_remove): Make switch-page
signal send correct page index when page index 0 is active and
removed. (#131920, Samuel Fogh)
svn path=/trunk/; revision=20339
2008-06-08 Kristian Rietveld <kris@gtk.org>
Bug 536730 - memory corruption in gtktreeview
* gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): first
remove the expand/collapse timeout and node, then free the rbtree.
svn path=/trunk/; revision=20334
2008-06-08 Kristian Rietveld <kris@gtk.org>
Bug 488119 - critical warnings from gtk_tree_view_get_visible_range
* gtk/gtktreeview.c (gtk_tree_view_get_visible_range): only try to
find path if we found valid nodes, return FALSE otherwise. (Patch
from Matthias Clasen).
svn path=/trunk/; revision=20333
Don't store the accel path as a string in gtkmenu/gtkmenuitem.
The accel path will be interned anyway, so keeping a string copy around
is just a waste of memory.
Improve the documentation to mention this.
svn path=/trunk/; revision=20331
2008-06-05 Johan Dahlin <jdahlin@async.com.br>
* gtk/gtkbuilder.h (enum): Add the new version mismatch error
constant to the end of the list, to avoid breaking the stable ABI
svn path=/trunk/; revision=20319
2008-06-05 Li Yuan <li.yuan@sun.com>
* gail-uninstalled.pc.in:
Bug #536430. Patch from Damien Carbery <damien.carbery@sun.com>.
Correct paths to gail headers and libraries in
gail-uninstalled.pc.in.
svn path=/trunk/; revision=20316
2008-06-03 Federico Mena Quintero <federico@novell.com>
* gtk/gtkfilechooserentry.c (install_completion_feedback_timer):
If the user presses Tab while the completion feedback window is
active, then we'll assert. Remove the assertion and just re-set
the timer. Fixes https://bugzilla.novell.com/show_bug.cgi?id=355225
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20305
2008-06-03 Colin Walters <walters@redhat.com>
Bug 535303 – add _get_implementation to GtkStatusIcon
* gtk/gtkstatusicon.c (gtk_status_icon_get_x11_window_id): New
function to retrieve internal X11 window ID, useful for libnotify.
* gtk/gtkstatusicon.h: Prototype it.
* docs/reference/gtk/gtk-sections.txt: Add to docs.
* gtk/gtk.symbols: Export it.
svn path=/trunk/; revision=20304
2008-06-03 Michael Natterer <mitch@imendio.com>
* gtk/gtkclist.h
* gtk/gtkctree.h: revert includes to how they have been before the
GTK_DISABLE_SINGLE_INCLUDES changes. Apparently I missed the fact
that you can't include <gtk/gtk.h> from two headers where one is a
parent class of the other and expect them both to be includable
individually.
svn path=/trunk/; revision=20302
* gtk/gtkentrycompletion.c (gtk_entry_completion_init): Set
a type hint on the popup window to help compiz.
Patch by Vaclav Slavik.
svn path=/trunk/; revision=20294
2008-06-02 Claudio Saavedra <csaavedra@igalia.com>
Bug 535862 – gtk_action_create_icon can't create icons from the
icon themes
* gtk/gtkaction.c: (gtk_action_create_icon): Look for the icon in
the default factories as it's supposed.
svn path=/trunk/; revision=20290
2008-06-02 Michael Natterer <mitch@imendio.com>
* gtk/gtksignal.h: put back #include <gtk/gtkmarshal.h>, it's not
in <gtk/gtk.h>. Fixes stuff that uses deprecated cruft.
(bug #536126).
svn path=/trunk/; revision=20269
2008-05-31 Emmanuele Bassi <ebassi@gnome.org>
Bug 535830 – wrong content type adding an item
* gtk/gtkrecentmanager.c:
(gtk_recent_manager_add_item_query_info): Use the correct API
for retrieving the fast MIME type of a URI. (Carlos Garcia
Campos)
svn path=/trunk/; revision=20262
2008-05-31 Kristian Rietveld <kris@imendio.com>
Bug 530146 - Setting non-string tooltip with
gtk_tree_view_set_tooltip_column() segfaults
* gtk/gtktreeview.c (gtk_tree_view_set_tooltip_query_cb): use
gtk_tree_model_get_value() and explicitly transform the value to a
string before setting it as tooltip.
svn path=/trunk/; revision=20261
2008-05-30 Michael Natterer <mitch@imendio.com>
* gtk/gtkmenu.c (get_attach_info): cast attach_info_free() to
GDestroyNotify when using it in g_object_set_data_full().
svn path=/trunk/; revision=20257
2008-05-30 Michael Natterer <mitch@imendio.com>
* gdk/gdkapplaunchcontext.h
* gdk/gdktestutils.h
* gtk/gtkmountoperation.h
* gtk/gtkshow.h
* gtk/gtktestutils.h
* gtk/gtktoolshell.h: no need to allow disabling single includes
conditionally in these new files. Simply forbid including them
individually from the beginning.
svn path=/trunk/; revision=20256
2008-05-30 Michael Natterer <mitch@imendio.com>
* gtk/gtkmountoperation.h
* gtk/gtkshow.h
* gtk/gtktestutils.h
* gtk/gtktoolshell.h: no need to allow disabling single includes
conditionally in these new files. Simply forbid including them
individually from the beginning.
svn path=/trunk/; revision=20255
2008-05-30 Tor Lillqvist <tml@novell.com>
Bug 533108 - leak of GDI region in function 'handle_wm_paint'
* gdk/win32/gdkevents-win32.c (handle_wm_paint): Patch by Daniel
Atallah.
svn path=/trunk/; revision=20250
2008-05-29 Tor Lillqvist <tml@novell.com>
Bug 535526 - updateiconcache.c: using open/close without prototype
* gtk/updateiconcache.c: Include <io.h> if _MSC_VER. Also, use
g_utime() instead of utime() for UTF-8 pathname support on Windows
when available.
svn path=/trunk/; revision=20238
2008-05-27 Matthias Clasen <mclasen@redhat.com>
Bug 522084 – GIcon support for GtkIconTheme & GtkImage
* gtk/gtkicontheme.[hc]: Add support for GIcon based lookups.
* gtk/gtkimage.[hc]: Allow setting an image from a GIcon.
* gtk/gtk.symbols: Additions
* tests/testimage.c: Add a GIcon test
svn path=/trunk/; revision=20236
2008-05-29 Michael Natterer <mitch@imendio.org>
* gtk/Makefile.am
* gtk/gtkunixprint.h: add a single-include header for the unix
print stuff.
* gtk/gtkpagesetupunixdialog.h
* gtk/gtkprinter.h
* gtk/gtkprintjob.h
* gtk/gtkprintunixdialog.h: add single-include guards that #error
out if GTK_DISABLE_SINGLE_INCLUDES is defined and any of these
files is included individually.
* gtk/gtkprintbackend.h
* gtk/gtkprinter-private.h
* modules/printbackends/cups/gtkprintbackendcups.c
* modules/printbackends/cups/gtkprintercups.h
* modules/printbackends/lpr/gtkprintbackendlpr.c
* tests/buildertest.c
* tests/defaultvaluetest.c
* docs/tools/widgets.c: include <gtk/gtkunixprint.h> instead of
individual files.
svn path=/trunk/; revision=20230
2008-05-28 Michael Natterer <mitch@imendio.com>
* gtk/gtk*.h: whitespace cleanup: remove trailing whitespace and
excess newlines and sprinkled some newlines where needed. Zero
code or formatting changes included.
svn path=/trunk/; revision=20225
2008-05-28 Michael Natterer <mitch@imendio.com>
* gtk/gtkcolorbutton.h: fix comment: the widget is called
GtkColorButton, not GtkColorSelectButton. Remove trailing
whitespace and excess newlines.
svn path=/trunk/; revision=20223
2008-05-28 Michael Natterer <mitch@gimp.org>
* configure.in: last but not least, add G_DISABLE_SINGLE_INCLUDES,
GDK_PIXBUF_DISABLE_SINGLE_INCLUDES and GTK_DISABLE_SINGLE_INCLUDES
to CPPFLAGS so it's impossible to commit code that would break
apps which use DISABLE_INCLUDE defines.
svn path=/trunk/; revision=20222
2008-05-28 Michael Natterer <mitch@imendio.com>
* gtk/gtk.h: define __GTK_H_INSIDE__ around including all other
headers.
* gtk/gtktypebuiltins.h.template
* gtk/gtkversion.h.in
* gtk/gtk*.h: add single-include guards that #error out if
GTK_DISABLE_SINGLE_INCLUDES is defined and any of these files is
included individually.
* gtk/gtkprintbackend.h
* gtk/gtkprinter-private.h
* gtk/gtktextlayout.h
* gtk/gtktexttagprivate.h
* gtk/gtktexttypes.h
* gtk/gtktreedatalist.h: include <gtk/gtk.h> instead of individual
headers in these private or semi-private headers.
* gtk/gtkimmodule.h: also here because it's not in gtk.h.
* gtk/gtkpagesetupunixdialog.h
* gtk/gtkprinter.h
* gtk/gtkprintjob.h
* gtk/gtkprintunixdialog.h: likewise in the gtkunixprint headers.
* gtk/gtkclist.h
* gtk/gtkcombo.h
* gtk/gtkctree.h
* gtk/gtkfilesel.h
* gtk/gtkitemfactory.h
* gtk/gtklist.h
* gtk/gtklistitem.h
* gtk/gtkoldeditable.h
* gtk/gtkoptionmenu.h
* gtk/gtkpixmap.h
* gtk/gtkpreview.h
* gtk/gtksignal.h
* gtk/gtktipsquery.h: whenever possible, include only <gtk/gtk.h>
instead of individual headers in these deprecated headers. They
don't get included at all when GTK_DISABLE_DEPRECATED is defined,
so if an app needs them anyway, it must undef GTK_DISABLE_DEPRECATED
and include them individually, which should continue to work.
* gtk/gtkclist.c: include "gtkctree.h" because of the change
above.
svn path=/trunk/; revision=20221
2008-05-28 Kristian Rietveld <kris@imendio.com>
Bug 449625 - crash in gtk_tree_view_real_move_cursor at
gtktreeview.c:9641
* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down):
cursor_offset *must* be larger than background height of the cursor
node, not just equal otherwise there is no guarantee there is a next
node.
svn path=/trunk/; revision=20219
2008-05-28 Michael Natterer <mitch@imendio.com>
* gdk/gdk.h: define __GDK_H_INSIDE__ around including all other
headers.
* gdk/gdkenumtypes.h.template
* gdk/gdk*.h: add single-include guards that #error out if
GTK_DISABLE_SINGLE_INCLUDES is defined and any of these files is
included individually. Also removed some redundant includes and
did some tiny trailing whitespace removal that's not worth to
commit separately.
* gdk/gdkprivate.h: include <gdk/gdk.h> instead of individual
files.
* gdk/win32/gdkwin32.h
* gdk/x11/gdkx.h: only include <gdk/gdkprivate.h> and remove all
other includes.
svn path=/trunk/; revision=20217
2008-05-28 Kristian Rietveld <kris@imendio.com>
Bug 504087 - make gtk_tooltip_set_custom a no-op for setting the
current widget again.
* gtk/gtktooltip.c (gtk_tooltip_set_custom),
(gtk_tooltip_reset), (gtk_tooltip_run_requery): use a
custom_was_reset field to check if the custom widget is set again in
the query-tooltip callback; if not, we set it to NULL. Based on a
patch by Xavier Claessens, insightful comments from Jean-Yves Lefort
and Christian Persch.
svn path=/trunk/; revision=20215
2008-05-28 Michael Natterer <mitch@gimp.org>
* modules/other/gail/gailwidget.h: include <gtk/gtk.h> instead of
<gtk/gtkaccessible.h>
* modules/other/gail/*.h: don't include anyting from gtk since all
headers indirectly include gailwidget.h.
* modules/other/gail/gailcellparent.c: include <gtk/gtk.h> instead
of individual files.
* modules/other/gail/gailcheckmenuitem.c
* modules/other/gail/gailmenu.c
* modules/other/gail/gailtreeview.c: remove all gtk includes since
it's always included by including any gail header.
svn path=/trunk/; revision=20211
2008-05-28 Michael Natterer <mitch@imendio.com>
* demos/testpixbuf.c: include <gdk-pixbuf/gdk-pixbuf.h> instead of
individual files.
svn path=/trunk/; revision=20209
2006-05-28 Kristian Rietveld <kris@imendio.com>
Bug 324282 - add selected signal to cell renderer combo.
* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init),
(gtk_cell_renderer_combo_changed),
(gtk_cell_renderer_combo_start_editing): add a new "changed" signal
that will be emitted as soon as the combo box emitted changed and has
an active iterator. (Modified patch based on work by James
Pelletier).
* gtk/gtkmarshalers.list: add marshaler.
svn path=/trunk/; revision=20206
2008-05-28 Kristian Rietveld <kris@imendio.com>
Refactor expand/collapse timeout handling (amendment to bug 511217).
* gtk/gtktreeview.c (add_expand_collapse_timeout),
(remove_expand_collapse_timeout): new functions, the remove function
also clears expanded_collapsed_node,
(cancel_arrow_animation): moved to be next to the add/remove timeout
functions,
(gtk_tree_view_unrealize),
(gtk_tree_view_row_deleted),
(gtk_tree_view_set_model),
(cancel_arrow_animation),
(gtk_tree_view_real_expand_row),
(gtk_tree_view_real_collapse_row): use the new add/remove functions.
svn path=/trunk/; revision=20205
2008-05-28 Kristian Rietveld <kris@imendio.com>
Amendment of bug 485218 - Strange warning encountered.
* gtk/gtktreemodelsort.[ch]
(gtk_tree_model_sort_convert_child_iter_to_iter): return a boolean
indication whether or not the conversion had succeeded.
svn path=/trunk/; revision=20204
* modules/printbackends/cups/gtkprintbackendcups.c
(cups_printer_create_cairo_surface): Fall back to PostScript level 2
if the printer does not support level 3. Patch by Marek Kašík.
svn path=/trunk/; revision=20203
detail
* gtk/gtkmenu.c (gtk_menu_paint): Use "menu_scroll_arrow_up/down"
as detail when drawing scroll arrow backgrounds. Proposed by
Tommi Komulainen.
svn path=/trunk/; revision=20202
* gtk/gtktreeview.c (cancel_arrow_animation): Reset
expanded_collapsed_node when canceling the animation.
Patch by Nicholas Setton.
svn path=/trunk/; revision=20201
* gtk/gtkspinbutton.c (gtk_spin_button_real_value_change):
Commit the entry text before doing an increment. Patch by
Björn Lindqvist.
svn path=/trunk/; revision=20196
2008-05-27 Federico Mena Quintero <federico@novell.com>
http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow
drag and drop from the file list into itself, as it doesn't make
sense (it would just change the current folder).
* gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use
GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into
itself.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20194
2008-05-27 Michael Natterer <mitch@imendio.com>
* gtk/gtksignal.h: move deprecated guards around everything,
including includes and include guards (just as in all other
deprecated files).
svn path=/trunk/; revision=20191
2008-05-27 Tor Lillqvist <tml@novell.com>
* gtk/updateiconcache.c (build_cache): Use simpler mode for open()
on Windows. (No S_I?GRP and S_I?OTH bits are defined in
<sys/stat.h> on Windows, and the mode used in open() doesn't
matter much as there are no rwxrwxrwx bits on Windows anyway.)
Open file in binary mode. Passing "b" to fdopen() later isn't
enough.
svn path=/trunk/; revision=20190
2008-05-27 Carlos Garnacho <carlos@imendio.com>
* gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Enable
correctly dialog buttons sensitivity when the anonymous option is
enabled by default. Bug #531865.
svn path=/trunk/; revision=20183
2008-05-27 Carlos Garnacho <carlos@imendio.com>
* gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Set
password dialog modal and transient for the parent window also if it
was specified in the constructor. Bug #531864.
svn path=/trunk/; revision=20182
2008-05-26 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkevents-quartz.c: (gdk_screen_get_setting): Try
setting the default font, might need to tweak this.
svn path=/trunk/; revision=20181
2008-05-26 Michael Natterer <mitch@imendio.com>
* gtk/gtkshow.h: include "gdk/gdk.h" instead of "gdk/gdkscreen.h"
* gtk/gtkshow.c: remove inclusion of single files from gdk/
Removed trailing whitespace in both files.
svn path=/trunk/; revision=20176
2008-05-26 Richard Hult <richard@imendio.com>
Bug 530353 – Mac-like gtk_accelerator_get_label()
* gtk/gtkaccellabel.c: (gtk_accel_label_class_init),
(append_keyval_symbol), (_gtk_accel_label_class_get_accelerator_label):
On quartz, make gtk_accelerator_get_label() format a Mac-like
string, using unicode characters for modifier keys, arrows, delete
etc. Patch from Yevgen Muntyan.
svn path=/trunk/; revision=20175
2008-05-26 Richard Hult <richard@imendio.com>
Bug 534869 – Length miscalculation in
_gtk_quartz_get_selection_data_from_pasteboard
* gtk/gtkquartz.c: (_gtk_quartz_get_selection_data_from_pasteboard):
Get the number of bytes, not the number of characters, patch from
Yevgen Muntyan.
svn path=/trunk/; revision=20174
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 507389 – use gslice for gtksettings
* gtk/gtksettings.c: Change from g_new0/g_free to use GSlice.
Report and patch by Christian Persch.
svn path=/trunk/; revision=20168
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and
when options are missing
* gtk/updateiconcache.c: Open the cache file (O_CREAT | O_EXCL) so
that other processes that try to open it will fail gracefully. Also
fix a crasher caused by lack of a NULL check. Report and patch
by Erwann Chenede.
svn path=/trunk/; revision=20167
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 526635 - _gdk_window_get_toplevel handles FOREIGN windows
* gdk/x11/gdkwindow-x11.c (_gdk_window_get_toplevel): Check
!WINDOW_IS_TOPLEVEL instead of checking for GDK_WINDOW_CHILD,
so that we also take into account for foreign windows.
Report and patch by Nathaniel Smith.
svn path=/trunk/; revision=20166
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 525461 - Don't invalidate under an input-only child
* gdk/x11/gdkgeometry-x11.c (_gdk_window_move_resize_child):
Check that the window is not input-only before invalidating.
Report and patch by Owen Taylor.
svn path=/trunk/; revision=20165
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 524110 - Gdk should not assume reparenting WMs when retrieving
window frame extents
* gdk/x11/gdkwindow-x11.c (gdk_window_get_frame_extents):
Use _NET_FRAME_EXTENTS, if available. Patch by Danny Baumann.
svn path=/trunk/; revision=20164
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 522269 - Evince windows sometimes incorrectly unmaximized,
caused by missing flag initialization
* gdk/x11/gdkwindow-x11.c (set_initial_hints): Initialize
top-level private flags correctly. Patch by Danny Baumann.
svn path=/trunk/; revision=20163
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 534463 - non-editable GtkTextView should not call
gtk_im_context_focus_in in focus event
* gtk/gtktextview.c: Add checks to see if the textview is
editable. Patch by Wang Diancheng.
svn path=/trunk/; revision=20162
