Emmanuele Bassi
8f8b68f847
Terminate strncpy() buffers correctly
...
When using strncpy() with a buffer we need to account for the
terminating NUL character. GCC 8 started warning when using PPD_MAX_NAME
as the buffer length for strncpy() because the buffer we're copying into
has the same length — which means that the terminating NUL may be
skipped if the source string has a length of PPD_MAX_NAME.
The appropriate way to handle the case where we're copying a source with
a length bigger than of PPD_MAX_NAME is, as reported in the strncpy()
documentation, to copy `PPD_MAX_NAME - 1` bytes, and explicitly NUL
terminate the destination buffer. This has the additional benefit of
avoiding the compiler warning.
2019-02-05 15:34:08 +01:00
Emmanuele Bassi
eb732b3f68
container: Disable deprecation warnings
...
We know we're using deprecated GtkContainer API, because we're
implementing it.
2019-02-05 15:23:09 +01:00
Emmanuele Bassi
c2ddb932b2
popover: Disable deprecation warning
...
For gtk_render_frame_gap().
2019-02-05 15:22:06 +01:00
Emmanuele Bassi
d9d3ec7cad
menu: Fix condition check
...
A logical "and" became a binary "and" in commit c35878ec
.
2019-02-05 15:18:41 +01:00
Matthias Clasen
f533ef8650
Link gdk against fribidi
...
It is required now.
2019-02-05 07:17:07 -05:00
Matthias Clasen
bf60bf15de
3.24.5
2019-02-04 11:48:56 -05:00
Jakub Steiner
224213dad6
Adwaita: selection mode buttons fix
...
- don't allow the headerbar :active darkening (bug #1588 ) to override
selection-mode blue buttons.
Fixes issue #1642
2019-02-04 17:24:55 +01:00
Jakub Steiner
1661e2888a
Merge branch 'wip/jimmac/adwaita-3-32' into 'gtk-3-24'
...
Wip/jimmac/adwaita 3 32
See merge request GNOME/gtk!551
2019-02-04 14:27:58 +00:00
Alex Monday
7c325ed852
HighContrast: Add style for overflow buttons
...
Add missing style for overflow buttons located on scrollable dropdown
menus.
2019-02-04 15:08:07 +01:00
Alex Monday
950480cea4
HighContrast: Add menu padding
...
Add 1px padding to menus, to prevent menuitems and overflow buttons
overlapping with menu's border.
2019-02-04 15:07:56 +01:00
Jakub Steiner
57ba052522
Revert "HighContrast: Add style for overflow buttons"
...
This reverts commit ff4dcf5fa4
.
2019-02-04 15:05:43 +01:00
Jakub Steiner
af3bcc6adc
Revert "HighContrast: Add menu padding"
...
Revert conflicting patches to rebase adwaita-3-32 easily. will apply afterwards.
This reverts commit a7ea8248ce
.
2019-02-04 15:05:43 +01:00
Balázs Úr
391469e365
Update Hungarian translation
2019-02-04 15:05:43 +01:00
Balázs Úr
cca1cf03df
Update Hungarian translation
2019-02-04 15:05:43 +01:00
Matthias Clasen
ffa8fef2fa
gtk: Stop using deprecated pango api
2019-02-04 15:05:43 +01:00
Matthias Clasen
13c126b277
gtk: Add a copy of some deprecated pango api
...
We use pango_find_base_dir() in a few places, and
this api has been deprecated.
2019-02-04 15:05:43 +01:00
Matthias Clasen
148650c23a
gdk: Stop using deprecated pango api
2019-02-04 15:05:43 +01:00
Matthias Clasen
8c973bd837
gdk: Add a copy of pango_unichar_direction
...
This api has been deprecated in pango.
2019-02-04 15:05:43 +01:00
Matthias Clasen
3e5a7bb898
Add an explicit fribidi dependency
...
We already depend on it indirectly, via pango.
And we will use it to replace deprecated pango apis.
2019-02-04 15:05:43 +01:00
Christian Hergert
53767ce1d3
quartz: release linked list as we process it
...
Rather than performing the list iteration and the list free as separate
steps, free the list link while iterating.
2019-02-04 15:05:43 +01:00
Alex Monday
806e98d67e
HighContrast: Add style for overflow buttons
...
Add missing style for overflow buttons located on scrollable dropdown
menus.
2019-02-04 15:05:43 +01:00
Alex Monday
377b2872be
HighContrast: Add menu padding
...
Add 1px padding to menus, to prevent menuitems and overflow buttons
overlapping with menu's border.
2019-02-04 15:05:43 +01:00
Emmanuele Bassi
e28c7a41ee
switch: Take gadget clip into account
...
Now that we've switched the on and off states to gadgets, we need to
ensure that the widget's clip take into account the clip of every
gadget.
Fixes #1631
2019-02-04 15:05:43 +01:00
Tomasz Miąsko
7644c0866b
g-i: Add transfer none annotations for frame clock timings getters
2019-02-04 15:05:43 +01:00
Alex Monday
933765204f
Adwaita: Horizontal OSD spinbutton entry fix
...
Add placeholder to hande horizontal spinbutton entries,
add instructions for horizontal OSD spinbutton entry to use this
placeholder.
2019-02-04 15:05:43 +01:00
Balázs Úr
43b6541eae
Update Hungarian translation
2019-02-03 13:57:00 +00:00
Balázs Úr
3937fb4ebe
Update Hungarian translation
2019-02-02 14:55:21 +00:00
Benjamin Otte
df890474ed
Merge branch 'pango-deprecations' into 'gtk-3-24'
...
Pango deprecations
See merge request GNOME/gtk!544
2019-01-31 20:08:30 +00:00
Matthias Clasen
a3f1e02b9b
gtk: Stop using deprecated pango api
2019-01-31 14:07:28 -05:00
Matthias Clasen
c23e07f60f
gtk: Add a copy of some deprecated pango api
...
We use pango_find_base_dir() in a few places, and
this api has been deprecated.
2019-01-31 14:07:28 -05:00
Matthias Clasen
3da6497d9f
gdk: Stop using deprecated pango api
2019-01-31 14:07:28 -05:00
Matthias Clasen
998314b8ba
gdk: Add a copy of pango_unichar_direction
...
This api has been deprecated in pango.
2019-01-31 14:07:28 -05:00
Matthias Clasen
417c57e5b7
Add an explicit fribidi dependency
...
We already depend on it indirectly, via pango.
And we will use it to replace deprecated pango apis.
2019-01-31 14:07:28 -05:00
Christian Hergert
99d013994b
quartz: release linked list as we process it
...
Rather than performing the list iteration and the list free as separate
steps, free the list link while iterating.
2019-01-31 17:55:19 +01:00
Alex Monday
ff4dcf5fa4
HighContrast: Add style for overflow buttons
...
Add missing style for overflow buttons located on scrollable dropdown
menus.
2019-01-31 16:43:39 +01:00
Alex Monday
a7ea8248ce
HighContrast: Add menu padding
...
Add 1px padding to menus, to prevent menuitems and overflow buttons
overlapping with menu's border.
2019-01-31 16:43:30 +01:00
Alex Monday
7395160e5b
Adwaita: Improve dropdown menu buttons
...
Improve overflow arrow buttons drawing on a scrollable dropdown menu:
reduce top button's margin-top to match size of a bottom button, add
margin-top for bottom button to compensate bottom margin (otherwise
button overlaps with menu content).
Closes https://gitlab.gnome.org/GNOME/gtk/issues/1539
2019-01-31 16:42:32 +01:00
Benjamin Otte
2c15e59c16
Merge branch 'issue-1631' into 'gtk-3-24'
...
switch: Take gadget clip into account
See merge request GNOME/gtk!543
2019-01-30 19:20:46 +00:00
Emmanuele Bassi
0a9aa768d8
switch: Take gadget clip into account
...
Now that we've switched the on and off states to gadgets, we need to
ensure that the widget's clip take into account the clip of every
gadget.
Fixes #1631
2019-01-30 18:41:24 +00:00
Christoph Reiter
a0129f556b
Merge branch 'get-timings-transfer-3' into 'gtk-3-24'
...
g-i: Add transfer none annotations for frame clock timings getters
See merge request GNOME/gtk!512
2019-01-29 10:36:19 +00:00
Jakub Steiner
64c28f40a0
Merge branch 'adwaita-osd-spinbutton-entry-fix-3-24' into 'gtk-3-24'
...
Horizontal OSD spinbutton entry fix
See merge request GNOME/gtk!331
2019-01-29 09:40:51 +00:00
Jakub Steiner
b522c59880
Adwaita: switches with no labels
...
- it's less busy and still clearer without the label
- It may be right that color alone is a poor differentiator,
but labels do still exist for the accessible theme.
2019-01-28 12:34:48 +01:00
Jakub Steiner
519ff2ac6a
Merge branch 'fix-button-icon-position' into 'wip/jimmac/adwaita-3-32'
...
Adwaita: Fix wrong icon position in some buttons
See merge request GNOME/gtk!533
2019-01-28 11:57:42 +01:00
Jakub Steiner
6f1e611c3b
Merge branch 'wip/jimmac/adwaita-3-32' into 'fix-button-icon-position'
...
# Conflicts:
# gtk/theme/Adwaita/_common.scss
# gtk/theme/Adwaita/gtk-contained-dark.css
# gtk/theme/Adwaita/gtk-contained.css
2019-01-28 10:46:48 +00:00
Sam Hewitt
17ab084f28
Adwaita: fix padding and rounding on menubar submenus
2019-01-28 11:43:54 +01:00
Jakub Steiner
4d08be5d03
Adwaita: selection mode labels
...
- when not in focus, make sure labels are legible
but flat.
Fixes issue #1562
2019-01-28 11:43:54 +01:00
Jakub Steiner
b6082efdc0
Adwaita: use neutral greys for dark
...
- the hint of warm color is too subtle to even notice for most people
Fixes issue #1589
2019-01-28 11:43:54 +01:00
Jakub Steiner
aa1e565fb5
Adwaita: darken dark mode
...
- match lightness of the old theme.
Fixes issue #1605
2019-01-28 11:43:54 +01:00
feichtmeier
fec7874d0e
Reduce vertical menu padding from 8px to 4px
2019-01-28 11:43:54 +01:00
Jakub Steiner
72010d7894
Adwaita: do show labels on switches
...
- now that we have I/O and not ON/OFF
2019-01-28 11:43:54 +01:00