2008-11-07 Michael Natterer <mitch@imendio.com>
* gtk/gtkscrollbar.c: remove bogus newlines in the middle of
function calls, fix broken indentation and remove trailing
whitespace.
svn path=/trunk/; revision=21769
* gtk/gtkmenuitem.c: Made buildable and added support for adding children
of type "submenu"
* gtk/gtkwindow.c: Added support for custom tag "accel-groups" to add GtkAccelGroups
to the window.
* gtk/gtkcontainer.c: Added builder contextual warnings in buildable_add_child()
* gtk/tests/builder.c: Added tests for buildable menus (test that accelerators are
properly connected on stock items, test the menu hierarchy, test permission to
add alien/custom menuitem children).
* docs/reference/gtk/tmpl/gtkbuilder.sgml, docs/reference/gtk/tmpl/gtkwindow.sgml,
docs/reference/gtk/tmpl/gtkmenuitem.sgml: Updated docs for buildable submenus
and accel groups.
svn path=/trunk/; revision=21767
2008-11-06 Tristan Van Berkom <tvb@gnome.org>
* gtk/gtkmenuitem.[ch]: added new apis gtk_menu_item_[set/get]_label() and
gtk_menu_item_[set/get]_use_underline() with "label" and "use-underline"
properties, constructors cleaned up to use g_object_new().
GtkMenuItemClass take new vfuncs ->get/set_label().
* gtk/gtkcheckmenuitem.c: constructors cleaned up to use g_object_new().
* gtk/gtkimagemenuitem.[ch]: added new apis gtk_image_menu_item_[get/set]_use_stock()
and gtk_image_menu_item_set_accel_group() with "use-stock" and write-only
"accel-group" properties. constructors cleaned up to use g_object_new().
svn path=/trunk/; revision=21766
* gtk/gtklabel.c: gtk_label_set_attributes() now applies attributes
on top of any markup or mnemonic attributes (bug 558409).
* README: Updated and added release notes for 2.16
svn path=/trunk/; revision=21764
2008-11-05 Christian Dywan <christian@imendio.com>
Bug 559404 – gtk_editable_insert_text counts length in bytes
* gtk/gtkeditable.c:
Document new_text_length as the number of bytes
svn path=/trunk/; revision=21760
2008-11-02 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkimagemenuitem.c: Make it possible to overrule the
gtk-menu-images setting.
* gtk/gtkaction.c (connect_proxy): Show the image before adding
it to the image menu item.
svn path=/trunk/; revision=21751
* gtk/gtkmenu.c (gtk_menu_size_request): Use consistent padding
regardless of imagees or checks being in the menu. Also add
padding on the right edge.
Proposal by Luca Ferretti, patch by Jon McCann
svn path=/trunk/; revision=21745
2008-11-01 Matthias Clasen <mclasen@redhat.com>
Bug 412134 – Add API to query style properties from the style
* gtk/gtk.symbols:
* gtk/gtkstyle.[hc]: Add getters for style properties to
avoid the need for ugly workarounds with dummy widget instances.
Patch by Mariano Suárez-Alvarez
svn path=/trunk/; revision=21744
gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_set_property):
Don't set the model property on the combo box, since that leads
to loops.
svn path=/trunk/; revision=21740
2008-10-30 Matthias Clasen <mclasen@redhat.com>
Bug 558522 – scroll arrow painted insensitive even though there
are pages beyond the edge
gtk/gtknotebook.c (gtk_notebook_real_insert_page): Redraw
arrows. Pointed out by Christian Persch
svn path=/trunk/; revision=21738
2008-10-30 Michael Natterer <mitch@imendio.com>
* gtk/*.h: no need to include <gtk/gtkenums.h> in headers which
somehow include gtkobject.h or another header which includes it.
svn path=/trunk/; revision=21734
2008-10-30 Marek Kasik <mkasik@redhat.com>
Bug 339714 - Set printer dpi on cairo ps/pdf surfaces when printing
* gtk/gtk.symbols
* gtk/gtkprintsettings.c
* gtk/gtkprintsettings.h
* docs/reference/gtk/gtk-sections.txt
* modules/printbackends/file/gtkprintbackendfile.c
* modules/printbackends/test/gtkprintbackendtest.c
* modules/printbackends/cups/gtkprintbackendcups.c
* modules/printbackends/lpr/gtkprintbackendlpr.c:
Added lpi (lines per inch) setting to GtkPrintSettings and support
for anamorphic dpi. Surface fallback resolution is set to 2*lpi.
svn path=/trunk/; revision=21733
2008-10-30 Michael Natterer <mitch@imendio.com>
* gtk/*.h: no need to include <gdk/gdk.h> in any widget header,
it's included via gtkwidget.h anyway.
svn path=/trunk/; revision=21732
2008-10-26 Philip Withnall <philip@tecnocode.co.uk>
Bug 530454 – Clarify page_nr when printing
* gtk/gtkprintoperation.c (gtk_print_operation_class_init):
Point out
that page_nr is 0-based in the documentation.
svn path=/trunk/; revision=21714
2008-10-24 Matthias Clasen <mclasen@redhat.com>
Bug 556954 – gtk+/gtk/gtkrecentchooserdefault.c: mismatching
allocation and deallocation
* gtk/gtkrecentchooserdefault.c (remove_selected_from_list): Don't
free a strdup'ed string by g_free. Pointed out by Daniel Marjamäki
svn path=/trunk/; revision=21708
2008-10-24 Matthias Clasen <mclasen@redhat.com>
Bug 556835 – gtkentry.c: variable is declared at middle of block
* gtk/gtkentry.c (gtk_entry_copy_clipboard): Fix a C99ism pointed
out by Kazuki Iwamoto
svn path=/trunk/; revision=21707
2008-10-24 Matthias Clasen <mclasen@redhat.com>
Bug 557524 – "va_end(args);" should be added into
gtk_text_buffer_insert_with_tags_by_name( )
* gtk/gtktextbuffer.c (gtk_text_buffer_insert_with_tags_by_name):
Don't forget to call va_end. Pointed out by Boram Park
svn path=/trunk/; revision=21706
2008-10-23 Alexander Larsson <alexl@redhat.com>
Bug 528320 - Incorrect icons displayed for files with custom mimetype icons
* gtk/gtkfilesystem.c:
(_gtk_file_info_render_icon):
Fall back on default file icon if there was no icon or it
was not found in the theme. This goes with the corresponding
change in glib to not add the fallback icon, but is useful
in other cases too.
svn path=/trunk/; revision=21702
2008-10-20 Christian Persch <chpe@gnome.org>
Bug 557059 – crash when compositing emblems with icon
* gtk/gtkicontheme.c: (apply_emblems): Copy the pixbuf before using it
with gtk_pixbuf_composite, in case its pixdata is read-only (mmaped
from icon cache or builtins).
svn path=/trunk/; revision=21690
2008-10-16 Marek Kasik <mkasik@redhat.com>
Bug 556527 - The current page property is not passed to
GtkPrintUnixDialog
* gtk/gtkprintoperation-unix.c: pass current-page property
to GtkPrintUnixDialog
svn path=/trunk/; revision=21660
2008-10-13 Matthias Clasen <mclasen@redhat.com>
Bug 555779 – GtkCellRendererPixbuf crashed on failed GIcon lookup
* gtk/gtkcellrendererpixbuf
(gtk_cell_renderer_pixbuf_create_themed_pixbuf): Don't crash
if a GIcon is not present in the current theme. Patch by
Alex Larsson.
svn path=/trunk/; revision=21650
2008-10-13 Matthias Clasen <mclasen@redhat.com>
Bug 552318 – menubar mnemonics consumed even when
gtk-enable-mnemonics=false
* gtk/gtkwindow.c (gtk_window_activate_key): Don't let mnemonic
entries block accelerator activation when gtk-enable-mnemonics is
FALSE. Problem reported by Andreas Moog.
svn path=/trunk/; revision=21648
2008-10-11 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktoolbar.c: Revert the GtkSettings::gtk-toolbar-icon-size
part of the previous change, since it doesn't work correctly without
extra complication, and using custom icon sizes doesn't make too
much sense in a desktop-wide setting.
svn path=/trunk/; revision=21633
2008-10-11 Matthias Clasen <mclasen@redhat.com>
Bug 555186 – Setting gtk-toolbar-icon-size with custom icon_size
* gtk/gtktoolbar.c: Turn GtkToolbar::icon-size and
GtkSettings::gtk-toolbar-icon-size into int properties, to
allow the use of app-registered icon sizes.
svn path=/trunk/; revision=21632
shouldn't require a screen
* gtk/gtkfontsel.c (gtk_font_selection_set_font_name):
Don't warn if there is no screen, just return FALSE
svn path=/trunk/; revision=21621
* gtk/gtkscalebutton.c (gtk_scale_button_set_adjustment):
Create a new adjustment if NULL is passed, like other widgets
svn path=/trunk/; revision=21620
* gtk/gtktable.c (gtk_table_class_init), (gtk_table_resize):
Always use 65535 instead of G_MAXUINT since that is
the actually supported maximum number of columns and rows
svn path=/trunk/; revision=21619
2008-10-09 Michael Natterer <mitch@imendio.com>
Bug 516425 – Optionally display accelerators in popups
* gtk/gtkuimanager.h (enum GtkUIManagerItemType): add value
GTK_UI_MANAGER_POPUP_WITH_ACCELS which works like _POPUP but
shows the actions' accelerators.
* gtk/gtkuimanager.c: honor the new enum value for programmatically
created UIs, and support <popup accelerators="true"> in the XML
for the same purpose.
svn path=/trunk/; revision=21615
2008-10-08 Christian Dywan <christian@imendio.com>
Bug 555270 – Allow unsetting a MessageDialog's image
* gtk/gtkmessagedialog.c (gtk_message_dialog_set_property),
Remove a superfluous cast to GtkWidget*
(gtk_message_dialog_set_image): Accept NULL for the image
and unset the image in that case.
svn path=/trunk/; revision=21607
* gtk/gtkenums.h: Add GtkArrowPlacement
* gtk/gtkmenu.c (gtk_menu_class_init), (get_arrows_border),
(get_arrows_visible_area), (get_double_arrows),
(get_arrows_sensitive_area): Implement GtkMenu::arrow-placement
to allow scrolling arrows to be placed at the start, end or both
Patch by Tommi Komulainen and myself
svn path=/trunk/; revision=21606
mistakenly requires a display
* gtk/gtkstatusbar.c (set_grip_cursor): Only change the cursor
of the resize grip if there is a grip window.
svn path=/trunk/; revision=21605
2008-10-07 11:03:30 Tim Janik <timj@imendio.com>
* gtk/gtkbox.h: keep GtkBox as an abstract type and keep _gtk_box_new()
as private function until we settle on the exact semantics.
renamed _gtk_box_set_old_defaults() as suggested by Mitch.
svn path=/trunk/; revision=21599
2008-10-07 Michael Natterer <mitch@imendio.com>
Bug 553573 – Add orientation API to GtkBox
* gtk/gtkbox.[hh]: implement the GtkOrientable interface and
swallow all code from GtkHBox and GtkVBox. Add gtk_box_new()
which takes a GtkOrientation argument. Also move the newly
added "spacing_set" boolean from struct GtkBox to the new
private struct.
* gtk/gtkhbox.[ch]
* gtk/gtkvbox.[ch]: remove all code except the constructor and
call gtk_orientable_set_orientation() in init().
* gtk/gtk.symbols: add gtk_box_new().
svn path=/trunk/; revision=21596
2008-10-06 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkprintunixdialog.c (create_main_page): Show the tooltip
on the range entry itself, too.
svn path=/trunk/; revision=21591
2008-10-02 Matthias Clasen <mclasen@redhat.com>
Bug 96431 – Can't cut and paste / DND within invisible entry
* gtk/gtkentry.c: Disable cut, copy and drag out of an invisible
entry. Proposed by Owen Taylor
svn path=/trunk/; revision=21582
2008-10-02 Matthias Clasen <mclasen@redhat.com>
Bug 530575 – GtkEntry with invisible chars has a confused cursor in
overwrite mode
* gtk/gtkentry.c (gtk_entry_draw_cursor): Use the visible text
in the layout when positioning the cursor, not the actual text
content of the entry. This makes a different when using overwrite
mode in an invisible entry.
Problem noticed by Jonathan Blandford
* gtk/gtktextutil.c: Fix a typo in a comment
svn path=/trunk/; revision=21580
2008-10-02 Michael Natterer <mitch@imendio.com>
Bug 553585 – Add orientation API to GtkRuler
* gtk/gtkruler.[ch]: implement the GtkOrientable interface and
swallow all code from GtkHRuler and GtkVRuler. Add gtk_ruler_new()
which takes a GtkOrientation argument.
* gtk/gtkhruler.c
* gtk/gtkvruler.c: remove all code except the constructor and
call gtk_orientable_set_orientation() in init().
* gtk/gtk.symbols: add gtk_ruler_new().
svn path=/trunk/; revision=21565
2008-10-01 Tor Lillqvist <tml@novell.com>
* gtk/gtkscalebutton.c: Don't #define _GNU_SOURCE on Windows as it
confuses newest mingw headers.
svn path=/trunk/; revision=21559
2008-09-30 Michael Natterer <mitch@imendio.com>
Bug 553582 – Add orientation API to GtkSeparator
* gtk/gtkseparator.[ch]: implement the GtkOrientable interface and
swallow all code from GtkHSeparator and GtkVSeparator. Add
gtk_separator_new() which takes a GtkOrientation argument.
* gtk/gtkhseparator.c
* gtk/gtkvseparator.c: remove all code except the constructor and
call gtk_orientable_set_orientation() in init().
* gtk/gtk.symbols: add gtk_separator_new().
svn path=/trunk/; revision=21553
2008-09-30 Marek Kasik <mkasik@redhat.com>
Bug 344522 – support non-local destination files (GtkPrint):
* gtk/gtkprintunixdialog.c
* gtk/gtkprinteroptionwidget.c: Process URI instead of filename.
* modules/printbackends/file/gtkprintbackendfile.c: Add ability
to save files on non-local filesystems.
svn path=/trunk/; revision=21552
2008-09-30 Michael Natterer <mitch@imendio.com>
* gtk/gtk.symbols: forgot the G_GNUC_CONST of
gtk_orientable_get_type().
svn path=/trunk/; revision=21551
2008-09-30 Michael Natterer <mitch@imendio.com>
Bug 541009 – Get rid of separate subclasses for horizontal and
vertical orientation:
* gtk/Makefile.am
* gtk/gtk.symbols
* gtk/gtk.h
* gtk/gtkorientable.[ch]: add new interface GtkOrientable which
will be implemented by everything that can switch orientation.
svn path=/trunk/; revision=21550
2008-09-29 Matthias Clasen <mclasen@redhat.com>
Bug 553086 – hard to see current immodule
* gtk/gtkimmulticontext.c (gtk_im_multicontext_append_menuitems):
Display the actually selected context in the system menuitem.
Complaint by Akira Tagoh.
svn path=/trunk/; revision=21548
2008-09-29 Matthias Clasen <mclasen@redhat.com>
Bug 530568 – Entries with visibility=FALSE should warn for caps-lock
on
* gtk/gtkentry.c: Add a tooltip-like Caps Lock warning for
password entries. The warning is also triggered if an input method
is active. The warning can be turned off using the
GtkEntry::caps-lock-warning property.
Proposed by Owen Taylor
svn path=/trunk/; revision=21547
2008-09-29 Kristian Rietveld <kris@imendio.com>
Bug 487624 - Tooltips doesn't get updated if ther's no mouse motion
over widget
* gtk/gtkwidget.c (gtk_widget_set_property): after updating
tooltip text or markup, call gtk_widget_trigger_tooltip_query()
so that existing visible tooltips are updated.
svn path=/trunk/; revision=21544
2008-09-29 Richard Hult <richard@imendio.com>
Bug 554141 – uninitialized data use/free in gtkclipboard-quartz.c
* gtk/gtkclipboard-quartz.c: (gtk_clipboard_wait_for_contents):
Patch from Jon A. Cruz to initialize the allocated selection data.
svn path=/trunk/; revision=21540
2008-09-27 Denis Washington <denisw@svn.gnome.org>
* gtk/gtkiconview.c: only draw keyboard focus when keyboard navigation
is used, like GtkTreeView. (Bug #553575)
svn path=/trunk/; revision=21534
transparency
* gtk/gtktrayicon-x11.c: Add support for the _BET_SYSTEM_TRAY_VISUAL
property described in
http://lists.freedesktop.org/archives/xdg/2008-September/009919.html
If _NET_SYSTEM_TRAY_VISUAL is a visual with an alpha channel, the
parent-relative-background hack is skipped and we draw with a real
transparent background.
* gtk/gtkrc.c: Remove the default GtkTrayIcon style, since the
parent-relative background is now set when realizing the tray
icon.
Patch by Owen Taylor
svn path=/trunk/; revision=21531
2008-09-26 Matthias Clasen <mclasen@redhat.com>
Bug 553578 - tabs are not drawn correctly
* gtk/gtknotebook.c: Track the visibility state of notebook tabs
between allocations so that we know to redraw the tab labels if
tabs are hidden and shown without changing position.
Reported by Marek Kašík, patch by Owen Taylor.
svn path=/trunk/; revision=21525
2008-09-26 Matthias Clasen <mclasen@redhat.com>
Bug 553133 – GtkFileChooser won't ask to mount a volume
* gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Use
a GtkMountOperation when mounting, so that we get a password
dialog when required.
svn path=/trunk/; revision=21523
2008-09-25 Michael Natterer <mitch@imendio.com>
* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
don't unref the file system backend, the newly added
unset_file_system_backend() already does this (bug #553135).
svn path=/trunk/; revision=21514
2008-09-24 Johan Dahlin <johan@gnome.org>
Bug 553385 – gtk-builder-convert creates untranslated combobox models
* gtk/gtk-builder-convert: Set the translatable property on
col tags for converted combos.
svn path=/trunk/; revision=21512
* gtk/gtkbox.c (gtk_box_init), (gtk_box_set_spacing),
(_gtk_box_set_spacing_set), (_gtk_box_get_spacing_set):
* gtk/gtkbox.h:
* gtk/gtkdialog.c (gtk_dialog_class_init), (update_spacings):
Implement "content-area-spacing" style property in GtkDialog
and internal helper _gtk_box_get_spacing_set in GtkBox.
Patch by Tim Janik, Sven Herzberg and myself.
svn path=/trunk/; revision=21508
2008-09-24 Denis Washington <denisw@svn.gnome.org>
* gtk/gtkiconview.c: draw focus as a rectangle around the
complete item, not just the text. (Bug #38254)
svn path=/trunk/; revision=21506
2008-09-22 Matthias Clasen <mclasen@redhat.com>
Bug 553135 – eog crash: assertion failed. Gtk error:
shortcuts_remove_rows: code should not be reached
* gtk/gtkfilechooserdefault.c: Disconnect from GtkFileSystem
signals when we are destroyed, in order to avoid nasty surprises.
Patch by Claudio Saavedra
svn path=/trunk/; revision=21492
2008-09-22 Emmanuele Bassi <ebassi@linux.intel.com>
Bug 552789 – Show size column in the search and recently used
files modes
* gtk/gtkfilechooserdefault.c: Display the file size column
when in OPERATION_MODE_SEARCH. This removes a stat() call
and simplifies the code a little bit by changing the query
for file informations for each search engine hit.
svn path=/trunk/; revision=21491
2008-09-22 Michael Natterer <mitch@imendio.com>
* gtk/gtksignal.[ch]
* gtk/gtkclist.c
* gtk/gtklist.c
* gtk/gtkmain.c
* gtk/gtktext.c
* gtk/gtktreeitem.c: use G_CALLBACK and GCallback instead of
GTK_SIGNAL_FUNC and GtkSignalFunc also in deprecated code.
svn path=/trunk/; revision=21488
2008-09-22 Michael Natterer <mitch@imendio.com>
* gtk/gtktoolbar.[ch]: add "Deprecated: 2.4" to all the deprecated
append(), prepend() and insert() functions and recommend to use
gtk_toolbar_insert() instead. Use GCallback instead of
GtkSignalFunc even in deprecated API.
svn path=/trunk/; revision=21485
2008-09-19 Owen Taylor <otaylor@redhat.com>
Small cleanups to debug messages for GtkPlug/GtkSocket
* gtk/gtksocket-x11.c: Fix debug message to say "Socket" not "Plug"
* gtk/gtkplug-x11.c: Remove excess newlines from the ends of debug messages.
svn path=/trunk/; revision=21458
2008-09-19 Carlos Garnacho <carlos@imendio.com>
Bug 83935 – GtkEntry's default invisible char should be U+25CF
* gtk/gtkentry.c (find_invisible_char) (gtk_entry_init): Find a
more suitable invisible char than '*' based on the used font.
(gtk_entry_class_init) (gtk_entry_set_property)
(gtk_entry_get_property): Add a "invisible-char-set" property.
(gtk_entry_unset_invisible_char): New function, needed now that the
default invisible char isn't fixed.
* gtk/gtkentry.h:
* gtk/gtk.symbols:
* docs/reference/gtk/gtk-sections.txt: Add the new function.
svn path=/trunk/; revision=21446
2008-09-18 Emmanuele Bassi <ebassi@linux.intel.com>
* gtk/gtkfilechooserdefault.c (settings_save): Save the size column
visibility state with the rest of the FileChooser settings.
svn path=/trunk/; revision=21437
2008-09-18 Emmanuele Bassi <ebassi@linux.intel.com>
Bug 325095 – show a 'size' column
* gtk/gtkfilechooserdefault.c:
* gtk/gtkfilechooserprivate.h: Add a context menu item controlling
the visibility of the file size column. This works only for the
browse mode, and the column is not visible by default.
* gtk/gtkfilechoosersettings.[ch]: Add a ShowSizeColumn key to the
settings file.
svn path=/trunk/; revision=21431
2008-09-17 Matthias Clasen <mclasen@redhat.com>
Bug 346903 – gtk_enumerate_printers needs events to complete
* gtk/gtkprintbackend.h:
* gtk/gtkprintbackend.c: Add a GtkPrintBackend::status property.
* modules/printbackends/cups/gtkcupsutils.h:
* modules/printbackends/cups/gtkcupsutils.c: Turn the connection
test into a tristate available/unavailable/in progress.
* modules/printbackends/cups/gtkprintbackendcups.c: Use a single
connection test instance for getting the default printer and for
getting the printer list. Set the GtkPrintBackend::status property
according to the result of the connection test. Use the printer-type
attribute to find the default printer, if cups supports it.
* gtk/gtkprinter.c: When enumerating printers, give up when
the backend status is 'unavailable'.
* gtk/gtkprintunixdialog.c (printer_status_cb): Select the printer
when it is the default and nothing else has been selected yet.
svn path=/trunk/; revision=21417
slow
* gtk/gtknotebook.c (gtk_notebook_page_allocate): Return a boolean
that indicates whether the tab allocation has changed.
(gtk_notebook_pages_allocate): Only redraw the tabs if their
allocation has changed.
(gtk_notebook_calculate_tabs_allocations): Remove unused return value.
Patch by Owen Taylor
svn path=/trunk/; revision=21414
2008-09-17 Matthias Clasen <mclasen@redhat.com>
Bug 408154 – [PATCH] Change GtkEntryCompletion max-items to style
property
* gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
Take actions into account when finding the available space for
matches. Patch by Ross Burton
svn path=/trunk/; revision=21413
2008-09-17 Matthias Clasen <mclasen@redhat.com>
Bug 551722 – gtk_widget_set_scroll_adjustments() should check the
signal signature
* gtk/gtkwidget.c (gtk_widget_set_scroll_adjustments): Check the
signature of the signal. Patch by Christian Persch
svn path=/trunk/; revision=21410
2008-09-16 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.c (_gtk_widget_set,get_pointer_window): don't
access widget->window if the widget is not realized.
svn path=/trunk/; revision=21403
2008-09-16 Matthias Clasen <mclasen@redhat.com>
Bug 551987 – GtkPaned redrawing problem
* gtk/gtkhpaned.c:
* gtk/gtkvpaned.c: Queue invalidations when the handle is moved
due to child changes. Patch by Owen Taylor
svn path=/trunk/; revision=21399
2008-09-13 Tor Lillqvist <tml@novell.com>
* gdk-pixbuf/gdk-pixbuf-io.c
* gtk/gtkmain.c: Don't use the deprectated
g_win32_get_package_installation_directory() and
g_win32_get_package_installation_subdirectory() functions. Use
g_win32_get_package_installation_directory_of_module()
instead. Also, don't use the deprecated silly
G_WIN32_DLLMAIN_FOR_DLL_NAME macro, but an explicit minimal
DllMain() that just saves the DLL handle.
svn path=/trunk/; revision=21381
2008-09-13 Cosimo Cecchi <cosimoc@gnome.org>
Bug 552153 – GtkModules loading with XSettings doesn't work if the
GTK_MODULES env var isn't set.
* gtk/gtkmain.c: (do_post_parse_initialization):
* gtk/gtkmodules.c: (_gtk_modules_init):
Call _gtk_modules_init () even if gtk_modules_string is NULL, so
that GtkModules specified with XSettings could be loaded.
svn path=/trunk/; revision=21380
2008-09-13 Tor Lillqvist <tml@novell.com>
* gdk-pixbuf/gdk-pixbuf-io.c
* gtk/gtkmain.c: Do as the docs for
g_win32_get_package_installation_directory() say and pass NULL as
the first parameter.
svn path=/trunk/; revision=21379
2008-09-11 Cosimo Cecchi <cosimoc@gnome.org>
Bug 536542 – gtk_list_store_set() documentation doesn't say whether
values are copied.
* gtk/gtkliststore.c:
* gtk/gtktreestore.c:
Explicitly mention in the docs that gtk_[list,tree]_store_set copies
or keep a reference of the values.
svn path=/trunk/; revision=21349
2008-09-10 Björn Lindqvist <bjourne@gmail.com>
Bug 551699 – gtk_scrolled_window_destroy() is broken
* gtk/gtkscrolledwindow.c (gtk_scrolled_window_destroy,
gtk_scrolled_window_finalize): Check that the [hv]scrollbar
attributes are not-NULL before destroying and unparenting them.
svn path=/trunk/; revision=21341
2008-09-09 Marek Kasik <mkasik@redhat.com>
Bug 551386 – gtk_printer_set_is_default() always sets TRUE
* gtk/gtkprinter.c: sets the is_default parameter to the value
given by caller
svn path=/trunk/; revision=21325
2008-09-08 Cosimo Cecchi <cosimoc@gnome.org>
Bug 551325 - Reference to wrong parameter in gtk_editable_insert_text
* gtk/gtkeditable.c: Fix a reference to an invalid parameter in the
docs.
svn path=/trunk/; revision=21324
2008-09-08 Paolo Borelli <pborelli@katamail.com>
* gtk/gtkfilechooserentry.c (install_start_autocompletion_idle):
use gdk_threads_add_idle so that the handler acquires the lock
since it calls gtk functions.
svn path=/trunk/; revision=21321
2008-09-07 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (search_add_hit): Don't unref the
GFile we just put into the search_model. This adds a new memory
leak...
svn path=/trunk/; revision=21315
2008-09-05 Michael Natterer <mitch@imendio.com>
* gtk/gtkfilechooserdefault.c (file_list_drag_data_received_cb):
stop the emission of the signal also when we bail out early
because we don't accept drops from ourselves. Keeps the code from
running into a warning in gtktreeview.c.
svn path=/trunk/; revision=21302
2008-09-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.c (gtk_widget_get_draw_rectangle): when extending
the draw rectangle by the "draw-border" style property, subtract
"left" from "x" and "top" from "y", not the other way around.
svn path=/trunk/; revision=21285
2008-09-03 Matthias Clasen <mclasen@redhat.com>
Bug 550528 - IconView DND interface does not work if only used as
source
* gtk/gtkiconview.c: Make source-only DND work.
Found by Alex Simon
svn path=/trunk/; revision=21270
2008-09-03 Michael Natterer <mitch@imendio.com>
* gtk/gtkarrow.c: expose-event returns gboolean not gint,
reindented static prototypes and did some minor cleanups.
svn path=/trunk/; revision=21265
2008-09-02 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.c (gtk_widget_get_allocation): removed this
function because there is massive disagreement about how to
implement it. Needs some general discussion in the next
development cycle about how our C api should evolve.
* gtk/gtk.symbols: changed accordingly.
svn path=/trunk/; revision=21259
2008-09-01 Wouter Bolsterlee <wbolster@svn.gnome.org>
* gtk/gtkselection.c:
Update documentation for gtk_selection_data_get_data to
match the changes introduced in -r21232 (the length
parameter was removed).
svn path=/trunk/; revision=21256
2008-08-29 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.h: move the gtk_widget_get_parent() and
gtk_widget_get_parent_window() prototypes together with their
respective setters.
* gtk/gtkwidget.c: move gtk_widget_get_parent_window() together
with its setter.
svn path=/trunk/; revision=21240
2008-08-29 Matthias Clasen <mclasen@redhat.com>
Bug 549262 – GtkScrolledWindow should not accept focus unless
GTK_CAN_FOCUS is set
* gtk/gtkscrolledwindow.c (gtk_scrolled_window_focus): only grab the
focus, if GTK_WIDGET_CAN_FOCUS() returns TRUE. Patch by Sven
Herzberg
svn path=/trunk/; revision=21233
2008-08-28 Christian Dywan <christian@imendio.com>
Bug 549734 – gtk_selection_data_get_data prototype is wrong
* gtk/gtkselection.[ch] (gtk_selection_data_get_data): make the
'length' argument of gtk_selection_data_get_data a 'gint', that's
what it should be.
svn path=/trunk/; revision=21229
2008-08-26 Matthias Clasen <mclasen@redhat.com>
Bug 549354 – Crash trying to open a file on a remote folder
* gtk/gtkfilechooserdefault.c (error_message_with_parent): Handle
the fact that parent may be NULL without crashing.
svn path=/trunk/; revision=21206
* gtk/gtksettings.c: When reconstructing the color hash, try
harder to avoid unnecessary notification, since this can lead
to infinite reloading of rc files in some situations.
svn path=/trunk/; revision=21182
2008-08-21 Marek Kasik <mkasik@redhat.com>
Bug 545875 – evo crashed when trying to print pages 6-7 of a 1 page
email
* gtk/gtkprintoperation.c: Clamp page ranges to correct ranges
svn path=/trunk/; revision=21177
2008-08-21 Marek Kasik <mkasik@redhat.com>
Bug 535158 – can't rearrange the order of multi pages per side
* gtk/gtkprinter.c
* gtk/gtkprinter.h
* gtk/gtkprintunixdialog.c
* gtk/gtkprintsettings.c
* gtk/gtkprintsettings.h
* gtk/gtkenums.h
* modules/printbackends/cups/gtkprintbackendcups.c: Allow user to
specify layout of pages per sheet in number-up mode
svn path=/trunk/; revision=21175
2008-08-05 Milan Crha <mcrha@redhat.com>
* gtk/gtknotebook.c: (gtk_notebook_do_arrow): Allow changing page with
arrows even on non-focusable notebook. (#528091)
svn path=/trunk/; revision=21170
Only emit default-size-changed if the file chooser widget is mapped.
It only makes sense to do this once we know our final configuration,
which is actually when we are mapped.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=21164
2008-08-19 Björn Lindqvist <bjourne@gmail.com>
Bug 548354 – Remove repeated code in gtk_cell_view_size_allocate
* gtk/gtkcellview.c (gtk_cell_view_size_allocate): Remove some
code duplication, no need for separate loops for GTK_PACK_START
and GTK_PACK_END.
svn path=/trunk/; revision=21158
2008-08-19 Johan Dahlin <johan@gnome.org>
* gtk/gtk-builder-convert (GtkBuilderConverter._parse):
Remove the requres-version tag as well
svn path=/trunk/; revision=21157
* gtk/gtkcalendar.c (gtk_calendar_class_init()): Limit the "year"
property to G_MAXINT >> 9, instead of G_MAXINT >> 8: year_to_days()
multiplies the year property with 365 and returns the result as
glong. Therefore ceil(log(365, 2)) = 9 bits must be available,
not just 8 bits.
svn path=/trunk/; revision=21150
2008-08-18 Björn Lindqvist <bjourne@gmail.com>
Bug 541315 – Segfault when selecting a GtkMenuItem with submenu
and no parent
* gtk/gtkmenuitem.c (gtk_menu_item_real_popup_submenu): Ensure
that the menu item has a parent before popping it up.
svn path=/trunk/; revision=21149
2008-08-13 Michael Natterer <mitch@imendio.com>
* gtk/gtkstock.c (gtk_stock_lookup): cast the return value of
g_dgettext() to fix warning about discarded qualifier.
svn path=/trunk/; revision=21106
2008-08-12 Paolo Borelli <pborelli@katamail.com>
* gtk/gtkclipboard.c (gtk_clipboard_store):
use canonical signal name.
svn path=/trunk/; revision=21104
2008-08-12 Paolo Borelli <pborelli@katamail.com>
Bug 526234 - make shift+ctrl+del delete till the end of line
* gtk/gtktextview.c: add shift+ctrl+del and shift+ctrl+backspace
keyboard shortcuts to delete to the end/start of the current line.
svn path=/trunk/; revision=21103
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/gtklinkbutton.c (set_link_color): bail out if there is no
label to set the color on.
(gtk_link_button_add): call set_link_color() so the label gets
the right color no matter how the link button is created.
svn path=/trunk/; revision=21100
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkassistant.c: remove unused variable and fix formatting of
some function headers.
svn path=/trunk/; revision=21099
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkstatusicon.c (gtk_status_icon_get_gicon): use
g_return_val_if_fail() now that the function has a return value.
svn path=/trunk/; revision=21095
2008-08-12 Sven Neumann <sven@gimp.org>
* gtk/gtknotebook.c
* gtk/gtkradiotoolbutton.c: property nick and blurb should be
marked with P_(), not _().
svn path=/trunk/; revision=21091
2008-08-12 Michael Natterer <mitch@imendio.com>
* gtk/*.c: consistently chain up using
GTK_FOO_CLASS(parent_class)->bar(instance) instead of
(*GTK_FOO_CLASS(parent_class))->bar(instance).
svn path=/trunk/; revision=21085
2008-08-11 Michael Natterer <mitch@imendio.com>
Bug 546754 – 2.13.6 update create rendering issue in the evolution
composer
* gtk/gtkadjustment.c: instead of CLAMP(), use
value = MIN (value, upper - page_size);
value = MAX (value, lower);
so we don't end up below lower if upper - page_size is smaller
than lower.
svn path=/trunk/; revision=21080
2008-08-11 Michael Natterer <mitch@imendio.com>
Bug 547270 – Make GtkHSV public
* gtk/Makefile.am
* gtk/gtk.h: install gtkhsv.h as public header (its symbols were
always public anyway).
* gtk/gtkhsv.h: add single-include guards, add class struct padding,
seal the instance member, cleanup.
* gtk/gtkhsv.c: center the widget in its allocation,
add "Since: 2.14", cleanup.
svn path=/trunk/; revision=21078
2008-08-09 Sven Herzberg <sven@imendio.com>
Bug 544863 – gtkquartz.h not included in released 2.13.5 package
* gtk/Makefile.am: always add gtkquartz.h to EXTRA_DIST
svn path=/trunk/; revision=21052
2008-08-08 Cody Russell <bratsche@gnome.org>
* gtk/gtkmenushell.c
* gtk/gtkmenu.c: In enter/leave notify events, check that the crossing
mode is not GTK_GRAB, GTK_UNGRAB, or STATE_CHANGED. Fixes regressions
in menus caused by bug #56070.
svn path=/trunk/; revision=21049
2008-08-07 Michael Natterer <mitch@imendio.com>
Bug 546756 – gnome-panel crashed with SIGSEGV in
g_type_check_instance_cast()
* gtk/gtkimagemenuitem.c: add GtkObject::destroy() implementation
and remove the image now that it's an internal child and isn't
destroyed by gtk_container_destroy() any longer. Thanks to tml for
helping bisecting this down.
svn path=/trunk/; revision=21034
2008-08-07 Sven Neumann <sven@gimp.org>
Bug 546771 - Add writable property "visited" to GtkLinkButton
* gtk/gtk.symbols
* gtk/gtklinkbutton.[ch]: expose the 'visited' state as a
read-write property with getters and setters. Also move the nick
and blurb of the "uri" property to the proper translation
domain.
svn path=/trunk/; revision=21032
2008-08-07 Michael Natterer <mitch@imendio.com>
* gtk/gtkicontheme.c (apply_emblems): move variables to local
scopes, fix indentation and silence bogus warning about using
uninitialized variables.
svn path=/trunk/; revision=21031
2008-08-07 Emmanuele Bassi <ebassi@gnome.org>
Bug 545031 – list of recently used files is created world-readable
* gtk/gtkrecentmanager.c:
(gtk_recent_manager_real_changed): Set the recently-used.xbel
file to 0600. (Guido Berhoerster)
svn path=/trunk/; revision=21028
2008-08-06 Michael Natterer <mitch@imendio.com>
* gtk/gtkcombobox.c
* gtk/gtkiconview.c
* gtk/gtkrange.c
* gtk/gtkscrolledwindow.c
* gtk/gtktreeview.c: remove CLAMPing from values passed to
gtk_adjustment_set_value() since it does it right now.
svn path=/trunk/; revision=21021
2008-08-05 Michael Natterer <mitch@imendio.com>
* gtk/gtkcombobox.c (gtk_combo_box_update_sensitivity): bail out
early if priv->button is NULL to avoid zillions of warnings when
destroying combo boxes that were working fine before the
button sensitivity patch.
svn path=/trunk/; revision=21014
2008-08-05 Michael Natterer <mitch@imendio.com>
Bug 544858 – Seal GtkAdjustment
* gtk/gtk.symbols
* gtk/gtkadjustment.[ch] (struct GtkAdjustment): seal all struct
members.
Add accessors for all properties and additionally a new function
gtk_adjustment_configure() which sets all properties at
once. Patch by Christian Dywan and myself.
svn path=/trunk/; revision=21013
2008-08-05 Michael Natterer <mitch@imendio.com>
* gtk/gtkadjustment.c (gtk_adjustment_set_value): clamp the value
to [lower...upper-page_size] instead of only [lower...upper].
* README: add note about this change.
While this fix is correct and should have been there forever, it
has the potential to break some corner cases, however these cases
would set page_size to a value != 0 which suggests they want it
honored.
svn path=/trunk/; revision=21012
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/gtktext.c: Cast pointer to gintptr instead of gulong to
avoid warning on Win64.
svn path=/trunk/; revision=21003
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/gtkgc.c: Cast tile, stipple and clip_mask pointers to
gintptr when calculating hash, so we get all of the pointer bits
on Win64 where long is 32 bits.
svn path=/trunk/; revision=21002
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/gtkprintoperation-win32.c: Don't need to declare
IPrintDialogCallback with mingw64 either. It seems to come with
newer versions of the headers.
svn path=/trunk/; revision=21001
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gtk/gtksocket-win32.c: Don't cast HWND to guint, pass it as such
as the GdkNativeWindow parameter to
gtk_window_remove_embedded_xid(). Debugging printout format fixes.
* gtk/gtkwin32embed.h
* gtk/gtkwin32embed.c: Change the types of wparam and lparam
parameters to actually be WPARAM and LPARAM.
* gtk/gtkplug-win32.c: Adapt accordingly.
svn path=/trunk/; revision=21000
2008-08-04 Matthias Clasen <mclasen@redhat.com>
Bug 382291 – Automatically dim the combobox when the model is empty
* gtk/gtk.symbols:
* gtkcombobox.[hc]: Add a GtkComboBox::button-sensitivity
property with getter and setter to control the sensitity of
empty combo boxes. Patch by Carlos Garnacho, Sven Herzberg,
Christian Dywan and others.
* README.in: Add a note about automatic combobox sensitivity.
svn path=/trunk/; revision=20997
2008-08-05 Tor Lillqvist <tml@novell.com>
* gtk/updateiconcache.c (write_bucket): Enclose ?: expression
with parens so cast covers all of it.
svn path=/trunk/; revision=20996
2008-08-05 Tor Lillqvist <tml@novell.com>
Bug 544684 - Win64 issue, window handles are assumed to be 32-bit
* gtk/gtkwindow.h
* gtk/gtkwindow.c: Change the type of the xid parameter of the
internal gtk_window_remove_embedded_xid() and
gtk_window_add_embedded_xid() functions from guint to
GdkNativeWindow.
* gtk/gtkwindow.c (send_client_message_to_embedded_windows):
Instead of GPOINTER_TO_UINT(), just cast the gpointer to
GdkNativeWindow. GPOINTER_TO_UINT() drops the upper 32 bits on
Win64.
svn path=/trunk/; revision=20992
2008-08-04 Björn Lindqvist <bjourne@gmail.com>
Bug 534979 – GtkImageMenuItem is a bin but has two children.
* gtk/gtkimagemenuitem.c (gtk_image_menu_item_forall): Do not
include the image widget when iterating over non-internal
children. Patch by rainwoodman.
svn path=/trunk/; revision=20985
2008-08-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkclist.c
* gtk/gtkctree.c
* gtk/gtkpixmap.c
* gtk/gtkpreview.c: get rid of using deprecated GDK APIs.
* gtk/gtktext.c: ditto, apart from the text cruft APIs.
svn path=/trunk/; revision=20982
2008-08-04 Carlos Garnacho <carlos@imendio.com>
* gtk/gtknotebook.c (gtk_notebook_expose): Set drag window background
to be the GtkNotebook background color. This is a workaround to
prevent black pixels in rounded tabs when reordering. Improves
#368234.
svn path=/trunk/; revision=20973
2008-08-04 Carlos Garnacho <carlos@imendio.com>
* gtk/gtk.symbols:
* gtk/gtkfilechooser.[ch]: Make GFile-oriented API public. Fixes
#545978.
* gtk/gtkfilechooserbutton.c:
* gtk/gtkfilechooserdefault.c:
* gtk/gtkfilechooserutils.c: Update to use public GFile API.
svn path=/trunk/; revision=20971
2008-08-04 Michael Natterer <mitch@imendio.com>
* gtk/Makefile.am: build with GTK_DISABLE_DEPRECATED again.
Fix pltcheck.sh by restricting the visibility of deprecated
symbols to the places where they are actually used:
* gtk/gtkclist.c
* gtk/gtkctree.c
* gtk/gtklistitem.c
* gtk/gtklist.c
* gtk/gtkprogressbar.c
* gtk/gtkpixmap.c
* gtk/gtkprogress.c: #undef GTK_DISABLE_DEPRECATED and #define
__GTK_FOO_C__ on top instead of before including gtkaliasdef.c.
* gtk/gtkclist.h
* gtk/gtkctree.h
* gtk/gtklistitem.h
* gtk/gtklist.h
* gtk/gtkpixmap.h
* gtk/gtkprogress.h: make the headers visible if the respective
__GTK_FOO_C__ are defined.
svn path=/trunk/; revision=20970
2008-08-04 Sven Neumann <sven@gimp.org>
* gtk/gtklinkbutton.c (gtk_link_button_set_uri): update the link
color when the "visited" state is changed.
svn path=/trunk/; revision=20966
2008-08-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkwindow.c: move the code of the deprecated
gtk_window_set_policy() to a new private function
gtk_window_set_policy_internal() and call it from
gtk_window_set_policy().
(gtk_window_set_resizable): use the new internal function in order
to avoid our own deprecated public API.
svn path=/trunk/; revision=20965
2008-08-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkbindings.c: move the code of the deprecated
gtk_binding_entry_clear() to a new private function
gtk_binding_entry_clear_internal() and call it from
gtk_binding_entry_clear().
(_gtk_binding_entry_add_signall)
(gtk_binding_parse_bind): use the new internal function in order
to avoid our own deprecated public API.
svn path=/trunk/; revision=20963
2008-08-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkfontsel.c (gtk_font_selection_dialog_get_font):
avoid our own deprecated public API and use
gtk_font_selection_get_font_internal() instead of
gtk_font_selection_get_font().
(gtk_font_selection_get_font)
(gtk_font_selection_dialog_get_font): Add missing
"Deprecated: 2.0" to the api doc comments.
svn path=/trunk/; revision=20962
2008-08-04 Tor Lillqvist <tml@novell.com>
* configure.in: Set LIB_EXE_MACHINE_FLAG to either X86 or X64 on
Windows. AC_SUBST it.
* gdk/Makefile.am
* gtk/Makefile.am: Pass appropriate -machine flag to lib.exe.
svn path=/trunk/; revision=20957
2008-08-02 Matthias Clasen <mclasen@redhat.com>
Bug 429427 – Add "arrow-spacing" style property to GtkRange
* gtk/gtkrange.c: Add an arrow-spacing style property.
Patch by Carlos Garnacho and Christian Dywan
svn path=/trunk/; revision=20939
2008-08-02 Matthias Clasen <mclasen@redhat.com>
Bug 429411 – add style properties to set minimum progressbar
width/height
* gtk/gtkprogressbar.c: Add style properties for minimum size.
Patch by Carlos Garnacho and Christian Dywan
svn path=/trunk/; revision=20938
2008-08-01 Hans Breuer <hans@breuer.org>
* gdk/makefile.msc : build gdkwindowimpl
* gtk/gtkwidget.c : fix c99ism - declaration needs to be at the
start of a block
* tests/makefile.msc : update
svn path=/trunk/; revision=20926
2008-07-31 Cody Russell <bratsche@gnome.org>
Bug 56070 – Can't click button after setting it sensitive.
* gtk/gtkwidget.[ch]
* gtk/gtkwindow.c
* gtk/gtkmain.c
* gtk/gtkbutton.c
* gtk/gtkprivate.h
* gdk/gdkevents.h: Synthesize crossing events events where necessary.
* gtk/tests/crossingevents.c: Add unit tests for crossing events.
Big thanks to Ed Catmur, Matthias Clasen, and everyone else who
has worked on and helped out with this.
svn path=/trunk/; revision=20924
2008-07-30 Tor Lillqvist <tml@novell.com>
* gtk/gtkprintoperation-win32.c: Fix problems in handling custom
paper sizes. The DEVMODE::dmPaperWidth and dmPaperLength are in
tenths of a millimeter, and the RECT passed to CreateEnhMetaFile()
is in hundredths of a millimeter. Patch by Sven Neumann.
svn path=/trunk/; revision=20916
2008-07-27 Sven Herzberg <sven@imendio.com>
Bug 544863 – gtkquartz.h not included in released 2.13.5 package
* gtk/Makefile.am: explicitly include the moved header in EXTRA_DIST
svn path=/trunk/; revision=20908
2008-07-25 Murray Cumming <murrayc@murrayc.com>
* gtk/gtkstatusicon.c (gtk_status_icon_class_init):
Documented the activate and popup-menu signals as being for use
by applications and language bindings, though they are G_SIGNAL_ACTION,
as stated in bug #361561.
svn path=/trunk/; revision=20905
2008-07-21 Michael Natterer <mitch@imendio.com>
* gtk/gtkbox.c (gtk_box_add): use gtk_box_pack_start() instead of
the deprecated gtk_box_pack_start_defaults().
* gtk/gtkbindings.c (gtk_binding_entry_add_signal)
(gtk_binding_parse_signal): use _gtk_binding_entry_add_signall()
instead of the deprecated gtk_binding_entry_add_signall().
svn path=/trunk/; revision=20885
2008-07-21 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkrecentmanager.c:
(recent_app_info_new), (recent_app_info_free): Use GSlice to
allocate the application data for recently used resources;
do not call time() to initialize the timestamp, as it will
be overwritten anyway later. (#535223, Michael Meeks)
svn path=/trunk/; revision=20884
