2021-03-11 20:53:06 +00:00
|
|
|
### Compilation failed:
|
|
|
|
|
|
|
|
|
|
error: SPIR-V validation error: Variable must be decorated with a location
|
|
|
|
|
%a = OpVariable %_ptr_Input_float Input
|
|
|
|
|
|
2020-12-09 21:19:37 +00:00
|
|
|
OpCapability Shader
|
|
|
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
|
|
|
OpMemoryModel Logical GLSL450
|
2020-12-30 19:53:17 +00:00
|
|
|
OpEntryPoint Fragment %main "main" %sk_FragColor %sk_Clockwise %a %b %c %d
|
2020-12-09 21:19:37 +00:00
|
|
|
OpExecutionMode %main OriginUpperLeft
|
|
|
|
|
OpName %sk_FragColor "sk_FragColor"
|
|
|
|
|
OpName %sk_Clockwise "sk_Clockwise"
|
|
|
|
|
OpName %a "a"
|
|
|
|
|
OpName %b "b"
|
2020-12-30 19:53:17 +00:00
|
|
|
OpName %c "c"
|
|
|
|
|
OpName %d "d"
|
2020-12-09 21:19:37 +00:00
|
|
|
OpName %main "main"
|
|
|
|
|
OpDecorate %sk_FragColor RelaxedPrecision
|
|
|
|
|
OpDecorate %sk_FragColor Location 0
|
|
|
|
|
OpDecorate %sk_FragColor Index 0
|
Revert "Refactored SPIR-V RelaxedPrecision handling"
This reverts commit 9e476b798f03930b6bc7fb6eacab574f197e172d.
Reason for revert: Angry Vulkan bots
Original change's description:
> Refactored SPIR-V RelaxedPrecision handling
>
> The RelaxedPrecision decoration is now handled by nextId(), to make it
> easier to see all spots where a RelaxedPrecision decoration might be
> necessary. The goal of this initial refactor is not to actually fix the
> issues with RelaxedPrecision decorations, but rather to lay the
> groundwork for doing so in followup CLs.
>
> The initial intent of this change was to not affect the SPIR-V at all,
> saving modifications for followups, but there ended up being three kinds
> of changes to the output:
>
> 1. Doing things at nextId() time rather than later means some
> decorations move to an earlier spot in the output. This results in
> diffs, but should not cause any behavioral changes.
> 2. We were incorrectly tagging bools as RelaxedPrecision in some
> situations. By funneling things through fewer code paths, the refactor
> would have caused this to happen in even more situations, and the code
> responsible for the bug was being rewritten in this CL anyway, so it
> seemed worth just fixing the issue as part of this change.
> 3. Funneling things through fewer code paths ended up adding
> (correct) RelaxedPrecision modifiers to binary operations that had
> previously been missing them. It seemed better to just let it happen
> than to try to maintain bug-for-bug compatibility with the previous
> approach.
>
> Change-Id: Ia9654d6b5754e2c797e02226660cb618c9189b36
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384318
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
Change-Id: I9ada728e5fd5798bc1179640560c2e6045b7efd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385158
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-03-15 21:24:32 +00:00
|
|
|
OpDecorate %sk_Clockwise RelaxedPrecision
|
2020-12-09 21:19:37 +00:00
|
|
|
OpDecorate %sk_Clockwise BuiltIn FrontFacing
|
|
|
|
|
OpDecorate %a RelaxedPrecision
|
|
|
|
|
OpDecorate %b RelaxedPrecision
|
2020-12-30 19:53:17 +00:00
|
|
|
OpDecorate %c RelaxedPrecision
|
|
|
|
|
OpDecorate %d RelaxedPrecision
|
|
|
|
|
OpDecorate %20 RelaxedPrecision
|
|
|
|
|
OpDecorate %21 RelaxedPrecision
|
|
|
|
|
OpDecorate %27 RelaxedPrecision
|
|
|
|
|
OpDecorate %28 RelaxedPrecision
|
2020-12-09 21:19:37 +00:00
|
|
|
%float = OpTypeFloat 32
|
|
|
|
|
%v4float = OpTypeVector %float 4
|
|
|
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
|
|
|
|
%sk_FragColor = OpVariable %_ptr_Output_v4float Output
|
|
|
|
|
%bool = OpTypeBool
|
|
|
|
|
%_ptr_Input_bool = OpTypePointer Input %bool
|
|
|
|
|
%sk_Clockwise = OpVariable %_ptr_Input_bool Input
|
2020-12-30 19:53:17 +00:00
|
|
|
%_ptr_Input_float = OpTypePointer Input %float
|
|
|
|
|
%a = OpVariable %_ptr_Input_float Input
|
|
|
|
|
%b = OpVariable %_ptr_Input_float Input
|
2020-12-09 21:19:37 +00:00
|
|
|
%_ptr_Input_v4float = OpTypePointer Input %v4float
|
2020-12-30 19:53:17 +00:00
|
|
|
%c = OpVariable %_ptr_Input_v4float Input
|
|
|
|
|
%d = OpVariable %_ptr_Input_v4float Input
|
2020-12-09 21:19:37 +00:00
|
|
|
%void = OpTypeVoid
|
2020-12-30 19:53:17 +00:00
|
|
|
%17 = OpTypeFunction %void
|
2020-12-09 21:19:37 +00:00
|
|
|
%_ptr_Output_float = OpTypePointer Output %float
|
|
|
|
|
%int = OpTypeInt 32 1
|
|
|
|
|
%int_0 = OpConstant %int 0
|
2020-12-30 19:53:17 +00:00
|
|
|
%main = OpFunction %void None %17
|
|
|
|
|
%18 = OpLabel
|
|
|
|
|
%20 = OpLoad %float %a
|
|
|
|
|
%21 = OpLoad %float %b
|
|
|
|
|
%19 = OpFMul %float %20 %21
|
|
|
|
|
%22 = OpAccessChain %_ptr_Output_float %sk_FragColor %int_0
|
|
|
|
|
OpStore %22 %19
|
|
|
|
|
%27 = OpLoad %v4float %c
|
|
|
|
|
%28 = OpLoad %v4float %d
|
|
|
|
|
%26 = OpDot %float %27 %28
|
|
|
|
|
%29 = OpAccessChain %_ptr_Output_float %sk_FragColor %int_0
|
|
|
|
|
OpStore %29 %26
|
2020-12-09 21:19:37 +00:00
|
|
|
OpReturn
|
|
|
|
|
OpFunctionEnd
|
2021-03-11 20:53:06 +00:00
|
|
|
|
|
|
|
|
1 error
|
